103177 2012-11-24 07:52:09 -0800 [EFL][WK2] Check errors in EwkView callbacks usage at compile time 2012-11-24 08:46:51 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov cdumez gyuyoung.kim kenneth lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 774832 0 mikhail.pozdnyakov 2012-11-24 07:52:09 -0800 Errors in EwkView callbacks usage shall be checked at compile time. 774834 1 175858 mikhail.pozdnyakov 2012-11-24 07:58:00 -0800 Created attachment 175858 patch 774836 2 cdumez 2012-11-24 08:26:01 -0800 Cool :) Looks good. 774838 3 175858 webkit.review.bot 2012-11-24 08:46:47 -0800 Comment on attachment 175858 patch Clearing flags on attachment: 175858 Committed r135652: <http://trac.webkit.org/changeset/135652> 774839 4 webkit.review.bot 2012-11-24 08:46:51 -0800 All reviewed patches have been landed. Closing bug. 175858 2012-11-24 07:58:00 -0800 2012-11-24 08:46:46 -0800 patch bug103177 text/plain 3079 mikhail.pozdnyakov Y29tbWl0IDk3ODcxNTk2NDk1YzA3OGYzZGU1ZTQ4NjZlZmZiNTE0MWVhZGY2ODgKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg U2F0IE5vdiAyNCAxNzo1MzoyMSAyMDEyICswMjAwCgogICAgYnVnMTAzMTc3CgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmlu ZGV4IDUyN2UzOWQuLmY4ZDQ4ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0x MS0yNCAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4K KworICAgICAgICBbRUZMXVtXSzJdIENoZWNrIGVycm9ycyBpbiBFd2tWaWV3IGNhbGxiYWNrcyB1 c2FnZSBhdCBjb21waWxlIHRpbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwMzE3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEVycm9ycyBpbiBFd2tWaWV3IGNhbGxiYWNrcyB1c2FnZSBhcmUgbm93IGNo ZWNrZWQgYXQgY29tcGlsZSB0aW1lLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvRXdr Vmlld0NhbGxiYWNrcy5oOgorICAgICAgICAoQ2FsbEJhY2spOgorICAgICAgICAoRXdrVmlld0Nh bGxiYWNrczo6Q2FsbEJhY2s6OkNhbGxCYWNrKToKKyAgICAgICAgKEV3a1ZpZXdDYWxsYmFja3M6 OkNhbGxCYWNrOjpjYWxsKToKKwogMjAxMi0xMS0yMyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2 aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEz NTU3NS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1Zp ZXdDYWxsYmFja3MuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdD YWxsYmFja3MuaAppbmRleCA0MTQwYzc0Li42NjI3OWRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3Q2FsbGJhY2tzLmgKKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0NhbGxiYWNrcy5oCkBAIC05Niw0OCArOTYs NTYgQEAgZW51bSBDYWxsYmFja1R5cGUgewogI2VuZGlmCiB9OwogCi10ZW1wbGF0ZTx0eXBlbmFt ZSBUPgotaW5saW5lIGJvb2wgY2FsbGJhY2tBcmd1bWVudHNFeHBlY3RlZCgpCi17Ci0gICAgcmV0 dXJuIHRydWU7Ci19Ci0KLXRlbXBsYXRlPD4KLWlubGluZSBib29sIGNhbGxiYWNrQXJndW1lbnRz RXhwZWN0ZWQ8dm9pZD4oKQotewotICAgIHJldHVybiBmYWxzZTsKLX0KLQogdGVtcGxhdGUgPENh bGxiYWNrVHlwZT4KLXN0cnVjdCBDYWxsQmFja0luZm8gewotICAgIHR5cGVkZWYgdm9pZCogVHlw ZTsKK3N0cnVjdCBDYWxsQmFja0luZm87CisKK3RlbXBsYXRlIDxDYWxsYmFja1R5cGUgY2FsbGJh Y2tUeXBlLCB0eXBlbmFtZSBBcmdUeXBlID0gdHlwZW5hbWUgQ2FsbEJhY2tJbmZvPGNhbGxiYWNr VHlwZT46OlR5cGU+CitjbGFzcyBDYWxsQmFjayB7CitwdWJsaWM6CisgICAgZXhwbGljaXQgQ2Fs bEJhY2soRXZhc19PYmplY3QqIHZpZXcpCisgICAgICAgIDogbV92aWV3KHZpZXcpCisgICAgewor ICAgICAgICBBU1NFUlQobV92aWV3KTsKKyAgICB9CiAKLSAgICBzdGF0aWMgaW5saW5lIGNvbnN0 IGNoYXIqIG5hbWUoKQorICAgIHZvaWQgY2FsbChBcmdUeXBlKiBhcmd1bWVudCkKICAgICB7Ci0g ICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwotICAgICAgICByZXR1cm4gIiI7CisgICAgICAg IGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2NhbGwobV92aWV3LCBDYWxsQmFja0luZm88Y2Fs bGJhY2tUeXBlPjo6bmFtZSgpLCBzdGF0aWNfY2FzdDx2b2lkKj4oYXJndW1lbnQpKTsKICAgICB9 CisKK3ByaXZhdGU6CisgICAgRXZhc19PYmplY3QqIG1fdmlldzsKIH07CiAKIHRlbXBsYXRlIDxD YWxsYmFja1R5cGUgY2FsbGJhY2tUeXBlPgotY2xhc3MgQ2FsbEJhY2sgeworY2xhc3MgQ2FsbEJh Y2sgPGNhbGxiYWNrVHlwZSwgdm9pZD4gewogcHVibGljOgotICAgIHR5cGVkZWYgdHlwZW5hbWUg Q2FsbEJhY2tJbmZvPGNhbGxiYWNrVHlwZT46OlR5cGUgQXJnVHlwZTsKLQogICAgIGV4cGxpY2l0 IENhbGxCYWNrKEV2YXNfT2JqZWN0KiB2aWV3KQogICAgICAgICA6IG1fdmlldyh2aWV3KQogICAg IHsKICAgICAgICAgQVNTRVJUKG1fdmlldyk7CiAgICAgfQogCi0gICAgdm9pZCBjYWxsKEFyZ1R5 cGUqIGFyZ3VtZW50ID0gMCkKKyAgICB2b2lkIGNhbGwoKQorICAgIHsKKyAgICAgICAgZXZhc19v YmplY3Rfc21hcnRfY2FsbGJhY2tfY2FsbChtX3ZpZXcsIENhbGxCYWNrSW5mbzxjYWxsYmFja1R5 cGU+OjpuYW1lKCksIDApOworICAgIH0KKworcHJpdmF0ZToKKyAgICBFdmFzX09iamVjdCogbV92 aWV3OworfTsKKwordGVtcGxhdGUgPENhbGxiYWNrVHlwZSBjYWxsYmFja1R5cGU+CitjbGFzcyBD YWxsQmFjayA8Y2FsbGJhY2tUeXBlLCBjaGFyPiB7CitwdWJsaWM6CisgICAgZXhwbGljaXQgQ2Fs bEJhY2soRXZhc19PYmplY3QqIHZpZXcpCisgICAgICAgIDogbV92aWV3KHZpZXcpCiAgICAgewot ICAgICAgICBpZiAoYXJndW1lbnQgJiYgIWNhbGxiYWNrQXJndW1lbnRzRXhwZWN0ZWQ8QXJnVHlw ZT4oKSkgewotICAgICAgICAgICAgQ1JJVElDQUwoInNob3VsZCBub3QgcGFzcyBhcmd1bWVudHMg Zm9yIHRoaXMgY2FsbGJhY2shIik7Ci0gICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsK LSAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgfQorICAgICAgICBBU1NFUlQobV92aWV3KTsK KyAgICB9CiAKKyAgICB2b2lkIGNhbGwoY2hhciogYXJndW1lbnQpCisgICAgewogICAgICAgICBl dmFzX29iamVjdF9zbWFydF9jYWxsYmFja19jYWxsKG1fdmlldywgQ2FsbEJhY2tJbmZvPGNhbGxi YWNrVHlwZT46Om5hbWUoKSwgc3RhdGljX2Nhc3Q8dm9pZCo+KGFyZ3VtZW50KSk7CiAgICAgfQog Cg==