103160 2012-11-23 14:27:25 -0800 [BlackBerry] Define platform limitations in platform layer 2012-11-23 17:31:08 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nima.ghanavatian nima.ghanavatian mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 774704 0 nima.ghanavatian 2012-11-23 14:27:25 -0800 Moving some static const's out of webkit repo; general cleanup in InputHandler. 774705 1 175836 nima.ghanavatian 2012-11-23 14:31:24 -0800 Created attachment 175836 Patch 774713 2 175836 rwlbuis 2012-11-23 15:13:24 -0800 Comment on attachment 175836 Patch LGTM. 774714 3 175836 webkit.review.bot 2012-11-23 15:15:46 -0800 Comment on attachment 175836 Patch Rejecting attachment 175836 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: angeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/blackberry/Api/WebPageClient.h Hunk #1 FAILED at 152. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/Api/WebPageClient.h.rej patching file Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp Hunk #3 succeeded at 616 (offset -4 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14970604 774719 4 175840 nima.ghanavatian 2012-11-23 15:35:32 -0800 Created attachment 175840 Patch 774720 5 nima.ghanavatian 2012-11-23 15:36:11 -0800 whoops, had another patch underneath this that caused a merge conflict. fixed now. 774730 6 175840 rwlbuis 2012-11-23 17:07:52 -0800 Comment on attachment 175840 Patch Ok. retrying. 774732 7 175840 webkit.review.bot 2012-11-23 17:31:05 -0800 Comment on attachment 175840 Patch Clearing flags on attachment: 175840 Committed r135639: <http://trac.webkit.org/changeset/135639> 774733 8 webkit.review.bot 2012-11-23 17:31:08 -0800 All reviewed patches have been landed. Closing bug. 175836 2012-11-23 14:31:24 -0800 2012-11-23 15:35:30 -0800 Patch bug-103160-20121123172348.patch text/plain 3407 nima.ghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA0Nzg4NTc0ZDQ4OWJmZTM1NDJmOWMyYTU3NGQ0ODk3OWM5YzI3ZDNjLi4zNWY0ZjVjYjZl OWVlNjk1MzdkNDk2Yjk5MGQxMTBmMTlkNjgyMDZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0xMS0yMyAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBEZWZpbmUgcGxhdGZv cm0gbGltaXRhdGlvbnMgaW4gcGxhdGZvcm0gbGF5ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzE2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRha2luZyBsZW5ndGggYXMgY29uc3QgdW5zaWduZWQg aW4gY2hlY2tTcGVsbGluZ09mU3RyaW5nQXN5bmMuCisgICAgICAgIFRoaXMgdmFsdWUgaXMgdW5j aGFuZ2luZyBhbmQgc2hvdWxkIG5ldmVyIGJlIGxlc3MgdGhhbiAwLCBldmVuCisgICAgICAgIGlu IGFuIGVycm9yIGNhc2UuCisKKyAgICAgICAgSW50ZXJuYWxseSByZXZpZXdlZCBieSBNaWtlIEZl bnRvbi4KKworICAgICAgICAqIEFwaS9XZWJQYWdlQ2xpZW50Lmg6CisgICAgICAgICogV2ViS2l0 U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJ bnB1dEhhbmRsZXI6OnJlcXVlc3RDaGVja2luZ09mU3RyaW5nKToKKwogMjAxMi0xMS0yMyAgQW5k cmV3IExvICA8YW5sb0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBJbnB1dEhhbmRs ZXI6OmVuc3VyZUZvY3VzVGV4dEVsZW1lbnRWaXNpYmxlIGluY29ycmVjdGx5IHVzZWQgeSBjb29y ZGluYXRlIGFzIHggY29vcmRpbmF0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L0FwaS9XZWJQYWdlQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dl YlBhZ2VDbGllbnQuaAppbmRleCBhNWM1ZWI0OGNhMTNjMmJmZGM2ZDAyZTNkMTliODMwZWJlZmIx NzQ1Li5kZGQwMGRjMmJjYjk1MmFkYzMzYjRhZjc0MDUwYWU1YzFjYzE0OTk0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaApAQCAtMTUyLDcgKzE1Miw3 IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgc2hvd1ZpcnR1YWxLZXlib2FyZChib29sKSA9 IDA7CiAKICAgICB2aXJ0dWFsIHZvaWQgcmVxdWVzdFNwZWxsaW5nQ2hlY2tpbmdPcHRpb25zKGlt Zl9zcF90ZXh0X3QmLCBjb25zdCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6SW50UmVjdCYgZG9jdW1l bnRDYXJldFJlY3QsIGNvbnN0IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpJbnRTaXplJiBzY3JlZW5P ZmZzZXQsIGNvbnN0IGJvb2wgc2hvdWxkTW92ZURpYWxvZykgPSAwOwotICAgIHZpcnR1YWwgaW50 MzJfdCBjaGVja1NwZWxsaW5nT2ZTdHJpbmdBc3luYyh3Y2hhcl90KiB0ZXh0LCBpbnQgbGVuZ3Ro KSA9IDA7CisgICAgdmlydHVhbCBpbnQzMl90IGNoZWNrU3BlbGxpbmdPZlN0cmluZ0FzeW5jKHdj aGFyX3QqIHRleHQsIGNvbnN0IHVuc2lnbmVkIGxlbmd0aCkgPSAwOwogCiAgICAgdmlydHVhbCB2 b2lkIG5vdGlmeVNlbGVjdGlvbkRldGFpbHNDaGFuZ2VkKGNvbnN0IFBsYXRmb3JtOjpJbnRSZWN0 JiBkb2N1bWVudFN0YXJ0UmVjdCwgY29uc3QgUGxhdGZvcm06OkludFJlY3QmIGRvY3VtZW50RW5k UmVjdCwgY29uc3QgUGxhdGZvcm06OkludFJlY3RSZWdpb24mIGRvY3VtZW50UmVnaW9uLCBib29s IG92ZXJyaWRlVG91Y2hIYW5kbGluZyA9IGZhbHNlKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGNh bmNlbFNlbGVjdGlvblZpc3VhbHMoKSA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAppbmRleCA5NjVlZmEwMjVj ZTBkYmM1NTk5YjI4NjVlZjBlMDdjMGNmZTU1NGRhLi5kZGFmZDUzNWVjMGY1MDcxMGJlOWYxMGY3 YTBjYzdjZmI0ZDUyY2JmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2Vi S2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKQEAgLTY0LDYgKzY0LDcgQEAKICNpbmNs dWRlICJodG1sZWRpdGluZy5oIgogI2luY2x1ZGUgInZpc2libGVfdW5pdHMuaCIKIAorI2luY2x1 ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUlNRi5oPgogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9y bUtleWJvYXJkRXZlbnQuaD4KICNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1Mb2cuaD4KICNp bmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1NaXNjLmg+CkBAIC03Nyw3ICs3OCw2IEBACiAjZGVm aW5lIEVOQUJMRV9TUEVMTElOR19MT0cgMAogCiBzdGF0aWMgY29uc3QgdW5zaWduZWQgTWF4TGVh cm5UZXh0RGF0YVNpemUgPSA1MDA7Ci1zdGF0aWMgY29uc3QgdW5zaWduZWQgTWF4U3BlbGxDaGVj a2luZ1N0cmluZ0xlbmd0aCA9IDI1MDsKIAogdXNpbmcgbmFtZXNwYWNlIEJsYWNrQmVycnk6OlBs YXRmb3JtOwogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CkBAIC02MjAsNyArNjIwLDcgQEAgdm9p ZCBJbnB1dEhhbmRsZXI6OnJlcXVlc3RDaGVja2luZ09mU3RyaW5nKFBhc3NSZWZQdHI8V2ViQ29y ZTo6VGV4dENoZWNraW5nUmVxdWUKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIG1fcHJv Y2Vzc2luZ1RyYW5zYWN0aW9uSWQgPSBtX3dlYlBhZ2UtPm1fY2xpZW50LT5jaGVja1NwZWxsaW5n T2ZTdHJpbmdBc3luYyhjaGVja2luZ1N0cmluZywgcGFyYWdyYXBoTGVuZ3RoKTsKKyAgICBtX3By b2Nlc3NpbmdUcmFuc2FjdGlvbklkID0gbV93ZWJQYWdlLT5tX2NsaWVudC0+Y2hlY2tTcGVsbGlu Z09mU3RyaW5nQXN5bmMoY2hlY2tpbmdTdHJpbmcsIHN0YXRpY19jYXN0PHVuc2lnbmVkPihwYXJh Z3JhcGhMZW5ndGgpKTsKICAgICBmcmVlKGNoZWNraW5nU3RyaW5nKTsKIAogICAgIC8vIElmIHRo ZSBjYWxsIHRvIHRoZSBpbnB1dCBzZXJ2aWNlIGRpZCBub3QgZ28gdGhyb3VnaCwgdGhlbiBjYW5j ZWwgdGhlIHJlcXVlc3Qgc28gd2UgZG9uJ3QgYmxvY2sgZW5kbGVzc2x5Lgo= 175840 2012-11-23 15:35:32 -0800 2012-11-23 17:31:04 -0800 Patch bug-103160-20121123182755.patch text/plain 3337 nima.ghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBkYTE2MjhmZWUxY2E1NjZkN2RiNzZkNTNiMDdmMzQxZDI0Y2QxODk5Li4xOWM3MTdlMzdm MzE5Yzc0YmQ4NGRiZTNkNDhkNjNkMzU3M2M1ODAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0xMS0yMyAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBEZWZpbmUgcGxhdGZv cm0gbGltaXRhdGlvbnMgaW4gcGxhdGZvcm0gbGF5ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzE2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRha2luZyBsZW5ndGggYXMgY29uc3QgdW5zaWduZWQg aW4gY2hlY2tTcGVsbGluZ09mU3RyaW5nQXN5bmMuCisgICAgICAgIFRoaXMgdmFsdWUgaXMgdW5j aGFuZ2luZyBhbmQgc2hvdWxkIG5ldmVyIGJlIGxlc3MgdGhhbiAwLCBldmVuCisgICAgICAgIGlu IGFuIGVycm9yIGNhc2UuCisKKyAgICAgICAgSW50ZXJuYWxseSByZXZpZXdlZCBieSBNaWtlIEZl bnRvbi4KKworICAgICAgICAqIEFwaS9XZWJQYWdlQ2xpZW50Lmg6CisgICAgICAgICogV2ViS2l0 U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJ bnB1dEhhbmRsZXI6OnJlcXVlc3RDaGVja2luZ09mU3RyaW5nKToKKwogMjAxMi0xMS0yMyAgSmFj a3kgSmlhbmcgIDx6aGFqaWFuZ0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBNZXRh IHZpZXdwb3J0IGNhbid0IGJlIGNoYW5nZWQgZHluYW1pY2FsbHkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNsaWVudC5oIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50LmgKaW5kZXggMjZkZGYwOTE4ZGZhN2EyOWZiYWU3 MTEwNjkwNjk0ZTNiYzg1ZjE3Yi4uZmY2ZjJkM2EyNGE0MWNmN2NmMTMxNGE5NjFiMWRkYmE5ZGU1 NjQyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xp ZW50LmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50LmgK QEAgLTE1MSw3ICsxNTEsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNob3dWaXJ0dWFs S2V5Ym9hcmQoYm9vbCkgPSAwOwogCiAgICAgdmlydHVhbCB2b2lkIHJlcXVlc3RTcGVsbGluZ0No ZWNraW5nT3B0aW9ucyhpbWZfc3BfdGV4dF90JiwgY29uc3QgQmxhY2tCZXJyeTo6UGxhdGZvcm06 OkludFJlY3QmIGRvY3VtZW50Q2FyZXRSZWN0LCBjb25zdCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6 SW50U2l6ZSYgc2NyZWVuT2Zmc2V0KSA9IDA7Ci0gICAgdmlydHVhbCBpbnQzMl90IGNoZWNrU3Bl bGxpbmdPZlN0cmluZ0FzeW5jKHdjaGFyX3QqIHRleHQsIGludCBsZW5ndGgpID0gMDsKKyAgICB2 aXJ0dWFsIGludDMyX3QgY2hlY2tTcGVsbGluZ09mU3RyaW5nQXN5bmMod2NoYXJfdCogdGV4dCwg Y29uc3QgdW5zaWduZWQgbGVuZ3RoKSA9IDA7CiAKICAgICB2aXJ0dWFsIHZvaWQgbm90aWZ5U2Vs ZWN0aW9uRGV0YWlsc0NoYW5nZWQoY29uc3QgUGxhdGZvcm06OkludFJlY3QmIGRvY3VtZW50U3Rh cnRSZWN0LCBjb25zdCBQbGF0Zm9ybTo6SW50UmVjdCYgZG9jdW1lbnRFbmRSZWN0LCBjb25zdCBQ bGF0Zm9ybTo6SW50UmVjdFJlZ2lvbiYgZG9jdW1lbnRSZWdpb24sIGJvb2wgb3ZlcnJpZGVUb3Vj aEhhbmRsaW5nID0gZmFsc2UpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgY2FuY2VsU2VsZWN0aW9u VmlzdWFscygpID0gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJL aXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2Vi S2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCmluZGV4IDZhMzlhYTVkNTg0Mzg2ZmRkNTljYjFl Y2YxYjkyZWU4Y2RhZjZkZTUuLjExNWIyZmJjNGJiOTBhMjIzMDI0OTgzMTBlY2M4YjhkZDgwN2M2 NzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lu cHV0SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBv cnQvSW5wdXRIYW5kbGVyLmNwcApAQCAtNjQsNiArNjQsNyBAQAogI2luY2x1ZGUgImh0bWxlZGl0 aW5nLmgiCiAjaW5jbHVkZSAidmlzaWJsZV91bml0cy5oIgogCisjaW5jbHVkZSA8QmxhY2tCZXJy eVBsYXRmb3JtSU1GLmg+CiAjaW5jbHVkZSA8QmxhY2tCZXJyeVBsYXRmb3JtS2V5Ym9hcmRFdmVu dC5oPgogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUxvZy5oPgogI2luY2x1ZGUgPEJsYWNr QmVycnlQbGF0Zm9ybU1pc2MuaD4KQEAgLTc3LDcgKzc4LDYgQEAKICNkZWZpbmUgRU5BQkxFX1NQ RUxMSU5HX0xPRyAwCiAKIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBNYXhMZWFyblRleHREYXRhU2l6 ZSA9IDUwMDsKLXN0YXRpYyBjb25zdCB1bnNpZ25lZCBNYXhTcGVsbENoZWNraW5nU3RyaW5nTGVu Z3RoID0gMjUwOwogCiB1c2luZyBuYW1lc3BhY2UgQmxhY2tCZXJyeTo6UGxhdGZvcm07CiB1c2lu ZyBuYW1lc3BhY2UgV2ViQ29yZTsKQEAgLTYxNiw3ICs2MTYsNyBAQCB2b2lkIElucHV0SGFuZGxl cjo6cmVxdWVzdENoZWNraW5nT2ZTdHJpbmcoUGFzc1JlZlB0cjxXZWJDb3JlOjpUZXh0Q2hlY2tp bmdSZXF1ZQogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgbV9wcm9jZXNzaW5nVHJhbnNh Y3Rpb25JZCA9IG1fd2ViUGFnZS0+bV9jbGllbnQtPmNoZWNrU3BlbGxpbmdPZlN0cmluZ0FzeW5j KGNoZWNraW5nU3RyaW5nLCBwYXJhZ3JhcGhMZW5ndGgpOworICAgIG1fcHJvY2Vzc2luZ1RyYW5z YWN0aW9uSWQgPSBtX3dlYlBhZ2UtPm1fY2xpZW50LT5jaGVja1NwZWxsaW5nT2ZTdHJpbmdBc3lu YyhjaGVja2luZ1N0cmluZywgc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHBhcmFncmFwaExlbmd0aCkp OwogICAgIGZyZWUoY2hlY2tpbmdTdHJpbmcpOwogCiAgICAgLy8gSWYgdGhlIGNhbGwgdG8gdGhl IGlucHV0IHNlcnZpY2UgZGlkIG5vdCBnbyB0aHJvdWdoLCB0aGVuIGNhbmNlbCB0aGUgcmVxdWVz dCBzbyB3ZSBkb24ndCBibG9jayBlbmRsZXNzbHkuCg==