103159 2012-11-23 12:52:43 -0800 Removing unnecessary RenderBox friend access in RenderObject 2012-11-23 14:04:58 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 0 savagobr webkit-unassigned abarth darin eric hyatt kenneth ojan webkit.review.bot oldest_to_newest 774686 0 savagobr 2012-11-23 12:52:43 -0800 RenderObject has several classes marked as friend, thus allowing full access to its private and protected members. Between those friends, one of them (RenderBox) is actually derived from it indirectly and is not accessing its forefather private data members/functions. This patch removes the unnecessary friend keyword from RenderObject. 774687 1 175835 savagobr 2012-11-23 13:00:44 -0800 Created attachment 175835 The patch v01 774695 2 175835 eric 2012-11-23 13:50:33 -0800 Comment on attachment 175835 The patch v01 I assume this was for accessing private: members? RenderBlock and REnderSVGContainer also derive from RenderObject. 774698 3 175835 webkit.review.bot 2012-11-23 14:04:54 -0800 Comment on attachment 175835 The patch v01 Clearing flags on attachment: 175835 Committed r135633: <http://trac.webkit.org/changeset/135633> 774699 4 webkit.review.bot 2012-11-23 14:04:58 -0800 All reviewed patches have been landed. Closing bug. 175835 2012-11-23 13:00:44 -0800 2012-11-23 14:04:54 -0800 The patch v01 0001-Removing-unnecessary-friend-access.patch text/plain 1846 savagobr RnJvbSBmZDEwNjY1ZGFjZWJiMzk1OGUyYjEzOGMxMWQ0M2M3MGQzM2U5MmM4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVuaWxzb24gQ2F2YWxjYW50aSA8Y2F2YWxjYW50aWlAZ21h aWwuY29tPgpEYXRlOiBGcmksIDIzIE5vdiAyMDEyIDE2OjU3OjEwIC0wNDAwClN1YmplY3Q6IFtQ QVRDSF0gUmVtb3ZpbmcgdW5uZWNlc3NhcnkgZnJpZW5kIGFjY2Vzcy4KClNpZ25lZC1vZmYtYnk6 IEFkZW5pbHNvbiBDYXZhbGNhbnRpIDxjYXZhbGNhbnRpaUBnbWFpbC5jb20+Ci0tLQogU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgIHwgICAxNiArKysrKysrKysrKysrKysr CiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmggfCAgICAxIC0KIDIgZmls ZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCA1ZDM1NzE0Li5lZWRhZjM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMTEt MjMgIEFkZW5pbHNvbiBDYXZhbGNhbnRpICA8Y2F2YWxjYW50aWlAZ21haWwuY29tPgorCisgICAg ICAgIFJlbW92aW5nIHVubmVjZXNzYXJ5IFJlbmRlckJveCBmcmllbmQgYWNjZXNzIGluIFJlbmRl ck9iamVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAzMTU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmVuZGVyT2JqZWN0IGhhcyBzZXZlcmFsIGNsYXNzZXMgbWFya2VkIGFzIGZyaWVuZCwgYmV0d2Vl biB0aGVtLAorICAgICAgICB0aGVyZSBpcyBSZW5kZXJCb3ggd2hpY2ggaXMgZGVyaXZlZCBmcm9t IGl0IGluZGlyZWN0bHkgYW5kIGlzIG5vdCBhY2Nlc3NpbmcKKyAgICAgICAgaXRzIGZvcmVmYXRo ZXIgcHJpdmF0ZSBkYXRhIG1ha2luZyB1bm5lY2Vzc2FyeSB0aGUgJ2ZyaWVuZCcgYWNjZXNzIGxl dmVsLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gY2hhbmdlcyBpbiBmdW5jdGlvbmFsaXR5 LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oOgorICAgICAgICAoUmVuZGVy T2JqZWN0KToKKwogMjAxMi0xMS0yMyAgRGFuIENhcm5leSAgPGRjYXJuZXlAZ29vZ2xlLmNvbT4K IAogICAgICAgICBSZW1vdmUgVjhET01XaW5kb3dTaGVsbDo6Z2V0RW50ZXJlZApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCmluZGV4IDExOGE5OTYuLjlmZmJjZmIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgKQEAgLTE1Nyw3ICsxNTcsNiBAQCBj b25zdCBpbnQgc2hvd1RyZWVDaGFyYWN0ZXJPZmZzZXQgPSAzOTsKIGNsYXNzIFJlbmRlck9iamVj dCA6IHB1YmxpYyBDYWNoZWRJbWFnZUNsaWVudCB7CiAgICAgZnJpZW5kIGNsYXNzIExheW91dFJl cGFpbnRlcjsKICAgICBmcmllbmQgY2xhc3MgUmVuZGVyQmxvY2s7Ci0gICAgZnJpZW5kIGNsYXNz IFJlbmRlckJveDsKICAgICBmcmllbmQgY2xhc3MgUmVuZGVyTGF5ZXI7CiAgICAgZnJpZW5kIGNs YXNzIFJlbmRlck9iamVjdENoaWxkTGlzdDsKICAgICBmcmllbmQgY2xhc3MgUmVuZGVyU1ZHQ29u dGFpbmVyOwotLSAKMS43LjEwLjQKCg==