103153 2012-11-23 10:49:47 -0800 [CSS Regions] renderer is attached improperly when undo affects a node inside a flow thread 2012-11-29 02:01:20 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 103501 P2 Normal --- 103501 57312 1 pravind.2k4 pravind.2k4 abucur jchaffraix rniwa WebkitBugTracker oldest_to_newest 774644 0 pravind.2k4 2012-11-23 10:49:47 -0800 Steps to repo: 1) Select all the text inside the red box. 2) Press indent button(once). 3) Press Undo. Do the same with text inside the green box n compare. The behavior in the green is correct. The issue is with red box. 774645 1 175828 pravind.2k4 2012-11-23 10:50:21 -0800 Created attachment 175828 TestCase 774648 2 pravind.2k4 2012-11-23 10:55:11 -0800 The issue is due to the fact that in case of text nodes which get inserted into anonymous block, insertbefore does not work properly. When Indent button is pressed, the nodes from <div class="artical" contenteditable="true"> are removed in the order "Non-Workingcase1", <br>, "Non-Workingcase2" and placed inside htmlQuote elem. When Undo button is pressed, the reverse should happen. The content from htmlquote is removed and inserted into the original div, in the reverse order. (Skipping the node removals) "Non-Workingcase 2" is first inserted to div. As its a text node, an Anonymous Block is created. Then an attempt to insert <br > before "Non-Workingcase 2 " is made. While doing so "Non-Workingcase 2 " 's renderer is queried to check if its part of same flow thread as <div class="artical" contenteditable="true"> . However as the parent of "Non-Workingcase2 " is an Anonymous Block , flow thread info is not set and results in a mismatch. So the renderer before which <br> must be inserted comes null. Which results in <br> being appended to the Anonymous Block .... {"Non-Workingcase 2 " , <br> } . When an attemp to insert "Non-Workingcase 1" before <br> is made, it succeeds as <br> does not have any flowthread info, n proper renderer is returmed resulting in {"Non-Workingcase 2 " , "Non-Workingcase 1", <br> } . Will try n upload a better testcase. 775736 3 rniwa 2012-11-26 11:51:08 -0800 (In reply to comment #2) > Then an attempt to insert <br > before "Non-Workingcase 2 " is made. While doing so "Non-Workingcase 2 " 's renderer is queried to check if its part of same flow thread as <div class="artical" contenteditable="true">. Who does this check? 776423 4 pravind.2k4 2012-11-27 00:02:37 -0800 (In reply to comment #3) > (In reply to comment #2) > > Then an attempt to insert <br > before "Non-Workingcase 2 " is made. While doing so "Non-Workingcase 2 " 's renderer is queried to check if its part of same flow thread as <div class="artical" contenteditable="true">. > > Who does this check? > The check is done in nextRenderer() in NodeRenderingContext.cpp . if (renderer->style() && !renderer->style()->flowThread().isEmpty()) continue; However the fix need not be here. I think I'll submit a sample patch, so that we'll have more context to discuss the issue. Thank you Rniwa 777128 5 176328 abucur 2012-11-27 12:41:55 -0800 Created attachment 176328 Same issue different repro? 778125 6 rniwa 2012-11-28 11:42:14 -0800 I don't understand this bug. Undo/redo code should not be accessing renderer at all other than to check its editability. If you're saying that attach/detach doesn't work properly, then that's a layout bug, not an editing bug. 778686 7 pravind.2k4 2012-11-28 21:56:27 -0800 (In reply to comment #6) > I don't understand this bug. Undo/redo code should not be accessing renderer at all other than to check its editability. If you're saying that attach/detach doesn't work properly, then that's a layout bug, not an editing bug. > Yes its an layout and rendering bug only. The component is also set to the same. 778833 8 abucur 2012-11-29 02:01:20 -0800 *** This bug has been marked as a duplicate of bug 103501 *** 175828 2012-11-23 10:50:21 -0800 2012-11-23 10:50:21 -0800 TestCase test.html text/html 789 pravind.2k4 PGh0bWw+DQo8aGVhZD4NCjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4NCmZ1bmN0aW9u IENoYW5nZUluZGVudCgpDQp7DQogIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJJbmRlbnQiLCBmYWxz ZSwgMCk7ICANCn0NCg0KZnVuY3Rpb24gQ2hhbmdlVW5kbygpDQp7DQogIGRvY3VtZW50LmV4ZWND b21tYW5kKCJVbmRvIiwgZmFsc2UsIDApOyAgDQp9DQoNCjwvc2NyaXB0Pg0KPHN0eWxlIHR5cGU9 InRleHQvY3NzIj4NCi5hcnRpY2Fsew0KIC13ZWJraXQtZmxvdy1pbnRvOiB0aHJlYWQ7DQogYm9y ZGVyOiAycHggc29saWQgcmVkOw0KfQ0KLnJlZ2lvbnsNCmhlaWdodDogMTAwcHg7DQotd2Via2l0 LWZsb3ctZnJvbTp0aHJlYWQ7DQpib3JkZXIgOiAycHggc29saWQgYmx1ZTsNCn0NCjwvc3R5bGU+ DQo8L2hlYWQ+DQo8Ym9keT4NCjxpbnB1dCB0eXBlPSJCdXR0b24iIG9uY2xpY2s9IkNoYW5nZUlu ZGVudCgpIiB2YWx1ZT0iSW5kZW50Ij4NCjxpbnB1dCB0eXBlPSJCdXR0b24iIG9uY2xpY2s9IkNo YW5nZVVuZG8oKSIgdmFsdWU9IlVuZG8iPg0KPGRpdiBjbGFzcz0iYXJ0aWNhbCIgY29udGVudGVk aXRhYmxlPSJ0cnVlIj4NCk5vbi1Xb3JraW5nQ2FzZSAxPGJyPk5vbi1Xb3JraW5nQ2FzZSAyLg0K PC9kaXY+DQo8ZGl2IHN0eWxlPSJib3JkZXI6IDJweCBzb2xpZCBncmVlbjsiIGNvbnRlbnRlZGl0 YWJsZT0idHJ1ZSI+DQpXb3JraW5nQ2FzZSAxPGJyPldvcmtpbmdDYXNlIDIuDQo8L2Rpdj4NCjxi cj4NCjxkaXYgY2xhc3M9InJlZ2lvbiI+PC9kaXY+DQo8L2JvZHk+DQo8L2h0bWw+ 176328 2012-11-27 12:41:55 -0800 2012-11-27 12:41:55 -0800 Same issue different repro? test_hover.html text/html 1275 abucur PCFkb2N0eXBlIGh0bWw+DQo8aHRtbD4NCiAgICA8aGVhZD4NCiAgICAgICAgPHN0eWxlPg0KICAg ICAgICAgICAgLmNvbnRlbnQgeyAtd2Via2l0LWZsb3ctaW50bzogY29udGVudC1mbG93OyB9DQoN CiAgICAgICAgICAgIC5yZWdpb24gew0KICAgICAgICAgICAgICAgIC13ZWJraXQtZmxvdy1mcm9t OiBjb250ZW50LWZsb3c7DQogICAgICAgICAgICAgICAgaGVpZ2h0OiA1MDBweDsNCiAgICAgICAg ICAgICAgICB3aWR0aDogNjAwcHg7DQogICAgICAgICAgICAgICAgYm9yZGVyOiAxcHggc29saWQg YmxhY2s7DQogICAgICAgICAgICB9DQoNCiAgICAgICAgICAgIHAgew0KICAgICAgICAgICAgICAg IGRpc3BsYXk6IGlubGluZTsNCiAgICAgICAgICAgIH0NCg0KICAgICAgICAgICAgZGl2LmNvbnRl bnQ6aG92ZXIgcCB7DQogICAgICAgICAgICAgICAgZGlzcGxheTogYmxvY2s7DQogICAgICAgICAg ICB9DQogICAgICAgIDwvc3R5bGU+DQogICAgPC9oZWFkPg0KICAgIDxib2R5Pg0KICAgICAgICA8 ZGl2IGNsYXNzPSJjb250ZW50Ij4NCiAgICAgICAgICAgIHgNCiAgICAgICAgICAgIDxwPlRlc3Qg Zm9yIDxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI5 NTciPiBbQ1NTIFJlZ2lvbnNdIENyYXNoIHdoZW4gdXNpbmcgaG92ZXIgYW5kIGZpcnN0LWxldHRl ciBpbnNpZGUgYSBmbG93LXRocmVhZDwvYT4uPC9wPg0KICAgICAgICAgICAgPHA+T24gc3VjY2Vz cywgaXQgc2hvdWxkIG5vdCBjcmFzaCBvciBhc3NlcnQuPC9wPg0KICAgICAgICAgICAgPHA+T24g c3VjY2VzcywgaXQgc2hvdWxkIG5vdCBjcmFzaCBvciBhc3NlcnQuPC9wPg0KICAgICAgICAgICAg PHA+T24gc3VjY2VzcywgaXQgc2hvdWxkIG5vdCBjcmFzaCBvciBhc3NlcnQuPC9wPg0KICAgICAg ICAgICAgeA0KICAgICAgICA8L2Rpdj4NCiAgICAgICAgPGRpdiBjbGFzcz0icmVnaW9uIj48L2Rp dj4NCg0KICAgICAgICA8c2NyaXB0Pg0KICAgICAgICAgICAgZG9jdW1lbnQuYm9keS5vZmZzZXRU b3A7DQogICAgICAgICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpIHsNCiAgICAgICAgICAgICAg ICB3aW5kb3cudGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7DQogICAgICAgICAgICAgICAgZXZlbnRT ZW5kZXIubW91c2VNb3ZlVG8oNTAsIDUwKTsNCiAgICAgICAgICAgICAgICBldmVudFNlbmRlci5t b3VzZU1vdmVUbyg1MCwgNDAwKTsNCiAgICAgICAgICAgIH0NCiAgICAgICAgPC9zY3JpcHQ+DQog ICAgPC9ib2R5Pg0KPC9odG1sPg0K