103151 2012-11-23 09:48:25 -0800 [GStreamer] verify if GStreamer was previously initialized 2012-11-27 07:59:27 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 vjaquez webkit-unassigned gustavo menard mrobinson pnormand webkit-ews webkit.review.bot oldest_to_newest 774625 0 vjaquez 2012-11-23 09:48:25 -0800 by using gst_is_initialized() in initializeGStreamer() This may be useful for WK1, so the the application can initialize GStreamer before. 774630 1 175824 vjaquez 2012-11-23 10:01:15 -0800 Created attachment 175824 Patch 774633 2 175824 webkit-ews 2012-11-23 10:06:25 -0800 Comment on attachment 175824 Patch Attachment 175824 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14970528 774634 3 175824 webkit-ews 2012-11-23 10:06:58 -0800 Comment on attachment 175824 Patch Attachment 175824 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14962777 774650 4 vjaquez 2012-11-23 11:01:29 -0800 What version of GStreamer does Qt port use? The gst_is_initialized() appeared in 0.10.31 http://gstreamer.freedesktop.org/data/doc/gstreamer/0.10.36/gstreamer/html/gstreamer-Gst.html#gst-is-initialized 774657 5 menard 2012-11-23 11:17:10 -0800 (In reply to comment #4) > What version of GStreamer does Qt port use? > > The gst_is_initialized() appeared in 0.10.31 > > http://gstreamer.freedesktop.org/data/doc/gstreamer/0.10.36/gstreamer/html/gstreamer-Gst.html#gst-is-initialized If the EWS is the same machine as http://build.webkit.org/buildslaves/szeged-linux-1 then it's Debian Squeeze (6.0) so 0.10.30 774800 6 175824 pnormand 2012-11-24 00:30:54 -0800 Comment on attachment 175824 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175824&action=review Looks good overall, have a look at the other ChangeLog entries to see how they're structured :) > Source/WebCore/ChangeLog:5 > + Verify if GStreamer was previously initialized > + > + The patch also contains the proof of concept for GtkLaunch Please move this down the Reviewed by line. Also it's GtkLauncher. And maybe you can explain why the same is not done for the WK2 MiniBrowser. > Source/WebCore/ChangeLog:12 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). This one should be replaced by the 2 lines above. > Source/WebCore/ChangeLog:14 > + No new tests (OOPS!). Usually for a small patch like this without any impact on the tests we state something like "No new tests, existing media tests cover this change." > Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:32 > + if (gst_is_initialized ()) We don't allow space between the function name and the parenthesis, usually. Maybe the style bot can check that. Also as this is an API introduced in 0.10.31 and we require 0.10.30 in configure.ac it'd be nice to wrap this code in a #if GST_CHECK_VERSION(0, 10, 31) block. > Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:33 > + return true; A blank line wouldn't hurt after this one :) > Tools/ChangeLog:5 > + Verify if GStreamer was previously initialized > + > + The patch also contains the proof of concept for GtkLaunch Well the same apply to this ChangeLog and please don't copy-paste from the other one :) It'd be fine if this entry mentions only the change related to the GtkLauncher. 775689 7 176038 vjaquez 2012-11-26 11:10:18 -0800 Created attachment 176038 Patch 775703 8 176038 pnormand 2012-11-26 11:25:20 -0800 Comment on attachment 176038 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176038&action=review Ok almost perfect! > Source/WebCore/ChangeLog:17 > + No new tests (OOPS!). I think the commit queue will not like the OOPS. I think I mentioned previously that you can state existing media tests cover this change. > Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:33 > + if (gst_is_initialized ()) Can you please remove the space after the function name? :) > Tools/ChangeLog:14 > + This approach is not valid for MiniBrowser because it uses WebKit2, > + where the GStreamer backend lives in the web process, which is > + different from the UI process. Nice explanation! 776722 9 176260 vjaquez 2012-11-27 07:02:14 -0800 Created attachment 176260 Patch 776723 10 vjaquez 2012-11-27 07:03:03 -0800 (In reply to comment #8) > (From update of attachment 176038 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=176038&action=review > > Ok almost perfect! Hi Phil! Thanks again for the review. I hope now everything correct. 776751 11 176260 webkit.review.bot 2012-11-27 07:59:23 -0800 Comment on attachment 176260 Patch Clearing flags on attachment: 176260 Committed r135863: <http://trac.webkit.org/changeset/135863> 776753 12 webkit.review.bot 2012-11-27 07:59:27 -0800 All reviewed patches have been landed. Closing bug. 175824 2012-11-23 10:01:15 -0800 2012-11-26 11:10:12 -0800 Patch bug-103151-20121123185858.patch text/plain 4236 vjaquez U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzQwYTUzNjU2YjAxOTkw YWIxMzM5ZGE3NGJlYWU1ZmEzNzIxMDM1Mi4uOTJmNWYxYjIwMGJlODdiNzJhNTZlMjAyMjQzMjgz MTRhMWY0NzBhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTExLTIzICBWw61j dG9yIE1hbnVlbCBKw6FxdWV6IExlYWwgIDx2amFxdWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAg VmVyaWZ5IGlmIEdTdHJlYW1lciB3YXMgcHJldmlvdXNseSBpbml0aWFsaXplZAorCisgICAgICAg IFRoZSBwYXRjaCBhbHNvIGNvbnRhaW5zIHRoZSBwcm9vZiBvZiBjb25jZXB0IGZvciBHdGtMYXVu Y2gKKworICAgICAgICBbR1N0cmVhbWVyXSB2ZXJpZnkgaWYgR1N0cmVhbWVyIHdhcyBwcmV2aW91 c2x5IGluaXRpYWxpemVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMDMxNTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGRpdGlvbmFsIGluZm9ybWF0aW9uIG9mIHRoZSBjaGFuZ2Ugc3VjaCBhcyBhcHBy b2FjaCwgcmF0aW9uYWxlLiBQbGVhc2UgYWRkIHBlci1mdW5jdGlvbiBkZXNjcmlwdGlvbnMgYmVs b3cgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJVdGlsaXRpZXMuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6aW5pdGlhbGl6ZUdTdHJlYW1lcik6CisKIDIwMTItMTEtMjEgIEhhcmFs ZCBBbHZlc3RyYW5kICA8aHRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgV2ViTWVkaWFTdHJlYW1D b21wb25lbnQ6IEFkZCBhc3NpZ25tZW50IGFuZCBjb3B5IG9wZXJhdG9ycwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lclV0aWxp dGllcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0 cmVhbWVyVXRpbGl0aWVzLmNwcAppbmRleCBhYzM2M2E3NWQyNWM4YWVlMDk4NWExNTEyZmMxZTlj NzVhM2E1NTJiLi5iNzVhODYxNmQ4YzI1NWRhNzZhMDU1OWM2ODBmZDAyOGE1MWEwMjU3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVh bWVyVXRpbGl0aWVzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvR1N0cmVhbWVyVXRpbGl0aWVzLmNwcApAQCAtMjksNiArMjksOCBAQCBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKIGJvb2wgaW5pdGlhbGl6ZUdTdHJlYW1lcigpCiB7CisgICAgaWYgKGdz dF9pc19pbml0aWFsaXplZCAoKSkKKyAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgR093blB0cjxH RXJyb3I+IGVycm9yOwogICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgcHJvYmFibHkgcGFzcyB0aGUg YXJndW1lbnRzIGZyb20gdGhlIGNvbW1hbmQgbGluZS4KICAgICBib29sIGdzdEluaXRpYWxpemVk ID0gZ3N0X2luaXRfY2hlY2soMCwgMCwgJmVycm9yLm91dFB0cigpKTsKZGlmZiAtLWdpdCBhL1Rv b2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlOTFjMGVlMjUwNzMwOTRlMGY4 YjJkYWE0MjljN2QyYTgwMTYxZTc2Li5kZWYzZGRmOWI1OGRjMmJkOGExODg2ZmU4ODhhMDZlMjdi NGUxYjA3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMjAgQEAKKzIwMTItMTEtMjMgIFbDrWN0b3IgTWFudWVsIErDoXF1ZXogTGVh bCAgPHZqYXF1ZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBWZXJpZnkgaWYgR1N0cmVhbWVyIHdh cyBwcmV2aW91c2x5IGluaXRpYWxpemVkCisKKyAgICAgICAgVGhlIHBhdGNoIGFsc28gY29udGFp bnMgdGhlIHByb29mIG9mIGNvbmNlcHQgZm9yIEd0a0xhdW5jaAorCisgICAgICAgIFtHU3RyZWFt ZXJdIHZlcmlmeSBpZiBHU3RyZWFtZXIgd2FzIHByZXZpb3VzbHkgaW5pdGlhbGl6ZWQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzE1MQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGl0aW9uYWwgaW5m b3JtYXRpb24gb2YgdGhlIGNoYW5nZSBzdWNoIGFzIGFwcHJvYWNoLCByYXRpb25hbGUuIFBsZWFz ZSBhZGQgcGVyLWZ1bmN0aW9uIGRlc2NyaXB0aW9ucyBiZWxvdyAoT09QUyEpLgorCisgICAgICAg ICogR05VbWFrZWZpbGUuYW06CisgICAgICAgICogR3RrTGF1bmNoZXIvbWFpbi5jOgorICAgICAg ICAobWFpbik6CisKIDIwMTItMTEtMjEgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25AaW50ZWwu Y29tPiwgR3l1eW91bmcgS2ltIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAg W0VGTF0gVHVybiBvbiBXVEZfVVNFX1RJTEVEX0JBQ0tJTkdfU1RPUkUgYnkgZGVmYXVsdApkaWZm IC0tZ2l0IGEvVG9vbHMvR05VbWFrZWZpbGUuYW0gYi9Ub29scy9HTlVtYWtlZmlsZS5hbQppbmRl eCA2MDU4YmU4ZWM5ZDJmODVlZDg4MDE3ZTdmM2M2NDZmNjcyYWZkOWIxLi44MGFiMDRjMmI1MTE0 MzU0YWFjNDEzMTI0MzNiMjliOTdkNTU5ZjBiIDEwMDY0NAotLS0gYS9Ub29scy9HTlVtYWtlZmls ZS5hbQorKysgYi9Ub29scy9HTlVtYWtlZmlsZS5hbQpAQCAtMjIsNyArMjIsOCBAQCBQcm9ncmFt c19HdGtMYXVuY2hlcl9DRkxBR1MgPSBcCiAJLWZuby1zdHJpY3QtYWxpYXNpbmcgXAogCSQoZ2xv YmFsX2NmbGFncykgXAogCSQoR1RLX0NGTEFHUykgXAotCSQoTElCU09VUF9DRkxBR1MpCisJJChM SUJTT1VQX0NGTEFHUykgXAorCSQoR1NUUkVBTUVSX0NGTEFHUykKIAogUHJvZ3JhbXNfR3RrTGF1 bmNoZXJfTERBREQgPSBcCiAJbGlid2Via2l0Z3RrLUBXRUJLSVRHVEtfQVBJX01BSk9SX1ZFUlNJ T05ALkBXRUJLSVRHVEtfQVBJX01JTk9SX1ZFUlNJT05ALmxhIFwKQEAgLTMwLDcgKzMxLDggQEAg UHJvZ3JhbXNfR3RrTGF1bmNoZXJfTERBREQgPSBcCiAJJChHVEtfTElCUykgXAogCSQoR0xJQl9M SUJTKSBcCiAJJChMSUJTT1VQX0xJQlMpIFwKLQkkKFdJTk1NX0xJQlMpCisJJChXSU5NTV9MSUJT KSBcCisJJChHU1RSRUFNRVJfTElCUykKIAogUHJvZ3JhbXNfR3RrTGF1bmNoZXJfTERGTEFHUyA9 IFwKIAktbm8tZmFzdC1pbnN0YWxsIFwKZGlmZiAtLWdpdCBhL1Rvb2xzL0d0a0xhdW5jaGVyL21h aW4uYyBiL1Rvb2xzL0d0a0xhdW5jaGVyL21haW4uYwppbmRleCA5NDJhMjBiMGZjMGI5MWVlZGFh ZTc1YzA2OTdjMjg2NWNjYzg1ZDViLi43NDcwZTE3MTRjNDk0OWIyNGVlNTc3OWI4OTQ5MjgxZDhm MDc2ZWQwIDEwMDY0NAotLS0gYS9Ub29scy9HdGtMYXVuY2hlci9tYWluLmMKKysrIGIvVG9vbHMv R3RrTGF1bmNoZXIvbWFpbi5jCkBAIC0yNyw2ICsyNyw3IEBACiAKICNpbmNsdWRlICJMYXVuY2hl ckluc3BlY3RvcldpbmRvdy5oIgogI2luY2x1ZGUgPGVycm5vLmg+CisjaW5jbHVkZSA8Z3N0L2dz dC5oPgogI2luY2x1ZGUgPGd0ay9ndGsuaD4KICNpbmNsdWRlIDxzdGRsaWIuaD4KICNpbmNsdWRl IDxzdHJpbmcuaD4KQEAgLTQ4MywxMCArNDg0LDEyIEBAIGludCBtYWluKGludCBhcmdjLCBjaGFy KiBhcmd2W10pCiAgICAgfTsKIAogICAgIGd0a19pbml0KCZhcmdjLCAmYXJndik7CisgICAgZ3N0 X2luaXQoJmFyZ2MsICZhcmd2KTsKIAogICAgIEdPcHRpb25Db250ZXh0ICpjb250ZXh0ID0gZ19v cHRpb25fY29udGV4dF9uZXcoMCk7CiAgICAgZ19vcHRpb25fY29udGV4dF9hZGRfbWFpbl9lbnRy aWVzKGNvbnRleHQsIGNvbW1hbmRMaW5lT3B0aW9ucywgMCk7CiAgICAgZ19vcHRpb25fY29udGV4 dF9hZGRfZ3JvdXAoY29udGV4dCwgZ3RrX2dldF9vcHRpb25fZ3JvdXAoVFJVRSkpOworICAgIGdf b3B0aW9uX2NvbnRleHRfYWRkX2dyb3VwKGNvbnRleHQsIGdzdF9pbml0X2dldF9vcHRpb25fZ3Jv dXAoKSk7CiAKICAgICB3ZWJraXRTZXR0aW5ncyA9IHdlYmtpdF93ZWJfc2V0dGluZ3NfbmV3KCk7 CiAgICAgZ19vYmplY3Rfc2V0KHdlYmtpdFNldHRpbmdzLCAiZW5hYmxlLWRldmVsb3Blci1leHRy YXMiLCBUUlVFLCBOVUxMKTsK 176038 2012-11-26 11:10:18 -0800 2012-11-27 07:02:06 -0800 Patch bug-103151-20121126190755.patch text/plain 4508 vjaquez U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjM0MmU3ODQyMmY5YzI1 YTZjZGU0OTQ4ZmU3Y2Y3ZDhiMGRhMzY5MC4uMmUzMzI2ODU1MTliYzQ0MzA0ZDBiYTY1NjQ4ZDY4 NDdhNTZkMWQ2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTExLTI2ICBWw61j dG9yIE1hbnVlbCBKw6FxdWV6IExlYWwgIDx2amFxdWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAg W0dTdHJlYW1lcl0gVmVyaWZ5IGlmIEdTdHJlYW1lciB3YXMgcHJldmlvdXNseSBpbml0aWFsaXpl ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzMTUx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBw YXRjaCBjYWxscyBnc3RfaXNfaW5pdGlhbGl6ZWQoKSBiZWZvcmUgY2FsbGluZyBnc3RfaW5pdF9j aGVjaygpCisgICAgICAgIGluIG9yZGVyIHRvIHZlcmlmeSBpZiBHU3RyZWFtZXIgaGFzIG5vdCBi ZWVuIGluaXRpYWxpemVkIGJlZm9yZS4KKworICAgICAgICBUaGlzIGlzIHVzZWZ1bCBwYXJ0aWN1 bGFybHkgZm9yIFdlYktpdDEgc28gdGhlIGFwcGxpY2F0aW9ucyBjb3VsZAorICAgICAgICBpbml0 aWFsaXplIEdTdHJlYW1lciBiZWZvcmUuCisKKyAgICAgICAgQXMgdGhlIEFQSSBjYWxsIHdhcyBh ZGRlZCBpbiBHU3RyZWFtZXIgdjAuMTAuMzEsIHRoZSBwYXRjaCBmZW5jZXMgdGhlCisgICAgICAg IGNhbGwgb25seSBpbiB0aGF0IHZlcnNpb24gb2YgR1N0cmVhbWVyIG9yIGFib3ZlLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cyAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL0dTdHJlYW1lclV0aWxpdGllcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjppbml0 aWFsaXplR1N0cmVhbWVyKToKKwogMjAxMi0xMS0yNiAgTWlrZSBXZXN0ICA8bWt3c3RAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFVSTHMgY29udGFpbmluZyAnXicgYXJl IGltcHJvcGVybHkgbGlua2VkIGluIGNvbnNvbGUgbWVzc2FnZXMuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyVXRpbGl0aWVz LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFt ZXJVdGlsaXRpZXMuY3BwCmluZGV4IGFjMzYzYTc1ZDI1YzhhZWUwOTg1YTE1MTJmYzFlOWM3NWEz YTU1MmIuLmM4MjU3NDdkN2NkNzBiNWQ1MWY3NDY2ODJhMzRiMmRmYzk0NmQ4ZDAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJV dGlsaXRpZXMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9HU3RyZWFtZXJVdGlsaXRpZXMuY3BwCkBAIC0yOSw2ICsyOSwxMSBAQCBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAKIGJvb2wgaW5pdGlhbGl6ZUdTdHJlYW1lcigpCiB7CisjaWYgR1NUX0NIRUNL X1ZFUlNJT04oMCwgMTAsIDMxKQorICAgIGlmIChnc3RfaXNfaW5pdGlhbGl6ZWQgKCkpCisgICAg ICAgIHJldHVybiB0cnVlOworI2VuZGlmCisKICAgICBHT3duUHRyPEdFcnJvcj4gZXJyb3I7CiAg ICAgLy8gRklYTUU6IFdlIHNob3VsZCBwcm9iYWJseSBwYXNzIHRoZSBhcmd1bWVudHMgZnJvbSB0 aGUgY29tbWFuZCBsaW5lLgogICAgIGJvb2wgZ3N0SW5pdGlhbGl6ZWQgPSBnc3RfaW5pdF9jaGVj aygwLCAwLCAmZXJyb3Iub3V0UHRyKCkpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIv VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDNjYzljNzgwN2MwYWQ1Yjg0MGQ0ZDI2YTIxZjVjZThlMWJk NjlhZWMuLmY0MTdlM2I4NzkzYTk5ZjRiNDkzY2VlZTllZjI3OTdlZjI0ZmZiYjQgMTAwNjQ0Ci0t LSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBA QAorMjAxMi0xMS0yNiAgVsOtY3RvciBNYW51ZWwgSsOhcXVleiBMZWFsICA8dmphcXVlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHU3RyZWFtZXJdIFZlcmlmeSBpZiBHU3RyZWFtZXIgd2FzIHBy ZXZpb3VzbHkgaW5pdGlhbGl6ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwMzE1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyB0aGUgZ3N0X2luaXQoKSBpbiBHdGtMYXVuY2hl ciwgc28gd2UgY2FuIGFkZCB0aGUKKyAgICAgICAgR1N0cmVhbWVyIG9wdGlvbnMgaW4gdGhlIGNv bW1hbmQgbGluZSB0aHJvdWdoCisgICAgICAgIGdzdF9pbml0X2dldF9vcHRpb25fZ3JvdXAoKS4K KworICAgICAgICBUaGlzIGFwcHJvYWNoIGlzIG5vdCB2YWxpZCBmb3IgTWluaUJyb3dzZXIgYmVj YXVzZSBpdCB1c2VzIFdlYktpdDIsCisgICAgICAgIHdoZXJlIHRoZSBHU3RyZWFtZXIgYmFja2Vu ZCBsaXZlcyBpbiB0aGUgd2ViIHByb2Nlc3MsIHdoaWNoIGlzCisgICAgICAgIGRpZmZlcmVudCBm cm9tIHRoZSBVSSBwcm9jZXNzLgorCisgICAgICAgICogR05VbWFrZWZpbGUuYW06CisgICAgICAg ICogR3RrTGF1bmNoZXIvbWFpbi5jOgorICAgICAgICAobWFpbik6CisKIDIwMTItMTEtMjYgIEph ZWh1biBMaW0gIDxsamFlaHVuLmxpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBUZXh0IEF1dG9z aXppbmc6IEFkZCBUZXh0IEF1dG9zaXppbmcgQVBJcyBmb3IgV0syCmRpZmYgLS1naXQgYS9Ub29s cy9HTlVtYWtlZmlsZS5hbSBiL1Rvb2xzL0dOVW1ha2VmaWxlLmFtCmluZGV4IDYwNThiZThlYzlk MmY4NWVkODgwMTdlN2YzYzY0NmY2NzJhZmQ5YjEuLjgwYWIwNGMyYjUxMTQzNTRhYWM0MTMxMjQz M2IyOWI5N2Q1NTlmMGIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0dOVW1ha2VmaWxlLmFtCisrKyBiL1Rv b2xzL0dOVW1ha2VmaWxlLmFtCkBAIC0yMiw3ICsyMiw4IEBAIFByb2dyYW1zX0d0a0xhdW5jaGVy X0NGTEFHUyA9IFwKIAktZm5vLXN0cmljdC1hbGlhc2luZyBcCiAJJChnbG9iYWxfY2ZsYWdzKSBc CiAJJChHVEtfQ0ZMQUdTKSBcCi0JJChMSUJTT1VQX0NGTEFHUykKKwkkKExJQlNPVVBfQ0ZMQUdT KSBcCisJJChHU1RSRUFNRVJfQ0ZMQUdTKQogCiBQcm9ncmFtc19HdGtMYXVuY2hlcl9MREFERCA9 IFwKIAlsaWJ3ZWJraXRndGstQFdFQktJVEdUS19BUElfTUFKT1JfVkVSU0lPTkAuQFdFQktJVEdU S19BUElfTUlOT1JfVkVSU0lPTkAubGEgXApAQCAtMzAsNyArMzEsOCBAQCBQcm9ncmFtc19HdGtM YXVuY2hlcl9MREFERCA9IFwKIAkkKEdUS19MSUJTKSBcCiAJJChHTElCX0xJQlMpIFwKIAkkKExJ QlNPVVBfTElCUykgXAotCSQoV0lOTU1fTElCUykKKwkkKFdJTk1NX0xJQlMpIFwKKwkkKEdTVFJF QU1FUl9MSUJTKQogCiBQcm9ncmFtc19HdGtMYXVuY2hlcl9MREZMQUdTID0gXAogCS1uby1mYXN0 LWluc3RhbGwgXApkaWZmIC0tZ2l0IGEvVG9vbHMvR3RrTGF1bmNoZXIvbWFpbi5jIGIvVG9vbHMv R3RrTGF1bmNoZXIvbWFpbi5jCmluZGV4IDk0MmEyMGIwZmMwYjkxZWVkYWFlNzVjMDY5N2MyODY1 Y2NjODVkNWIuLjc0NzBlMTcxNGM0OTQ5YjI0ZWU1Nzc5Yjg5NDkyODFkOGYwNzZlZDAgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL0d0a0xhdW5jaGVyL21haW4uYworKysgYi9Ub29scy9HdGtMYXVuY2hlci9t YWluLmMKQEAgLTI3LDYgKzI3LDcgQEAKIAogI2luY2x1ZGUgIkxhdW5jaGVySW5zcGVjdG9yV2lu ZG93LmgiCiAjaW5jbHVkZSA8ZXJybm8uaD4KKyNpbmNsdWRlIDxnc3QvZ3N0Lmg+CiAjaW5jbHVk ZSA8Z3RrL2d0ay5oPgogI2luY2x1ZGUgPHN0ZGxpYi5oPgogI2luY2x1ZGUgPHN0cmluZy5oPgpA QCAtNDgzLDEwICs0ODQsMTIgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqIGFyZ3ZbXSkKICAg ICB9OwogCiAgICAgZ3RrX2luaXQoJmFyZ2MsICZhcmd2KTsKKyAgICBnc3RfaW5pdCgmYXJnYywg JmFyZ3YpOwogCiAgICAgR09wdGlvbkNvbnRleHQgKmNvbnRleHQgPSBnX29wdGlvbl9jb250ZXh0 X25ldygwKTsKICAgICBnX29wdGlvbl9jb250ZXh0X2FkZF9tYWluX2VudHJpZXMoY29udGV4dCwg Y29tbWFuZExpbmVPcHRpb25zLCAwKTsKICAgICBnX29wdGlvbl9jb250ZXh0X2FkZF9ncm91cChj b250ZXh0LCBndGtfZ2V0X29wdGlvbl9ncm91cChUUlVFKSk7CisgICAgZ19vcHRpb25fY29udGV4 dF9hZGRfZ3JvdXAoY29udGV4dCwgZ3N0X2luaXRfZ2V0X29wdGlvbl9ncm91cCgpKTsKIAogICAg IHdlYmtpdFNldHRpbmdzID0gd2Via2l0X3dlYl9zZXR0aW5nc19uZXcoKTsKICAgICBnX29iamVj dF9zZXQod2Via2l0U2V0dGluZ3MsICJlbmFibGUtZGV2ZWxvcGVyLWV4dHJhcyIsIFRSVUUsIE5V TEwpOwo= 176260 2012-11-27 07:02:14 -0800 2012-11-27 07:59:22 -0800 Patch bug-103151-20121127145950.patch text/plain 4546 vjaquez U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1ODQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDhlMzc0YTBlZjIyY2Nj ZTU0YWUwOTA1YzFmZDE0Njg2ZmY3Yzg3Zi4uYTg5MGYwZDg3NWY3NWE4ZTY4YzFlMjRhNzM3Y2M4 NjIxMWNjZjk3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTExLTI3ICBWw61j dG9yIE1hbnVlbCBKw6FxdWV6IExlYWwgIDx2amFxdWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAg W0dTdHJlYW1lcl0gVmVyaWZ5IGlmIEdTdHJlYW1lciB3YXMgcHJldmlvdXNseSBpbml0aWFsaXpl ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzMTUx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBw YXRjaCBjYWxscyBnc3RfaXNfaW5pdGlhbGl6ZWQoKSBiZWZvcmUgY2FsbGluZyBnc3RfaW5pdF9j aGVjaygpCisgICAgICAgIGluIG9yZGVyIHRvIHZlcmlmeSBpZiBHU3RyZWFtZXIgaGFzIG5vdCBi ZWVuIGluaXRpYWxpemVkIGJlZm9yZS4KKworICAgICAgICBUaGlzIGlzIHVzZWZ1bCBwYXJ0aWN1 bGFybHkgZm9yIFdlYktpdDEgc28gdGhlIGFwcGxpY2F0aW9ucyBjb3VsZAorICAgICAgICBpbml0 aWFsaXplIEdTdHJlYW1lciBiZWZvcmUuCisKKyAgICAgICAgQXMgdGhlIEFQSSBjYWxsIHdhcyBh ZGRlZCBpbiBHU3RyZWFtZXIgdjAuMTAuMzEsIHRoZSBwYXRjaCBmZW5jZXMgdGhlCisgICAgICAg IGNhbGwgb25seSBpbiB0aGF0IHZlcnNpb24gb2YgR1N0cmVhbWVyIG9yIGFib3ZlLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cywgZXhpc3RpbmcgbWVkaWEgdGVzdHMgY292ZXIgdGhpcyBjaGFuZ2Uu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyVXRpbGl0 aWVzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmluaXRpYWxpemVHU3RyZWFtZXIpOgorCiAyMDEy LTExLTI3ICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4K IAogICAgICAgICBSRUdSRVNTSU9OKDEzNDg4NykgW1F0XVtFRkxdW1dLMl0gUmVwYWludCBjb3Vu dGVyIG5vdCB3b3JraW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyVXRpbGl0aWVzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJVdGlsaXRpZXMuY3BwCmluZGV4IGFj MzYzYTc1ZDI1YzhhZWUwOTg1YTE1MTJmYzFlOWM3NWEzYTU1MmIuLjFiNTc0MWU1NWRhOWMwZDlm MDk5YjRkZGE5MDkyMDg4MDQyZDI1ZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJVdGlsaXRpZXMuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJVdGlsaXRpZXMu Y3BwCkBAIC0yOSw2ICsyOSwxMSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGJvb2wgaW5pdGlh bGl6ZUdTdHJlYW1lcigpCiB7CisjaWYgR1NUX0NIRUNLX1ZFUlNJT04oMCwgMTAsIDMxKQorICAg IGlmIChnc3RfaXNfaW5pdGlhbGl6ZWQoKSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisjZW5kaWYK KwogICAgIEdPd25QdHI8R0Vycm9yPiBlcnJvcjsKICAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIHBy b2JhYmx5IHBhc3MgdGhlIGFyZ3VtZW50cyBmcm9tIHRoZSBjb21tYW5kIGxpbmUuCiAgICAgYm9v bCBnc3RJbml0aWFsaXplZCA9IGdzdF9pbml0X2NoZWNrKDAsIDAsICZlcnJvci5vdXRQdHIoKSk7 CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTY3 NDlhNTNhYTE4ZGU0MWY4YmNkODZhMmIwODY0YzFlNWIxMjk4Yi4uMTBlZWFkZGZjYWY1NmRmODll ZGE5ZjNmMmRlMDE5OGE4ZWE4NWI5OCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTExLTI3ICBWw61jdG9yIE1h bnVlbCBKw6FxdWV6IExlYWwgIDx2amFxdWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dTdHJl YW1lcl0gVmVyaWZ5IGlmIEdTdHJlYW1lciB3YXMgcHJldmlvdXNseSBpbml0aWFsaXplZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzMTUxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBh ZGRzIHRoZSBnc3RfaW5pdCgpIGluIEd0a0xhdW5jaGVyLCBzbyB3ZSBjYW4gYWRkIHRoZQorICAg ICAgICBHU3RyZWFtZXIgb3B0aW9ucyBpbiB0aGUgY29tbWFuZCBsaW5lIHRocm91Z2gKKyAgICAg ICAgZ3N0X2luaXRfZ2V0X29wdGlvbl9ncm91cCgpLgorCisgICAgICAgIFRoaXMgYXBwcm9hY2gg aXMgbm90IHZhbGlkIGZvciBNaW5pQnJvd3NlciBiZWNhdXNlIGl0IHVzZXMgV2ViS2l0MiwKKyAg ICAgICAgd2hlcmUgdGhlIEdTdHJlYW1lciBiYWNrZW5kIGxpdmVzIGluIHRoZSB3ZWIgcHJvY2Vz cywgd2hpY2ggaXMKKyAgICAgICAgZGlmZmVyZW50IGZyb20gdGhlIFVJIHByb2Nlc3MuCisKKyAg ICAgICAgKiBHTlVtYWtlZmlsZS5hbToKKyAgICAgICAgKiBHdGtMYXVuY2hlci9tYWluLmM6Cisg ICAgICAgIChtYWluKToKKwogMjAxMi0xMS0yNyAgU2FkcnVsIEhhYmliIENob3dkaHVyeSAgPHNh ZHJ1bEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW3N0eWxlXSBBZGQgYSBzdHlsZS1jaGVjayBm b3IgZW51bS1tZW1iZXIgbmFtZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL0dOVW1ha2VmaWxlLmFtIGIv VG9vbHMvR05VbWFrZWZpbGUuYW0KaW5kZXggNjA1OGJlOGVjOWQyZjg1ZWQ4ODAxN2U3ZjNjNjQ2 ZjY3MmFmZDliMS4uODBhYjA0YzJiNTExNDM1NGFhYzQxMzEyNDMzYjI5Yjk3ZDU1OWYwYiAxMDA2 NDQKLS0tIGEvVG9vbHMvR05VbWFrZWZpbGUuYW0KKysrIGIvVG9vbHMvR05VbWFrZWZpbGUuYW0K QEAgLTIyLDcgKzIyLDggQEAgUHJvZ3JhbXNfR3RrTGF1bmNoZXJfQ0ZMQUdTID0gXAogCS1mbm8t c3RyaWN0LWFsaWFzaW5nIFwKIAkkKGdsb2JhbF9jZmxhZ3MpIFwKIAkkKEdUS19DRkxBR1MpIFwK LQkkKExJQlNPVVBfQ0ZMQUdTKQorCSQoTElCU09VUF9DRkxBR1MpIFwKKwkkKEdTVFJFQU1FUl9D RkxBR1MpCiAKIFByb2dyYW1zX0d0a0xhdW5jaGVyX0xEQUREID0gXAogCWxpYndlYmtpdGd0ay1A V0VCS0lUR1RLX0FQSV9NQUpPUl9WRVJTSU9OQC5AV0VCS0lUR1RLX0FQSV9NSU5PUl9WRVJTSU9O QC5sYSBcCkBAIC0zMCw3ICszMSw4IEBAIFByb2dyYW1zX0d0a0xhdW5jaGVyX0xEQUREID0gXAog CSQoR1RLX0xJQlMpIFwKIAkkKEdMSUJfTElCUykgXAogCSQoTElCU09VUF9MSUJTKSBcCi0JJChX SU5NTV9MSUJTKQorCSQoV0lOTU1fTElCUykgXAorCSQoR1NUUkVBTUVSX0xJQlMpCiAKIFByb2dy YW1zX0d0a0xhdW5jaGVyX0xERkxBR1MgPSBcCiAJLW5vLWZhc3QtaW5zdGFsbCBcCmRpZmYgLS1n aXQgYS9Ub29scy9HdGtMYXVuY2hlci9tYWluLmMgYi9Ub29scy9HdGtMYXVuY2hlci9tYWluLmMK aW5kZXggOTQyYTIwYjBmYzBiOTFlZWRhYWU3NWMwNjk3YzI4NjVjY2M4NWQ1Yi4uNzQ3MGUxNzE0 YzQ5NDliMjRlZTU3NzliODk0OTI4MWQ4ZjA3NmVkMCAxMDA2NDQKLS0tIGEvVG9vbHMvR3RrTGF1 bmNoZXIvbWFpbi5jCisrKyBiL1Rvb2xzL0d0a0xhdW5jaGVyL21haW4uYwpAQCAtMjcsNiArMjcs NyBAQAogCiAjaW5jbHVkZSAiTGF1bmNoZXJJbnNwZWN0b3JXaW5kb3cuaCIKICNpbmNsdWRlIDxl cnJuby5oPgorI2luY2x1ZGUgPGdzdC9nc3QuaD4KICNpbmNsdWRlIDxndGsvZ3RrLmg+CiAjaW5j bHVkZSA8c3RkbGliLmg+CiAjaW5jbHVkZSA8c3RyaW5nLmg+CkBAIC00ODMsMTAgKzQ4NCwxMiBA QCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciogYXJndltdKQogICAgIH07CiAKICAgICBndGtfaW5p dCgmYXJnYywgJmFyZ3YpOworICAgIGdzdF9pbml0KCZhcmdjLCAmYXJndik7CiAKICAgICBHT3B0 aW9uQ29udGV4dCAqY29udGV4dCA9IGdfb3B0aW9uX2NvbnRleHRfbmV3KDApOwogICAgIGdfb3B0 aW9uX2NvbnRleHRfYWRkX21haW5fZW50cmllcyhjb250ZXh0LCBjb21tYW5kTGluZU9wdGlvbnMs IDApOwogICAgIGdfb3B0aW9uX2NvbnRleHRfYWRkX2dyb3VwKGNvbnRleHQsIGd0a19nZXRfb3B0 aW9uX2dyb3VwKFRSVUUpKTsKKyAgICBnX29wdGlvbl9jb250ZXh0X2FkZF9ncm91cChjb250ZXh0 LCBnc3RfaW5pdF9nZXRfb3B0aW9uX2dyb3VwKCkpOwogCiAgICAgd2Via2l0U2V0dGluZ3MgPSB3 ZWJraXRfd2ViX3NldHRpbmdzX25ldygpOwogICAgIGdfb2JqZWN0X3NldCh3ZWJraXRTZXR0aW5n cywgImVuYWJsZS1kZXZlbG9wZXItZXh0cmFzIiwgVFJVRSwgTlVMTCk7Cg==