103145 2012-11-23 08:14:33 -0800 [sh4] JavaScriptCore JIT build is broken for sh4 arch since r135330 2012-11-26 11:38:07 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Major --- 0 jbriance webkit-unassigned fpizlo oliver webkit.review.bot oldest_to_newest 774571 0 jbriance 2012-11-23 08:14:33 -0800 Implementation of the following functions are missing from JavaScriptCore sh4 JIT since r135330: CodeLocationLabel startOfBranchPtrWithPatchOnRegister(CodeLocationDataLabelPtr label) void revertJumpReplacementToBranchPtrWithPatch(CodeLocationLabel instructionStart, RegisterID, void* initialValue) CodeLocationLabel startOfPatchableBranchPtrWithPatchOnAddress(CodeLocationDataLabelPtr) void revertJumpReplacementToPatchableBranchPtrWithPatch(CodeLocationLabel, Address, void*) 775513 1 176008 jbriance 2012-11-26 08:39:13 -0800 Created attachment 176008 Add missing implementation in SH4 JIT (since r135330) 775718 2 176008 webkit.review.bot 2012-11-26 11:38:04 -0800 Comment on attachment 176008 Add missing implementation in SH4 JIT (since r135330) Clearing flags on attachment: 176008 Committed r135745: <http://trac.webkit.org/changeset/135745> 775719 3 webkit.review.bot 2012-11-26 11:38:07 -0800 All reviewed patches have been landed. Closing bug. 176008 2012-11-26 08:39:13 -0800 2012-11-26 11:38:04 -0800 Add missing implementation in SH4 JIT (since r135330) javascript_sh4_jit_build_since_r135330.patch text/plain 3780 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM1NzI4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDEyLTExLTI2ICBKdWxpZW4gQlJJQU5DRUFVICAgPGpicmlhbmNlYXVAbmRzLmNvbT4KKwor ICAgICAgICBbc2g0XSBKYXZhU2NyaXB0Q29yZSBKSVQgYnVpbGQgaXMgYnJva2VuIHNpbmNlIHIx MzUzMzAKKyAgICAgICAgQWRkIG1pc3NpbmcgaW1wbGVtZW50YXRpb24gZm9yIHNoNCBhcmNoLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzMTQ1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBhc3NlbWJs ZXIvTWFjcm9Bc3NlbWJsZXJTSDQuaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJTSDQ6 OmNhbkp1bXBSZXBsYWNlUGF0Y2hhYmxlQnJhbmNoUHRyV2l0aFBhdGNoKToKKyAgICAgICAgKE1h Y3JvQXNzZW1ibGVyU0g0KToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJTSDQ6OnN0YXJ0 T2ZCcmFuY2hQdHJXaXRoUGF0Y2hPblJlZ2lzdGVyKToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3Nl bWJsZXJTSDQ6OnJldmVydEp1bXBSZXBsYWNlbWVudFRvQnJhbmNoUHRyV2l0aFBhdGNoKToKKyAg ICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJTSDQ6OnN0YXJ0T2ZQYXRjaGFibGVCcmFuY2hQdHJX aXRoUGF0Y2hPbkFkZHJlc3MpOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlclNINDo6cmV2 ZXJ0SnVtcFJlcGxhY2VtZW50VG9QYXRjaGFibGVCcmFuY2hQdHJXaXRoUGF0Y2gpOgorICAgICAg ICAqIGFzc2VtYmxlci9TSDRBc3NlbWJsZXIuaDoKKyAgICAgICAgKEpTQzo6U0g0QXNzZW1ibGVy OjpyZXZlcnRKdW1wKToKKyAgICAgICAgKFNINEFzc2VtYmxlcik6CisgICAgICAgIChKU0M6OlNI NEFzc2VtYmxlcjo6cHJpbnRJbnN0cik6CisKIDIwMTItMTEtMjYgIEdhYm9yIEJhbGxhYmFzICA8 Z2Fib3JiQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBbUXRdW0FSTV0gUkVHUkVTU0lPTihy MTMwODI2KTogSXQgbWFkZSAzMyBKU0MgdGVzdCBhbmQgNDY2IGxheW91dCB0ZXN0cyBjcmFzaApJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclNINC5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3Nl bWJsZXJTSDQuaAkocmV2aXNpb24gMTM1NzI4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fz c2VtYmxlci9NYWNyb0Fzc2VtYmxlclNINC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMjE2LDYgKzIy MTYsMjkgQEAgdm9pZCBvcjMyKFRydXN0ZWRJbW0zMiBpbW0sIFJlZ2lzdGVySUQgcwogICAgICAg ICByZXR1cm4gMDsKICAgICB9CiAKKyAgICBzdGF0aWMgYm9vbCBjYW5KdW1wUmVwbGFjZVBhdGNo YWJsZUJyYW5jaFB0cldpdGhQYXRjaCgpIHsgcmV0dXJuIGZhbHNlOyB9CisKKyAgICBzdGF0aWMg Q29kZUxvY2F0aW9uTGFiZWwgc3RhcnRPZkJyYW5jaFB0cldpdGhQYXRjaE9uUmVnaXN0ZXIoQ29k ZUxvY2F0aW9uRGF0YUxhYmVsUHRyIGxhYmVsKQorICAgIHsKKyAgICAgICAgcmV0dXJuIGxhYmVs LmxhYmVsQXRPZmZzZXQoMCk7CisgICAgfQorCisgICAgc3RhdGljIHZvaWQgcmV2ZXJ0SnVtcFJl cGxhY2VtZW50VG9CcmFuY2hQdHJXaXRoUGF0Y2goQ29kZUxvY2F0aW9uTGFiZWwgaW5zdHJ1Y3Rp b25TdGFydCwgUmVnaXN0ZXJJRCwgdm9pZCogaW5pdGlhbFZhbHVlKQorICAgIHsKKyAgICAgICAg U0g0QXNzZW1ibGVyOjpyZXZlcnRKdW1wKGluc3RydWN0aW9uU3RhcnQuZGF0YUxvY2F0aW9uKCks IHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0cl90Pihpbml0aWFsVmFsdWUpICYgMHhmZmZmKTsKKyAg ICB9CisKKyAgICBzdGF0aWMgQ29kZUxvY2F0aW9uTGFiZWwgc3RhcnRPZlBhdGNoYWJsZUJyYW5j aFB0cldpdGhQYXRjaE9uQWRkcmVzcyhDb2RlTG9jYXRpb25EYXRhTGFiZWxQdHIpCisgICAgewor ICAgICAgICBVTlJFQUNIQUJMRV9GT1JfUExBVEZPUk0oKTsKKyAgICAgICAgcmV0dXJuIENvZGVM b2NhdGlvbkxhYmVsKCk7CisgICAgfQorCisgICAgc3RhdGljIHZvaWQgcmV2ZXJ0SnVtcFJlcGxh Y2VtZW50VG9QYXRjaGFibGVCcmFuY2hQdHJXaXRoUGF0Y2goQ29kZUxvY2F0aW9uTGFiZWwgaW5z dHJ1Y3Rpb25TdGFydCwgQWRkcmVzcywgdm9pZCogaW5pdGlhbFZhbHVlKQorICAgIHsKKyAgICAg ICAgVU5SRUFDSEFCTEVfRk9SX1BMQVRGT1JNKCk7CisgICAgfQorCiBwcm90ZWN0ZWQ6CiAgICAg U0g0QXNzZW1ibGVyOjpDb25kaXRpb24gU0g0Q29uZGl0aW9uKFJlbGF0aW9uYWxDb25kaXRpb24g Y29uZCkKICAgICB7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1NINEFz c2VtYmxlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIv U0g0QXNzZW1ibGVyLmgJKHJldmlzaW9uIDEzNTcyOCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvU0g0QXNzZW1ibGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0NjIsNiArMTQ2 MiwyMCBAQCBwdWJsaWM6CiAKICAgICAvLyBMaW5raW5nICYgcGF0Y2hpbmcKIAorICAgIHN0YXRp YyB2b2lkIHJldmVydEp1bXAodm9pZCogaW5zdHJ1Y3Rpb25TdGFydCwgU0g0V29yZCBpbW0pCisg ICAgeworICAgICAgICBTSDRXb3JkICppbnNuID0gcmVpbnRlcnByZXRfY2FzdDxTSDRXb3JkKj4o aW5zdHJ1Y3Rpb25TdGFydCk7CisgICAgICAgIFNINFdvcmQgZGlzcDsKKworICAgICAgICBBU1NF UlQoKGluc25bMF0gJiAweGYwMDApID09IE1PVkxfUkVBRF9PRkZQQ19PUENPREUpOworCisgICAg ICAgIGRpc3AgPSBpbnNuWzBdICYgMHgwMGZmOworICAgICAgICBpbnNuICs9IDIgKyAoZGlzcCA8 PCAxKTsgLy8gUEMgKz0gNCArIChkaXNwKjQpCisgICAgICAgIGluc24gPSAoU0g0V29yZCAqKSAo KHVuc2lnbmVkKSBpbnNuICYgKH4zKSk7CisgICAgICAgIGluc25bMF0gPSBpbW07CisgICAgICAg IGNhY2hlRmx1c2goaW5zbiwgc2l6ZW9mKFNINFdvcmQpKTsKKyAgICB9CisKICAgICB2b2lkIGxp bmtKdW1wKEFzc2VtYmxlckxhYmVsIGZyb20sIEFzc2VtYmxlckxhYmVsIHRvLCBKdW1wVHlwZSB0 eXBlID0gSnVtcEZhcikKICAgICB7CiAgICAgICAgIEFTU0VSVCh0by5pc1NldCgpKTsKQEAgLTE3 NTUsNiArMTc2OSw5IEBAIHB1YmxpYzoKICAgICAgICAgY2FzZSBGQ05WRFNfRFJNX0ZQVUxfT1BD T0RFOgogICAgICAgICAgICAgZm9ybWF0ID0gIiAgICBGQ05WRFMgRlIlZCwgRlBVTFxuIjsKICAg ICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIEZDTlZTRF9GUFVMX0RSTl9PUENPREU6Cisg ICAgICAgICAgICBmb3JtYXQgPSAiICAgIEZDTlZTRCBGUFVMLCBGUiVkXG4iOworICAgICAgICAg ICAgYnJlYWs7CiAgICAgICAgIH0KICAgICAgICAgaWYgKGZvcm1hdCkgewogICAgICAgICAgICAg aWYgKGlzZG91YmxlSW5zdCkK