103137 2012-11-23 06:43:35 -0800 [Gtk] Tools/TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp fails to link 2013-10-09 14:29:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 102510 1 yurys webkit-unassigned berto gustavo loislo pfeldman philn xan.lopez yurys oldest_to_newest 774510 0 yurys 2012-11-23 06:43:35 -0800 Adding Tools/TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp to Tools/TestWebKitAPI/GNUmakefile.am causes linker failure. Although doing the same with e.g. Tools/TestWebKitAPI/Tests/WTF/WTFSring.cpp works just fine. I originally faced this issue while working on patch for webkit.org/b/102510. Compilation started failing when I moved part of wtf/MemoryInstrumentation.h into wtf/MemoryInstrumentation.cpp (see http://queues.webkit.org/results/14899240): "ts/WTF/Programs_TestWebKitAPI_TestWTF-MemoryInstrumentationTest.o:MemoryInstrumentationTest.cpp:function typeinfo for (anonymous namespace)::InstrumentationTestImpl: error: undefined reference to 'typeinfo for WTF::MemoryInstrumentation" 774513 1 175798 yurys 2012-11-23 06:46:22 -0800 Created attachment 175798 Failing change 774547 2 yurys 2012-11-23 07:27:27 -0800 Can someone familiar with Gtk build system help me resolve the issue? Source/WTF/wtf/MemoryInstrumentation.cpp seems to be included in the same places in GNUmakefiles as Source/WTF/wtf/text/WTFString.cpp, still methods from Source/WTF/wtf/text/WTFString.cpp are accessible from Tools/TestWebKitAPI/Tests/WTF/WTFSring.cpp while those of Source/WTF/wtf/MemoryInstrumentation.cpp aren't. 938074 3 berto 2013-10-09 14:29:22 -0700 Obsolete after bug 114931. 175798 2012-11-23 06:46:22 -0800 2012-11-23 06:46:22 -0800 Failing change gtk-failure.patch text/plain 977 yurys ZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvR05VbWFrZWZpbGUuYW0gYi9Ub29scy9U ZXN0V2ViS2l0QVBJL0dOVW1ha2VmaWxlLmFtCmluZGV4IDAxYjExNTguLjRhZmY5ZTUgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvR05VbWFrZWZpbGUuYW0KKysrIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9HTlVtYWtlZmlsZS5hbQpAQCAtNTQsNiArNTQsNyBAQCBQcm9ncmFtc19UZXN0 V2ViS2l0QVBJX1Rlc3RXVEZfU09VUkNFUyA9IFwKIAlUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dURi9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmNwcCBcCiAJVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XVEYvTWF0aEV4dHJhcy5jcHAgXAogCVRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv V1RGL01lZGlhVGltZS5jcHAgXAorCVRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL01lbW9y eUluc3RydW1lbnRhdGlvblRlc3QuY3BwIFwKIAlUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dU Ri9SZWRCbGFja1RyZWUuY3BwIFwKIAlUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9TYXR1 cmF0ZWRBcml0aG1ldGljT3BlcmF0aW9ucy5jcHAgXAogCVRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV1RGL1N0cmluZ0J1aWxkZXIuY3BwIFwKQEAgLTYzLDYgKzY0LDcgQEAgUHJvZ3JhbXNfVGVz dFdlYktpdEFQSV9UZXN0V1RGX1NPVVJDRVMgPSBcCiAJVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XVEYvVmVjdG9yQmFzaWMuY3BwIFwKIAlUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9W ZWN0b3IuY3BwIFwKIAlUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9WZWN0b3JSZXZlcnNl LmNwcCBcCisJVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvV1RGU3RyaW5nLmNwcCBcCiAJ VG9vbHMvVGVzdFdlYktpdEFQSS9XVEZTdHJpbmdVdGlsaXRpZXMuaAogCiBub2luc3RfUFJPR1JB TVMgKz0gXAo=