103133 2012-11-23 05:59:20 -0800 [EFL][WK2][AC] EwkViewImpl::transformToScreen() does not retrieve the Ecore_X_Window properly 2012-11-23 07:16:45 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi rakuco tonikitoo webkit.review.bot yael oldest_to_newest 774490 0 cdumez 2012-11-23 05:59:20 -0800 If accelerated compositing is enabled EwkViewImpl::transformToScreen() should try to get the Ecore_X_Window using ecore_evas_gl_x11_window_get() first and only fallback to ecore_evas_software_x11_window_get(). Currently it calls ecore_evas_software_x11_window_get() no matter what, which will always return 0 if accelerated compositing is enabled. 774491 1 175789 cdumez 2012-11-23 06:02:36 -0800 Created attachment 175789 Patch 774539 2 175789 webkit.review.bot 2012-11-23 07:16:41 -0800 Comment on attachment 175789 Patch Clearing flags on attachment: 175789 Committed r135609: <http://trac.webkit.org/changeset/135609> 774540 3 webkit.review.bot 2012-11-23 07:16:45 -0800 All reviewed patches have been landed. Closing bug. 175789 2012-11-23 06:02:36 -0800 2012-11-23 07:16:41 -0800 Patch 103133_transformToScreen.patch text/plain 1792 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxZWQwNWZjLi45ODNhNWFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMTEtMjMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdW0FDXSBFd2tWaWV3SW1wbDo6dHJhbnNmb3JtVG9T Y3JlZW4oKSBkb2VzIG5vdCByZXRyaWV2ZSB0aGUgRWNvcmVfWF9XaW5kb3cgcHJvcGVybHkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzEzMworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIGFjY2VsZXJh dGVkIGNvbXBvc2l0aW5nIGlzIGVuYWJsZWQsIEV3a1ZpZXdJbXBsOjp0cmFuc2Zvcm1Ub1NjcmVl bigpIHNob3VsZAorICAgICAgICBhdHRlbXB0IHRvIHJldHJpZXZlIHRoZSBFY29yZV9YX1dpbmRv dyB1c2luZyBlY29yZV9ldmFzX2dsX3gxMV93aW5kb3dfZ2V0KCkgZmlyc3QKKyAgICAgICAgYW5k IG9ubHkgZmFsbCBiYWNrIHRvIGVjb3JlX2V2YXNfc29mdHdhcmVfeDExX3dpbmRvd19nZXQoKS4K KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcDoKKyAgICAgICAg KEV3a1ZpZXdJbXBsOjp0cmFuc2Zvcm1Ub1NjcmVlbik6CisKIDIwMTItMTEtMjIgIFBpZXJyZSBS b3NzaSAgPHBpZXJyZS5yb3NzaUBnbWFpbC5jb20+CiAKICAgICAgICAgW1F0XSBBdm9pZCBpbml0 aWFsaXppbmcgUGxhdGZvcm1TdHJhdGVnaWVzIHR3aWNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwCmluZGV4IGUwYzU5MDUuLjI5MTYxZmYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBs LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5j cHAKQEAgLTMxNCw3ICszMTQsMTQgQEAgQWZmaW5lVHJhbnNmb3JtIEV3a1ZpZXdJbXBsOjp0cmFu c2Zvcm1Ub1NjcmVlbigpIGNvbnN0CiAKICNpZmRlZiBIQVZFX0VDT1JFX1gKICAgICBFY29yZV9F dmFzKiBlY29yZUV2YXMgPSBlY29yZV9ldmFzX2Vjb3JlX2V2YXNfZ2V0KHNkLT5iYXNlLmV2YXMp OwotICAgIEVjb3JlX1hfV2luZG93IHdpbmRvdyA9IGVjb3JlX2V2YXNfc29mdHdhcmVfeDExX3dp bmRvd19nZXQoZWNvcmVFdmFzKTsgLy8gUmV0dXJucyAwIGlmIG5vbmUuCisKKyAgICBFY29yZV9Y X1dpbmRvdyB3aW5kb3c7CisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQorICAgIHdp bmRvdyA9IGVjb3JlX2V2YXNfZ2xfeDExX3dpbmRvd19nZXQoZWNvcmVFdmFzKTsKKyAgICAvLyBG YWxsYmFjayB0byBzb2Z0d2FyZSBtb2RlIGlmIG5lY2Vzc2FyeS4KKyAgICBpZiAoIXdpbmRvdykK KyNlbmRpZgorICAgIHdpbmRvdyA9IGVjb3JlX2V2YXNfc29mdHdhcmVfeDExX3dpbmRvd19nZXQo ZWNvcmVFdmFzKTsgLy8gUmV0dXJucyAwIGlmIG5vbmUuCiAKICAgICBpbnQgeCwgeTsgLy8geCwg eSBhcmUgcmVsYXRpdmUgdG8gcGFyZW50IChpbiBhIHJlcGFyZW50aW5nIHdpbmRvdyBtYW5hZ2Vy KS4KICAgICB3aGlsZSAod2luZG93KSB7Cg==