103115 2012-11-23 03:19:56 -0800 http/tests/loading/remove-child-triggers-parser.html is flaky 2020-02-04 20:03:00 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jussi.kukkonen rniwa aakash_jain ap cdumez jacob_uphoff jbedard rniwa ryanhaddad simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 774366 0 jussi.kukkonen 2012-11-23 03:19:56 -0800 The following layout test is flaky on various platforms but especially so on WK2 EFL: http/tests/loading/remove-child-triggers-parser.html Testing locally, the first run seems to print correct output, except it's missing the last empty line of output. Running with --iterations shows all the subsequent runs passing. 1247074 1 ryanhaddad 2016-11-01 15:08:21 -0700 https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20(Tests)/builds/1034 https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Floading%2Fremove-child-triggers-parser.html --- /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/http/tests/loading/remove-child-triggers-parser-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/http/tests/loading/remove-child-triggers-parser-actual.txt @@ -3,4 +3,3 @@ main frame - didFinishDocumentLoadForFrame main frame - didHandleOnloadEventsForFrame main frame - didFinishLoadForFrame - 1248358 2 jbedard 2016-11-04 16:22:24 -0700 Some brief analysis of the failures of this test shows that it has the very odd feature of it's failures sharing a very long list of tests (a few hundred) which were executed before failures and not before successes. I will run this analysis on a larger set of success/failures, my guess would be that this test isn't flakey, it's order dependent. 1609985 3 ap 2020-01-22 23:09:01 -0800 *** Bug 206628 has been marked as a duplicate of this bug. *** 1609986 4 ap 2020-01-22 23:09:31 -0800 <rdar://problem/58815922> 1609988 5 ap 2020-01-22 23:12:26 -0800 > setTimeout(function() { var child = document.documentElement; child.parentNode.removeChild(child); }, 36); Certainly smells like a not so great test. Since this is a test for a security bug, it may be important enough to deflake. CC'ing Ryosuke, who reviewed it many years ago. 1611683 6 388933 rniwa 2020-01-27 16:13:16 -0800 Created attachment 388933 Deflake the test 1611705 7 388933 ap 2020-01-27 16:53:37 -0800 Comment on attachment 388933 Deflake the test View in context: https://bugs.webkit.org/attachment.cgi?id=388933&action=review > LayoutTests/http/tests/loading/remove-child-triggers-parser.html:13 > +}, 36); 36? Can we just do this in onload instead? 1611742 8 rniwa 2020-01-27 17:39:51 -0800 (In reply to Alexey Proskuryakov from comment #7) > Comment on attachment 388933 [details] > Deflake the test > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388933&action=review > > > LayoutTests/http/tests/loading/remove-child-triggers-parser.html:13 > > +}, 36); > > 36? Can we just do this in onload instead? Sure. I think we still want to wait more than 0s (I think the threshold is 5ms or 10ms). Will delay until load event & then schedule a timer. 1611784 9 rniwa 2020-01-27 19:55:01 -0800 Committed r255223: <https://trac.webkit.org/changeset/255223> 1611938 10 ap 2020-01-28 08:36:56 -0800 I wouldn't expect needing a timer after the load event. 1612912 11 aakash_jain 2020-01-30 04:44:05 -0800 > Committed r255223: <https://trac.webkit.org/changeset/255223> This change might have made this test fail consistently on windows, tracked in Bug 206992. Can you please have a look? 1614917 12 rniwa 2020-02-04 20:03:00 -0800 (In reply to Aakash Jain from comment #11) > > Committed r255223: <https://trac.webkit.org/changeset/255223> > This change might have made this test fail consistently on windows, tracked > in Bug 206992. Can you please have a look? FWIW, I've fixed this, and it looks like the test is no long flaky & not falling on Windows now. 388933 2020-01-27 16:13:16 -0800 2020-01-27 16:53:37 -0800 Deflake the test bug-103115-20200127161315.patch text/plain 2138 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI1NTE5MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAxLTI3ICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIGh0dHAvdGVzdHMvbG9hZGluZy9yZW1vdmUtY2hp bGQtdHJpZ2dlcnMtcGFyc2VyLmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzExNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIERlbGF5IHRoZSBlbmQgb2YgdGhlIHRlc3QgdW50aWwg dGhlIHRpbWVyIGZpcmVzLgorCisgICAgICAgICogaHR0cC90ZXN0cy9sb2FkaW5nL3JlbW92ZS1j aGlsZC10cmlnZ2Vycy1wYXJzZXItZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMv bG9hZGluZy9yZW1vdmUtY2hpbGQtdHJpZ2dlcnMtcGFyc2VyLmh0bWw6CisKIDIwMjAtMDEtMjcg IERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHVuYWJsZSB0byBldmFsdWF0ZSBpbiB0aGUgaXNvbGF0ZWQgd29ybGQgb2YgY29udGVudCBz Y3JpcHRzIGluamVjdGVkIGJ5IHNhZmFyaSBhcHAgZXh0ZW5zaW9ucwpJbmRleDogTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9sb2FkaW5nL3JlbW92ZS1jaGlsZC10cmlnZ2Vycy1wYXJzZXItZXhwZWN0 ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvbG9hZGluZy9yZW1v dmUtY2hpbGQtdHJpZ2dlcnMtcGFyc2VyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMjU1MTE0KQor KysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9sb2FkaW5nL3JlbW92ZS1jaGlsZC10cmlnZ2Vycy1w YXJzZXItZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0zLDQgKzMsMyBAQCBtYWluIGZy YW1lIC0gZGlkQ29tbWl0TG9hZEZvckZyYW1lCiBtYWluIGZyYW1lIC0gZGlkRmluaXNoRG9jdW1l bnRMb2FkRm9yRnJhbWUKIG1haW4gZnJhbWUgLSBkaWRIYW5kbGVPbmxvYWRFdmVudHNGb3JGcmFt ZQogbWFpbiBmcmFtZSAtIGRpZEZpbmlzaExvYWRGb3JGcmFtZQotCkluZGV4OiBMYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL2xvYWRpbmcvcmVtb3ZlLWNoaWxkLXRyaWdnZXJzLXBhcnNlci5odG1sCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvbG9hZGluZy9yZW1vdmUtY2hpbGQt dHJpZ2dlcnMtcGFyc2VyLmh0bWwJKHJldmlzaW9uIDI1NTExNCkKKysrIExheW91dFRlc3RzL2h0 dHAvdGVzdHMvbG9hZGluZy9yZW1vdmUtY2hpbGQtdHJpZ2dlcnMtcGFyc2VyLmh0bWwJKHdvcmtp bmcgY29weSkKQEAgLTEsOSArMSwxNiBAQAogPHNjcmlwdD48L3NjcmlwdD4KIDwhLS0gVGhpcyB0 ZXN0IGNvdmVycyBCdWcgOTM2NDEgLS0+CiA8c2NyaXB0PgotaWYgKHdpbmRvdy50ZXN0UnVubmVy KQoraWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CiAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7 Ci1zZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeyB2YXIgY2hpbGQgPSBkb2N1bWVudC5kb2N1bWVudEVs ZW1lbnQ7IGNoaWxkLnBhcmVudE5vZGUucmVtb3ZlQ2hpbGQoY2hpbGQpOyB9LCAzNik7CisgICAg dGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7Cit9CitzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgewor ICAgIHZhciBjaGlsZCA9IGRvY3VtZW50LmRvY3VtZW50RWxlbWVudDsKKyAgICBjaGlsZC5wYXJl bnROb2RlLnJlbW92ZUNoaWxkKGNoaWxkKTsKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisg ICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworfSwgMzYpOwogPC9zY3JpcHQ+CiA8c2Ny aXB0Pjwvc2NyaXB0PgogPHNwYW4+PC9zcGFuPgo=