103108 2012-11-23 01:59:11 -0800 REGRESSION (r135455): Compilation without SVG enabled broken 2012-11-23 08:35:59 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 102967 1 jochen jochen dino koivisto krit webkit.review.bot zimmermann oldest_to_newest 774316 0 jochen 2012-11-23 01:59:11 -0800 Seems like some #if ENABLE(SVG) got lost in the refactoring Source/WebCore/platform/graphics/filters/FilterOperation.h:198:40: error: private field 'm_cachedSVGDocumentReference' is not used [-Werror,-Wunused-private-field] OwnPtr<CachedSVGDocumentReference> m_cachedSVGDocumentReference; 774318 1 175755 jochen 2012-11-23 02:03:25 -0800 Created attachment 175755 Patch 774369 2 175755 webkit.review.bot 2012-11-23 03:23:23 -0800 Comment on attachment 175755 Patch Clearing flags on attachment: 175755 Committed r135583: <http://trac.webkit.org/changeset/135583> 774370 3 webkit.review.bot 2012-11-23 03:23:26 -0800 All reviewed patches have been landed. Closing bug. 774578 4 175755 krit 2012-11-23 08:35:59 -0800 Comment on attachment 175755 Patch Thanks for fixing. 175755 2012-11-23 02:03:25 -0800 2012-11-23 08:35:59 -0800 Patch bug-103108-20121123110109.patch text/plain 2423 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDhkMzkzZjE1YzdlYzIy MmI2MDM0YzFlYTljN2MxOWZlNDBjZmUyZS4uYjMyOTZlMDhiMjVkNmQ5ZjJkOWZiNDIzZjBhMmZm MTEzZmZjZjMxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTIzICBKb2No ZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04g KHIxMzU0NTUpOiBDb21waWxhdGlvbiB3aXRob3V0IFNWRyBlbmFibGVkIGJyb2tlbgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzMTA4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZSBTVkctb25seSBj b2RlIGJlaGluZCAjaWYgRU5BQkxFKFNWRykgdGhhdCB3YXMgYWNjaWRlbnRpYWxseSBtb3ZlZAor ICAgICAgICBvdXRzaWRlIG9mIHRoZSAjaWYgYmxvY2sgZHVyaW5nIHRoZSByZWZhY3RvcmluZy4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRmlsdGVyT3BlcmF0aW9uLmg6 CisgICAgICAgIChSZWZlcmVuY2VGaWx0ZXJPcGVyYXRpb24pOgorCiAyMDEyLTA5LTI2ICBHdXN0 YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgogCiAgICAgICAgIFtHVEtdIFNwbGl0 IFNWRyBmcm9tIFdlYkNvcmUgdG8gd29yay1hcm91bmQgbWFrZSBsaW1pdGF0aW9uCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZpbHRlck9wZXJh dGlvbi5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GaWx0ZXJP cGVyYXRpb24uaAppbmRleCA1OWJjZDk3MDcwYjNjNTljYmJlYjc0OGU2NmEwNzNmOTAwZWVhYzc5 Li5mYjliNjc2MTk4OTJhZDJkMmYyYWQwM2ZjMDA3MTZlNjJlZDZjYjQ0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZpbHRlck9wZXJhdGlvbi5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRmlsdGVyT3Bl cmF0aW9uLmgKQEAgLTI4LDcgKzI4LDYgQEAKIAogI2lmIEVOQUJMRShDU1NfRklMVEVSUykKIAot I2luY2x1ZGUgIkNhY2hlZFNWR0RvY3VtZW50UmVmZXJlbmNlLmgiCiAjaW5jbHVkZSAiQ29sb3Iu aCIKICNpbmNsdWRlICJGaWx0ZXJFZmZlY3QuaCIKICNpbmNsdWRlICJMYXlvdXRTaXplLmgiCkBA IC00Miw2ICs0MSwxMCBAQAogI2luY2x1ZGUgPHd0Zi9UaHJlYWRTYWZlUmVmQ291bnRlZC5oPgog I2VuZGlmCiAKKyNpZiBFTkFCTEUoU1ZHKQorI2luY2x1ZGUgIkNhY2hlZFNWR0RvY3VtZW50UmVm ZXJlbmNlLmgiCisjZW5kaWYKKwogLy8gQW5ub3lpbmdseSwgd2luZ2RpLmggI2RlZmluZXMgdGhp cy4KICNpZmRlZiBQQVNTVEhST1VHSAogI3VuZGVmIFBBU1NUSFJPVUdICkBAIC0xNzAsOCArMTcz LDEwIEBAIHB1YmxpYzoKICAgICBjb25zdCBTdHJpbmcmIHVybCgpIGNvbnN0IHsgcmV0dXJuIG1f dXJsOyB9CiAgICAgY29uc3QgU3RyaW5nJiBmcmFnbWVudCgpIGNvbnN0IHsgcmV0dXJuIG1fZnJh Z21lbnQ7IH0KIAorI2lmIEVOQUJMRShTVkcpCiAgICAgQ2FjaGVkU1ZHRG9jdW1lbnRSZWZlcmVu Y2UqIGNhY2hlZFNWR0RvY3VtZW50UmVmZXJlbmNlKCkgY29uc3QgeyByZXR1cm4gbV9jYWNoZWRT VkdEb2N1bWVudFJlZmVyZW5jZS5nZXQoKTsgfQogICAgIHZvaWQgc2V0Q2FjaGVkU1ZHRG9jdW1l bnRSZWZlcmVuY2UoUGFzc093blB0cjxDYWNoZWRTVkdEb2N1bWVudFJlZmVyZW5jZT4gY2FjaGVk U1ZHRG9jdW1lbnRSZWZlcmVuY2UpIHsgbV9jYWNoZWRTVkdEb2N1bWVudFJlZmVyZW5jZSA9IGNh Y2hlZFNWR0RvY3VtZW50UmVmZXJlbmNlOyB9CisjZW5kaWYKIAogICAgIEZpbHRlckVmZmVjdCog ZmlsdGVyRWZmZWN0KCkgY29uc3QgeyByZXR1cm4gbV9maWx0ZXJFZmZlY3QuZ2V0KCk7IH0KICAg ICB2b2lkIHNldEZpbHRlckVmZmVjdChQYXNzUmVmUHRyPEZpbHRlckVmZmVjdD4gZmlsdGVyRWZm ZWN0KSB7IG1fZmlsdGVyRWZmZWN0ID0gZmlsdGVyRWZmZWN0OyB9CkBAIC0xOTUsNyArMjAwLDkg QEAgcHJpdmF0ZToKIAogICAgIFN0cmluZyBtX3VybDsKICAgICBTdHJpbmcgbV9mcmFnbWVudDsK KyNpZiBFTkFCTEUoU1ZHKQogICAgIE93blB0cjxDYWNoZWRTVkdEb2N1bWVudFJlZmVyZW5jZT4g bV9jYWNoZWRTVkdEb2N1bWVudFJlZmVyZW5jZTsKKyNlbmRpZgogICAgIFJlZlB0cjxGaWx0ZXJF ZmZlY3Q+IG1fZmlsdGVyRWZmZWN0OwogfTsKIAo=