103101 2012-11-22 23:40:29 -0800 [CMake] Allow user specified compiler flags to take precedence 2012-11-26 00:32:09 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned gyuyoung.kim paroga rakuco webkit.review.bot oldest_to_newest 774247 0 laszlo.gombos 2012-11-22 23:40:29 -0800 Compiler/linker flags (e.g. CMAKE_C_FLAGS, CMAKE_CXX_FLAGS, CMAKE_SHARED_LINKER_FLAGS) specified by the build system should be always prepended to the user specified flags to make sure that the user specified flags take precedence. As an example - for the efl port - if the user would specify "build-webkit --efl --cmakearg="-DCMAKE_CXX_FLAGS=-Werror=unused-parameter" to treat unused-parameter warnings as errors, it would not work because the gcc command line would look something like the following: "... --Werror=unused-parameter ... -Werror -Wno-error=unused-parameter" and -Wno-error=unused-parameter takes precedence and the user specified option is ignored. This is also an attempt to not only fix this bug, but also make the code more consistent by always prepending compiler/linker flags in cmake files (as sometimes the code appends, sometimes prepends currently). 774267 1 175741 laszlo.gombos 2012-11-23 00:09:38 -0800 Created attachment 175741 proposed patch 775205 2 175741 bfulgham 2012-11-26 00:06:31 -0800 Comment on attachment 175741 proposed patch R=me 775220 3 175741 webkit.review.bot 2012-11-26 00:32:05 -0800 Comment on attachment 175741 proposed patch Clearing flags on attachment: 175741 Committed r135688: <http://trac.webkit.org/changeset/135688> 775221 4 webkit.review.bot 2012-11-26 00:32:09 -0800 All reviewed patches have been landed. Closing bug. 175741 2012-11-23 00:09:38 -0800 2012-11-26 00:32:05 -0800 proposed patch 103101.patch text/plain 3303 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEzNTU2 MikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEx LTIyICBMYXN6bG8gR29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0NN YWtlXSBBbGxvdyB1c2VyIHNwZWNpZmllZCBjb21waWxlciBmbGFncyB0byB0YWtlIHByZWNlZGVu Y2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzEw MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ug c3VyZSB0aGF0IGNvbXBpbGVyIGFuZCBsaW5rZXIgZmxhZ3Mgc3BlY2lmaWVkIGJ5IHRoZSBidWls ZCBzeXN0ZW0KKyAgICAgICAgYXJlIGFsd2F5cyBwcmVwZW5kZWQgdG8gdGhlIHZhcmlhYmxlcyB0 aGF0IGNhbiBiZSBzcGVjaWZpZWQgYnkgdGhlCisgICAgICAgIGVudmlyb25tZW50IGFuZCB0aGUg dXNlciBhcyB3ZWxsLiAKKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNt YWtlOgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zV2luZG93cy5jbWFrZToKKyAgICAg ICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZToKKwogMjAxMi0wOS0yNiAgR3Vz dGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KIAogICAgICAgICBbR1RLXSBTcGxp dCBTVkcgZnJvbSBXZWJDb3JlIHRvIHdvcmstYXJvdW5kIG1ha2UgbGltaXRhdGlvbgpJbmRleDog U291cmNlL2NtYWtlL09wdGlvbnNDb21tb24uY21ha2UKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL2Nt YWtlL09wdGlvbnNDb21tb24uY21ha2UJKHJldmlzaW9uIDEzNTUzMykKKysrIFNvdXJjZS9jbWFr ZS9PcHRpb25zQ29tbW9uLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBAIC0zMCw3ICszMCw3IEBAIFNU UklORyhUT0xPV0VSICR7Q01BS0VfSE9TVF9TWVNURU1fUFJPQ0UKIElGICgiJHtDTUFLRV9DWFhf Q09NUElMRVJfSUR9IiBTVFJFUVVBTCAiR05VIiBBTkQgIiR7TE9XRVJDQVNFX0NNQUtFX0hPU1Rf U1lTVEVNX1BST0NFU1NPUn0iIE1BVENIRVMgIihpWzMtNl04Nnx4ODYpIiBBTkQgIiR7Q01BS0Vf QlVJTERfVFlQRX0iIFNUUkVRVUFMICJEZWJ1ZyIpCiAgICAgIyBUbyBhdm9pZCBvdXQgb2YgbWVt b3J5IHdoZW4gYnVpbGRpbmcgd2l0aCBkZWJ1ZyBvcHRpb24gaW4gMzJiaXQgc3lzdGVtLgogICAg ICMgU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzMyNwotICAg IFNFVChDTUFLRV9TSEFSRURfTElOS0VSX0ZMQUdTICIke0NNQUtFX1NIQVJFRF9MSU5LRVJfRkxB R1N9IC1XbCwtLW5vLWtlZXAtbWVtb3J5IikKKyAgICBTRVQoQ01BS0VfU0hBUkVEX0xJTktFUl9G TEFHUyAiLVdsLC0tbm8ta2VlcC1tZW1vcnkgJHtDTUFLRV9TSEFSRURfTElOS0VSX0ZMQUdTfSIp CiBFTkRJRiAoKQogCiBTRVQoTElCX1NVRkZJWCAiIiBDQUNIRSBTVFJJTkcgIkRlZmluZSBzdWZm aXggb2YgZGlyZWN0b3J5IG5hbWUgKDMyLzY0KSIpCkluZGV4OiBTb3VyY2UvY21ha2UvT3B0aW9u c1dpbmRvd3MuY21ha2UKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL2NtYWtlL09wdGlvbnNXaW5kb3dz LmNtYWtlCShyZXZpc2lvbiAxMzU1MzMpCisrKyBTb3VyY2UvY21ha2UvT3B0aW9uc1dpbmRvd3Mu Y21ha2UJKHdvcmtpbmcgY29weSkKQEAgLTE0LDggKzE0LDggQEAgSUYgKE1TVkMpCiAgICAgU1RS SU5HKFJFR0VYIFJFUExBQ0UgIi9HUiIgIiIgQ01BS0VfQ1hYX0ZMQUdTICR7Q01BS0VfQ1hYX0ZM QUdTfSkgIyBEaXNhYmxlIFJUVEkKIAogICAgIElGIChOT1QgTVNWQ19WRVJTSU9OIExFU1MgMTUw MCkKLSAgICAgICAgU0VUKENNQUtFX0NfRkxBR1MgIiR7Q01BS0VfQ19GTEFHU30gL01QIikKLSAg ICAgICAgU0VUKENNQUtFX0NYWF9GTEFHUyAiJHtDTUFLRV9DWFhfRkxBR1N9IC9NUCIpCisgICAg ICAgIFNFVChDTUFLRV9DX0ZMQUdTICIvTVAgJHtDTUFLRV9DX0ZMQUdTfSIpCisgICAgICAgIFNF VChDTUFLRV9DWFhfRkxBR1MgIi9NUCAke0NNQUtFX0NYWF9GTEFHU30iKQogICAgIEVORElGICgp CiBFTkRJRiAoKQogCkluZGV4OiBTb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZQkocmV2aXNpb24gMTM1 NTMzKQorKysgU291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2UJKHdvcmtpbmcgY29weSkK QEAgLTIxLDcgKzIxLDcgQEAgTUFDUk8oV0VCS0lUX1NFVF9FWFRSQV9DT01QSUxFUl9GTEFHUyBf dAogICAgICMgRGlzYWJsZSBzb21lIG9wdGltaXphdGlvbnMgb24gYnVnZ3kgY29tcGlsZXIgdmVy c2lvbnMKICAgICAjIEdDQyA0LjUuMSBkb2VzIG5vdCBpbXBsZW1lbnQgLWZ0cmVlLXNyYSBjb3Jy ZWN0bHkKICAgICBJRiAoJHtDT01QSUxFUl9WRVJTSU9OfSBTVFJFUVVBTCAiNC41LjEiKQotICAg ICAgICBTRVQoT0xEX0NPTVBJTEVfRkxBR1MgIiR7T0xEX0NPTVBJTEVfRkxBR1N9IC1mbm8tdHJl ZS1zcmEiKQorICAgICAgICBTRVQoT0xEX0NPTVBJTEVfRkxBR1MgIi1mbm8tdHJlZS1zcmEgJHtP TERfQ09NUElMRV9GTEFHU30iKQogICAgIEVORElGICgpCiAKICAgICBJRiAoTk9UIFNIQVJFRF9D T1JFKQpAQCAtNDIsNyArNDIsNyBAQCBNQUNSTyhXRUJLSVRfU0VUX0VYVFJBX0NPTVBJTEVSX0ZM QUdTIF90CiAKICAgICAjIEVuYWJsZSBlcnJvcnMgb24gd2FybmluZwogICAgIElGIChPUFRJT05f RU5BQkxFX1dFUlJPUikKLSAgICAgICAgU0VUKE9MRF9DT01QSUxFX0ZMQUdTICIke09MRF9DT01Q SUxFX0ZMQUdTfSAtV2Vycm9yIC1Xbm8tZXJyb3I9dW51c2VkLXBhcmFtZXRlciIpCisgICAgICAg IFNFVChPTERfQ09NUElMRV9GTEFHUyAiLVdlcnJvciAtV25vLWVycm9yPXVudXNlZC1wYXJhbWV0 ZXIgJHtPTERfQ09NUElMRV9GTEFHU30iKQogICAgIEVORElGICgpCiAKICAgICAjIERpc2FibGUg QysrMHggY29tcGF0IHdhcm5pbmdzIGZvciBHQ0MgPj0gNC42LjAgdW50aWwgd2UgYnVpbGQK