103098 2012-11-22 17:45:01 -0800 [BlackBerry] Meta viewport can't be changed dynamically 2012-11-23 08:32:54 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jkjiang jkjiang manyoso mifenton rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 774147 0 jkjiang 2012-11-22 17:45:01 -0800 PR:237072 774151 1 175720 jkjiang 2012-11-22 18:08:22 -0800 Created attachment 175720 Patch 774178 2 175720 rwlbuis 2012-11-22 19:59:35 -0800 Comment on attachment 175720 Patch LGTM 774432 3 175720 tonikitoo 2012-11-23 04:36:03 -0800 Comment on attachment 175720 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175720&action=review I think it could have a comment on that of the changed block. > Source/WebKit/blackberry/Api/WebPage.cpp:3467 > + bool isLoadFinished = loadState() == WebKit::WebPagePrivate::Finished; nit: is the namespace needed? > Source/WebKit/blackberry/Api/WebPage.cpp:3472 > + if (loadState() == WebKit::WebPagePrivate::Committed || isLoadFinished) ditto 774561 4 jkjiang 2012-11-23 07:49:15 -0800 (In reply to comment #3) > (From update of attachment 175720 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=175720&action=review > > I think it could have a comment on that of the changed block. > > > Source/WebKit/blackberry/Api/WebPage.cpp:3467 > > + bool isLoadFinished = loadState() == WebKit::WebPagePrivate::Finished; > > nit: is the namespace needed? > > > Source/WebKit/blackberry/Api/WebPage.cpp:3472 > > + if (loadState() == WebKit::WebPagePrivate::Committed || isLoadFinished) > > ditto Nice catch, thanks Antonio! I will update these and push directly. 774575 5 jkjiang 2012-11-23 08:32:54 -0800 Committed r135615: <http://trac.webkit.org/changeset/135615> 175720 2012-11-22 18:08:22 -0800 2012-11-23 04:36:03 -0800 Patch bug-103098-20121122210605.patch text/plain 1989 jkjiang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBlYmQ1ZDQ2NzNlYmEwNDgxN2M3YjJkZTU1ZmNhZjJkOTM3OTJmZDI2Li44NTMwNDU4M2Uz OWI3YjQyN2YyNjQ3MWVlNmMwMDdiNWVhOTE5M2QwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0xMS0yMiAgSmFja3kgSmlhbmcgIDx6aGFqaWFu Z0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBNZXRhIHZpZXdwb3J0IGNhbid0IGJl IGNoYW5nZWQgZHluYW1pY2FsbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwMzA5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorICAgICAgICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5IEFydmlkIE5pbHNzb24uCisKKyAgICAg ICAgUFI6IDIzNzA3MgorICAgICAgICBSZXNldCBtX3VzZXJQZXJmb3JtZWRNYW51YWxab29tIGFu ZCBlbmFibGUKKyAgICAgICAgbV9zaG91bGRab29tVG9Jbml0aWFsU2NhbGVBZnRlckxvYWRGaW5p c2hlZCBzbyB0aGF0IHdlIGNhbiByZWxheW91dCB0aGUKKyAgICAgICAgcGFnZSBhbmQgem9vbSBp dCB0byBmaXQgdGhlIHNjcmVlbiB3aGVuIHdlIGR5bmFtaWNhbGx5IGNoYW5nZSB0aGUgbWV0YQor ICAgICAgICB2aWV3cG9ydCBhZnRlciB0aGUgbG9hZCBpcyBmaW5pc2hlZC4KKworICAgICAgICAq IEFwaS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZVBy aXZhdGU6OmRpc3BhdGNoVmlld3BvcnRQcm9wZXJ0aWVzRGlkQ2hhbmdlKToKKwogMjAxMi0xMS0y MSAgR2VuZXZpZXZlIE1hayAgPGdtYWtAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0g RHJvcCBTeW5jaHJvbm91cyBNb3VzZSBFdmVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBp L1dlYlBhZ2UuY3BwCmluZGV4IGJkMzcyYjk2MWNjMzNjNzlkNzEwNDA1MWNiMDI3ZGNlOWNiNDBk MWIuLjc5YjgwYzRjMmJhZDQxZDFiYjdhMjNjNGNjNjNmZjZiMzY2YzcyNGEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtMzQ2NCw3ICszNDY0LDEyIEBAIHZv aWQgV2ViUGFnZVByaXZhdGU6OmRpc3BhdGNoVmlld3BvcnRQcm9wZXJ0aWVzRGlkQ2hhbmdlKGNv bnN0IFZpZXdwb3J0QXJndW1lbnRzCiAgICAgUGxhdGZvcm06OkludFNpemUgdmlydHVhbFZpZXdw b3J0ID0gcmVjb21wdXRlVmlydHVhbFZpZXdwb3J0RnJvbVZpZXdwb3J0QXJndW1lbnRzKCk7CiAg ICAgbV93ZWJQYWdlLT5zZXRWaXJ0dWFsVmlld3BvcnRTaXplKHZpcnR1YWxWaWV3cG9ydCk7CiAK LSAgICBpZiAobG9hZFN0YXRlKCkgPT0gV2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6Q29tbWl0dGVk KQorICAgIGJvb2wgaXNMb2FkRmluaXNoZWQgPSBsb2FkU3RhdGUoKSA9PSBXZWJLaXQ6OldlYlBh Z2VQcml2YXRlOjpGaW5pc2hlZDsKKyAgICBpZiAoaXNMb2FkRmluaXNoZWQpIHsKKyAgICAgICAg bV91c2VyUGVyZm9ybWVkTWFudWFsWm9vbSA9IGZhbHNlOworICAgICAgICBzZXRTaG91bGRab29t VG9Jbml0aWFsU2NhbGVBZnRlckxvYWRGaW5pc2hlZCh0cnVlKTsKKyAgICB9CisgICAgaWYgKGxv YWRTdGF0ZSgpID09IFdlYktpdDo6V2ViUGFnZVByaXZhdGU6OkNvbW1pdHRlZCB8fCBpc0xvYWRG aW5pc2hlZCkKICAgICAgICAgem9vbVRvSW5pdGlhbFNjYWxlT25Mb2FkKCk7CiB9CiAK