103097 2012-11-22 16:55:21 -0800 Coordinated Graphics: Match the behavior of selfOrAncestorHaveNonAffineTransforms() to its name. 2012-11-23 09:10:49 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dongseong.hwang dongseong.hwang noam webkit.review.bot zeno oldest_to_newest 774143 0 dongseong.hwang 2012-11-22 16:55:21 -0800 CoordinatedGraphicsLayer::selfOrAncestorHaveNonAffineTransforms() does not check its ancestor. This patch makes this method check its ancestor to match the name of this method. 774144 1 175718 dongseong.hwang 2012-11-22 16:57:07 -0800 Created attachment 175718 Patch 774145 2 dongseong.hwang 2012-11-22 16:58:14 -0800 effectiveContentsScale() only uses selfOrAncestorHaveNonAffineTransforms() and I think checking parents makes sense. float CoordinatedGraphicsLayer::effectiveContentsScale() { return selfOrAncestorHaveNonAffineTransforms() ? 1 : m_contentsScale; } 774606 3 175718 webkit.review.bot 2012-11-23 09:10:46 -0800 Comment on attachment 175718 Patch Clearing flags on attachment: 175718 Committed r135624: <http://trac.webkit.org/changeset/135624> 774607 4 webkit.review.bot 2012-11-23 09:10:49 -0800 All reviewed patches have been landed. Closing bug. 175718 2012-11-22 16:57:07 -0800 2012-11-23 09:10:46 -0800 Patch bug-103097-20121123095446.patch text/plain 2062 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzU0NDQ2YmM2NzJkMWNk MmVkOThlNTFkMDlmOTI2M2QxODRkMWRkZi4uY2JlY2VkMjcyZTlmOGU2MTI0ZGQ4NDc4NDFkOWFh YTBmOTViM2Q2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTExLTIyICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCisgICAgICAgIENvb3JkaW5h dGVkIEdyYXBoaWNzOiBNYXRjaCB0aGUgYmVoYXZpb3Igb2Ygc2VsZk9yQW5jZXN0b3JIYXZlTm9u QWZmaW5lVHJhbnNmb3JtcygpIHRvIGl0cyBuYW1lLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzMDk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjpzZWxmT3JB bmNlc3RvckhhdmVOb25BZmZpbmVUcmFuc2Zvcm1zKCkgZG9lcworICAgICAgICBub3QgY2hlY2sg aXRzIGFuY2VzdG9yLiBUaGlzIHBhdGNoIG1ha2VzIHRoaXMgbWV0aG9kIGNoZWNrIGl0cyBhbmNl c3RvcgorICAgICAgICB0byBtYXRjaCBpdHMgbmFtZS4KKworICAgICAgICAqIFdlYlByb2Nlc3Mv V2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXI6OnNlbGZPckFuY2Vz dG9ySGF2ZU5vbkFmZmluZVRyYW5zZm9ybXMpOgorCisyMDEyLTExLTIyICBIdWFuZyBEb25nc3Vu ZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCiAgICAgICAgIFtUZXhNYXBdIFJlbW92ZSBk ZXBlbmRlbmN5IG9mIFRleHR1cmVNYXBwZXJMYXllciBvbiBHcmFwaGljc0xheWVyVGV4dHVyZU1h cHBlci4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MzA0NgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29v cmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRH cmFwaGljc0xheWVyLmNwcAppbmRleCBlNTYzOWNmNzk5MmQ0YTJiMDY4ODYxNjEzZDhiODdiODk4 MWZmYzlmLi5jNzgwOGIyYjJjYzJmZDE5ODg5ZDAzNmRmNGFhZmMyYTAyZmMyYjI5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGlj cy9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXll ci5jcHAKQEAgLTg2MCw3ICs4NjAsMTAgQEAgYm9vbCBDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXI6 OnNlbGZPckFuY2VzdG9ySGF2ZU5vbkFmZmluZVRyYW5zZm9ybXMoKQogICAgIGlmICghbV9sYXll clRyYW5zZm9ybS5jb21iaW5lZCgpLmlzQWZmaW5lKCkpCiAgICAgICAgIHJldHVybiB0cnVlOwog Ci0gICAgcmV0dXJuIGZhbHNlOworICAgIGlmICghcGFyZW50KCkpCisgICAgICAgIHJldHVybiBm YWxzZTsKKworICAgIHJldHVybiB0b0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllcihwYXJlbnQoKSkt PnNlbGZPckFuY2VzdG9ySGF2ZU5vbkFmZmluZVRyYW5zZm9ybXMoKTsKIH0KIAogYm9vbCBDb29y ZGluYXRlZEdyYXBoaWNzTGF5ZXI6OmFkZEFuaW1hdGlvbihjb25zdCBLZXlmcmFtZVZhbHVlTGlz dCYgdmFsdWVMaXN0LCBjb25zdCBJbnRTaXplJiBib3hTaXplLCBjb25zdCBBbmltYXRpb24qIGFu aW0sIGNvbnN0IFN0cmluZyYga2V5ZnJhbWVzTmFtZSwgZG91YmxlIGRlbGF5QXNOZWdhdGl2ZVRp bWVPZmZzZXQpCg==