103082 2012-11-22 10:03:05 -0800 [Chromium] Shared graphics context should only pushGroupMarker() once 2012-11-26 20:15:00 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco dino gman jamesr oliver webkit.review.bot oldest_to_newest 774018 0 senorblanco 2012-11-22 10:03:05 -0800 [Chromium] Shared graphics context should only pushGroupMarker() once 774020 1 175691 senorblanco 2012-11-22 10:06:10 -0800 Created attachment 175691 Patch 775127 2 175691 jamesr 2012-11-25 21:45:28 -0800 Comment on attachment 175691 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175691&action=review > Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp:56 > + m_context->getExtensions()->pushGroupMarkerEXT("AcceleratedCanvasContext"); this is a bit misleading (although it was in ImageBufferSkia.cpp as well) since this context is used for things other than canvas. 776016 3 175691 senorblanco 2012-11-26 16:15:10 -0800 Comment on attachment 175691 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175691&action=review >> Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp:56 >> + m_context->getExtensions()->pushGroupMarkerEXT("AcceleratedCanvasContext"); > > this is a bit misleading (although it was in ImageBufferSkia.cpp as well) since this context is used for things other than canvas. Yeah, I was thinking of renaming this "SharedGraphicsContext" or something. WDYT? 776040 4 jamesr 2012-11-26 16:23:42 -0800 SGTM! 776120 5 176124 senorblanco 2012-11-26 17:25:35 -0800 Created attachment 176124 Patch for landing 776243 6 176124 webkit.review.bot 2012-11-26 20:10:33 -0800 Comment on attachment 176124 Patch for landing Clearing flags on attachment: 176124 Committed r135809: <http://trac.webkit.org/changeset/135809> 776244 7 webkit.review.bot 2012-11-26 20:10:36 -0800 All reviewed patches have been landed. Closing bug. 776248 8 gman 2012-11-26 20:15:00 -0800 If that's that case can't you move the pushGroupEXT to the code that's creating the SharedGraphicsContext? The whole point of this is so you, at a glance from the logs, tell which part of the code is generating errors. If SharedGraphicsContext is used by more than one thing each of those things should be calling pushGroupEXT so we can tell them apart 175691 2012-11-22 10:06:10 -0800 2012-11-26 17:25:33 -0800 Patch bug-103082-20121122130354.patch text/plain 3048 senorblanco U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjEwZDE0N2Y3YTg1MzBk ZjZlZTBkNjViYTI1NmQxNmYwM2U2YTJhMi4uYWQ2OTI0OTZjZjMzMzA4MjJlZjhlNDFhYmM0YTcz NzM5MDY5YzBjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTExLTIyICBTdGVw aGVuIFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1 bV0gU2hhcmVkIGdyYXBoaWNzIGNvbnRleHQgc2hvdWxkIG9ubHkgcHVzaEdyb3VwTWFya2VyKCkg b25jZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAz MDgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR3Jh cGhpY3NDb250ZXh0M0QncyBwdXNoR3JvdXBNYXJrZXJFWFQoKSBpcyBiZWluZyBjYWxsZWQgZXZl cnkgdGltZQorICAgICAgICBhbiBJbWFnZUJ1ZmZlciBpcyBjcmVhdGVkLCBsZWFkaW5nIHRvIHVu bGltaXRlZCBtZW1vcnkgZ3Jvd3RoLCBzaW5jZQorICAgICAgICB0aGV5IHNoYXJlIGEgY29tbW9u IEdyYXBoaWNzQ29udGV4dDNELiAgSXQgc2hvdWxkIGJlIGNhbGxlZCBvbmx5IG9uY2UsCisgICAg ICAgIG9uIGNvbnRleHQgY3JlYXRpb24uCisKKyAgICAgICAgVGVzdGVkIGJ5IG1hbnVhbGx5IGNo ZWNraW5nIHRoZSBtZW1vcnkgdXNhZ2UgaW4gQ2hyb21lJ3MgVGFza01hbmFnZXIuCisgICAgICAg IChTb3JyeSwgSSBjYW4ndCB0aGluayBvZiBhIHdheSB0byB0ZXN0IHRoaXMgYXV0b21hdGljYWxs eS4pCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvU2hhcmVkR3JhcGhpY3NDb250 ZXh0M0QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2hhcmVkR3JhcGhpY3NDb250ZXh0M0RJbXBs OjpnZXRPckNyZWF0ZUNvbnRleHQpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEv SW1hZ2VCdWZmZXJTa2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZUFjY2VsZXJhdGVk Q2FudmFzKToKKwogMjAxMi0xMS0yMiAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgW1Y4XSBSZW5hbWUgdG9XZWJDb3JlU3RyaW5nV2l0aE51bGxPclVuZGVm aW5lZENoZWNrKCkgd2l0aCB0b1dlYkNvcmVTdHJpbmdXaXRoVW5kZWZpbmVkT3JOdWxsQ2hlY2so KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1NoYXJl ZEdyYXBoaWNzQ29udGV4dDNELmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dwdS9TaGFyZWRHcmFwaGljc0NvbnRleHQzRC5jcHAKaW5kZXggYzA2M2ZlNGJiYzhjOTAyZjNj YTlhNGQwOGZlOTk1YmQ1MWY5NTNkZS4uNzQzNjlmOGY4ZWM1ZWFmNGE1NTc4YTBmMzNiZDY5M2Ni MzE3YjVjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1 L1NoYXJlZEdyYXBoaWNzQ29udGV4dDNELmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9ncHUvU2hhcmVkR3JhcGhpY3NDb250ZXh0M0QuY3BwCkBAIC00MiwxMiArNDIs MTkgQEAgcHVibGljOgogICAgICAgICBpZiAobV9jb250ZXh0ICYmICghbV9jb250ZXh0LT5tYWtl Q29udGV4dEN1cnJlbnQoKSB8fCAobV9jb250ZXh0LT5nZXRFeHRlbnNpb25zKCktPmdldEdyYXBo aWNzUmVzZXRTdGF0dXNBUkIoKSAhPSBHcmFwaGljc0NvbnRleHQzRDo6Tk9fRVJST1IpKSkKICAg ICAgICAgICAgIG1fY29udGV4dC5jbGVhcigpOwogCi0gICAgICAgIGlmICghbV9jb250ZXh0KQor ICAgICAgICBib29sIHdhc0NyZWF0ZWQgPSBmYWxzZTsKKworICAgICAgICBpZiAoIW1fY29udGV4 dCkgewogICAgICAgICAgICAgY3JlYXRlQ29udGV4dCgpOworICAgICAgICAgICAgd2FzQ3JlYXRl ZCA9IHRydWU7CisgICAgICAgIH0KIAogICAgICAgICBpZiAobV9jb250ZXh0ICYmICFtX2NvbnRl eHQtPm1ha2VDb250ZXh0Q3VycmVudCgpKQogICAgICAgICAgICAgbV9jb250ZXh0LmNsZWFyKCk7 CiAKKyAgICAgICAgaWYgKG1fY29udGV4dCAmJiB3YXNDcmVhdGVkKQorICAgICAgICAgICAgbV9j b250ZXh0LT5nZXRFeHRlbnNpb25zKCktPnB1c2hHcm91cE1hcmtlckVYVCgiQWNjZWxlcmF0ZWRD YW52YXNDb250ZXh0Iik7CisKICAgICAgICAgcmV0dXJuIG1fY29udGV4dDsKICAgICB9CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZm ZXJTa2lhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VC dWZmZXJTa2lhLmNwcAppbmRleCAxN2U5MWRiN2VlNmE3ZDdjNTI3ZDY4ODYwZDU4MWY4NzY2ZjQ0 YTlmLi44Yjc4ODY1MGQ3NmM5YzcxOGIzMWExMDk0NTE1YTQyM2Q5Yzc5ZGQyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZl clNraWEuY3BwCkBAIC03OSw3ICs3OSw2IEBAIHN0YXRpYyBTa0NhbnZhcyogY3JlYXRlQWNjZWxl cmF0ZWRDYW52YXMoY29uc3QgSW50U2l6ZSYgc2l6ZSwgSW1hZ2VCdWZmZXJEYXRhKiBkCiAgICAg R3JDb250ZXh0KiBnciA9IGNvbnRleHQzRC0+Z3JDb250ZXh0KCk7CiAgICAgaWYgKCFncikKICAg ICAgICAgcmV0dXJuIDA7Ci0gICAgY29udGV4dDNELT5nZXRFeHRlbnNpb25zKCktPnB1c2hHcm91 cE1hcmtlckVYVCgiQWNjZWxlcmF0ZWRDYW52YXNDb250ZXh0Iik7CiAgICAgZ3ItPnJlc2V0Q29u dGV4dCgpOwogICAgIEdyVGV4dHVyZURlc2MgZGVzYzsKICAgICBkZXNjLmZGbGFncyA9IGtSZW5k ZXJUYXJnZXRfR3JUZXh0dXJlRmxhZ0JpdDsK 176124 2012-11-26 17:25:35 -0800 2012-11-26 20:10:33 -0800 Patch for landing bug-103082-20121126172313.patch text/plain 3034 senorblanco U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1Nzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTMxZmQ2YzAxODhmNDFi YjFjOTE0OWVjYzE3ZDc4OWVhZWU1MmM2Ni4uYTRmYjA0OWJlMDNlMzFkZGM5NDJhYmUwNzM5MTJl YzgzNTFmZjg0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTExLTIyICBTdGVw aGVuIFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1 bV0gU2hhcmVkIGdyYXBoaWNzIGNvbnRleHQgc2hvdWxkIG9ubHkgcHVzaEdyb3VwTWFya2VyKCkg b25jZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAz MDgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSmFtZXMgUm9iaW5zb24uCisKKyAgICAgICAgR3Jh cGhpY3NDb250ZXh0M0QncyBwdXNoR3JvdXBNYXJrZXJFWFQoKSBpcyBiZWluZyBjYWxsZWQgZXZl cnkgdGltZQorICAgICAgICBhbiBJbWFnZUJ1ZmZlciBpcyBjcmVhdGVkLCBsZWFkaW5nIHRvIHVu bGltaXRlZCBtZW1vcnkgZ3Jvd3RoLCBzaW5jZQorICAgICAgICB0aGV5IHNoYXJlIGEgY29tbW9u IEdyYXBoaWNzQ29udGV4dDNELiAgSXQgc2hvdWxkIGJlIGNhbGxlZCBvbmx5IG9uY2UsCisgICAg ICAgIG9uIGNvbnRleHQgY3JlYXRpb24uCisKKyAgICAgICAgVGVzdGVkIGJ5IG1hbnVhbGx5IGNo ZWNraW5nIHRoZSBtZW1vcnkgdXNhZ2UgaW4gQ2hyb21lJ3MgVGFza01hbmFnZXIuCisgICAgICAg IChTb3JyeSwgSSBjYW4ndCB0aGluayBvZiBhIHdheSB0byB0ZXN0IHRoaXMgYXV0b21hdGljYWxs eS4pCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvU2hhcmVkR3JhcGhpY3NDb250 ZXh0M0QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2hhcmVkR3JhcGhpY3NDb250ZXh0M0RJbXBs OjpnZXRPckNyZWF0ZUNvbnRleHQpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEv SW1hZ2VCdWZmZXJTa2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZUFjY2VsZXJhdGVk Q2FudmFzKToKKwogMjAxMi0xMS0yNiAgVmFydW4gSmFpbiAgPHZhcnVuamFpbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgTG9uZ1ByZXNzIGFuZCBMb25nVGFwIGdlc3R1cmVzIHNob3VsZCBzdGFy dCBkcmFnL2Ryb3AgYW5kIG9wZW4gY29udGV4dCBtZW51IHJlc3BlY3RpdmVseS4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9TaGFyZWRHcmFwaGljc0Nv bnRleHQzRC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvU2hhcmVk R3JhcGhpY3NDb250ZXh0M0QuY3BwCmluZGV4IGMwNjNmZTRiYmM4YzkwMmYzY2E5YTRkMDhmZTk5 NWJkNTFmOTUzZGUuLjU4YTE2YjRhY2ZmNWU1ZTEyMzQ0Mzk3ZjdlOTQ0NzY0MzIzNGE4OWIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9TaGFyZWRHcmFw aGljc0NvbnRleHQzRC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3B1L1NoYXJlZEdyYXBoaWNzQ29udGV4dDNELmNwcApAQCAtNDIsMTIgKzQyLDE5IEBAIHB1Ymxp YzoKICAgICAgICAgaWYgKG1fY29udGV4dCAmJiAoIW1fY29udGV4dC0+bWFrZUNvbnRleHRDdXJy ZW50KCkgfHwgKG1fY29udGV4dC0+Z2V0RXh0ZW5zaW9ucygpLT5nZXRHcmFwaGljc1Jlc2V0U3Rh dHVzQVJCKCkgIT0gR3JhcGhpY3NDb250ZXh0M0Q6Ok5PX0VSUk9SKSkpCiAgICAgICAgICAgICBt X2NvbnRleHQuY2xlYXIoKTsKIAotICAgICAgICBpZiAoIW1fY29udGV4dCkKKyAgICAgICAgYm9v bCB3YXNDcmVhdGVkID0gZmFsc2U7CisKKyAgICAgICAgaWYgKCFtX2NvbnRleHQpIHsKICAgICAg ICAgICAgIGNyZWF0ZUNvbnRleHQoKTsKKyAgICAgICAgICAgIHdhc0NyZWF0ZWQgPSB0cnVlOwor ICAgICAgICB9CiAKICAgICAgICAgaWYgKG1fY29udGV4dCAmJiAhbV9jb250ZXh0LT5tYWtlQ29u dGV4dEN1cnJlbnQoKSkKICAgICAgICAgICAgIG1fY29udGV4dC5jbGVhcigpOwogCisgICAgICAg IGlmIChtX2NvbnRleHQgJiYgd2FzQ3JlYXRlZCkKKyAgICAgICAgICAgIG1fY29udGV4dC0+Z2V0 RXh0ZW5zaW9ucygpLT5wdXNoR3JvdXBNYXJrZXJFWFQoIlNoYXJlZEdyYXBoaWNzQ29udGV4dCIp OworCiAgICAgICAgIHJldHVybiBtX2NvbnRleHQ7CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAK aW5kZXggMTdlOTFkYjdlZTZhN2Q3YzUyN2Q2ODg2MGQ1ODFmODc2NmY0NGE5Zi4uOGI3ODg2NTBk NzZjOWM3MThiMzFhMTA5NDUxNWE0MjNkOWM3OWRkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcApAQCAt NzksNyArNzksNiBAQCBzdGF0aWMgU2tDYW52YXMqIGNyZWF0ZUFjY2VsZXJhdGVkQ2FudmFzKGNv bnN0IEludFNpemUmIHNpemUsIEltYWdlQnVmZmVyRGF0YSogZAogICAgIEdyQ29udGV4dCogZ3Ig PSBjb250ZXh0M0QtPmdyQ29udGV4dCgpOwogICAgIGlmICghZ3IpCiAgICAgICAgIHJldHVybiAw OwotICAgIGNvbnRleHQzRC0+Z2V0RXh0ZW5zaW9ucygpLT5wdXNoR3JvdXBNYXJrZXJFWFQoIkFj Y2VsZXJhdGVkQ2FudmFzQ29udGV4dCIpOwogICAgIGdyLT5yZXNldENvbnRleHQoKTsKICAgICBH clRleHR1cmVEZXNjIGRlc2M7CiAgICAgZGVzYy5mRmxhZ3MgPSBrUmVuZGVyVGFyZ2V0X0dyVGV4 dHVyZUZsYWdCaXQ7Cg==