103066 2012-11-22 06:37:00 -0800 [V8] fix DOMWrapperWorld destructor 2012-11-22 14:56:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dcarney webkit-unassigned abarth haraken japhet webkit.review.bot oldest_to_newest 773910 0 dcarney 2012-11-22 06:37:00 -0800 [V8] fix DOMWrapperWorld destructor 773912 1 175664 dcarney 2012-11-22 06:39:51 -0800 Created attachment 175664 Patch 773923 2 175664 jochen 2012-11-22 06:51:28 -0800 Comment on attachment 175664 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175664&action=review > Source/WebCore/bindings/v8/DOMWrapperWorld.cpp:85 > + ASSERT(!isMainWorld()); why is the assert and the if in the next line not using the same condition? 773925 3 175664 dcarney 2012-11-22 06:55:08 -0800 Comment on attachment 175664 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175664&action=review >> Source/WebCore/bindings/v8/DOMWrapperWorld.cpp:85 >> + ASSERT(!isMainWorld()); > > why is the assert and the if in the next line not using the same condition? there is a third type of world - uninitialized, which is the target of the return statement 774110 4 175664 webkit.review.bot 2012-11-22 14:56:17 -0800 Comment on attachment 175664 Patch Clearing flags on attachment: 175664 Committed r135545: <http://trac.webkit.org/changeset/135545> 774111 5 webkit.review.bot 2012-11-22 14:56:20 -0800 All reviewed patches have been landed. Closing bug. 175664 2012-11-22 06:39:51 -0800 2012-11-22 14:56:16 -0800 Patch bug-103066-20121122153735.patch text/plain 4295 dcarney U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODJiYWRlMmYxZmM5MTY0 YzljODJjMzBlNmFmNTc2NDA5NTgxN2MwNy4uMTI3Njg2OTdjNDJmMDFiM2IxZGY1MjNhMzc2NjY2 NDFhMDQ1ZmI1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTExLTIyICBEYW4g Q2FybmV5ICA8ZGNhcm5leUBnb29nbGUuY29tPgorCisgICAgICAgIFtWOF0gZml4IERPTVdyYXBw ZXJXb3JsZCBkZXN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMDMwNjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBET01XcmFwcGVyV29ybGQgaGFkIGEgd29ya2Fyb3VuZCBpbiBwbGFjZSBkdXJp bmcgZGVsZXRpb24uCisgICAgICAgIFRoaXMgcGF0Y2ggYnJpbmdzIGl0IGluIGxpbmUgd2l0aCBX ZWJLaXQgc3RhbmRhcmRzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0czogcmVmYWN0b3IuCisKKyAg ICAgICAgKiBiaW5kaW5ncy92OC9ET01XcmFwcGVyV29ybGQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RE9NV3JhcHBlcldvcmxkOjp+RE9NV3JhcHBlcldvcmxkKToKKyAgICAgICAgKFdlYkNvcmU6 OkRPTVdyYXBwZXJXb3JsZDo6ZW5zdXJlSXNvbGF0ZWRXb3JsZCk6CisgICAgICAgICogYmluZGlu Z3MvdjgvRE9NV3JhcHBlcldvcmxkLmg6CisgICAgICAgIChET01XcmFwcGVyV29ybGQpOgorICAg ICAgICAoV2ViQ29yZTo6RE9NV3JhcHBlcldvcmxkOjppc29sYXRlZFdvcmxkRE9NRGF0YVN0b3Jl KToKKwogMjAxMi0xMS0yMiAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQGRp Z2lhLmNvbT4KIAogICAgICAgICBbUXRdIExvb2t1cCBtaW1ldHlwZXMgdXNpbmcgUU1pbWVEYXRh YmFzZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NV3JhcHBlcldv cmxkLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTVdyYXBwZXJXb3JsZC5jcHAK aW5kZXggZDNhMDk1MmE5Zjk3NWUwMmE1MDc3OTJhN2ExZjk3YTZiYTQ0YmExYS4uNzhkZmUwZGU2 YmMyNmQ5ZmU3ZjFkYzU4NWM3ODg2NTE3NGE1NWU5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvRE9NV3JhcHBlcldvcmxkLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9ET01XcmFwcGVyV29ybGQuY3BwCkBAIC04MCwyOSArODAsMjQgQEAgdm9pZCBE T01XcmFwcGVyV29ybGQ6OmdldEFsbFdvcmxkcyhWZWN0b3I8UmVmUHRyPERPTVdyYXBwZXJXb3Js ZD4gPiYgd29ybGRzKQogICAgICAgICB3b3JsZHMuYXBwZW5kKGl0LT52YWx1ZSk7CiB9CiAKLXZv aWQgRE9NV3JhcHBlcldvcmxkOjpkZWFsbG9jYXRlKERPTVdyYXBwZXJXb3JsZCogd29ybGQpCitE T01XcmFwcGVyV29ybGQ6On5ET01XcmFwcGVyV29ybGQoKQogewotICAgIGludCB3b3JsZElkID0g d29ybGQtPndvcmxkSWQoKTsKKyAgICBBU1NFUlQoIWlzTWFpbldvcmxkKCkpOwogCi0gICAgLy8g RW5zdXJlIHdlIG5ldmVyIGRlYWxsb2NhdGUgbWFpblRocmVhZE5vcm1hbFdvcmxkCi0gICAgaWYg KHdvcmxkSWQgPT0gbWFpbldvcmxkSWQpCi0gICAgICAgIHJldHVybjsKLQotICAgIGRlbGV0ZSB3 b3JsZDsKLQotICAgIGlmICh3b3JsZElkID09IHVuaW5pdGlhbGl6ZWRXb3JsZElkKQorICAgIGlm ICghaXNJc29sYXRlZFdvcmxkKCkpCiAgICAgICAgIHJldHVybjsKIAogICAgIFdvcmxkTWFwJiBt YXAgPSBpc29sYXRlZFdvcmxkTWFwKCk7Ci0gICAgV29ybGRNYXA6Oml0ZXJhdG9yIGkgPSBtYXAu ZmluZCh3b3JsZElkKTsKKyAgICBXb3JsZE1hcDo6aXRlcmF0b3IgaSA9IG1hcC5maW5kKG1fd29y bGRJZCk7CiAgICAgaWYgKGkgPT0gbWFwLmVuZCgpKSB7CiAgICAgICAgIEFTU0VSVF9OT1RfUkVB Q0hFRCgpOwogICAgICAgICByZXR1cm47CiAgICAgfQotICAgIEFTU0VSVChpLT52YWx1ZSA9PSB3 b3JsZCk7CisgICAgQVNTRVJUKGktPnZhbHVlID09IHRoaXMpOwogCiAgICAgbWFwLnJlbW92ZShp KTsKICAgICBpc29sYXRlZFdvcmxkQ291bnQtLTsKKyAgICBBU1NFUlQobWFwLnNpemUoKSA9PSBp c29sYXRlZFdvcmxkQ291bnQpOwogfQogCiBzdGF0aWMgaW50IHRlbXBvcmFyeVdvcmxkSWQgPSBE T01XcmFwcGVyV29ybGQ6OnVuaW5pdGlhbGl6ZWRXb3JsZElkLTE7CkBAIC0xMjYsNiArMTIxLDgg QEAgUGFzc1JlZlB0cjxET01XcmFwcGVyV29ybGQ+IERPTVdyYXBwZXJXb3JsZDo6ZW5zdXJlSXNv bGF0ZWRXb3JsZChpbnQgd29ybGRJZCwgaW4KICAgICBSZWZQdHI8RE9NV3JhcHBlcldvcmxkPiB3 b3JsZCA9IGFkb3B0UmVmKG5ldyBET01XcmFwcGVyV29ybGQod29ybGRJZCwgZXh0ZW5zaW9uR3Jv dXApKTsKICAgICBtYXAuYWRkKHdvcmxkSWQsIHdvcmxkLmdldCgpKTsKICAgICBpc29sYXRlZFdv cmxkQ291bnQrKzsKKyAgICBBU1NFUlQobWFwLnNpemUoKSA9PSBpc29sYXRlZFdvcmxkQ291bnQp OworCiAgICAgcmV0dXJuIHdvcmxkLnJlbGVhc2UoKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NV3JhcHBlcldvcmxkLmggYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9ET01XcmFwcGVyV29ybGQuaAppbmRleCAyOTAwODg2ZDdiNzRlMzEwMDRjZTQ3 NGEwMWE3YTFkZGI4MTRlNWE5Li5iNDc4ODhiYWNhM2FhYTYwNDA2MmM1ZWJmZGE0ZDVlZDM0YmM4 NTI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9ET01XcmFwcGVyV29y bGQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9ET01XcmFwcGVyV29ybGQuaApA QCAtNDIsNyArNDIsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBjbGFzcyBET01EYXRhU3RvcmU7 CiAKIC8vIFRoaXMgY2xhc3MgcmVwcmVzZW50IGEgY29sbGVjdGlvbiBvZiBET00gd3JhcHBlcnMg Zm9yIGEgc3BlY2lmaWMgd29ybGQuCi1jbGFzcyBET01XcmFwcGVyV29ybGQgOiBwdWJsaWMgV1RG OjpSZWZDb3VudGVkQmFzZSB7CitjbGFzcyBET01XcmFwcGVyV29ybGQgOiBwdWJsaWMgUmVmQ291 bnRlZDxET01XcmFwcGVyV29ybGQ+IHsKIHB1YmxpYzoKICAgICBzdGF0aWMgY29uc3QgaW50IG1h aW5Xb3JsZElkID0gMDsKICAgICBzdGF0aWMgY29uc3QgaW50IG1haW5Xb3JsZEV4dGVuc2lvbkdy b3VwID0gMDsKQEAgLTUwLDYgKzUwLDggQEAgcHVibGljOgogICAgIHN0YXRpYyBjb25zdCBpbnQg dW5pbml0aWFsaXplZEV4dGVuc2lvbkdyb3VwID0gLTE7CiAgICAgLy8gSWYgdW5pbml0aWFsaXpl ZFdvcmxkSWQgaXMgcGFzc2VkIGFzIHdvcmxkSWQsIHRoZSB3b3JsZCB3aWxsIGJlIGFzc2lnbmVk IGEgdGVtcG9yYXJ5IGlkIGluc3RlYWQuCiAgICAgc3RhdGljIFBhc3NSZWZQdHI8RE9NV3JhcHBl cldvcmxkPiBlbnN1cmVJc29sYXRlZFdvcmxkKGludCB3b3JsZElkLCBpbnQgZXh0ZW5zaW9uR3Jv dXApOworICAgIH5ET01XcmFwcGVyV29ybGQoKTsKKwogICAgIHN0YXRpYyBib29sIGlzb2xhdGVk V29ybGRzRXhpc3QoKSB7IHJldHVybiBpc29sYXRlZFdvcmxkQ291bnQ7IH0KICAgICBzdGF0aWMg Ym9vbCBpc0lzb2xhdGVkV29ybGRJZChpbnQgd29ybGRJZCkgeyByZXR1cm4gd29ybGRJZCAhPSBt YWluV29ybGRJZCAmJiB3b3JsZElkICE9IHVuaW5pdGlhbGl6ZWRXb3JsZElkOyB9CiAgICAgc3Rh dGljIHZvaWQgZ2V0QWxsV29ybGRzKFZlY3RvcjxSZWZQdHI8RE9NV3JhcHBlcldvcmxkPiA+JiB3 b3JsZHMpOwpAQCAtODUsMTYgKzg3LDEwIEBAIHB1YmxpYzoKICAgICAgICAgQVNTRVJUKGlzSXNv bGF0ZWRXb3JsZCgpKTsKICAgICAgICAgcmV0dXJuIG1fZG9tRGF0YVN0b3JlLmdldCgpOwogICAg IH0KLSAgICB2b2lkIGRlcmVmKCkKLSAgICB7Ci0gICAgICAgIGlmIChkZXJlZkJhc2UoKSkKLSAg ICAgICAgICAgIGRlYWxsb2NhdGUodGhpcyk7Ci0gICAgfQogCiBwcml2YXRlOgogICAgIHN0YXRp YyBpbnQgaXNvbGF0ZWRXb3JsZENvdW50OwogICAgIHN0YXRpYyBQYXNzUmVmUHRyPERPTVdyYXBw ZXJXb3JsZD4gY3JlYXRlTWFpbldvcmxkKCk7Ci0gICAgc3RhdGljIHZvaWQgZGVhbGxvY2F0ZShE T01XcmFwcGVyV29ybGQqKTsKIAogICAgIERPTVdyYXBwZXJXb3JsZChpbnQgd29ybGRJZCwgaW50 IGV4dGVuc2lvbkdyb3VwKTsKIAo=