103057 2012-11-22 05:06:49 -0800 [V8] Make worker context prototype chain match other browsers 2012-11-22 23:33:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dcarney webkit-unassigned abarth haraken japhet webkit.review.bot oldest_to_newest 773845 0 dcarney 2012-11-22 05:06:49 -0800 [V8] Make worker context prototype chain match other browsers 773846 1 175650 dcarney 2012-11-22 05:10:09 -0800 Created attachment 175650 Patch 773856 2 dcarney 2012-11-22 05:21:13 -0800 This is required in advance of the v8 patch correctly throwing TypeErrors: https://codereview.chromium.org/11415046/ 773951 3 175674 dcarney 2012-11-22 07:49:03 -0800 Created attachment 175674 Patch 773953 4 dcarney 2012-11-22 07:50:46 -0800 I would have added a test for this, but the v8 patch would cause all worker tests to fail without this patch, so it's covered. 774228 5 175674 abarth 2012-11-22 22:55:48 -0800 Comment on attachment 175674 Patch OK. I'm not sure why we have an extra object for these worker contexts... Maybe to let global variables shadow own properties? In any case, I'm certainly willing to believe we should hide one level of prototype. 774242 6 175674 webkit.review.bot 2012-11-22 23:33:30 -0800 Comment on attachment 175674 Patch Clearing flags on attachment: 175674 Committed r135560: <http://trac.webkit.org/changeset/135560> 774243 7 webkit.review.bot 2012-11-22 23:33:33 -0800 All reviewed patches have been landed. Closing bug. 175650 2012-11-22 05:10:09 -0800 2012-11-22 07:48:57 -0800 Patch bug-103057-20121122140754.patch text/plain 1621 dcarney U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NDg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGJmZTQwMWNkNjhmNjI2 ZmZlZWZiMTUyOGQxM2I3NzM2YjRlODRiNC4uYmEyMDkwNjNiYThlOTcyMDVmM2RhOTg2ZjBhZWRk ZmJlNzAxNTdlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTIyICBEYW4g Q2FybmV5ICA8ZGNhcm5leUBnb29nbGUuY29tPgorCisgICAgICAgIFtWOF0gTWFrZSB3b3JrZXIg Y29udGV4dCBwcm90b3R5cGUgY2hhaW4gbWF0Y2ggb3RoZXIgYnJvd3NlcnMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzA1NworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGl0aW9uYWwgaW5mb3JtYXRp b24gb2YgdGhlIGNoYW5nZSBzdWNoIGFzIGFwcHJvYWNoLCByYXRpb25hbGUuIFBsZWFzZSBhZGQg cGVyLWZ1bmN0aW9uIGRlc2NyaXB0aW9ucyBiZWxvdyAoT09QUyEpLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cy4gTm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBiaW5kaW5n cy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbToKKyAgICAgICAgKEdlbmVyYXRlSW1wbGVtZW50 YXRpb24pOgorCiAyMDEyLTExLTIyICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTM1NDgyLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0gYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQppbmRleCAx OWM5MGJlMDU3NjM2MTIyNmEwNzMyNzQ4NDY4YTdkZTFmYjZjYWNkLi44ZDU2YmI2ODI3ZDhhMjVj Y2U5MThiZTg5MjE4MGZhMmFjOTUwZDMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpAQCAtMzA0Nyw3ICszMDQ3LDcgQEAgRU5E CiAgICAgaW5zdGFuY2UtPlNldEFjY2Vzc0NoZWNrQ2FsbGJhY2tzKFY4RE9NV2luZG93OjpuYW1l ZFNlY3VyaXR5Q2hlY2ssIFY4RE9NV2luZG93OjppbmRleGVkU2VjdXJpdHlDaGVjaywgdjg6OkV4 dGVybmFsOjpOZXcoJlY4RE9NV2luZG93OjppbmZvKSwgZmFsc2UpOwogRU5ECiAgICAgfQotICAg IGlmICgkaW50ZXJmYWNlTmFtZSBlcSAiSFRNTERvY3VtZW50IikgeworICAgIGlmICgkaW50ZXJm YWNlTmFtZSBlcSAiSFRNTERvY3VtZW50IiBvciAkaW50ZXJmYWNlTmFtZSBlcSAiRGVkaWNhdGVk V29ya2VyQ29udGV4dCIgb3IgJGludGVyZmFjZU5hbWUgZXEgIlNoYXJlZFdvcmtlckNvbnRleHQi KSB7CiAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCA8PEVORCk7CiAgICAgZGVzYy0+U2V0SGlk ZGVuUHJvdG90eXBlKHRydWUpOwogRU5ECg== 175674 2012-11-22 07:49:03 -0800 2012-11-22 23:33:30 -0800 Patch bug-103057-20121122164648.patch text/plain 1747 dcarney U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWUyMDUyMmQwOWZjMTBj ODczZjI3NmNiMWFjNmUzOWM4ZGMxYzg1OC4uNjcwMDUyZWMwYTY2ZGYyZGNlZWRhYjJjZGIyZTM2 NzMzM2M1YjRjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTExLTIyICBEYW4g Q2FybmV5ICA8ZGNhcm5leUBnb29nbGUuY29tPgorCisgICAgICAgIFtWOF0gTWFrZSB3b3JrZXIg Y29udGV4dCBwcm90b3R5cGUgY2hhaW4gbWF0Y2ggb3RoZXIgYnJvd3NlcnMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzA1NworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBmb2xsb3dpbmcgc2hvdWxk IGJlIGRlZmluZWQgaW4gYSB3b3JrZXI6CisgICAgICAgIE9iamVjdC5nZXRPd25Qcm9wZXJ0eURl c2NyaXB0b3IodGhpcy5fX3Byb3RvX18sICJwb3N0TWVzc2FnZSIpCisgICAgICAgIEl0IGlzIGN1 cnJlbnRseSB1bmRlZmluZWQgaW4gY2hyb21lIG9ubHkuIFRoaXMgcGF0Y2ggZml4ZXMgdGhhdC4K KworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIGNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5LgorCisg ICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06CisgICAgICAgIChH ZW5lcmF0ZUltcGxlbWVudGF0aW9uKToKKwogMjAxMi0xMS0yMiAgRXVnZW5lIEtseXVjaG5pa292 ICA8ZXVzdGFzLmJ1Z0BnbWFpbC5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxp bmU6IERpc2Nsb3N1cmUgYXJyb3dzIHJlbmRlcmVkIHVuZGVybmVhdGggZnJhbWUgYm91bmRhcmll cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9yVjgucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JW OC5wbQppbmRleCAxOWM5MGJlMDU3NjM2MTIyNmEwNzMyNzQ4NDY4YTdkZTFmYjZjYWNkLi44ZDU2 YmI2ODI3ZDhhMjVjY2U5MThiZTg5MjE4MGZhMmFjOTUwZDMyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpAQCAtMzA0Nyw3ICsz MDQ3LDcgQEAgRU5ECiAgICAgaW5zdGFuY2UtPlNldEFjY2Vzc0NoZWNrQ2FsbGJhY2tzKFY4RE9N V2luZG93OjpuYW1lZFNlY3VyaXR5Q2hlY2ssIFY4RE9NV2luZG93OjppbmRleGVkU2VjdXJpdHlD aGVjaywgdjg6OkV4dGVybmFsOjpOZXcoJlY4RE9NV2luZG93OjppbmZvKSwgZmFsc2UpOwogRU5E CiAgICAgfQotICAgIGlmICgkaW50ZXJmYWNlTmFtZSBlcSAiSFRNTERvY3VtZW50IikgeworICAg IGlmICgkaW50ZXJmYWNlTmFtZSBlcSAiSFRNTERvY3VtZW50IiBvciAkaW50ZXJmYWNlTmFtZSBl cSAiRGVkaWNhdGVkV29ya2VyQ29udGV4dCIgb3IgJGludGVyZmFjZU5hbWUgZXEgIlNoYXJlZFdv cmtlckNvbnRleHQiKSB7CiAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCA8PEVORCk7CiAgICAg ZGVzYy0+U2V0SGlkZGVuUHJvdG90eXBlKHRydWUpOwogRU5ECg==