103054 2012-11-22 04:37:11 -0800 [Qt] Correct extensions on preferredFilename 2012-11-22 05:51:14 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 102667 1 allan.jensen allan.jensen hausmann oldest_to_newest 773831 0 allan.jensen 2012-11-22 04:37:11 -0800 When downloading files we currently save using the original extension, but these extensions can often be wrong, either lacking or ending in .php. We can fix this by checking if the extension is valid and added add a valid one or correct the existing in the preferredFilename. 773835 1 175647 allan.jensen 2012-11-22 04:47:15 -0800 Created attachment 175647 Patch 773841 2 hausmann 2012-11-22 04:58:55 -0800 Is there a http test for this, btw? Strong feeling there might :) 773878 3 allan.jensen 2012-11-22 05:51:14 -0800 Committed r135511: <http://trac.webkit.org/changeset/135511> 175647 2012-11-22 04:47:15 -0800 2012-11-22 04:58:33 -0800 Patch bug-103054-20121122134434.patch text/plain 4327 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NDk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWE3YTdlMmUwMmYxNjM3 YzYyNzZlZjdjYzVmYThjYWZiMjMzNGQ2OC4uYWI5OGZjZjVhNjIyMGM2YjIwMmQzM2NkMWM1Yzc1 MTljMmExYjNiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEyLTExLTIyICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCisgICAgICAgIFtR dF0gQ29ycmVjdCBleHRlbnNpb25zIG9uIHByZWZlcnJlZEZpbGVuYW1lCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDMwNTQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGd1ZXNzaW5nIGEgZmlsZW5h bWUgd2Ugd2lsbCBub3cgZW5zdXJlIGl0IGhhcyBhbiBleHRlbnNpb24gdGhhdCBpcyB2YWxpZCBm b3IgaXRzIG1pbWV0eXBlLgorICAgICAgICBUbyBkbyB0aGlzIHRoZSB0d28gbWlzc2luZyBtZXRo b2RzIGdldEV4dGVuc2lvbnNGb3JNSU1FVHlwZSBhbmQgZ2V0UHJlZmVycmVkRXh0ZW5zaW9uRm9y TUlNRVR5cGUKKyAgICAgICAgaGF2ZSBiZWVuIGFkZGVkIHRvIHRoZSBRdCBpbXBsZW1lbnRhdGlv biBvZiBNSU1FVHlwZVJlZ2lzdHJ5LgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9xdC9R TmV0d29ya1JlcGx5SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpRTmV0d29ya1JlcGx5 SGFuZGxlcjo6c2VuZFJlc3BvbnNlSWZOZWVkZWQpOgorICAgICAgICAqIHBsYXRmb3JtL3F0L01J TUVUeXBlUmVnaXN0cnlRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNSU1FVHlwZVJlZ2lzdHJ5 OjpnZXRFeHRlbnNpb25zRm9yTUlNRVR5cGUpOgorICAgICAgICAoV2ViQ29yZTo6TUlNRVR5cGVS ZWdpc3RyeTo6Z2V0UHJlZmVycmVkRXh0ZW5zaW9uRm9yTUlNRVR5cGUpOgorCisyMDEyLTExLTIy ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCiAgICAg ICAgIFtRdF0gTG9va3VwIG1pbWV0eXBlcyB1c2luZyBRTWltZURhdGFiYXNlCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI2NjcKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxl ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlI YW5kbGVyLmNwcAppbmRleCBiODNmMmJhMDhjMjE1NDk2YWQyZTgyMjQ4ZDJmYTg0ZTFhYzhjODk4 Li45MDRlODU5ODMxZDM4YjEwYTM2MDAzODAwZjA0Mzk4NjE2NDA2N2FmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlI YW5kbGVyLmNwcApAQCAtMzIsNiArMzIsNyBAQAogI2luY2x1ZGUgPFFEYXRlVGltZT4KICNpbmNs dWRlIDxRRmlsZT4KICNpbmNsdWRlIDxRRmlsZUluZm8+CisjaW5jbHVkZSA8UU1pbWVEYXRhYmFz ZT4KICNpbmNsdWRlIDxRTmV0d29ya0Nvb2tpZT4KICNpbmNsdWRlIDxRTmV0d29ya1JlcGx5Pgog CkBAIC01ODEsOCArNTgyLDIxIEBAIHZvaWQgUU5ldHdvcmtSZXBseUhhbmRsZXI6OnNlbmRSZXNw b25zZUlmTmVlZGVkKCkKIAogICAgICAgICBpZiAoIXN1Z2dlc3RlZEZpbGVuYW1lLmlzRW1wdHko KSkKICAgICAgICAgICAgIHJlc3BvbnNlLnNldFN1Z2dlc3RlZEZpbGVuYW1lKHN1Z2dlc3RlZEZp bGVuYW1lKTsKLSAgICAgICAgZWxzZQotICAgICAgICAgICAgcmVzcG9uc2Uuc2V0U3VnZ2VzdGVk RmlsZW5hbWUodXJsLmxhc3RQYXRoQ29tcG9uZW50KCkpOworICAgICAgICBlbHNlIHsKKyAgICAg ICAgICAgIFZlY3RvcjxTdHJpbmc+IGV4dGVuc2lvbnMgPSBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRF eHRlbnNpb25zRm9yTUlNRVR5cGUobWltZVR5cGUpOworICAgICAgICAgICAgaWYgKGV4dGVuc2lv bnMuaXNFbXB0eSgpKQorICAgICAgICAgICAgICAgIHJlc3BvbnNlLnNldFN1Z2dlc3RlZEZpbGVu YW1lKHVybC5sYXN0UGF0aENvbXBvbmVudCgpKTsKKyAgICAgICAgICAgIGVsc2UgeworICAgICAg ICAgICAgICAgIC8vIElmIHRoZSBzdWZmaXggZG9lc24ndCBtYXRjaCB0aGUgTUlNRSB0eXBlLCBj b3JyZWN0IHRoZSBzdWZmaXguCisgICAgICAgICAgICAgICAgUVN0cmluZyBmaWxlbmFtZSA9IHVy bC5sYXN0UGF0aENvbXBvbmVudCgpOworICAgICAgICAgICAgICAgIGNvbnN0IFN0cmluZyBzdWZm aXggPSBRTWltZURhdGFiYXNlKCkuc3VmZml4Rm9yRmlsZU5hbWUoZmlsZW5hbWUpOworICAgICAg ICAgICAgICAgIGlmICghZXh0ZW5zaW9ucy5jb250YWlucyhzdWZmaXgpKSB7CisgICAgICAgICAg ICAgICAgICAgIGZpbGVuYW1lLmNob3Aoc3VmZml4Lmxlbmd0aCgpKTsKKyAgICAgICAgICAgICAg ICAgICAgZmlsZW5hbWUgKz0gTUlNRVR5cGVSZWdpc3RyeTo6Z2V0UHJlZmVycmVkRXh0ZW5zaW9u Rm9yTUlNRVR5cGUobWltZVR5cGUpOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAg ICByZXNwb25zZS5zZXRTdWdnZXN0ZWRGaWxlbmFtZShmaWxlbmFtZSk7CisgICAgICAgICAgICB9 CisgICAgICAgIH0KIAogICAgICAgICByZXNwb25zZS5zZXRIVFRQU3RhdHVzQ29kZShzdGF0dXND b2RlKTsKICAgICAgICAgcmVzcG9uc2Uuc2V0SFRUUFN0YXR1c1RleHQobV9yZXBseVdyYXBwZXIt PnJlcGx5KCktPmF0dHJpYnV0ZShRTmV0d29ya1JlcXVlc3Q6Okh0dHBSZWFzb25QaHJhc2VBdHRy aWJ1dGUpLnRvQnl0ZUFycmF5KCkuY29uc3REYXRhKCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vcXQvTUlNRVR5cGVSZWdpc3RyeVF0LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3F0L01JTUVUeXBlUmVnaXN0cnlRdC5jcHAKaW5kZXggOTNmOGU4NmJlYTAwY2Nl NjJlMGY0MDU3OTllNDg1YTQ5YzUyZWE0Yi4uNTZkNDE3ZTJiYmNhYjk1YjU0NjYwYjI0OGU2Y2Qz YjI0Y2Y4ZGE4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvTUlNRVR5 cGVSZWdpc3RyeVF0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9NSU1FVHlw ZVJlZ2lzdHJ5UXQuY3BwCkBAIC01Niw2ICs1NiwyOCBAQCBTdHJpbmcgTUlNRVR5cGVSZWdpc3Ry eTo6Z2V0TUlNRVR5cGVGb3JQYXRoKGNvbnN0IFN0cmluZyYgcGF0aCkKICAgICByZXR1cm4gImFw cGxpY2F0aW9uL29jdGV0LXN0cmVhbSI7CiB9CiAKK1ZlY3RvcjxTdHJpbmc+IE1JTUVUeXBlUmVn aXN0cnk6OmdldEV4dGVuc2lvbnNGb3JNSU1FVHlwZShjb25zdCBTdHJpbmcmIG1pbWVUeXBlTmFt ZSkKK3sKKyAgICBWZWN0b3I8U3RyaW5nPiBleHRlbnNpb25zOworICAgIFFNaW1lVHlwZSBtaW1l VHlwZSA9IFFNaW1lRGF0YWJhc2UoKS5taW1lVHlwZUZvck5hbWUobWltZVR5cGVOYW1lKTsKKyAg ICBpZiAobWltZVR5cGUuaXNWYWxpZCgpICYmICFtaW1lVHlwZS5pc0RlZmF1bHQoKSkgeworICAg ICAgICBRX0ZPUkVBQ0goY29uc3QgUVN0cmluZyYgc3VmZml4LCBtaW1lVHlwZS5zdWZmaXhlcygp KSB7CisgICAgICAgICAgICBleHRlbnNpb25zLmFwcGVuZChzdWZmaXgpOworICAgICAgICB9Cisg ICAgfQorCisgICAgcmV0dXJuIGV4dGVuc2lvbnM7Cit9CisKK1N0cmluZyBNSU1FVHlwZVJlZ2lz dHJ5OjpnZXRQcmVmZXJyZWRFeHRlbnNpb25Gb3JNSU1FVHlwZShjb25zdCBTdHJpbmcmIG1pbWVU eXBlTmFtZSkKK3sKKyAgICBRTWltZVR5cGUgbWltZVR5cGUgPSBRTWltZURhdGFiYXNlKCkubWlt ZVR5cGVGb3JOYW1lKG1pbWVUeXBlTmFtZSk7CisgICAgaWYgKG1pbWVUeXBlLmlzVmFsaWQoKSAm JiAhbWltZVR5cGUuaXNEZWZhdWx0KCkpCisgICAgICAgIHJldHVybiBtaW1lVHlwZS5wcmVmZXJy ZWRTdWZmaXgoKTsKKworICAgIHJldHVybiBTdHJpbmcoKTsKK30KKwogU3RyaW5nIE1JTUVUeXBl UmVnaXN0cnk6OmdldE5vcm1hbGl6ZWRNSU1FVHlwZShjb25zdCBTdHJpbmcmIG1pbWVUeXBlTmFt ZSkKIHsKICAgICAvLyBUaGlzIGxvb2tzIHVwIHRoZSBtaW1lIHR5cGUgb2JqZWN0IGJ5IHByZWZl cnJlZCBuYW1lIG9yIGFsaWFzLCBhbmQgcmV0dXJucyB0aGUgcHJlZmVycmVkIG5hbWUuCg==