103025 2012-11-21 23:21:38 -0800 Web Inspector: NMI add instrumentation to DynamicNodeList classes hierarchy. 2012-11-22 23:38:10 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 103099 1 loislo loislo apavlov keishi koivisto loislo ojan pfeldman pmuellr rniwa vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 773610 0 loislo 2012-11-21 23:21:38 -0800 RNiwa changed pointer type in NodeRareData::NodeListAtomicNameCacheMap from the topmost DynamicSubtreeNodeList to the base DynamicNodeListCacheBase at r135429. As a result we got non zero count of pointers that don't match with tcmalloc data, because DynamicNodeList uses multiple inheritance. It could be fixed with help of explicit native memory instrumentation for DynamicNodeList class hierarchy. Patch to follow. 773616 1 175599 loislo 2012-11-21 23:31:21 -0800 Created attachment 175599 Patch 773721 2 loislo 2012-11-22 01:25:20 -0800 Committed r135493: <http://trac.webkit.org/changeset/135493> 774139 3 rniwa 2012-11-22 16:44:59 -0800 This patch regressed the memory usage of NodeList by introducing another vtable pointer in each NodeList and HTMLCollection. 774141 4 rniwa 2012-11-22 16:49:02 -0800 See https://bugs.webkit.org/show_bug.cgi?id=103096. 774198 5 webkit.review.bot 2012-11-22 21:36:49 -0800 Re-opened since this is blocked by bug 103099 774245 6 ap 2012-11-22 23:38:10 -0800 Looks like the plan is to fix without reverting, marking FIXED again. 175599 2012-11-21 23:31:21 -0800 2012-11-22 00:34:32 -0800 Patch bug-103025-20121122112906.patch text/plain 5115 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWI4YzczMmJjYTdkYjlm OTZkNzcxYzA2NjFiMTk2MzQwMDdhN2ZkZS4uODI5OWM3ZGU0YTFkOTA5MTMxOTEzNTVkOTU4MGRl ZjFjNzdmYmM1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDEyLTExLTIxICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBOTUkgYWRkIGluc3RydW1lbnRhdGlvbiB0byBEeW5hbWljTm9kZUxpc3QgY2xhc3NlcyBo aWVyYXJjaHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDMwMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSTml3YSBjaGFuZ2VkIHBvaW50ZXIgdHlwZSBpbiBOb2RlUmFyZURhdGE6Ok5vZGVMaXN0QXRv bWljTmFtZUNhY2hlTWFwIGZyb20gdGhlIHRvcG1vc3QKKyAgICAgICAgRHluYW1pY1N1YnRyZWVO b2RlTGlzdCB0byB0aGUgYmFzZSBEeW5hbWljTm9kZUxpc3RDYWNoZUJhc2UgYXQgcjEzNTQyOS4K KyAgICAgICAgQXMgYSByZXN1bHQgd2UgZ290IG5vbiB6ZXJvIGNvdW50IG9mIHBvaW50ZXJzIHRo YXQgZG9uJ3QgbWF0Y2ggd2l0aCB0Y21hbGxvYyBkYXRhLAorICAgICAgICBiZWNhdXNlIER5bmFt aWNOb2RlTGlzdCB1c2VzIG11bHRpcGxlIGluaGVyaXRhbmNlLgorICAgICAgICBJdCBjb3VsZCBi ZSBmaXhlZCB3aXRoIGhlbHAgb2YgZXhwbGljaXQgbmF0aXZlIG1lbW9yeSBpbnN0cnVtZW50YXRp b24gZm9yIER5bmFtaWNOb2RlTGlzdCBjbGFzcyBoaWVyYXJjaHkuCisKKyAgICAgICAgTm8gY2hh bmdlIGluIGJlaGF2aW9yLCBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBkb20vRG9jdW1l bnQuY3BwOiBkcml2ZSBieSBmaXguCisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6cmVwb3J0 TWVtb3J5VXNhZ2UpOgorICAgICAgICAqIGRvbS9EeW5hbWljTm9kZUxpc3QuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RHluYW1pY05vZGVMaXN0Q2FjaGVCYXNlOjpyZXBvcnRNZW1vcnlVc2FnZSk6 CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OkR5bmFtaWNOb2RlTGlzdDo6 cmVwb3J0TWVtb3J5VXNhZ2UpOgorICAgICAgICAoV2ViQ29yZTo6RHluYW1pY1N1YnRyZWVOb2Rl TGlzdDo6cmVwb3J0TWVtb3J5VXNhZ2UpOgorICAgICAgICAqIGRvbS9EeW5hbWljTm9kZUxpc3Qu aDoKKyAgICAgICAgKFdlYkNvcmU6OkR5bmFtaWNOb2RlTGlzdENhY2hlQmFzZTo6fkR5bmFtaWNO b2RlTGlzdENhY2hlQmFzZSk6CisgICAgICAgIChEeW5hbWljTm9kZUxpc3RDYWNoZUJhc2UpOgor ICAgICAgICAoRHluYW1pY05vZGVMaXN0KToKKyAgICAgICAgKER5bmFtaWNTdWJ0cmVlTm9kZUxp c3QpOgorCiAyMDEyLTExLTIxICBNaWNoYWVsIFBydWV0dCAgPG1pY2hhZWxANjhrLm9yZz4KIAog ICAgICAgICBJbmRleGVkREI6IE9idGFpbiBTY3JpcHRTdGF0ZSBmcm9tIElETCBiaW5kaW5nIGdl bmVyYXRvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggOTk3YjJjNDk5YTcyODMyZjljZGJm ZmY4YTdjYTAwNjhlOTMxMzJmNS4uNTQyYmY5ODA2ODlmZTYwYmEzMmE2NWFlZWE1NTc1MDZhNjFh OGJmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC01OTA5LDYgKzU5MDksNyBAQCB2b2lk IERvY3VtZW50OjpyZXBvcnRNZW1vcnlVc2FnZShNZW1vcnlPYmplY3RJbmZvKiBtZW1vcnlPYmpl Y3RJbmZvKSBjb25zdAogI2lmIEVOQUJMRShMSU5LX1BSRVJFTkRFUikKICAgICBpbmZvLmFkZE1l bWJlcihtX3ByZXJlbmRlcmVyKTsKICNlbmRpZgorICAgIGluZm8uYWRkTWVtYmVyKG1fbGlzdHNJ bnZhbGlkYXRlZEF0RG9jdW1lbnQpOwogfQogCiBjbGFzcyBJbW11dGFibGVBdHRyaWJ1dGVEYXRh Q2FjaGVLZXkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0R5bmFtaWNOb2RlTGlz dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRHluYW1pY05vZGVMaXN0LmNwcAppbmRleCA0ZTgz MTE3N2Q0Njg0YzdlNWIxNmI3OTBjYjJkM2M4NjNkMzRhZTc5Li41ZDI4ZmRiYzA2OGIyNmNkNWRl M2E0NzZmZjkzMjVkNzdhZWUzNzliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRHlu YW1pY05vZGVMaXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRHluYW1pY05vZGVMaXN0 LmNwcApAQCAtMjgsNiArMjgsNyBAQAogI2luY2x1ZGUgIkhUTUxDb2xsZWN0aW9uLmgiCiAjaW5j bHVkZSAiSFRNTFByb3BlcnRpZXNDb2xsZWN0aW9uLmgiCiAjaW5jbHVkZSAiUHJvcGVydHlOb2Rl TGlzdC5oIgorI2luY2x1ZGUgIldlYkNvcmVNZW1vcnlJbnN0cnVtZW50YXRpb24uaCIKIAogbmFt ZXNwYWNlIFdlYkNvcmUgewogCkBAIC03OSw2ICs4MCwyNiBAQCB2b2lkIER5bmFtaWNOb2RlTGlz dENhY2hlQmFzZTo6aW52YWxpZGF0ZUlkTmFtZUNhY2hlTWFwcygpIGNvbnN0CiAgICAgY2FjaGVC YXNlLT5tX25hbWVDYWNoZS5jbGVhcigpOwogfQogCit2b2lkIER5bmFtaWNOb2RlTGlzdENhY2hl QmFzZTo6cmVwb3J0TWVtb3J5VXNhZ2UoTWVtb3J5T2JqZWN0SW5mbyogbWVtb3J5T2JqZWN0SW5m bykgY29uc3QKK3sKKyAgICBNZW1vcnlDbGFzc0luZm8gaW5mbyhtZW1vcnlPYmplY3RJbmZvLCB0 aGlzLCBXZWJDb3JlTWVtb3J5VHlwZXM6OkRPTSk7CisgICAgaW5mby5hZGRNZW1iZXIobV9vd25l ck5vZGUpOworICAgIGluZm8uYWRkV2Vha1BvaW50ZXIobV9jYWNoZWRJdGVtKTsKK30KKwordm9p ZCBEeW5hbWljTm9kZUxpc3Q6OnJlcG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVjdEluZm8qIG1l bW9yeU9iamVjdEluZm8pIGNvbnN0Cit7CisgICAgTWVtb3J5Q2xhc3NJbmZvIGluZm8obWVtb3J5 T2JqZWN0SW5mbywgdGhpcywgV2ViQ29yZU1lbW9yeVR5cGVzOjpET00pOworICAgIE5vZGVMaXN0 OjpyZXBvcnRNZW1vcnlVc2FnZShtZW1vcnlPYmplY3RJbmZvKTsKKyAgICBEeW5hbWljTm9kZUxp c3RDYWNoZUJhc2U6OnJlcG9ydE1lbW9yeVVzYWdlKG1lbW9yeU9iamVjdEluZm8pOworfQorCit2 b2lkIER5bmFtaWNTdWJ0cmVlTm9kZUxpc3Q6OnJlcG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVj dEluZm8qIG1lbW9yeU9iamVjdEluZm8pIGNvbnN0Cit7CisgICAgTWVtb3J5Q2xhc3NJbmZvIGlu Zm8obWVtb3J5T2JqZWN0SW5mbywgdGhpcywgV2ViQ29yZU1lbW9yeVR5cGVzOjpET00pOworICAg IER5bmFtaWNOb2RlTGlzdDo6cmVwb3J0TWVtb3J5VXNhZ2UobWVtb3J5T2JqZWN0SW5mbyk7Cit9 CisKIHVuc2lnbmVkIER5bmFtaWNOb2RlTGlzdDo6bGVuZ3RoKCkgY29uc3QKIHsKICAgICByZXR1 cm4gbGVuZ3RoQ29tbW9uKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRHluYW1p Y05vZGVMaXN0LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRHluYW1pY05vZGVMaXN0LmgKaW5kZXgg ODhhOWJiNmY0YjE0YTlmYmQ3OWIwODhlZmJiZGZjODc0ODA0MTk2OS4uYWE2Y2FhMzY0Zjc3NmI5 ODNmZDFmZjRiMDkxMjgyNjBmZjAxYWU4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9t L0R5bmFtaWNOb2RlTGlzdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9EeW5hbWljTm9kZUxp c3QuaApAQCAtNjcsNiArNjcsMTAgQEAgcHVibGljOgogICAgICAgICBBU1NFUlQoIW1fb3ZlcnJp ZGVzSXRlbUFmdGVyIHx8IG1fY29sbGVjdGlvblR5cGUgIT0gTm9kZUxpc3RDb2xsZWN0aW9uVHlw ZSk7CiAgICAgfQogCisgICAgdmlydHVhbCB+RHluYW1pY05vZGVMaXN0Q2FjaGVCYXNlKCkgeyB9 CisKKyAgICB2aXJ0dWFsIHZvaWQgcmVwb3J0TWVtb3J5VXNhZ2UoTWVtb3J5T2JqZWN0SW5mbyop IGNvbnN0OworCiBwdWJsaWM6CiAgICAgQUxXQVlTX0lOTElORSBib29sIGlzUm9vdGVkQXREb2N1 bWVudCgpIGNvbnN0IHsgcmV0dXJuIG1fcm9vdFR5cGUgPT0gTm9kZUxpc3RJc1Jvb3RlZEF0RG9j dW1lbnQgfHwgbV9yb290VHlwZSA9PSBOb2RlTGlzdElzUm9vdGVkQXREb2N1bWVudElmT3duZXJI YXNJdGVtcmVmQXR0cjsgfQogICAgIEFMV0FZU19JTkxJTkUgTm9kZUxpc3RJbnZhbGlkYXRpb25U eXBlIGludmFsaWRhdGlvblR5cGUoKSBjb25zdCB7IHJldHVybiBzdGF0aWNfY2FzdDxOb2RlTGlz dEludmFsaWRhdGlvblR5cGU+KG1faW52YWxpZGF0aW9uVHlwZSk7IH0KQEAgLTIxNCw2ICsyMTgs OCBAQCBwdWJsaWM6CiAgICAgLy8gT3RoZXIgbWV0aG9kcyAobm90IHBhcnQgb2YgRE9NKQogICAg IHZpcnR1YWwgYm9vbCBub2RlTWF0Y2hlcyhFbGVtZW50KikgY29uc3QgPSAwOwogCisgICAgdmly dHVhbCB2b2lkIHJlcG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVjdEluZm8qKSBjb25zdCBPVkVS UklERTsKKwogcHJpdmF0ZToKICAgICB2aXJ0dWFsIGJvb2wgaXNEeW5hbWljTm9kZUxpc3QoKSBj b25zdCBPVkVSUklERSB7IHJldHVybiB0cnVlOyB9CiB9OwpAQCAtMjI1LDYgKzIzMSw4IEBAIHB1 YmxpYzoKICAgICAgICAgZG9jdW1lbnQoKS0+dW5yZWdpc3Rlck5vZGVMaXN0Q2FjaGUodGhpcyk7 CiAgICAgfQogCisgICAgdmlydHVhbCB2b2lkIHJlcG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVj dEluZm8qKSBjb25zdCBPVkVSUklERTsKKwogcHJvdGVjdGVkOgogICAgIER5bmFtaWNTdWJ0cmVl Tm9kZUxpc3QoUGFzc1JlZlB0cjxOb2RlPiBub2RlLCBOb2RlTGlzdFR5cGUgdHlwZSwgTm9kZUxp c3RJbnZhbGlkYXRpb25UeXBlIGludmFsaWRhdGlvblR5cGUsIE5vZGVMaXN0Um9vdFR5cGUgcm9v dFR5cGUgPSBOb2RlTGlzdElzUm9vdGVkQXROb2RlKQogICAgICAgICA6IER5bmFtaWNOb2RlTGlz dChub2RlLCB0eXBlLCByb290VHlwZSwgaW52YWxpZGF0aW9uVHlwZSkK