103005 2012-11-21 18:37:44 -0800 dumpOperands() claims that it needs a non-const Operands& when that is completely false 2012-11-21 19:06:23 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 773473 0 fpizlo 2012-11-21 18:37:44 -0800 There is some nasty const-casting being done, when it's completely unnecessary. The non-const variant of dumpOperands() should just be removed. 773478 1 175564 fpizlo 2012-11-21 18:41:56 -0800 Created attachment 175564 the patch 773488 2 fpizlo 2012-11-21 19:06:23 -0800 Landed in http://trac.webkit.org/changeset/135462 175564 2012-11-21 18:41:56 -0800 2012-11-21 18:59:21 -0800 the patch fixdump.patch text/plain 1723 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM1NDYxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEyLTExLTIxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg ZHVtcE9wZXJhbmRzKCkgY2xhaW1zIHRoYXQgaXQgbmVlZHMgYSBub24tY29uc3QgT3BlcmFuZHMm IHdoZW4gdGhhdCBpcyBjb21wbGV0ZWx5IGZhbHNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDMwMDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGJ5dGVjb2RlL09wZXJhbmRzLmg6CisgICAgICAgIChK U0M6OmR1bXBPcGVyYW5kcyk6CisgICAgICAgIChKU0MpOgorCiAyMDEyLTExLTIwICBGaWxpcCBQ aXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgQmFzZWxpbmUgSklUJ3MgZGlzYXNz ZW1ibHkgc2hvdWxkIGJlIGp1c3QgYXMgcHJldHR5IGFzIHRoZSBERkcncwpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL09wZXJhbmRzLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL09wZXJhbmRzLmgJKHJldmlzaW9uIDEzNTI2NikKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGVyYW5kcy5oCSh3b3JraW5nIGNvcHkp CkBAIC0xOTAsNyArMTkwLDcgQEAgcHJpdmF0ZToKIH07CiAKIHRlbXBsYXRlPHR5cGVuYW1lIFQs IHR5cGVuYW1lIFRyYWl0cz4KLXZvaWQgZHVtcE9wZXJhbmRzKE9wZXJhbmRzPFQsIFRyYWl0cz4m IG9wZXJhbmRzLCBGSUxFKiBvdXQpCit2b2lkIGR1bXBPcGVyYW5kcyhjb25zdCBPcGVyYW5kczxU LCBUcmFpdHM+JiBvcGVyYW5kcywgRklMRSogb3V0KQogewogICAgIGZvciAoc2l6ZV90IGFyZ3Vt ZW50ID0gMDsgYXJndW1lbnQgPCBvcGVyYW5kcy5udW1iZXJPZkFyZ3VtZW50cygpOyArK2FyZ3Vt ZW50KSB7CiAgICAgICAgIGlmIChhcmd1bWVudCkKQEAgLTIwNSwxNiArMjA1LDYgQEAgdm9pZCBk dW1wT3BlcmFuZHMoT3BlcmFuZHM8VCwgVHJhaXRzPiYgbwogICAgIH0KIH0KIAotdGVtcGxhdGU8 dHlwZW5hbWUgVCwgdHlwZW5hbWUgVHJhaXRzPgotdm9pZCBkdW1wT3BlcmFuZHMoY29uc3QgT3Bl cmFuZHM8VCwgVHJhaXRzPiYgb3BlcmFuZHMsIEZJTEUqIG91dCkKLXsKLSAgICAvLyBVc2UgY29u c3QtY2FzdCBiZWNhdXNlOgotICAgIC8vIDEpIEkgZG9uJ3QgZmVlbCBsaWtlIHdyaXRpbmcgdGhp cyBjb2RlIHR3aWNlLCBhbmQKLSAgICAvLyAyKSBTb21lIGR1bXAoKSBtZXRob2RzIG1heSBub3Qg YmUgY29uc3QsIGFuZCBJIGRvbid0IHJlYWxseSBjYXJlIGlmIHRoYXQncwotICAgIC8vICAgIHRo ZSBjYXNlLgotICAgIGR1bXBPcGVyYW5kcygqY29uc3RfY2FzdDxPcGVyYW5kczxULCBUcmFpdHM+ Kj4oJm9wZXJhbmRzKSwgb3V0KTsKLX0KLQogfSAvLyBuYW1lc3BhY2UgSlNDCiAKICNlbmRpZiAv LyBPcGVyYW5kc19oCg==