102998 2012-11-21 18:02:40 -0800 [V8] Move AddMessageListener() from WorkerContextExecutionProxy::initializeIfNeeded() to WorkerContextExecutionProxy::initIsolate() 2012-11-22 01:48:39 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth dglazkov japhet webkit.review.bot oldest_to_newest 773455 0 haraken 2012-11-21 18:02:40 -0800 This is an incremental step for moving initializeIfNeeded() to V8Initializer.h. Given that AddMessageListener() needs to be called once per Isolate, we can move AddMessageListener() from initializeIfNeeded() to initIsolate(). 773456 1 175558 haraken 2012-11-21 18:03:57 -0800 Created attachment 175558 Patch 773457 2 175558 haraken 2012-11-21 18:05:05 -0800 Comment on attachment 175558 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175558&action=review > Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:-135 > - static bool isV8Initialized = false; > - if (!isV8Initialized) Actually, isV8Initialized does nothing. 773481 3 175558 webkit.review.bot 2012-11-21 18:46:17 -0800 Comment on attachment 175558 Patch Attachment 175558 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14966172 New failing tests: platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html 773620 4 haraken 2012-11-21 23:34:56 -0800 (In reply to comment #3) > New failing tests: > platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html Looks like this failure is just a noise. abarth: r? 773635 5 abarth 2012-11-21 23:43:03 -0800 > Looks like this failure is just a noise. Perhaps we should mark it as flaky. 773737 6 175558 webkit.review.bot 2012-11-22 01:48:36 -0800 Comment on attachment 175558 Patch Clearing flags on attachment: 175558 Committed r135497: <http://trac.webkit.org/changeset/135497> 773738 7 webkit.review.bot 2012-11-22 01:48:39 -0800 All reviewed patches have been landed. Closing bug. 175558 2012-11-21 18:03:57 -0800 2012-11-22 01:48:36 -0800 Patch bug-102998-20121122110142.patch text/plain 2473 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGMzNjY0NjI1NTUwZmI5 MjQ4NjEyNDQ3MGExNzFkNGY5MmFmYjk2OC4uZjYwZjhhNGExMGJiOGJlZGU5NTIzM2Y1YWIzZGFi ZTY5M2IzNzU4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTExLTIxICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1vdmUgQWRk TWVzc2FnZUxpc3RlbmVyKCkgZnJvbSBXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHk6OmluaXRp YWxpemVJZk5lZWRlZCgpIHRvIFdvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eTo6aW5pdElzb2xh dGUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAy OTk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhp cyBpcyBhbiBpbmNyZW1lbnRhbCBzdGVwIGZvciBtb3ZpbmcgaW5pdGlhbGl6ZUlmTmVlZGVkKCkK KyAgICAgICAgdG8gVjhJbml0aWFsaXplci5oLiBHaXZlbiB0aGF0IEFkZE1lc3NhZ2VMaXN0ZW5l cigpIG5lZWRzIHRvCisgICAgICAgIGJlIGNhbGxlZCBvbmNlIHBlciBJc29sYXRlLCB3ZSBjYW4g bW92ZSBBZGRNZXNzYWdlTGlzdGVuZXIoKQorICAgICAgICBmcm9tIGluaXRpYWxpemVJZk5lZWRl ZCgpIHRvIGluaXRJc29sYXRlKCkuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBi ZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1dvcmtlckNvbnRleHRFeGVjdXRpb25Q cm94eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHk6 OmluaXRJc29sYXRlKToKKyAgICAgICAgKFdlYkNvcmU6OldvcmtlckNvbnRleHRFeGVjdXRpb25Q cm94eTo6aW5pdGlhbGl6ZUlmTmVlZGVkKToKKwogMjAxMi0xMS0yMSAgSGFqaW1lIE1vcnJpdGEg IDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgW1NoYWRvdyBET01dW1Y4XSBBc3NlcnRp b24gZmFpbHVyZSB3aGVuIHNoYWRvdyBob3N0IGlzIHJlY2xhaW1lZCBiZWZvcmUgU2hhZG93Um9v dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvV29ya2VyQ29udGV4dEV4 ZWN1dGlvblByb3h5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1dvcmtlckNvbnRl eHRFeGVjdXRpb25Qcm94eS5jcHAKaW5kZXggOTdjZWY4OTU3YTMwYTAwMTIzZDYwZmRkZTQ4ODdk NmUwOTg4Mjg3OC4uM2YxYTQ1MTExMjk1OTVjYjc5N2M0M2NjMmQyZWI3YjcxNGI0NjFjYiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvV29ya2VyQ29udGV4dEV4ZWN1dGlv blByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9Xb3JrZXJDb250ZXh0 RXhlY3V0aW9uUHJveHkuY3BwCkBAIC0xMDQsNiArMTA0LDkgQEAgdm9pZCBXb3JrZXJDb250ZXh0 RXhlY3V0aW9uUHJveHk6OmRpc3Bvc2UoKQogCiB2b2lkIFdvcmtlckNvbnRleHRFeGVjdXRpb25Q cm94eTo6aW5pdElzb2xhdGUoKQogeworICAgIC8vIFNldHVwIHRoZSBzZWN1cml0eSBoYW5kbGVy cyBhbmQgbWVzc2FnZSBsaXN0ZW5lci4KKyAgICB2ODo6Vjg6OkFkZE1lc3NhZ2VMaXN0ZW5lcigm djhNZXNzYWdlSGFuZGxlcik7CisKICAgICAvLyBUZWxsIFY4IG5vdCB0byBjYWxsIHRoZSBkZWZh dWx0IE9PTSBoYW5kbGVyLCBiaW5kaW5nIGNvZGUgd2lsbCBoYW5kbGUgaXQuCiAgICAgdjg6OlY4 OjpJZ25vcmVPdXRPZk1lbW9yeUV4Y2VwdGlvbigpOwogICAgIHY4OjpWODo6U2V0RmF0YWxFcnJv ckhhbmRsZXIocmVwb3J0RmF0YWxFcnJvckluVjgpOwpAQCAtMTI5LDEyICsxMzIsNiBAQCBib29s IFdvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eTo6aW5pdGlhbGl6ZUlmTmVlZGVkKCkKICAgICBp ZiAoIW1fY29udGV4dC5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybiB0cnVlOwogCi0gICAgLy8g U2V0dXAgdGhlIHNlY3VyaXR5IGhhbmRsZXJzIGFuZCBtZXNzYWdlIGxpc3RlbmVyLiBUaGlzIG9u bHkgaGFzCi0gICAgLy8gdG8gYmUgZG9uZSBvbmNlLgotICAgIHN0YXRpYyBib29sIGlzVjhJbml0 aWFsaXplZCA9IGZhbHNlOwotICAgIGlmICghaXNWOEluaXRpYWxpemVkKQotICAgICAgICB2ODo6 Vjg6OkFkZE1lc3NhZ2VMaXN0ZW5lcigmdjhNZXNzYWdlSGFuZGxlcik7Ci0KICAgICAvLyBDcmVh dGUgYSBuZXcgZW52aXJvbm1lbnQKICAgICB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0VGVtcGxh dGU+IGdsb2JhbFRlbXBsYXRlOwogICAgIG1fY29udGV4dC5hZG9wdCh2ODo6Q29udGV4dDo6TmV3 KDAsIGdsb2JhbFRlbXBsYXRlKSk7Cg==