102988 2012-11-21 16:18:13 -0800 [EFL] Remove unnecessary definition, -DENABLE_SPELLCHECK=1 2012-11-21 22:19:55 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 773388 0 ryuan.choi 2012-11-21 16:18:13 -0800 cmakeconfig.h already defines it when enabled. 773393 1 175544 ryuan.choi 2012-11-21 16:20:12 -0800 Created attachment 175544 Patch 773398 2 175545 ryuan.choi 2012-11-21 16:22:55 -0800 Created attachment 175545 Patch 773470 3 175545 laszlo.gombos 2012-11-21 18:28:07 -0800 Comment on attachment 175545 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175545&action=review > ChangeLog:8 > + Removed -DENABLE_SPELLCHECK=1 because it is already defined by cmakeconfig.h cmakeconfig.h seems to be generated. Did you mean OptionsEfl.cmake ? 773497 4 175568 ryuan.choi 2012-11-21 19:17:45 -0800 Created attachment 175568 Patch 773498 5 175568 laszlo.gombos 2012-11-21 19:19:59 -0800 Comment on attachment 175568 Patch r=me. 773569 6 ryuan.choi 2012-11-21 22:19:31 -0800 Committed r135477: <http://trac.webkit.org/changeset/135477> 175544 2012-11-21 16:20:12 -0800 2012-11-21 16:22:49 -0800 Patch bug-102988-20121122091758.patch text/plain 1093 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IGMyZmQ0 M2M1Yzg0NWNhNTU5MmE5N2NmN2I3ZGJlZDc2ZDZkY2UzMDUuLmM3ZmZhYmU4MWI1YTRkNWYzMDg4 YjU2ZjNmOTM3NjI4N2EwYWYyNDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC0xODksNSArMTg5 LDQgQEAgRU5ESUYoKQogCiBJRiAoRU5BQkxFX1NQRUxMQ0hFQ0spCiAgICAgICBGSU5EX1BBQ0tB R0UoRW5jaGFudCBSRVFVSVJFRCkKLSAgICAgIEFERF9ERUZJTklUSU9OUygtREVOQUJMRV9TUEVM TENIRUNLPTEpCiBFTkRJRigpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5k ZXggMjM0YzdiM2QwYjRlNDgxMWJiN2EwZDBjODJhNDMxMDA2MzczNmE3Ny4uNTNmNTgxNzBkOGRl OWI1ZWJiNGRlNTVlZjZmYzJmMzRiZDE0NDcxNyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBi L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTIxICBSeXVhbiBDaG9pICA8cnl1 YW4uY2hvaUBnbWFpbC5jb20+CisKKyAgICAgICAgW0VGTF0gUmVtb3ZlIHVubmVjZXNzYXJ5IGRl ZmluaXRpb24sIC1ERU5BQkxFX1NQRUxMQ0hFQ0s9MQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyOTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlZCAtREVOQUJMRV9TUEVMTENIRUNLPTEgYmVj YXVzZSBpdCBpcyBhbHJlYWR5IGRlZmluZWQgYnkgY21ha2Vjb25maWcuaAorICAgICAgICB3aGVu IFNQRUxMQ0hFQ0sgZW5hYmxlZC4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlOgorCiAyMDEyLTExLTIxICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQGludGVsLmNv bT4KIAogICAgICAgICBbRUZMXSBUdXJuIG9uIFdURl9VU0VfVElMRURfQkFDS0lOR19TVE9SRSBi eSBkZWZhdWx0Cg== 175545 2012-11-21 16:22:55 -0800 2012-11-21 19:17:39 -0800 Patch bug-102988-20121122092041.patch text/plain 1148 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IGMyZmQ0 M2M1Yzg0NWNhNTU5MmE5N2NmN2I3ZGJlZDc2ZDZkY2UzMDUuLmMxMzI1MGM3MDNjYTQ3NTNlMGEx NzBhMmY0MzU4Y2Q3YjFjOGRhNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC0xODgsNiArMTg4 LDUgQEAgSUYgKEVOQUJMRV9XRUJHTCkKIEVORElGKCkKIAogSUYgKEVOQUJMRV9TUEVMTENIRUNL KQotICAgICAgRklORF9QQUNLQUdFKEVuY2hhbnQgUkVRVUlSRUQpCi0gICAgICBBRERfREVGSU5J VElPTlMoLURFTkFCTEVfU1BFTExDSEVDSz0xKQorICAgIEZJTkRfUEFDS0FHRShFbmNoYW50IFJF UVVJUkVEKQogRU5ESUYoKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4 IDIzNGM3YjNkMGI0ZTQ4MTFiYjdhMGQwYzgyYTQzMTAwNjM3MzZhNzcuLjUzZjU4MTcwZDhkZTli NWViYjRkZTU1ZWY2ZmMyZjM0YmQxNDQ3MTcgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMS0yMSAgUnl1YW4gQ2hvaSAgPHJ5dWFu LmNob2lAZ21haWwuY29tPgorCisgICAgICAgIFtFRkxdIFJlbW92ZSB1bm5lY2Vzc2FyeSBkZWZp bml0aW9uLCAtREVOQUJMRV9TUEVMTENIRUNLPTEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjk4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZWQgLURFTkFCTEVfU1BFTExDSEVDSz0xIGJlY2F1 c2UgaXQgaXMgYWxyZWFkeSBkZWZpbmVkIGJ5IGNtYWtlY29uZmlnLmgKKyAgICAgICAgd2hlbiBT UEVMTENIRUNLIGVuYWJsZWQuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5j bWFrZToKKwogMjAxMi0xMS0yMSAgWWFlbCBBaGFyb24gIDx5YWVsLmFoYXJvbkBpbnRlbC5jb20+ CiAKICAgICAgICAgW0VGTF0gVHVybiBvbiBXVEZfVVNFX1RJTEVEX0JBQ0tJTkdfU1RPUkUgYnkg ZGVmYXVsdAo= 175568 2012-11-21 19:17:45 -0800 2012-11-21 22:19:55 -0800 Patch bug-102988-20121122121531.patch text/plain 1160 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IGMyZmQ0 M2M1Yzg0NWNhNTU5MmE5N2NmN2I3ZGJlZDc2ZDZkY2UzMDUuLmMxMzI1MGM3MDNjYTQ3NTNlMGEx NzBhMmY0MzU4Y2Q3YjFjOGRhNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC0xODgsNiArMTg4 LDUgQEAgSUYgKEVOQUJMRV9XRUJHTCkKIEVORElGKCkKIAogSUYgKEVOQUJMRV9TUEVMTENIRUNL KQotICAgICAgRklORF9QQUNLQUdFKEVuY2hhbnQgUkVRVUlSRUQpCi0gICAgICBBRERfREVGSU5J VElPTlMoLURFTkFCTEVfU1BFTExDSEVDSz0xKQorICAgIEZJTkRfUEFDS0FHRShFbmNoYW50IFJF UVVJUkVEKQogRU5ESUYoKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4 IDIzNGM3YjNkMGI0ZTQ4MTFiYjdhMGQwYzgyYTQzMTAwNjM3MzZhNzcuLjNhNGJlZDQzZjRiZTM3 ZDNjZDk5YzcxYTU1ZmU5ZGQxMDA4YmM0NWMgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMS0yMSAgUnl1YW4gQ2hvaSAgPHJ5dWFu LmNob2lAZ21haWwuY29tPgorCisgICAgICAgIFtFRkxdIFJlbW92ZSB1bm5lY2Vzc2FyeSBkZWZp bml0aW9uLCAtREVOQUJMRV9TUEVMTENIRUNLPTEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjk4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZWQgLURFTkFCTEVfU1BFTExDSEVDSz0xIGJlY2F1 c2UgZmVhdHVyZSBtYWNyb3MgYXJlIGNvbnRyb2xsZWQgYnkKKyAgICAgICAgV0VCS0lUX09QVElP Tl9YWFggYW5kIGNtYWtlY29uZmlnLmguY21ha2UuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2Uv T3B0aW9uc0VmbC5jbWFrZToKKwogMjAxMi0xMS0yMSAgWWFlbCBBaGFyb24gIDx5YWVsLmFoYXJv bkBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gVHVybiBvbiBXVEZfVVNFX1RJTEVEX0JBQ0tJ TkdfU1RPUkUgYnkgZGVmYXVsdAo=