102986 2012-11-21 15:46:33 -0800 REGRESSION(r135437): This patch causes crash to some layout tests (Requested by jianli on #webkit). 2012-11-21 16:03:14 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 102975 1 webkit.review.bot webkit.review.bot esprehn jianli ojan oldest_to_newest 773367 0 webkit.review.bot 2012-11-21 15:46:33 -0800 http://trac.webkit.org/changeset/135437 broke the build: This patch causes crash to some layout tests (Requested by jianli on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 773370 1 175540 webkit.review.bot 2012-11-21 15:47:13 -0800 Created attachment 175540 ROLLOUT of r135437 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 773371 2 jianli 2012-11-21 15:48:22 -0800 Here is the stack: /Volumes/Data/slave/mountainlion-debug/build/Source/WebCore/rendering/RenderObject.cpp(173) : static WebCore::RenderObject *WebCore::RenderObject::createObject(WebCore::Node *, WebCore::RenderStyle *) 1 0x102dbbc60 WebCore::RenderObject::createObject(WebCore::Node*, WebCore::RenderStyle*) 2 0x10221769e WebCore::HTMLElement::createRenderer(WebCore::RenderArena*, WebCore::RenderStyle*) 3 0x102b67b08 WebCore::NodeRenderingContext::createRendererIfNeeded() 4 0x102b4ef05 WebCore::Node::createRendererIfNeeded() 5 0x101fcc884 WebCore::Element::attach() Here're some bot output http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r135440%20(3070)/fast/css/xml-stylesheet-alternate-processing-stderr.txt http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/2052 773377 3 175540 webkit.review.bot 2012-11-21 16:03:10 -0800 Comment on attachment 175540 ROLLOUT of r135437 Clearing flags on attachment: 175540 Committed r135447: <http://trac.webkit.org/changeset/135447> 773378 4 webkit.review.bot 2012-11-21 16:03:14 -0800 All reviewed patches have been landed. Closing bug. 175540 2012-11-21 15:47:13 -0800 2012-11-21 16:03:10 -0800 ROLLOUT of r135437 bug-102986-20121121235330.patch text/plain 2453 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTUxNWU3MWEzNTRkYjQ2 MzBkM2U5NjI5NzU4MWU3Y2I5ZDJiZTU3OC4uY2JiZDMwYzA4OWU3MzRhYTUyOTYxZmRiZTMwNzhl ZGM1N2IyZDkyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTIxICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTM1NDM3LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMzU0MzcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwMjk4NgorCisgICAgICAgIFRoaXMgcGF0Y2ggY2F1c2VzIGNyYXNoIHRvIHNv bWUgbGF5b3V0IHRlc3RzIChSZXF1ZXN0ZWQgYnkKKyAgICAgICAgamlhbmxpIG9uICN3ZWJraXQp LgorCisgICAgICAgICogZG9tL05vZGVSZW5kZXJpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6Ok5vZGVSZW5kZXJpbmdDb250ZXh0OjpjcmVhdGVSZW5kZXJlcklmTmVlZGVkKToKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlck9iamVjdDo6Y3JlYXRlT2JqZWN0KToKKwogMjAxMi0xMS0yMSAgQW5kcmVhcyBLbGluZyAg PGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgU3R5bGUgc2hhcmluZzogQ29tcGFyZSBjbGFz cyBsaXN0cyB2aWEgU3BhY2VTcGxpdFN0cmluZyBpbnN0ZWFkIG9mIHN0cmluZyBjb21wYXJpc29u LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGVSZW5kZXJpbmdDb250ZXh0LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlUmVuZGVyaW5nQ29udGV4dC5jcHAKaW5kZXggY2Qy NjI1MDMxMjQ5ZThhNTdkODIyOTgwNzEwZjcwNmZkMmMwODc5ZS4uOWFlZWFjZmUxMDYwOGQzNjRj ZGQ0OWRjYTdjYWZmOTUwYzFkMjE3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL05v ZGVSZW5kZXJpbmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZVJlbmRl cmluZ0NvbnRleHQuY3BwCkBAIC0yMjksMTEgKzIyOSw4IEBAIHZvaWQgTm9kZVJlbmRlcmluZ0Nv bnRleHQ6OmNyZWF0ZVJlbmRlcmVySWZOZWVkZWQoKQogCiAgICAgRG9jdW1lbnQqIGRvY3VtZW50 ID0gbV9ub2RlLT5kb2N1bWVudCgpOwogICAgIFJlbmRlck9iamVjdCogbmV3UmVuZGVyZXIgPSBt X25vZGUtPmNyZWF0ZVJlbmRlcmVyKGRvY3VtZW50LT5yZW5kZXJBcmVuYSgpLCBtX3N0eWxlLmdl dCgpKTsKLSAgICBpZiAoIW5ld1JlbmRlcmVyKSB7Ci0gICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hF RCgpOworICAgIGlmICghbmV3UmVuZGVyZXIpCiAgICAgICAgIHJldHVybjsKLSAgICB9Ci0KICAg ICBpZiAoIXBhcmVudFJlbmRlcmVyLT5pc0NoaWxkQWxsb3dlZChuZXdSZW5kZXJlciwgbV9zdHls ZS5nZXQoKSkpIHsKICAgICAgICAgbmV3UmVuZGVyZXItPmRlc3Ryb3koKTsKICAgICAgICAgcmV0 dXJuOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAppbmRleCAxNWQy MWE2OThkODQ3YWQ5YTliZTE5NzlhMTU2NzFkYzMyMjkwZjc2Li4xNWRjZGQwNTgyOWU0ZTc2ZDhh MTQyNzZmMWJhN2Y2NDg0Yzc3NzIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy T2JqZWN0LmNwcApAQCAtMTcwLDcgKzE3MCw2IEBAIFJlbmRlck9iamVjdCogUmVuZGVyT2JqZWN0 OjpjcmVhdGVPYmplY3QoTm9kZSogbm9kZSwgUmVuZGVyU3R5bGUqIHN0eWxlKQogICAgICAgICBy ZXR1cm4gbmV3IChhcmVuYSkgUmVuZGVyUmVnaW9uKG5vZGUsIDApOwogICAgIHN3aXRjaCAoc3R5 bGUtPmRpc3BsYXkoKSkgewogICAgIGNhc2UgTk9ORToKLSAgICAgICAgQVNTRVJUX05PVF9SRUFD SEVEKCk7CiAgICAgICAgIHJldHVybiAwOwogICAgIGNhc2UgSU5MSU5FOgogICAgICAgICByZXR1 cm4gbmV3IChhcmVuYSkgUmVuZGVySW5saW5lKG5vZGUpOwpAQCAtMjEwLDcgKzIwOSw2IEBAIFJl bmRlck9iamVjdCogUmVuZGVyT2JqZWN0OjpjcmVhdGVPYmplY3QoTm9kZSogbm9kZSwgUmVuZGVy U3R5bGUqIHN0eWxlKQogICAgICAgICByZXR1cm4gbmV3IChhcmVuYSkgUmVuZGVyR3JpZChub2Rl KTsKICAgICB9CiAKLSAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICByZXR1cm4gMDsKIH0K IAo=