102985 2012-11-21 15:32:46 -0800 Rename the "eden" bit to something more descriptive 2012-11-22 01:59:30 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 webkit.review.bot abarth abarth haraken japhet koivisto mjs ojan oldest_to_newest 773354 0 webkit.review.bot 2012-11-21 15:32:46 -0800 Rename the "eden" bit to something more descriptive Requested by abarth on #webkit. 773361 1 abarth 2012-11-21 15:38:52 -0800 3:14 PM <anttik> abarth: ping 3:14 PM <abarth> anttik: hi 3:14 PM <rniwa> anttik: and here comes the patch: https://bugs.webkit.org/show_bug.cgi?id=102983 :D 3:14 PM <anttik> abarth: what is InEdenFlag in Node.h? 3:15 PM <abarth> anttik: it's a bit that records whether this node has participated in a minor GC cycle 3:16 PM <anttik> abarth: is that some v8 specific name? it makes no sense at all 3:16 PM <abarth> anttik: its from https://bugs.webkit.org/show_bug.cgi?id=98725 3:16 PM <abarth> anttik: it's just a name we made up. we can change the name if you like 3:16 PM <abarth> it refers to the garden of eden 3:16 PM <anttik> abarth: the webkit style prefers descriptive names 3:17 PM <anttik> so yeah, it should be renamed 3:26 PM <othermaciej> anttik, abarth: if you flip the polarity it could be HasSurvivedV8Collection 3:26 PM <othermaciej> or something 3:26 PM <othermaciej> I also thought "eden" was a bit of a wonky name, sorry for not commenting earlier 3:26 PM <abarth> yeah, i think eric mentioned not liking the name either 3:27 PM <abarth> MightBeReachableFromOutsideTheV8NewSpace 3:28 PM <anttik> Flag 3:28 PM <abarth> flag? 3:29 PM <anttik> MightBeReachableFromOutsideTheV8NewSpaceFlag :D 3:29 PM <abarth> .com 3:31 PM <othermaciej> abarth: what does "in eden" actually mean? 3:31 PM <othermaciej> from the patch it seemed like, mechanically, it would be unset if you survive a minor collection, but I may have misunderstood 3:33 PM <abarth> what it really means is "its too hard to calculate the reachability of this node during minor gc---you'll need to wait for a major gc" 773362 2 haraken 2012-11-21 15:39:37 -0800 MaybeInV8NewSpaceFlag ? 773364 3 abarth 2012-11-21 15:41:17 -0800 We might need to flip the bit in the future if the node is reachable from something like a MuationObserver that has a complicated lifetime. Hopefully we can find a name that will scale to that case as well. 773383 4 haraken 2012-11-21 16:10:47 -0800 In IRC, it looks like we have reached "CollectableOnlyDuringV8MajorGC". If you have no objection, I'll rename it. 773509 5 haraken 2012-11-21 20:01:12 -0800 The conclusion in IRC was V8CollectableOnlyDuringMajorGCFlag. However, I noticed that then we need to set the bit in a Node constructor. To avoid the overhead (though I don't know it's a problem), I would suggest V8CollectableDuringMinorGCFlag. It's shorter than V8CollectableOnlyDuringMajorGCFlag:) 773510 6 175570 haraken 2012-11-21 20:01:32 -0800 Created attachment 175570 Patch 773524 7 175570 abarth 2012-11-21 20:27:16 -0800 Comment on attachment 175570 Patch ok 773747 8 175570 webkit.review.bot 2012-11-22 01:59:26 -0800 Comment on attachment 175570 Patch Clearing flags on attachment: 175570 Committed r135498: <http://trac.webkit.org/changeset/135498> 773748 9 webkit.review.bot 2012-11-22 01:59:30 -0800 All reviewed patches have been landed. Closing bug. 175570 2012-11-21 20:01:32 -0800 2012-11-22 01:59:26 -0800 Patch bug-102985-20121122125918.patch text/plain 4248 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWRkZDE5YWM1YmFlMzc0 ZjM5N2JmOTNkZjY0ZDQ1ODdjODBiZmIxZC4uMDczOTkxYzlkZGQ0MDY5MGIwMTRkN2VmYjI3NmQ5 YmIyM2U4MGVjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEyLTExLTIxICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZW5hbWUgdGhlICJl ZGVuIiBiaXQgdG8gc29tZXRoaW5nIG1vcmUgZGVzY3JpcHRpdmUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjk4NQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluRWRlbkZsYWcgaXMgbm90IGRlc2NyaXB0 aXZlLiBQZXIgdGhlIGRpc2N1c3Npb24gaW4gSVJDLAorICAgICAgICB3ZSByZW5hbWUgSW5FZGVu RmxhZyB0byBWOENvbGxlY3RhYmxlRHVyaW5nTWlub3JHQ0ZsYWcuCisKKyAgICAgICAgTm8gdGVz dHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4R0ND b250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmdjVHJlZSk6CisgICAgICAgIChXZWJD b3JlOjpWOEdDQ29udHJvbGxlcjo6ZGlkQ3JlYXRlV3JhcHBlckZvck5vZGUpOgorICAgICAgICAo V2ViQ29yZTo6VjhHQ0NvbnRyb2xsZXI6Om1pbm9yR0NQcm9sb2d1ZSk6CisgICAgICAgICogZG9t L05vZGUuaDoKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OmlzVjhDb2xsZWN0YWJsZUR1cmluZ01p bm9yR0MpOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6c2V0VjhDb2xsZWN0YWJsZUR1cmluZ01p bm9yR0MpOgorCisyMDEyLTExLTIxICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9y Zz4KKwogICAgICAgICBbVjhdIFdlYkNvcmVTdHJpbmdSZXNvdXJjZUJhc2Ugc2hvdWxkIGJlIGxv Y2F0ZWQgaW4gVjhTdHJpbmdSZXNvdXJjZS5oCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDMwMDIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhHQ0NvbnRyb2xsZXIuY3BwCmluZGV4IDRjYzAzZmJkYzM4ZjExYjUyZGZmMDg1YjI4OGI3 Y2E0YjMzZWE2ZTUuLjk5Y2UzNTlmMDEzMTQwNTNiZGE1ZjdhNzg4MDExNjI2Y2JiNDFiNzggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAKQEAgLTIz Niw3ICsyMzYsNyBAQCBzdGF0aWMgdm9pZCBnY1RyZWUoTm9kZSogc3RhcnROb2RlKQogICAgIGRv IHsKICAgICAgICAgQVNTRVJUKG5vZGUpOwogICAgICAgICBpZiAoIW5vZGUtPndyYXBwZXIoKS5J c0VtcHR5KCkpIHsKLSAgICAgICAgICAgIGlmICghbm9kZS0+aW5FZGVuKCkpIHsKKyAgICAgICAg ICAgIGlmICghbm9kZS0+aXNWOENvbGxlY3RhYmxlRHVyaW5nTWlub3JHQygpKSB7CiAgICAgICAg ICAgICAgICAgLy8gVGhlIGZhY3QgdGhhdCB3ZSBlbmNvdW50ZXIgYSBub2RlIHRoYXQgaXMgbm90 IGluIHRoZSBFZGVuIHNwYWNlCiAgICAgICAgICAgICAgICAgLy8gaW1wbGllcyB0aGF0IGl0cyB3 cmFwcGVyIG1pZ2h0IGJlIGluIHRoZSBvbGQgc3BhY2Ugb2YgVjguCiAgICAgICAgICAgICAgICAg Ly8gVGhpcyBpbmRpY2F0ZXMgdGhhdCB0aGUgbWlub3IgR0MgY2Fubm90IGFueXdheSBqdWRnZSBy ZWFjaGFiaWxpdHkKQEAgLTI0NCw3ICsyNDQsNyBAQCBzdGF0aWMgdm9pZCBnY1RyZWUoTm9kZSog c3RhcnROb2RlKQogICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIH0KICAgICAg ICAgICAgIC8vIEEgb25jZSB0cmF2ZXJzZWQgbm9kZSBpcyByZW1vdmVkIGZyb20gdGhlIEVkZW4g c3BhY2UuCi0gICAgICAgICAgICBub2RlLT5zZXRFZGVuKGZhbHNlKTsKKyAgICAgICAgICAgIG5v ZGUtPnNldFY4Q29sbGVjdGFibGVEdXJpbmdNaW5vckdDKGZhbHNlKTsKICAgICAgICAgICAgIG5l d1NwYWNlV3JhcHBlcnMuYXBwZW5kKG5vZGUtPndyYXBwZXIoKSk7CiAgICAgICAgIH0KICAgICAg ICAgaWYgKG5vZGUtPmZpcnN0Q2hpbGQoKSkgewpAQCAtMjg1LDcgKzI4NSw3IEBAIHZvaWQgVjhH Q0NvbnRyb2xsZXI6OmRpZENyZWF0ZVdyYXBwZXJGb3JOb2RlKE5vZGUqIG5vZGUpCiAgICAgaWYg KG1fZWRlbk5vZGVzLT5zaXplKCkgPD0gd3JhcHBlcnNIYW5kbGVkQnlFYWNoTWlub3JHQykgewog ICAgICAgICAvLyBBIG5vZGUgb2YgYSBuZXdseSBjcmVhdGVkIHdyYXBwZXIgaXMgcHV0IGludG8g dGhlIEVkZW4gc3BhY2UuCiAgICAgICAgIG1fZWRlbk5vZGVzLT5hcHBlbmQobm9kZSk7Ci0gICAg ICAgIG5vZGUtPnNldEVkZW4odHJ1ZSk7CisgICAgICAgIG5vZGUtPnNldFY4Q29sbGVjdGFibGVE dXJpbmdNaW5vckdDKHRydWUpOwogICAgIH0KIH0KIApAQCAtMzA3LDcgKzMwNyw3IEBAIHZvaWQg VjhHQ0NvbnRyb2xsZXI6Om1pbm9yR0NQcm9sb2d1ZSgpCiAgICAgaWYgKGlzTWFpblRocmVhZE9y R0NUaHJlYWQoKSAmJiBtX2VkZW5Ob2RlcykgewogICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsg aSA8IG1fZWRlbk5vZGVzLT5zaXplKCk7IGkrKykgewogICAgICAgICAgICAgQVNTRVJUKCFtX2Vk ZW5Ob2Rlcy0+YXQoaSktPndyYXBwZXIoKS5Jc0VtcHR5KCkpOwotICAgICAgICAgICAgaWYgKG1f ZWRlbk5vZGVzLT5hdChpKS0+aW5FZGVuKCkpIC8vIFRoaXMgYnJhbmNoIGlzIGp1c3QgZm9yIHBl cmZvcm1hbmNlLgorICAgICAgICAgICAgaWYgKG1fZWRlbk5vZGVzLT5hdChpKS0+aXNWOENvbGxl Y3RhYmxlRHVyaW5nTWlub3JHQygpKSAvLyBUaGlzIGJyYW5jaCBpcyBqdXN0IGZvciBwZXJmb3Jt YW5jZS4KICAgICAgICAgICAgICAgICBnY1RyZWUobV9lZGVuTm9kZXMtPmF0KGkpKTsKICAgICAg ICAgfQogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmggYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vTm9kZS5oCmluZGV4IDJkOWNhY2RiMzEzZjYxM2M4ZDgzMzRiNzljMGRj N2UzOTNlMTM5MjguLjIzMmU3MGUwOGRiMTBkMDcxNDZmMjgxNGFmNTQxNzIzZTk2M2UyMTUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmgKKysrIGIvU291cmNlL1dlYkNvcmUv ZG9tL05vZGUuaApAQCAtMzU2LDggKzM1Niw4IEBAIHB1YmxpYzoKICAgICBib29sIGhhc0V2ZW50 VGFyZ2V0RGF0YSgpIGNvbnN0IHsgcmV0dXJuIGdldEZsYWcoSGFzRXZlbnRUYXJnZXREYXRhRmxh Zyk7IH0KICAgICB2b2lkIHNldEhhc0V2ZW50VGFyZ2V0RGF0YShib29sIGZsYWcpIHsgc2V0Rmxh ZyhmbGFnLCBIYXNFdmVudFRhcmdldERhdGFGbGFnKTsgfQogCi0gICAgYm9vbCBpbkVkZW4oKSBj b25zdCB7IHJldHVybiBnZXRGbGFnKEluRWRlbkZsYWcpOyB9Ci0gICAgdm9pZCBzZXRFZGVuKGJv b2wgZmxhZykgeyBzZXRGbGFnKGZsYWcsIEluRWRlbkZsYWcpOyB9CisgICAgYm9vbCBpc1Y4Q29s bGVjdGFibGVEdXJpbmdNaW5vckdDKCkgY29uc3QgeyByZXR1cm4gZ2V0RmxhZyhWOENvbGxlY3Rh YmxlRHVyaW5nTWlub3JHQ0ZsYWcpOyB9CisgICAgdm9pZCBzZXRWOENvbGxlY3RhYmxlRHVyaW5n TWlub3JHQyhib29sIGZsYWcpIHsgc2V0RmxhZyhmbGFnLCBWOENvbGxlY3RhYmxlRHVyaW5nTWlu b3JHQ0ZsYWcpOyB9CiAKICAgICBlbnVtIFNob3VsZFNldEF0dGFjaGVkIHsKICAgICAgICAgU2V0 QXR0YWNoZWQsCkBAIC03MjQsNyArNzI0LDcgQEAgcHJpdmF0ZToKICAgICAgICAgSGFzQ3VzdG9t Q2FsbGJhY2tzRmxhZyA9IDEgPDwgMjUsCiAgICAgICAgIEhhc1Njb3BlZEhUTUxTdHlsZUNoaWxk RmxhZyA9IDEgPDwgMjYsCiAgICAgICAgIEhhc0V2ZW50VGFyZ2V0RGF0YUZsYWcgPSAxIDw8IDI3 LAotICAgICAgICBJbkVkZW5GbGFnID0gMSA8PCAyOCwKKyAgICAgICAgVjhDb2xsZWN0YWJsZUR1 cmluZ01pbm9yR0NGbGFnID0gMSA8PCAyOCwKICAgICAgICAgSXNJbnNlcnRpb25Qb2ludEZsYWcg PSAxIDw8IDI5LAogCiAjaWYgRU5BQkxFKFNWRykK