102978 2012-11-21 14:03:30 -0800 [BlackBerry] Prevent screen from dimming on device when inspector front-end is connected 2012-11-21 15:02:10 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kpiascik kpiascik kpiascik mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 773259 0 kpiascik 2012-11-21 14:03:30 -0800 [BlackBerry] Prevent screen from dimming on device when inspector front-end is connected 773264 1 175519 kpiascik 2012-11-21 14:06:25 -0800 Created attachment 175519 Patch 773271 2 175519 rwlbuis 2012-11-21 14:10:22 -0800 Comment on attachment 175519 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175519&action=review LGTM. > Source/WebKit/blackberry/Api/WebPage.cpp:5223 > + d->setPreventsScreenDimming(true); Seems like setPreventScreenDimming is the better name, but you are just using this API. > Source/WebKit/blackberry/Api/WebPage.cpp:5230 > + d->m_page->settings()->setDeveloperExtrasEnabled(false); Would be nice to make this call implicit. 773273 3 kpiascik 2012-11-21 14:11:30 -0800 (In reply to comment #2) > (From update of attachment 175519 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=175519&action=review > > LGTM. > > > Source/WebKit/blackberry/Api/WebPage.cpp:5223 > > + d->setPreventsScreenDimming(true); > > Seems like setPreventScreenDimming is the better name, but you are just using this API. > > > Source/WebKit/blackberry/Api/WebPage.cpp:5230 > > + d->m_page->settings()->setDeveloperExtrasEnabled(false); > > Would be nice to make this call implicit. I'll work on a follow-up patch to fix the API. 773329 4 175519 webkit.review.bot 2012-11-21 15:02:06 -0800 Comment on attachment 175519 Patch Clearing flags on attachment: 175519 Committed r135441: <http://trac.webkit.org/changeset/135441> 773330 5 webkit.review.bot 2012-11-21 15:02:10 -0800 All reviewed patches have been landed. Closing bug. 175519 2012-11-21 14:06:25 -0800 2012-11-21 15:02:05 -0800 Patch bug-102978-20121121170045.patch text/plain 2009 kpiascik U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBiNDc1YWViZDFmODcwYTY2ZjY1YWRjNzdkZGEyZmM4NTAxYmUyYzg2Li45MGQwNTY5MGZh ODRjZWZiYWZkMTAxNDVjZWJmMDJmOWNkOGY5NjNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxMi0xMS0yMSAgS29ucmFkIFBpYXNjaWsgIDxrcGlh c2Npa0ByaW0uY29tPgogCisgICAgICAgIFtCbGFja0JlcnJ5XSBQcmV2ZW50IHNjcmVlbiBmcm9t IGRpbW1pbmcgb24gZGV2aWNlIHdoZW4gaW5zcGVjdG9yIGZyb250LWVuZCBpcyBjb25uZWN0ZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjk3OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEludGVybmFs IFBSIDIwMDg0OAorICAgICAgICBXZSBwcmV2ZW50IHNjcmVlbiBmcm9tIGdvaW5nIGRpbSB3aGVu IHRoZSBmcm9udC1lbmQgaXMgY29ubmVjdGVkIGFuZCByZXR1cm4gdG8gbm9ybWFsIHdoZW4KKyAg ICAgICAgdGhlIGZyb250LWVuZCBkaXNjb25uZWN0cy4KKworICAgICAgICAqIEFwaS9XZWJQYWdl LmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZTo6ZW5hYmxlV2ViSW5z cGVjdG9yKToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZTo6ZGlzYWJsZVdl Ykluc3BlY3Rvcik6CisKKzIwMTItMTEtMjEgIEtvbnJhZCBQaWFzY2lrICA8a3BpYXNjaWtAcmlt LmNvbT4KKwogICAgICAgICBbQmxhY2tCZXJyeV0gRG9uJ3QgYWRkIGVtcHR5IHJlY3RzIHRvIHRo ZSB0YXAgaGlnaGxpZ2h0IHJlZ2lvbi4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMjk2NgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQXBpL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQ YWdlLmNwcAppbmRleCA0YmNlM2ZhM2ZhZTIwODYzMTBkOTZkYTZkZTg2YmI1MWIwMjlhOWU5Li5j OTc1NjhlY2Y1MWE0MDU5ZTczZjg5YzQ2NmQ2YmFkMzRmMGJiYjA5IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKQEAgLTUyMjAsMTIgKzUyMjAsMTYgQEAgdm9pZCBX ZWJQYWdlOjplbmFibGVXZWJJbnNwZWN0b3IoKQogCiAgICAgZC0+bV9wYWdlLT5pbnNwZWN0b3JD b250cm9sbGVyKCktPmNvbm5lY3RGcm9udGVuZChkLT5tX2luc3BlY3RvckNsaWVudCk7CiAgICAg ZC0+bV9wYWdlLT5zZXR0aW5ncygpLT5zZXREZXZlbG9wZXJFeHRyYXNFbmFibGVkKHRydWUpOwor ICAgIGQtPnNldFByZXZlbnRzU2NyZWVuRGltbWluZyh0cnVlKTsKIH0KIAogdm9pZCBXZWJQYWdl OjpkaXNhYmxlV2ViSW5zcGVjdG9yKCkKIHsKLSAgICBkLT5tX3BhZ2UtPmluc3BlY3RvckNvbnRy b2xsZXIoKS0+ZGlzY29ubmVjdEZyb250ZW5kKCk7Ci0gICAgZC0+bV9wYWdlLT5zZXR0aW5ncygp LT5zZXREZXZlbG9wZXJFeHRyYXNFbmFibGVkKGZhbHNlKTsKKyAgICBpZiAoaXNXZWJJbnNwZWN0 b3JFbmFibGVkKCkpIHsKKyAgICAgICAgZC0+bV9wYWdlLT5pbnNwZWN0b3JDb250cm9sbGVyKCkt PmRpc2Nvbm5lY3RGcm9udGVuZCgpOworICAgICAgICBkLT5tX3BhZ2UtPnNldHRpbmdzKCktPnNl dERldmVsb3BlckV4dHJhc0VuYWJsZWQoZmFsc2UpOworICAgICAgICBkLT5zZXRQcmV2ZW50c1Nj cmVlbkRpbW1pbmcoZmFsc2UpOworICAgIH0KIH0KIAogYm9vbCBXZWJQYWdlOjppc1dlYkluc3Bl Y3RvckVuYWJsZWQoKQo=