102971 2012-11-21 12:43:28 -0800 REGRESSION(r135399): Wrong assertion causing an assertion failure: m_rawAttributes.initialScale > 0 2012-11-23 06:11:18 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 102801 1 tmpsantos mikhail.pozdnyakov abecsi jussi.kukkonen kenneth mikhail.pozdnyakov rakuco tmpsantos oldest_to_newest 773190 0 tmpsantos 2012-11-21 12:43:28 -0800 crash log for WebKitTestRunner (pid 9248): STDOUT: <empty> STDERR: ASSERTION FAILED: m_rawAttributes.initialScale > 0 STDERR: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/PageViewportController.cpp(152) : void WebKit::PageViewportController::pageTransitionViewportReady() STDERR: 1 0x7f0bd508cd5a WebKit::PageViewportController::pageTransitionViewportReady() STDERR: 2 0x7f0bd52b0579 WebKit::PageClientDefaultImpl::pageTransitionViewportReady() STDERR: 3 0x7f0bd50e2535 WebKit::WebPageProxy::pageTransitionViewportReady() STDERR: 4 0x7f0bd52e889e void CoreIPC::callMemberFunction<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)()>(CoreIPC::Arguments0 const&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)()) STDERR: 5 0x7f0bd52e4eaa void CoreIPC::handleMessage<Messages::WebPageProxy::PageTransitionViewportReady, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)()>(CoreIPC::MessageDecoder&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)()) STDERR: 6 0x7f0bd52de2bd WebKit::WebPageProxy::didReceiveWebPageProxyMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) STDERR: 7 0x7f0bd50dd8d9 WebKit::WebPageProxy::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) STDERR: 8 0x7f0bd511e9f5 WebKit::WebProcessProxy::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) STDERR: 9 0x7f0bd5006e64 CoreIPC::Connection::dispatchMessage(CoreIPC::MessageID, CoreIPC::MessageDecoder&) STDERR: 10 0x7f0bd5006fd0 CoreIPC::Connection::dispatchMessage(CoreIPC::Connection::Message<CoreIPC::MessageDecoder>&) STDERR: 11 0x7f0bd500721b CoreIPC::Connection::dispatchOneMessage() STDERR: 12 0x7f0bd50113bc WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>::operator()(CoreIPC::Connection*) STDERR: 13 0x7f0bd50111c2 WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>, void (CoreIPC::Connection*)>::operator()() STDERR: 14 0x7f0bdc1b8dca WTF::Function<void ()>::operator()() const STDERR: 15 0x7f0bd867fc5e WebCore::RunLoop::performWork() STDERR: 16 0x7f0bd909d69b WebCore::RunLoop::wakeUpEvent(void*, void*, unsigned int) STDERR: 17 0x7f0bd441a621 STDERR: 18 0x7f0bd4419571 STDERR: 19 0x7f0bd4419ab7 ecore_main_loop_begin STDERR: 20 0x43362b WTR::TestController::platformRunUntil(bool&, double) STDERR: 21 0x41e94e WTR::TestController::runUntil(bool&, WTR::TestController::TimeoutDuration) STDERR: 22 0x425a06 WTR::TestInvocation::invoke() STDERR: 23 0x41e686 WTR::TestController::runTest(char const*) STDERR: 24 0x41e7bf WTR::TestController::runTestingServerLoop() STDERR: 25 0x41e859 WTR::TestController::run() STDERR: 26 0x41c291 WTR::TestController::TestController(int, char const**) STDERR: 27 0x4337c6 main STDERR: 28 0x7f0bd2f7a76d __libc_start_main STDERR: 29 0x41ac09 STDERR: LEAK: 2 CachedResource 773761 1 abecsi 2012-11-22 02:26:08 -0800 Ouch, the assertion is not actually wrong, but my patch was not complete. I think I know what's going on, and can fix it. Mikhail, I see you assigned it to yourself, do you mind if I clean up my mess instead? 773766 2 175632 mikhail.pozdnyakov 2012-11-22 02:38:42 -0800 Created attachment 175632 patch 773770 3 mikhail.pozdnyakov 2012-11-22 02:42:36 -0800 (In reply to comment #1) > Ouch, the assertion is not actually wrong, but my patch was not complete. > I think I know what's going on, and can fix it. > > Mikhail, I see you assigned it to yourself, do you mind if I clean up my mess instead? sorry, did not see your message. Uploaded already a patch, feel free to take the bug if you see the patch does not suffice or wrong. 773780 4 175632 abecsi 2012-11-22 03:05:44 -0800 Comment on attachment 175632 patch View in context: https://bugs.webkit.org/attachment.cgi?id=175632&action=review I think this is the right fix. The patch looks good to me. > Source/WebKit2/ChangeLog:9 > + m_rawAttributes.initialScale has to be initialized even if m_minimumScaleToFit hasn't changed > + it's value. Indeed, the basic problem was that m_minimumScaleToFit is initialized to 1 and if the calculated minimum scale to fit turned out to be 1 we wrongly returned early and did not initialize the initialScale attribute. 773826 5 175632 rakuco 2012-11-22 04:15:35 -0800 Comment on attachment 175632 patch Clearing flags on attachment: 175632 Committed r135504: <http://trac.webkit.org/changeset/135504> 773827 6 rakuco 2012-11-22 04:15:42 -0800 All reviewed patches have been landed. Closing bug. 774498 7 tmpsantos 2012-11-23 06:11:18 -0800 *** Bug 102922 has been marked as a duplicate of this bug. *** 175632 2012-11-22 02:38:42 -0800 2012-11-22 04:15:35 -0800 patch bug102971 text/plain 2002 mikhail.pozdnyakov Y29tbWl0IGYyZjE4YTRiMDg3ZmMzZTM2YTM4ZTgyNzc0ZjczYjljYWM0NzAyMDUKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg VGh1IE5vdiAyMiAxMjozNDoyMCAyMDEyICswMjAwCgogICAgYnVnMTAyOTcxCgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmlu ZGV4IGU0MTFlOTEuLmE4MWQ5ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0x MS0yMiAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4K KworICAgICAgICBSRUdSRVNTSU9OKHIxMzUzOTkpOiBXcm9uZyBhc3NlcnRpb24gY2F1c2luZyBh biBhc3NlcnRpb24gZmFpbHVyZTogbV9yYXdBdHRyaWJ1dGVzLmluaXRpYWxTY2FsZSA+IDAKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjk3MQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG1fcmF3QXR0cmli dXRlcy5pbml0aWFsU2NhbGUgaGFzIHRvIGJlIGluaXRpYWxpemVkIGV2ZW4gaWYgbV9taW5pbXVt U2NhbGVUb0ZpdCBoYXNuJ3QgY2hhbmdlZAorICAgICAgICBpdCdzIHZhbHVlLgorCisgICAgICAg ICogVUlQcm9jZXNzL1BhZ2VWaWV3cG9ydENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViS2l0 OjpQYWdlVmlld3BvcnRDb250cm9sbGVyOjpkaWRDaGFuZ2VWaWV3cG9ydEF0dHJpYnV0ZXMpOgor CiAyMDEyLTExLTIyICBFdW5taSBMZWUgIDxldW5taTE1LmxlZUBzYW1zdW5nLmNvbT4KIAogICAg ICAgICBbRUZMXVtXSzJdIENvcnJlY3QgdGhlIHBhcmFtZXRlcnMgb2YgV2ViUGxhdGZvcm1Ub3Vj aFBvaW50LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VWaWV3cG9y dENvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VWaWV3cG9ydENv bnRyb2xsZXIuY3BwCmluZGV4IDM1ZjM2MWMuLjVkZTc5MTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9QYWdlVmlld3BvcnRDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvUGFnZVZpZXdwb3J0Q29udHJvbGxlci5jcHAKQEAgLTIxOSw4ICsy MTksNyBAQCB2b2lkIFBhZ2VWaWV3cG9ydENvbnRyb2xsZXI6OmRpZENoYW5nZVZpZXdwb3J0QXR0 cmlidXRlcyhjb25zdCBXZWJDb3JlOjpWaWV3cG9ydAogICAgIG1fcmF3QXR0cmlidXRlcyA9IG5l d0F0dHJpYnV0ZXM7CiAgICAgbV9hbGxvd3NVc2VyU2NhbGluZyA9ICEhbV9yYXdBdHRyaWJ1dGVz LnVzZXJTY2FsYWJsZTsKIAotICAgIGlmICghdXBkYXRlTWluaW11bVNjYWxlVG9GaXQoKSkKLSAg ICAgICAgcmV0dXJuOworICAgIGJvb2wgbWluaW11bVNjYWxlVXBkYXRlZCA9IHVwZGF0ZU1pbmlt dW1TY2FsZVRvRml0KCk7CiAKICAgICBBU1NFUlQobV9taW5pbXVtU2NhbGVUb0ZpdCA+IDApOwog CkBAIC0yMzAsNyArMjI5LDggQEAgdm9pZCBQYWdlVmlld3BvcnRDb250cm9sbGVyOjpkaWRDaGFu Z2VWaWV3cG9ydEF0dHJpYnV0ZXMoY29uc3QgV2ViQ29yZTo6Vmlld3BvcnQKIAogICAgIFdlYkNv cmU6OnJlc3RyaWN0U2NhbGVGYWN0b3JUb0luaXRpYWxTY2FsZUlmTm90VXNlclNjYWxhYmxlKG1f cmF3QXR0cmlidXRlcyk7CiAKLSAgICBtX2NsaWVudC0+ZGlkQ2hhbmdlVmlld3BvcnRBdHRyaWJ1 dGVzKCk7CisgICAgaWYgKG1pbmltdW1TY2FsZVVwZGF0ZWQpCisgICAgICAgIG1fY2xpZW50LT5k aWRDaGFuZ2VWaWV3cG9ydEF0dHJpYnV0ZXMoKTsKIH0KIAogV2ViQ29yZTo6RmxvYXRTaXplIFBh Z2VWaWV3cG9ydENvbnRyb2xsZXI6OnZpZXdwb3J0U2l6ZUluQ29udGVudHNDb29yZGluYXRlcygp IGNvbnN0Cg==