102962 2012-11-21 10:36:17 -0800 [BlackBerry] Switch to point instead of VisiblePosition comparison for input bounds check 2012-11-21 11:53:32 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 773103 0 mifenton 2012-11-21 10:36:17 -0800 SSIA. 773127 1 175485 mifenton 2012-11-21 11:16:15 -0800 Created attachment 175485 Patch 773131 2 175485 rwlbuis 2012-11-21 11:22:07 -0800 Comment on attachment 175485 Patch LGTM. 773152 3 175485 webkit.review.bot 2012-11-21 11:53:28 -0800 Comment on attachment 175485 Patch Clearing flags on attachment: 175485 Committed r135422: <http://trac.webkit.org/changeset/135422> 773153 4 webkit.review.bot 2012-11-21 11:53:32 -0800 All reviewed patches have been landed. Closing bug. 175485 2012-11-21 11:16:15 -0800 2012-11-21 11:53:28 -0800 Patch 0001-2012-11-21-Mike-Fenton-mifenton-rim.com.patch text/plain 6363 mifenton RnJvbSA1MjAzYzkyZDQ5MTg2MmY5YWQ4YTFlNDM3OTljYTIzNTQ4NDUxZjU2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog V2VkLCAyMSBOb3YgMjAxMiAxMzoxODoyMCAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMTEt MjEgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgUFIgMjQ3MjcwLgoK ICAgICAgICBTd2l0Y2ggZnJvbSB1c2luZyBWaXNpYmxlUG9zaXRpb24gdG8gZGV0ZXJtaW5lIGlm IHdlIGFyZSBpbiBhIG5vZGUKICAgICAgICB0byBhIGNvbXBhcmlzb24gb2YgdGhlIGZpZWxkIGJv dW5kcy4gIFRoaXMgZml4ZXMgdGhlIGNhc2Ugd2hlcmUKICAgICAgICB0aGVyZSBpcyBubyBub2Rl IGJlZm9yZSB0aGUgdGFyZ2V0IG5vZGUgdG8gbWF0Y2guCgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBBZGRpdGlvbmFsIGluZm9ybWF0aW9uIG9mIHRoZSBjaGFu Z2Ugc3VjaCBhcyBhcHByb2FjaCwgcmF0aW9uYWxlLiBQbGVhc2UgYWRkIHBlci1mdW5jdGlvbiBk ZXNjcmlwdGlvbnMgYmVsb3cgKE9PUFMhKS4KCiAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0RPTVN1 cHBvcnQuY3BwOgogICAgICAgICogV2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0Lmg6CiAgICAgICAg KiBXZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwOgogICAgICAgIChCbGFja0JlcnJ5 OjpXZWJLaXQ6OlNlbGVjdGlvbkhhbmRsZXI6OnNldENhcmV0UG9zaXRpb24pOgotLS0KIFNvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwgICAyMCArKysr KysrKysrKysrKwogLi4uL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRE9NU3VwcG9y dC5jcHAgfCAgIDI4IC0tLS0tLS0tLS0tLS0tLS0tLS0tCiAuLi4vV2ViS2l0L2JsYWNrYmVycnkv V2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0LmggICB8ICAgIDMgLS0tCiAuLi4vYmxhY2tiZXJyeS9X ZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwICB8ICAgMTkgKysrKysrKy0tLS0tLQog NCBmaWxlcyBjaGFuZ2VkLCAzMSBpbnNlcnRpb25zKCspLCAzOSBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0NoYW5nZUxvZwppbmRleCAzYjk3NWMyLi44ZTA2MTRjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMi0xMS0yMSAgTWlrZSBG ZW50b24gIDxtaWZlbnRvbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBTd2l0Y2gg dG8gcG9pbnQgaW5zdGVhZCBvZiBWaXNpYmxlUG9zaXRpb24gY29tcGFyaXNvbiBmb3IgaW5wdXQg Ym91bmRzIGNoZWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDI5NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBQUiAyNDcyNzAuCisKKyAgICAgICAgU3dpdGNoIGZyb20gdXNpbmcgVmlzaWJsZVBvc2l0 aW9uIHRvIGRldGVybWluZSBpZiB3ZSBhcmUgaW4gYSBub2RlCisgICAgICAgIHRvIGEgY29tcGFy aXNvbiBvZiB0aGUgZmllbGQgYm91bmRzLiAgVGhpcyBmaXhlcyB0aGUgY2FzZSB3aGVyZQorICAg ICAgICB0aGVyZSBpcyBubyBub2RlIGJlZm9yZSB0aGUgdGFyZ2V0IG5vZGUgdG8gbWF0Y2guCisK KyAgICAgICAgUmV2aWV3ZWQgSW50ZXJuYWxseSBieSBHZW4gTWFrLgorCisgICAgICAgICogV2Vi S2l0U3VwcG9ydC9ET01TdXBwb3J0LmNwcDoKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0RPTVN1 cHBvcnQuaDoKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwOgor ICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpTZWxlY3Rpb25IYW5kbGVyOjpzZXRDYXJldFBv c2l0aW9uKToKKwogMjAxMi0xMS0yMCAgQW5kcmV3IExvICA8YW5sb0ByaW0uY29tPgogCiAgICAg ICAgIFtCbGFja0JlcnJ5XSBBbmltYXRlZCBnaWZzIHBhdXNlIG9uIHNjcm9sbCBvciB6b29tIGFu ZCBzb21ldGltZXMgZG9uJ3QgcmVzdW1lIGFmdGVyIHNjcm9sbCBvciB6b29tIGNvbXBsZXRlcwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRE9NU3Vw cG9ydC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9ET01TdXBw b3J0LmNwcAppbmRleCAxZDgxYTVlLi43NTJjNTczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0LmNwcApAQCAtMzE0LDM0ICsz MTQsNiBAQCBWaXNpYmxlU2VsZWN0aW9uIHZpc2libGVTZWxlY3Rpb25Gb3JSYW5nZUlucHV0RWxl bWVudChFbGVtZW50KiBlbGVtZW50LCBpbnQgc3RhcgogICAgIHJldHVybiBWaXNpYmxlU2VsZWN0 aW9uKHZpc2libGVTdGFydCwgdmlzaWJsZUVuZCk7CiB9CiAKLU5vZGUqIERPTUNvbnRhaW5lck5v ZGVGb3JQb3NpdGlvbihjb25zdCBQb3NpdGlvbiYgcG9zaXRpb24pCi17Ci0gICAgTm9kZSogbm9k ZUF0UG9zID0gcG9zaXRpb24uY29udGFpbmVyTm9kZSgpOwotICAgIGlmIChub2RlQXRQb3MgJiYg bm9kZUF0UG9zLT5pc0luU2hhZG93VHJlZSgpKQotICAgICAgICBub2RlQXRQb3MgPSBub2RlQXRQ b3MtPnNoYWRvd0FuY2VzdG9yTm9kZSgpOwotCi0gICAgcmV0dXJuIG5vZGVBdFBvczsKLX0KLQot Ym9vbCBpc1Bvc2l0aW9uSW5Ob2RlKE5vZGUqIG5vZGUsIGNvbnN0IFBvc2l0aW9uJiBwb3NpdGlv bikKLXsKLSAgICBpZiAoIW5vZGUpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQotICAgIE5vZGUq IGRvbU5vZGVBdFBvcyA9IERPTUNvbnRhaW5lck5vZGVGb3JQb3NpdGlvbihwb3NpdGlvbik7Ci0g ICAgaWYgKCFkb21Ob2RlQXRQb3MpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQotICAgIGludCBv ZmZzZXQgPSAwOwotICAgIGlmIChkb21Ob2RlQXRQb3MgPT0gcG9zaXRpb24uY29udGFpbmVyTm9k ZSgpKQotICAgICAgICBvZmZzZXQgPSBwb3NpdGlvbi5jb21wdXRlT2Zmc2V0SW5Db250YWluZXJO b2RlKCk7Ci0KLSAgICBSZWZQdHI8UmFuZ2U+IHJhbmdlRm9yTm9kZSA9IHJhbmdlT2ZDb250ZW50 cyhub2RlKTsKLSAgICBpbnQgZWM7Ci0KLSAgICByZXR1cm4gcmFuZ2VGb3JOb2RlLT5pc1BvaW50 SW5SYW5nZShkb21Ob2RlQXRQb3MsIG9mZnNldCwgZWMpOwotfQotCiBzdGF0aWMgYm9vbCBtYXRj aGVzUmVzZXJ2ZWRTdHJpbmdFbWFpbChjb25zdCBBdG9taWNTdHJpbmcmIHN0cmluZykKIHsKICAg ICByZXR1cm4gc3RyaW5nLmNvbnRhaW5zKCJlbWFpbCIsIGZhbHNlIC8qIGNhc2VTZW5zaXRpdmUg Ki8pOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQv RE9NU3VwcG9ydC5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRE9N U3VwcG9ydC5oCmluZGV4IGE4NmUxMmEuLjc0MTc1ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQuaAorKysgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0LmgKQEAgLTc2LDkgKzc2LDYg QEAgdm9pZCB2aXNpYmxlVGV4dFF1YWRzKGNvbnN0IFdlYkNvcmU6OlZpc2libGVTZWxlY3Rpb24m LCBXVEY6OlZlY3RvcjxXZWJDb3JlOjpGbG8KIFdlYkNvcmU6OlZpc2libGVTZWxlY3Rpb24gdmlz aWJsZVNlbGVjdGlvbkZvclJhbmdlSW5wdXRFbGVtZW50KFdlYkNvcmU6OkVsZW1lbnQqLCBpbnQg c3RhcnQsIGludCBlbmQpOwogV2ViQ29yZTo6VmlzaWJsZVNlbGVjdGlvbiB2aXNpYmxlU2VsZWN0 aW9uRm9ySW5wdXRFbGVtZW50KFdlYkNvcmU6OkVsZW1lbnQqKTsKIAotV2ViQ29yZTo6Tm9kZSog RE9NQ29udGFpbmVyTm9kZUZvclBvc2l0aW9uKGNvbnN0IFdlYkNvcmU6OlBvc2l0aW9uJik7Ci1i b29sIGlzUG9zaXRpb25Jbk5vZGUoV2ViQ29yZTo6Tm9kZSosIGNvbnN0IFdlYkNvcmU6OlBvc2l0 aW9uJik7Ci0KIGJvb2wgZWxlbWVudElkT3JOYW1lSW5kaWNhdGVzTm9BdXRvY29tcGxldGUoY29u c3QgV2ViQ29yZTo6RWxlbWVudCopOwogYm9vbCBlbGVtZW50SWRPck5hbWVJbmRpY2F0ZXNFbWFp bChjb25zdCBXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50Kik7CiBib29sIGVsZW1lbnRJZE9yTmFt ZUluZGljYXRlc1VybChjb25zdCBXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50Kik7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5k bGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlv bkhhbmRsZXIuY3BwCmluZGV4IGZjZDJlN2UuLjFiODkwNzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIu Y3BwCkBAIC0yNTMsMTQgKzI1MywxNyBAQCB2b2lkIFNlbGVjdGlvbkhhbmRsZXI6OnNldENhcmV0 UG9zaXRpb24oY29uc3QgV2ViQ29yZTo6SW50UG9pbnQgJnBvc2l0aW9uKQogCiAgICAgVmlzaWJs ZVBvc2l0aW9uIHZpc2libGVDYXJldFBvc2l0aW9uKGZvY3VzZWRGcmFtZS0+dmlzaWJsZVBvc2l0 aW9uRm9yUG9pbnQocmVsYXRpdmVQb2ludCkpOwogCi0gICAgaWYgKCFET01TdXBwb3J0Ojppc1Bv c2l0aW9uSW5Ob2RlKG1fd2ViUGFnZS0+Zm9jdXNlZE9yTWFpbkZyYW1lKCktPmRvY3VtZW50KCkt PmZvY3VzZWROb2RlKCksIHZpc2libGVDYXJldFBvc2l0aW9uLmRlZXBFcXVpdmFsZW50KCkpKSB7 Ci0gICAgICAgIGlmICh1bnNpZ25lZCBzaG9ydCBjaGFyYWN0ZXIgPSBkaXJlY3Rpb25PZlBvaW50 UmVsYXRpdmVUb1JlY3QocmVsYXRpdmVQb2ludCwgY3VycmVudENhcmV0UmVjdCkpCi0gICAgICAg ICAgICBtX3dlYlBhZ2UtPm1faW5wdXRIYW5kbGVyLT5oYW5kbGVLZXlib2FyZElucHV0KFBsYXRm b3JtOjpLZXlib2FyZEV2ZW50KGNoYXJhY3RlcikpOwotCi0gICAgICAgIC8vIFNlbmQgdGhlIHNl bGVjdGlvbiBjaGFuZ2VkIGluIGNhc2UgdGhpcyBkb2VzIG5vdCB0cmlnZ2VyIGEgc2VsZWN0aW9u IGNoYW5nZSB0bwotICAgICAgICAvLyBlbnN1cmUgdGhlIGNhcmV0IHBvc2l0aW9uIGlzIGFjY3Vy YXRlLiBUaGlzIG1heSBiZSBhIGR1cGxpY2F0ZSBldmVudC4KLSAgICAgICAgc2VsZWN0aW9uUG9z aXRpb25DaGFuZ2VkKHRydWUgLyogZm9yY2VVcGRhdGVXaXRob3V0Q2hhbmdlICovKTsKLSAgICAg ICAgcmV0dXJuOworICAgIGlmIChSZW5kZXJPYmplY3QqIGZvY3VzZWRSZW5kZXJlciA9IGZvY3Vz ZWRGcmFtZS0+ZG9jdW1lbnQoKS0+Zm9jdXNlZE5vZGUoKS0+cmVuZGVyZXIoKSkgeworICAgICAg ICBXZWJDb3JlOjpJbnRSZWN0IG5vZGVPdXRsaW5lQm91bmRzKGZvY3VzZWRSZW5kZXJlci0+YWJz b2x1dGVPdXRsaW5lQm91bmRzKCkpOworICAgICAgICBpZiAoIW5vZGVPdXRsaW5lQm91bmRzLmNv bnRhaW5zKHJlbGF0aXZlUG9pbnQpKSB7CisgICAgICAgICAgICBpZiAodW5zaWduZWQgc2hvcnQg Y2hhcmFjdGVyID0gZGlyZWN0aW9uT2ZQb2ludFJlbGF0aXZlVG9SZWN0KHJlbGF0aXZlUG9pbnQs IGN1cnJlbnRDYXJldFJlY3QpKQorICAgICAgICAgICAgICAgIG1fd2ViUGFnZS0+bV9pbnB1dEhh bmRsZXItPmhhbmRsZUtleWJvYXJkSW5wdXQoUGxhdGZvcm06OktleWJvYXJkRXZlbnQoY2hhcmFj dGVyKSk7CisKKyAgICAgICAgICAgIC8vIFNlbmQgdGhlIHNlbGVjdGlvbiBjaGFuZ2VkIGluIGNh c2UgdGhpcyBkb2VzIG5vdCB0cmlnZ2VyIGEgc2VsZWN0aW9uIGNoYW5nZSB0bworICAgICAgICAg ICAgLy8gZW5zdXJlIHRoZSBjYXJldCBwb3NpdGlvbiBpcyBhY2N1cmF0ZS4gVGhpcyBtYXkgYmUg YSBkdXBsaWNhdGUgZXZlbnQuCisgICAgICAgICAgICBzZWxlY3Rpb25Qb3NpdGlvbkNoYW5nZWQo dHJ1ZSAvKiBmb3JjZVVwZGF0ZVdpdGhvdXRDaGFuZ2UgKi8pOworICAgICAgICAgICAgcmV0dXJu OworICAgICAgICB9CiAgICAgfQogCiAgICAgVmlzaWJsZVNlbGVjdGlvbiBuZXdTZWxlY3Rpb24o dmlzaWJsZUNhcmV0UG9zaXRpb24pOwotLSAKMS43LjkuNQoK