102959 2012-11-21 10:13:56 -0800 REGRESSION(r135409): This patch causes compiling error to Chromium build (Requested by jianli_ on #webkit). 2012-11-21 10:21:00 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 102941 1 webkit.review.bot webkit.review.bot jianli jochen oldest_to_newest 773076 0 webkit.review.bot 2012-11-21 10:13:56 -0800 http://trac.webkit.org/changeset/135409 broke the build: This patch causes compiling error to Chromium build (Requested by jianli_ on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 773079 1 175474 webkit.review.bot 2012-11-21 10:14:36 -0800 Created attachment 175474 ROLLOUT of r135409 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 773082 2 jianli 2012-11-21 10:17:24 -0800 Here is the error: Undefined symbols: "__ZN6WebKit16FrameTestHelpers20createWebViewAndLoadERKSsbPNS_14WebFrameClientEPNS_13WebViewClientE", referenced from: __ZN12_GLOBAL__N_114IDBRequestTest5SetUpEv in IDBRequestTest.o http://build.chromium.org/p/chromium.webkit/builders/Mac%20Builder%20%28dbg%29/builds/17133 773086 3 175474 webkit.review.bot 2012-11-21 10:20:57 -0800 Comment on attachment 175474 ROLLOUT of r135409 Clearing flags on attachment: 175474 Committed r135415: <http://trac.webkit.org/changeset/135415> 773087 4 webkit.review.bot 2012-11-21 10:21:00 -0800 All reviewed patches have been landed. Closing bug. 175474 2012-11-21 10:14:36 -0800 2012-11-21 10:20:57 -0800 ROLLOUT of r135409 bug-102959-20121121182053.patch text/plain 3643 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDZhM2IyN2I0YTVlYmRmYzgyMjY5YWU3YzViZmMyZWFiNzVjYTQwYWIuLjY3NDY1Y2Y4N2ZmNGI2 YWNjMDQwYzliYmJkODE1ZjZjMDgzZmI2NDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMTEtMjEgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5i b3RAZ21haWwuY29tPgorCisgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMzU0MDku CisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEzNTQwOQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyOTU5CisKKyAgICAg ICAgVGhpcyBwYXRjaCBjYXVzZXMgY29tcGlsaW5nIGVycm9yIHRvIENocm9taXVtIGJ1aWxkIChS ZXF1ZXN0ZWQKKyAgICAgICAgYnkgamlhbmxpXyBvbiAjd2Via2l0KS4KKworICAgICAgICAqIHRl c3RzL0lEQlJlcXVlc3RUZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRFU1QpOgorCiAyMDEy LTExLTIxICBLZXZpbiBFbGxpcyAgPGtldmVyc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2No cm9taXVtXSBBZGQgZmxhZyB0byBlbmFibGUvZGlzYWJsZSB0b3VjaCBhZGp1c3RtZW50IGF0IHJ1 bnRpbWUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0lEQlJlcXVl c3RUZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvSURCUmVxdWVzdFRlc3Qu Y3BwCmluZGV4IGEwNzM0ZTE0YzQ0ZGNiYzVlNzhkYWZiODY5N2M4NWI3MTJhZWZkMDcuLjI3ZjZj MWU2YjM2NGE0ZTIyMzZhMTQyNTc1YjMyOTdlNjlhZjZjZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vdGVzdHMvSURCUmVxdWVzdFRlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vdGVzdHMvSURCUmVxdWVzdFRlc3QuY3BwCkBAIC0yOCw2NCArMjgsMjMgQEAK ICNpbmNsdWRlICJJREJSZXF1ZXN0LmgiCiAKICNpbmNsdWRlICJET01TdHJpbmdMaXN0LmgiCi0j aW5jbHVkZSAiRG9jdW1lbnQuaCIKLSNpbmNsdWRlICJGcmFtZS5oIgotI2luY2x1ZGUgIkZyYW1l VGVzdEhlbHBlcnMuaCIKICNpbmNsdWRlICJJREJDdXJzb3JCYWNrZW5kSW50ZXJmYWNlLmgiCiAj aW5jbHVkZSAiSURCRGF0YWJhc2VCYWNrZW5kSW1wbC5oIgogI2luY2x1ZGUgIklEQlRyYW5zYWN0 aW9uQ29vcmRpbmF0b3IuaCIKLSNpbmNsdWRlICJXZWJGcmFtZS5oIgotI2luY2x1ZGUgIldlYkZy YW1lSW1wbC5oIgotI2luY2x1ZGUgIldlYlZpZXcuaCIKIAogI2luY2x1ZGUgPGd0ZXN0L2d0ZXN0 Lmg+CiAKICNpZiBFTkFCTEUoSU5ERVhFRF9EQVRBQkFTRSkKIAogdXNpbmcgbmFtZXNwYWNlIFdl YkNvcmU7Ci11c2luZyBuYW1lc3BhY2UgV2ViS2l0OwogCiBuYW1lc3BhY2UgewogCi1jbGFzcyBJ REJSZXF1ZXN0VGVzdCA6IHB1YmxpYyB0ZXN0aW5nOjpUZXN0IHsKLXB1YmxpYzoKLSAgICBJREJS ZXF1ZXN0VGVzdCgpCi0gICAgICAgIDogbV93ZWJWaWV3KDApCi0gICAgewotICAgIH0KLQotICAg IHZvaWQgU2V0VXAoKSBPVkVSUklERQotICAgIHsKLSAgICAgICAgbV93ZWJWaWV3ID0gRnJhbWVU ZXN0SGVscGVyczo6Y3JlYXRlV2ViVmlld0FuZExvYWQoImFib3V0OmJsYW5rIik7Ci0gICAgICAg IG1fd2ViVmlldy0+c2V0Rm9jdXModHJ1ZSk7Ci0gICAgfQotCi0gICAgdm9pZCBUZWFyRG93bigp IE9WRVJSSURFCi0gICAgewotICAgICAgICBtX3dlYlZpZXctPmNsb3NlKCk7Ci0gICAgfQotCi0g ICAgdjg6OkhhbmRsZTx2ODo6Q29udGV4dD4gY29udGV4dCgpCi0gICAgewotICAgICAgICByZXR1 cm4gc3RhdGljX2Nhc3Q8V2ViRnJhbWVJbXBsKj4obV93ZWJWaWV3LT5tYWluRnJhbWUoKSktPmZy YW1lKCktPnNjcmlwdCgpLT5tYWluV29ybGRDb250ZXh0KCk7Ci0gICAgfQotCi0gICAgU2NyaXB0 RXhlY3V0aW9uQ29udGV4dCogc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpCi0gICAgewotICAgICAg ICByZXR1cm4gc3RhdGljX2Nhc3Q8V2ViRnJhbWVJbXBsKj4obV93ZWJWaWV3LT5tYWluRnJhbWUo KSktPmZyYW1lKCktPmRvY3VtZW50KCk7Ci0gICAgfQotCi1wcml2YXRlOgotICAgIFdlYlZpZXcq IG1fd2ViVmlldzsKLX07Ci0KLVRFU1RfRihJREJSZXF1ZXN0VGVzdCwgRXZlbnRzQWZ0ZXJTdG9w cGluZykKK1RFU1QoSURCUmVxdWVzdFRlc3QsIEV2ZW50c0FmdGVyU3RvcHBpbmcpCiB7Ci0gICAg djg6OkhhbmRsZVNjb3BlIGhhbmRsZVNjb3BlOwotICAgIHY4OjpDb250ZXh0OjpTY29wZSBzY29w ZShjb250ZXh0KCkpOwotCisgICAgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCA9IDA7 CiAgICAgSURCVHJhbnNhY3Rpb24qIHRyYW5zYWN0aW9uID0gMDsKLSAgICBSZWZQdHI8SURCUmVx dWVzdD4gcmVxdWVzdCA9IElEQlJlcXVlc3Q6OmNyZWF0ZShzY3JpcHRFeGVjdXRpb25Db250ZXh0 KCksIElEQkFueTo6Y3JlYXRlSW52YWxpZCgpLCB0cmFuc2FjdGlvbik7CisgICAgUmVmUHRyPElE QlJlcXVlc3Q+IHJlcXVlc3QgPSBJREJSZXF1ZXN0OjpjcmVhdGUoY29udGV4dCwgSURCQW55Ojpj cmVhdGVJbnZhbGlkKCksIHRyYW5zYWN0aW9uKTsKICAgICBFWFBFQ1RfRVEocmVxdWVzdC0+cmVh ZHlTdGF0ZSgpLCAicGVuZGluZyIpOwogICAgIHJlcXVlc3QtPnN0b3AoKTsKIApAQCAtMTAwLDEz ICs1OSwxMSBAQCBURVNUX0YoSURCUmVxdWVzdFRlc3QsIEV2ZW50c0FmdGVyU3RvcHBpbmcpCiAg ICAgcmVxdWVzdC0+b25TdWNjZXNzKElEQktleTo6Y3JlYXRlSW52YWxpZCgpLCBJREJLZXk6OmNy ZWF0ZUludmFsaWQoKSwgU2VyaWFsaXplZFNjcmlwdFZhbHVlOjpudWxsVmFsdWUoKSk7CiB9CiAK LVRFU1RfRihJREJSZXF1ZXN0VGVzdCwgQWJvcnRFcnJvckFmdGVyQWJvcnQpCitURVNUKElEQlJl cXVlc3RUZXN0LCBBYm9ydEVycm9yQWZ0ZXJBYm9ydCkKIHsKLSAgICB2ODo6SGFuZGxlU2NvcGUg aGFuZGxlU2NvcGU7Ci0gICAgdjg6OkNvbnRleHQ6OlNjb3BlIHNjb3BlKGNvbnRleHQoKSk7Ci0K KyAgICBTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0ID0gMDsKICAgICBJREJUcmFuc2Fj dGlvbiogdHJhbnNhY3Rpb24gPSAwOwotICAgIFJlZlB0cjxJREJSZXF1ZXN0PiByZXF1ZXN0ID0g SURCUmVxdWVzdDo6Y3JlYXRlKHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSwgSURCQW55OjpjcmVh dGVJbnZhbGlkKCksIHRyYW5zYWN0aW9uKTsKKyAgICBSZWZQdHI8SURCUmVxdWVzdD4gcmVxdWVz dCA9IElEQlJlcXVlc3Q6OmNyZWF0ZShjb250ZXh0LCBJREJBbnk6OmNyZWF0ZUludmFsaWQoKSwg dHJhbnNhY3Rpb24pOwogICAgIEVYUEVDVF9FUShyZXF1ZXN0LT5yZWFkeVN0YXRlKCksICJwZW5k aW5nIik7CiAKICAgICAvLyBTaW11bGF0ZSB0aGUgSURCVHJhbnNhY3Rpb24gaGF2aW5nIHJlY2Vp dmVkIG9uQWJvcnQgZnJvbSBiYWNrIGVuZCBhbmQgYWJvcnRpbmcgdGhlIHJlcXVlc3Q6Cg==