102946 2012-11-21 08:09:04 -0800 Source/WTF/wtf/Assertions.cpp: fix build on a uClibc system 2025-10-14 15:35:21 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=300701 https://bugs.webkit.org/show_bug.cgi?id=300735 https://bugs.gentoo.org/441674 P2 Normal --- 0 basile webkit-unassigned benjamin gnome ojan tony webkit.review.bot oldest_to_newest 772987 0 175450 basile 2012-11-21 08:09:04 -0800 Created attachment 175450 Refines the check for OS(LINUX) so that !defined(__UCLIBC__) webkit-gtk fails to build on a uClibc system because Assertions.cpp assumes that all Linux systems have execinfo.h and provide backtrace(). This is not necessarily the case for uClibc which can be configured without these. This patch refines the check for OS(LINUX) to prevent this breakage. Downstream bug: https://bugs.gentoo.org/441674 773098 1 175450 tony 2012-11-21 10:28:25 -0800 Comment on attachment 175450 Refines the check for OS(LINUX) so that !defined(__UCLIBC__) This patch is missing a ChangeLog. Please re-read http://www.webkit.org/coding/contributing.html . 773132 2 175488 basile 2012-11-21 11:22:17 -0800 Created attachment 175488 Refines the check for OS(LINUX) so that !defined(__UCLIBC__) This patch now includes the ChangeLog as produced by prepare-ChangeLog and edited according to http://www.webkit.org/coding/contributing.html#changelogs. 773135 3 175488 tony 2012-11-21 11:29:59 -0800 Comment on attachment 175488 Refines the check for OS(LINUX) so that !defined(__UCLIBC__) View in context: https://bugs.webkit.org/attachment.cgi?id=175488&action=review > Source/WTF/ChangeLog:13 > + Originally reported at https://bugs.gentoo.org/441673 Typo, this should be bug 441674. Please upload a new diff with this fixed. 773148 4 175492 basile 2012-11-21 11:42:31 -0800 Created attachment 175492 Refines the check for OS(LINUX) so that !defined(__UCLIBC__) Agh! Third times a charm? 773177 5 175492 webkit.review.bot 2012-11-21 12:24:59 -0800 Comment on attachment 175492 Refines the check for OS(LINUX) so that !defined(__UCLIBC__) Clearing flags on attachment: 175492 Committed r135425: <http://trac.webkit.org/changeset/135425> 773178 6 webkit.review.bot 2012-11-21 12:25:03 -0800 All reviewed patches have been landed. Closing bug. 175450 2012-11-21 08:09:04 -0800 2012-11-21 11:22:17 -0800 Refines the check for OS(LINUX) so that !defined(__UCLIBC__) 0001-Source-WTF-wtf-Assertions.cpp-fix-build-on-a-uClibc-.patch text/plain 1605 basile RnJvbSBkMmQyZmQ2MmVhYzI1NWQ4NzIzY2Q2YjkwMTVmNTYzMGFiMzZkYTRmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiQW50aG9ueSBHLiBCYXNpbGUiIDxibHVlbmVzc0BnZW50b28u b3JnPgpEYXRlOiBXZWQsIDIxIE5vdiAyMDEyIDEwOjU1OjE0IC0wNTAwClN1YmplY3Q6IFtQQVRD SF0gU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHA6IGZpeCBidWlsZCBvbiBhIHVDbGliYyBz eXN0ZW0KCndlYmtpdC1ndGsgZmFpbHMgdG8gYnVpbGQgb24gYSB1Q2xpYmMgc3lzdGVtIGJlY2F1 c2UgQXNzZXJ0aW9ucy5jcHAKYXNzdW1lcyB0aGF0IGFsbCBMaW51eCBzeXN0ZW1zIGhhdmUgZXhl Y2luZm8uaCBhbmQgcHJvdmlkZSBiYWNrdHJhY2UoKS4KVGhpcyBpcyBub3QgbmVjZXNzYXJpbHkg dGhlIGNhc2UgZm9yIHVDbGliYyB3aGljaCBjYW4gYmUgY29uZmlndXJlZAp3aXRob3V0IHRoZXNl LiAgVGhpcyBwYXRjaCByZWZpbmVzIHRoZSBjaGVjayBmb3IgT1MoTElOVVgpIHRvIHByZXZlbnQK dGhpcyBicmVha2FnZS4KClgtR2VudG9vLUJ1ZzogNDQxNjc0ClgtR2VudG9vLUJ1Zy1VUkw6IGh0 dHBzOi8vYnVncy5nZW50b28ub3JnLzQ0MTY3NApTaWduZWQtb2ZmLWJ5OiBBbnRob255IEcuIEJh c2lsZSA8Ymx1ZW5lc3NAZ2VudG9vLm9yZz4KLS0tCiBTb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25z LmNwcCB8ICAgIDQgKystLQogMSBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHAgYi9T b3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmNwcAppbmRleCAwNjQwYmM1Li5lZDQ4ZDgxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0 Zi9Bc3NlcnRpb25zLmNwcApAQCAtNTgsNyArNTgsNyBAQAogI2luY2x1ZGUgPHdpbmRvd3MuaD4K ICNlbmRpZgogCi0jaWYgKE9TKERBUldJTikgfHwgT1MoTElOVVgpKSAmJiAhT1MoQU5EUk9JRCkK KyNpZiAoT1MoREFSV0lOKSB8fCAoT1MoTElOVVgpICYmICFkZWZpbmVkKF9fVUNMSUJDX18pKSkg JiYgIU9TKEFORFJPSUQpCiAjaW5jbHVkZSA8Y3h4YWJpLmg+CiAjaW5jbHVkZSA8ZGxmY24uaD4K ICNpbmNsdWRlIDxleGVjaW5mby5oPgpAQCAtMjQyLDcgKzI0Miw3IEBAIHZvaWQgV1RGUmVwb3J0 QXJndW1lbnRBc3NlcnRpb25GYWlsdXJlKGNvbnN0IGNoYXIqIGZpbGUsIGludCBsaW5lLCBjb25z dCBjaGFyKiBmCiAKIHZvaWQgV1RGR2V0QmFja3RyYWNlKHZvaWQqKiBzdGFjaywgaW50KiBzaXpl KQogewotI2lmIChPUyhEQVJXSU4pIHx8IE9TKExJTlVYKSkgJiYgIU9TKEFORFJPSUQpCisjaWYg KE9TKERBUldJTikgfHwgKE9TKExJTlVYKSAmJiAhZGVmaW5lZChfX1VDTElCQ19fKSkpICYmICFP UyhBTkRST0lEKQogICAgICpzaXplID0gYmFja3RyYWNlKHN0YWNrLCAqc2l6ZSk7CiAjZWxpZiBP UyhXSU5ET1dTKSAmJiAhT1MoV0lOQ0UpCiAgICAgLy8gVGhlIENhcHR1cmVTdGFja0JhY2tUcmFj ZSBmdW5jdGlvbiBpcyBhdmFpbGFibGUgaW4gWFAsIGJ1dCBpdCBpcyBub3QgZGVmaW5lZAotLSAK MS43LjguNgoK 175488 2012-11-21 11:22:17 -0800 2012-11-21 11:42:31 -0800 Refines the check for OS(LINUX) so that !defined(__UCLIBC__) 0001-Source-WTF-wtf-Assertions.cpp-fix-build-on-a-uClibc-.patch text/plain 2575 basile RnJvbSAwMGRkNDU5ZjBmMGI1OWJmNTE0YzdkY2ZkMWY1NGFmY2VmOWJkNGQ0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiQW50aG9ueSBHLiBCYXNpbGUiIDxibHVlbmVzc0BnZW50b28u b3JnPgpEYXRlOiBXZWQsIDIxIE5vdiAyMDEyIDE0OjE1OjE2IC0wNTAwClN1YmplY3Q6IFtQQVRD SF0gU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHA6IGZpeCBidWlsZCBvbiBhIHVDbGliYyBz eXN0ZW0KCndlYmtpdC1ndGsgZmFpbHMgdG8gYnVpbGQgb24gYSB1Q2xpYmMgc3lzdGVtIGJlY2F1 c2UgQXNzZXJ0aW9ucy5jcHAKYXNzdW1lcyB0aGF0IGFsbCBMaW51eCBzeXN0ZW1zIGhhdmUgZXhl Y2luZm8uaCBhbmQgcHJvdmlkZSBiYWNrdHJhY2UoKS4KVGhpcyBpcyBub3QgbmVjZXNzYXJpbHkg dGhlIGNhc2UgZm9yIHVDbGliYyB3aGljaCBjYW4gYmUgY29uZmlndXJlZAp3aXRob3V0IHRoZXNl LiAgVGhpcyBwYXRjaCByZWZpbmVzIHRoZSBjaGVjayBmb3IgT1MoTElOVVgpIHRvIHByZXZlbnQK dGhpcyBicmVha2FnZS4KClgtR2VudG9vLUJ1ZzogNDQxNjc0ClgtR2VudG9vLUJ1Zy1VUkw6IGh0 dHBzOi8vYnVncy5nZW50b28ub3JnLzQ0MTY3NApTaWduZWQtb2ZmLWJ5OiBBbnRob255IEcuIEJh c2lsZSA8Ymx1ZW5lc3NAZ2VudG9vLm9yZz4KLS0tCiBTb3VyY2UvV1RGL0NoYW5nZUxvZyAgICAg ICAgICB8ICAgMTYgKysrKysrKysrKysrKysrKwogU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5j cHAgfCAgICA0ICsrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMiBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYv Q2hhbmdlTG9nCmluZGV4IDE2ZWQyZDkuLjI1MWFhMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIw MTItMTEtMjEgIEFudGhvbnkgRy4gQmFzaWxlICA8Ymx1ZW5lc3NAZ2VudG9vLm9yZz4KKworICAg ICAgICBTb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmNwcDogZml4IGJ1aWxkIG9uIGEgdUNsaWJj IHN5c3RlbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAyOTQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2Via2l0LUd0ayBmYWlscyB0byBidWlsZCBvbiBhIHVDbGliYyBzeXN0ZW0gYmVjYXVzZQorICAg ICAgICBBc3NlcnRpb25zLmNwcCBhc3N1bWVzIHRoYXQgYWxsIExpbnV4IHN5c3RlbXMgaGF2ZSBl eGVjaW5mby5oCisgICAgICAgIGFuZCBwcm92aWRlIGJhY2t0cmFjZSgpLiBUaGlzIGlzIG5vdCBu ZWNlc3NhcmlseSB0aGUgY2FzZSBmb3IKKyAgICAgICAgdUNsaWJjIHdoaWNoIGNhbiBiZSBjb25m aWd1cmVkIHdpdGhvdXQgdGhlc2UuICBUaGlzIHBhdGNoCisgICAgICAgIHJlZmluZXMgdGhlIGNo ZWNrIGZvciBPUyhMSU5VWCkgdG8gcHJldmVudCB0aGlzIGJyZWFrYWdlLgorICAgICAgICBPcmln aW5hbGx5IHJlcG9ydGVkIGF0IGh0dHBzOi8vYnVncy5nZW50b28ub3JnLzQ0MTY3MworCisgICAg ICAgICogd3RmL0Fzc2VydGlvbnMuY3BwOgorCiAyMDEyLTExLTE5ICBGaWxpcCBQaXpsbyAgPGZw aXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgREZHIHNob3VsZCBiZSBhYmxlIHRvIGNhY2hlIGNs b3N1cmUgY2FsbHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuY3BwIGIv U291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHAKaW5kZXggMDY0MGJjNS4uZWQ0OGQ4MSAxMDA2 NDQKLS0tIGEvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHAKKysrIGIvU291cmNlL1dURi93 dGYvQXNzZXJ0aW9ucy5jcHAKQEAgLTU4LDcgKzU4LDcgQEAKICNpbmNsdWRlIDx3aW5kb3dzLmg+ CiAjZW5kaWYKIAotI2lmIChPUyhEQVJXSU4pIHx8IE9TKExJTlVYKSkgJiYgIU9TKEFORFJPSUQp CisjaWYgKE9TKERBUldJTikgfHwgKE9TKExJTlVYKSAmJiAhZGVmaW5lZChfX1VDTElCQ19fKSkp ICYmICFPUyhBTkRST0lEKQogI2luY2x1ZGUgPGN4eGFiaS5oPgogI2luY2x1ZGUgPGRsZmNuLmg+ CiAjaW5jbHVkZSA8ZXhlY2luZm8uaD4KQEAgLTI0Miw3ICsyNDIsNyBAQCB2b2lkIFdURlJlcG9y dEFyZ3VtZW50QXNzZXJ0aW9uRmFpbHVyZShjb25zdCBjaGFyKiBmaWxlLCBpbnQgbGluZSwgY29u c3QgY2hhciogZgogCiB2b2lkIFdURkdldEJhY2t0cmFjZSh2b2lkKiogc3RhY2ssIGludCogc2l6 ZSkKIHsKLSNpZiAoT1MoREFSV0lOKSB8fCBPUyhMSU5VWCkpICYmICFPUyhBTkRST0lEKQorI2lm IChPUyhEQVJXSU4pIHx8IChPUyhMSU5VWCkgJiYgIWRlZmluZWQoX19VQ0xJQkNfXykpKSAmJiAh T1MoQU5EUk9JRCkKICAgICAqc2l6ZSA9IGJhY2t0cmFjZShzdGFjaywgKnNpemUpOwogI2VsaWYg T1MoV0lORE9XUykgJiYgIU9TKFdJTkNFKQogICAgIC8vIFRoZSBDYXB0dXJlU3RhY2tCYWNrVHJh Y2UgZnVuY3Rpb24gaXMgYXZhaWxhYmxlIGluIFhQLCBidXQgaXQgaXMgbm90IGRlZmluZWQKLS0g CjEuNy44LjYKCg== 175492 2012-11-21 11:42:31 -0800 2012-11-21 12:24:59 -0800 Refines the check for OS(LINUX) so that !defined(__UCLIBC__) 0001-Source-WTF-wtf-Assertions.cpp-fix-build-on-a-uClibc-.patch text/plain 2575 basile RnJvbSAwMGRkNDU5ZjBmMGI1OWJmNTE0YzdkY2ZkMWY1NGFmY2VmOWJkNGQ0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiQW50aG9ueSBHLiBCYXNpbGUiIDxibHVlbmVzc0BnZW50b28u b3JnPgpEYXRlOiBXZWQsIDIxIE5vdiAyMDEyIDE0OjE1OjE2IC0wNTAwClN1YmplY3Q6IFtQQVRD SF0gU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHA6IGZpeCBidWlsZCBvbiBhIHVDbGliYyBz eXN0ZW0KCndlYmtpdC1ndGsgZmFpbHMgdG8gYnVpbGQgb24gYSB1Q2xpYmMgc3lzdGVtIGJlY2F1 c2UgQXNzZXJ0aW9ucy5jcHAKYXNzdW1lcyB0aGF0IGFsbCBMaW51eCBzeXN0ZW1zIGhhdmUgZXhl Y2luZm8uaCBhbmQgcHJvdmlkZSBiYWNrdHJhY2UoKS4KVGhpcyBpcyBub3QgbmVjZXNzYXJpbHkg dGhlIGNhc2UgZm9yIHVDbGliYyB3aGljaCBjYW4gYmUgY29uZmlndXJlZAp3aXRob3V0IHRoZXNl LiAgVGhpcyBwYXRjaCByZWZpbmVzIHRoZSBjaGVjayBmb3IgT1MoTElOVVgpIHRvIHByZXZlbnQK dGhpcyBicmVha2FnZS4KClgtR2VudG9vLUJ1ZzogNDQxNjc0ClgtR2VudG9vLUJ1Zy1VUkw6IGh0 dHBzOi8vYnVncy5nZW50b28ub3JnLzQ0MTY3NApTaWduZWQtb2ZmLWJ5OiBBbnRob255IEcuIEJh c2lsZSA8Ymx1ZW5lc3NAZ2VudG9vLm9yZz4KLS0tCiBTb3VyY2UvV1RGL0NoYW5nZUxvZyAgICAg ICAgICB8ICAgMTYgKysrKysrKysrKysrKysrKwogU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5j cHAgfCAgICA0ICsrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMiBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYv Q2hhbmdlTG9nCmluZGV4IDE2ZWQyZDkuLjI1MWFhMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIw MTItMTEtMjEgIEFudGhvbnkgRy4gQmFzaWxlICA8Ymx1ZW5lc3NAZ2VudG9vLm9yZz4KKworICAg ICAgICBTb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmNwcDogZml4IGJ1aWxkIG9uIGEgdUNsaWJj IHN5c3RlbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAyOTQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2Via2l0LUd0ayBmYWlscyB0byBidWlsZCBvbiBhIHVDbGliYyBzeXN0ZW0gYmVjYXVzZQorICAg ICAgICBBc3NlcnRpb25zLmNwcCBhc3N1bWVzIHRoYXQgYWxsIExpbnV4IHN5c3RlbXMgaGF2ZSBl eGVjaW5mby5oCisgICAgICAgIGFuZCBwcm92aWRlIGJhY2t0cmFjZSgpLiBUaGlzIGlzIG5vdCBu ZWNlc3NhcmlseSB0aGUgY2FzZSBmb3IKKyAgICAgICAgdUNsaWJjIHdoaWNoIGNhbiBiZSBjb25m aWd1cmVkIHdpdGhvdXQgdGhlc2UuICBUaGlzIHBhdGNoCisgICAgICAgIHJlZmluZXMgdGhlIGNo ZWNrIGZvciBPUyhMSU5VWCkgdG8gcHJldmVudCB0aGlzIGJyZWFrYWdlLgorICAgICAgICBPcmln aW5hbGx5IHJlcG9ydGVkIGF0IGh0dHBzOi8vYnVncy5nZW50b28ub3JnLzQ0MTY3NAorCisgICAg ICAgICogd3RmL0Fzc2VydGlvbnMuY3BwOgorCiAyMDEyLTExLTE5ICBGaWxpcCBQaXpsbyAgPGZw aXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgREZHIHNob3VsZCBiZSBhYmxlIHRvIGNhY2hlIGNs b3N1cmUgY2FsbHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuY3BwIGIv U291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHAKaW5kZXggMDY0MGJjNS4uZWQ0OGQ4MSAxMDA2 NDQKLS0tIGEvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHAKKysrIGIvU291cmNlL1dURi93 dGYvQXNzZXJ0aW9ucy5jcHAKQEAgLTU4LDcgKzU4LDcgQEAKICNpbmNsdWRlIDx3aW5kb3dzLmg+ CiAjZW5kaWYKIAotI2lmIChPUyhEQVJXSU4pIHx8IE9TKExJTlVYKSkgJiYgIU9TKEFORFJPSUQp CisjaWYgKE9TKERBUldJTikgfHwgKE9TKExJTlVYKSAmJiAhZGVmaW5lZChfX1VDTElCQ19fKSkp ICYmICFPUyhBTkRST0lEKQogI2luY2x1ZGUgPGN4eGFiaS5oPgogI2luY2x1ZGUgPGRsZmNuLmg+ CiAjaW5jbHVkZSA8ZXhlY2luZm8uaD4KQEAgLTI0Miw3ICsyNDIsNyBAQCB2b2lkIFdURlJlcG9y dEFyZ3VtZW50QXNzZXJ0aW9uRmFpbHVyZShjb25zdCBjaGFyKiBmaWxlLCBpbnQgbGluZSwgY29u c3QgY2hhciogZgogCiB2b2lkIFdURkdldEJhY2t0cmFjZSh2b2lkKiogc3RhY2ssIGludCogc2l6 ZSkKIHsKLSNpZiAoT1MoREFSV0lOKSB8fCBPUyhMSU5VWCkpICYmICFPUyhBTkRST0lEKQorI2lm IChPUyhEQVJXSU4pIHx8IChPUyhMSU5VWCkgJiYgIWRlZmluZWQoX19VQ0xJQkNfXykpKSAmJiAh T1MoQU5EUk9JRCkKICAgICAqc2l6ZSA9IGJhY2t0cmFjZShzdGFjaywgKnNpemUpOwogI2VsaWYg T1MoV0lORE9XUykgJiYgIU9TKFdJTkNFKQogICAgIC8vIFRoZSBDYXB0dXJlU3RhY2tCYWNrVHJh Y2UgZnVuY3Rpb24gaXMgYXZhaWxhYmxlIGluIFhQLCBidXQgaXQgaXMgbm90IGRlZmluZWQKLS0g CjEuNy44LjYKCg==