102945 2012-11-21 08:06:57 -0800 Path::addBeziersForRoundedRect can emit degenerate cubics 2012-11-22 02:52:51 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tomhudson tomhudson jianli senorblanco webkit.review.bot oldest_to_newest 772985 0 tomhudson 2012-11-21 08:06:57 -0800 Path::addBeziersForRoundedRect calls addBezierCurveTo(), even for corners where both radii are 0. This is easy to suppress, and the resulting partially-round rects are still correct. 772988 1 175451 tomhudson 2012-11-21 08:09:20 -0800 Created attachment 175451 Patch 772995 2 175451 senorblanco 2012-11-21 08:21:52 -0800 Comment on attachment 175451 Patch Looks fine (although this code could use some refactoring). Please add a line to the ChangeLog about test coverage on landing. r=me 772997 3 175453 tomhudson 2012-11-21 08:25:39 -0800 Created attachment 175453 Patch for landing 773026 4 175453 webkit.review.bot 2012-11-21 09:28:46 -0800 Comment on attachment 175453 Patch for landing Clearing flags on attachment: 175453 Committed r135411: <http://trac.webkit.org/changeset/135411> 773027 5 webkit.review.bot 2012-11-21 09:28:49 -0800 All reviewed patches have been landed. Closing bug. 773161 6 jianli 2012-11-21 12:00:39 -0800 There're quite a few test failures caused by this patch. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fframes%2FonlyCommentInIFrame.html%2Cfast%2Fframes%2Fvalid.html%2Cfast%2Fframes%2Fiframe-scaling-with-scroll.html%2Cfast%2Fframes%2Fiframe-scrolling-attribute.html 773172 7 senorblanco 2012-11-21 12:14:31 -0800 I'm seeing flakiness in scrollbars on Mac 10.7 Debug. If it's just a few tests, I'd say don't roll it out just now. My suspicion is that the patch didn't introduce new flakiness, just moved it around between tests. 773774 8 tomhudson 2012-11-22 02:52:51 -0800 (In reply to comment #6) > There're quite a few test failures caused by this patch. > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fframes%2FonlyCommentInIFrame.html%2Cfast%2Fframes%2Fvalid.html%2Cfast%2Fframes%2Fiframe-scaling-with-scroll.html%2Cfast%2Fframes%2Fiframe-scrolling-attribute.html I'm not sure why you're pointing at this patch; it looks to me like those have been quite flaky ever since WebKit r135309. 175451 2012-11-21 08:09:20 -0800 2012-11-21 08:25:35 -0800 Patch bug-102945-20121121160707.patch text/plain 3949 tomhudson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNTM5MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTExLTIxICBUb20gSHVk c29uICA8dG9taHVkc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBBdm9pZCBjcmVhdGluZyBk ZWdlbmVyYXRlIGN1YmljcyBhdCBjb3JuZXJzIG9mIHJvdW5kZWQgcmVjdHMuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI5NDUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9QYXRoLmNw cDoKKyAgICAgICAgKFBhdGg6OmFkZEJlemllcnNGb3JSb3VuZGVkUmVjdCk6CisKIDIwMTItMTEt MjEgIEZsb3JpbiBNYWxpdGEgIDxmbWFsaXRhQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hy b21pdW1dIFVucmV2aWV3ZWQgTWFjIGJ1aWxkIGZpeCBhZnRlciBodHRwOi8vdHJhYy53ZWJraXQu b3JnL2NoYW5nZXNldC8xMzUzOTAuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9QYXRoLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9QYXRoLmNwcAkocmV2aXNpb24gMTM1MzkzKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvUGF0aC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2NSwyMSArMTY1LDI1IEBA IHZvaWQgUGF0aDo6YWRkQmV6aWVyc0ZvclJvdW5kZWRSZWN0KGNvbnMKICAgICBtb3ZlVG8oRmxv YXRQb2ludChyZWN0LngoKSArIHRvcExlZnRSYWRpdXMud2lkdGgoKSwgcmVjdC55KCkpKTsKIAog ICAgIGFkZExpbmVUbyhGbG9hdFBvaW50KHJlY3QubWF4WCgpIC0gdG9wUmlnaHRSYWRpdXMud2lk dGgoKSwgcmVjdC55KCkpKTsKLSAgICBhZGRCZXppZXJDdXJ2ZVRvKEZsb2F0UG9pbnQocmVjdC5t YXhYKCkgLSB0b3BSaWdodFJhZGl1cy53aWR0aCgpICogZ0NpcmNsZUNvbnRyb2xQb2ludCwgcmVj dC55KCkpLAotICAgICAgICAgICAgICAgICAgICAgRmxvYXRQb2ludChyZWN0Lm1heFgoKSwgcmVj dC55KCkgKyB0b3BSaWdodFJhZGl1cy5oZWlnaHQoKSAqIGdDaXJjbGVDb250cm9sUG9pbnQpLAot ICAgICAgICAgICAgICAgICAgICAgRmxvYXRQb2ludChyZWN0Lm1heFgoKSwgcmVjdC55KCkgKyB0 b3BSaWdodFJhZGl1cy5oZWlnaHQoKSkpOworICAgIGlmICh0b3BSaWdodFJhZGl1cy53aWR0aCgp ID4gMCB8fCB0b3BSaWdodFJhZGl1cy5oZWlnaHQoKSA+IDApCisgICAgICAgIGFkZEJlemllckN1 cnZlVG8oRmxvYXRQb2ludChyZWN0Lm1heFgoKSAtIHRvcFJpZ2h0UmFkaXVzLndpZHRoKCkgKiBn Q2lyY2xlQ29udHJvbFBvaW50LCByZWN0LnkoKSksCisgICAgICAgICAgICBGbG9hdFBvaW50KHJl Y3QubWF4WCgpLCByZWN0LnkoKSArIHRvcFJpZ2h0UmFkaXVzLmhlaWdodCgpICogZ0NpcmNsZUNv bnRyb2xQb2ludCksCisgICAgICAgICAgICBGbG9hdFBvaW50KHJlY3QubWF4WCgpLCByZWN0Lnko KSArIHRvcFJpZ2h0UmFkaXVzLmhlaWdodCgpKSk7CiAgICAgYWRkTGluZVRvKEZsb2F0UG9pbnQo cmVjdC5tYXhYKCksIHJlY3QubWF4WSgpIC0gYm90dG9tUmlnaHRSYWRpdXMuaGVpZ2h0KCkpKTsK LSAgICBhZGRCZXppZXJDdXJ2ZVRvKEZsb2F0UG9pbnQocmVjdC5tYXhYKCksIHJlY3QubWF4WSgp IC0gYm90dG9tUmlnaHRSYWRpdXMuaGVpZ2h0KCkgKiBnQ2lyY2xlQ29udHJvbFBvaW50KSwKLSAg ICAgICAgICAgICAgICAgICAgIEZsb2F0UG9pbnQocmVjdC5tYXhYKCkgLSBib3R0b21SaWdodFJh ZGl1cy53aWR0aCgpICogZ0NpcmNsZUNvbnRyb2xQb2ludCwgcmVjdC5tYXhZKCkpLAotICAgICAg ICAgICAgICAgICAgICAgRmxvYXRQb2ludChyZWN0Lm1heFgoKSAtIGJvdHRvbVJpZ2h0UmFkaXVz LndpZHRoKCksIHJlY3QubWF4WSgpKSk7CisgICAgaWYgKGJvdHRvbVJpZ2h0UmFkaXVzLndpZHRo KCkgPiAwIHx8IGJvdHRvbVJpZ2h0UmFkaXVzLmhlaWdodCgpID4gMCkKKyAgICAgICAgYWRkQmV6 aWVyQ3VydmVUbyhGbG9hdFBvaW50KHJlY3QubWF4WCgpLCByZWN0Lm1heFkoKSAtIGJvdHRvbVJp Z2h0UmFkaXVzLmhlaWdodCgpICogZ0NpcmNsZUNvbnRyb2xQb2ludCksCisgICAgICAgICAgICBG bG9hdFBvaW50KHJlY3QubWF4WCgpIC0gYm90dG9tUmlnaHRSYWRpdXMud2lkdGgoKSAqIGdDaXJj bGVDb250cm9sUG9pbnQsIHJlY3QubWF4WSgpKSwKKyAgICAgICAgICAgIEZsb2F0UG9pbnQocmVj dC5tYXhYKCkgLSBib3R0b21SaWdodFJhZGl1cy53aWR0aCgpLCByZWN0Lm1heFkoKSkpOwogICAg IGFkZExpbmVUbyhGbG9hdFBvaW50KHJlY3QueCgpICsgYm90dG9tTGVmdFJhZGl1cy53aWR0aCgp LCByZWN0Lm1heFkoKSkpOwotICAgIGFkZEJlemllckN1cnZlVG8oRmxvYXRQb2ludChyZWN0Lngo KSArIGJvdHRvbUxlZnRSYWRpdXMud2lkdGgoKSAqIGdDaXJjbGVDb250cm9sUG9pbnQsIHJlY3Qu bWF4WSgpKSwKLSAgICAgICAgICAgICAgICAgICAgIEZsb2F0UG9pbnQocmVjdC54KCksIHJlY3Qu bWF4WSgpIC0gYm90dG9tTGVmdFJhZGl1cy5oZWlnaHQoKSAqIGdDaXJjbGVDb250cm9sUG9pbnQp LAotICAgICAgICAgICAgICAgICAgICAgRmxvYXRQb2ludChyZWN0LngoKSwgcmVjdC5tYXhZKCkg LSBib3R0b21MZWZ0UmFkaXVzLmhlaWdodCgpKSk7CisgICAgaWYgKGJvdHRvbUxlZnRSYWRpdXMu d2lkdGgoKSA+IDAgfHwgYm90dG9tTGVmdFJhZGl1cy5oZWlnaHQoKSA+IDApCisgICAgICAgIGFk ZEJlemllckN1cnZlVG8oRmxvYXRQb2ludChyZWN0LngoKSArIGJvdHRvbUxlZnRSYWRpdXMud2lk dGgoKSAqIGdDaXJjbGVDb250cm9sUG9pbnQsIHJlY3QubWF4WSgpKSwKKyAgICAgICAgICAgIEZs b2F0UG9pbnQocmVjdC54KCksIHJlY3QubWF4WSgpIC0gYm90dG9tTGVmdFJhZGl1cy5oZWlnaHQo KSAqIGdDaXJjbGVDb250cm9sUG9pbnQpLAorICAgICAgICAgICAgRmxvYXRQb2ludChyZWN0Lngo KSwgcmVjdC5tYXhZKCkgLSBib3R0b21MZWZ0UmFkaXVzLmhlaWdodCgpKSk7CiAgICAgYWRkTGlu ZVRvKEZsb2F0UG9pbnQocmVjdC54KCksIHJlY3QueSgpICsgdG9wTGVmdFJhZGl1cy5oZWlnaHQo KSkpOwotICAgIGFkZEJlemllckN1cnZlVG8oRmxvYXRQb2ludChyZWN0LngoKSwgcmVjdC55KCkg KyB0b3BMZWZ0UmFkaXVzLmhlaWdodCgpICogZ0NpcmNsZUNvbnRyb2xQb2ludCksCi0gICAgICAg ICAgICAgICAgICAgICBGbG9hdFBvaW50KHJlY3QueCgpICsgdG9wTGVmdFJhZGl1cy53aWR0aCgp ICogZ0NpcmNsZUNvbnRyb2xQb2ludCwgcmVjdC55KCkpLAotICAgICAgICAgICAgICAgICAgICAg RmxvYXRQb2ludChyZWN0LngoKSArIHRvcExlZnRSYWRpdXMud2lkdGgoKSwgcmVjdC55KCkpKTsK KyAgICBpZiAodG9wTGVmdFJhZGl1cy53aWR0aCgpID4gMCB8fCB0b3BMZWZ0UmFkaXVzLmhlaWdo dCgpID4gMCkKKyAgICAgICAgYWRkQmV6aWVyQ3VydmVUbyhGbG9hdFBvaW50KHJlY3QueCgpLCBy ZWN0LnkoKSArIHRvcExlZnRSYWRpdXMuaGVpZ2h0KCkgKiBnQ2lyY2xlQ29udHJvbFBvaW50KSwK KyAgICAgICAgICAgIEZsb2F0UG9pbnQocmVjdC54KCkgKyB0b3BMZWZ0UmFkaXVzLndpZHRoKCkg KiBnQ2lyY2xlQ29udHJvbFBvaW50LCByZWN0LnkoKSksCisgICAgICAgICAgICBGbG9hdFBvaW50 KHJlY3QueCgpICsgdG9wTGVmdFJhZGl1cy53aWR0aCgpLCByZWN0LnkoKSkpOwogCiAgICAgY2xv c2VTdWJwYXRoKCk7CiB9Cg== 175453 2012-11-21 08:25:39 -0800 2012-11-21 09:28:46 -0800 Patch for landing bug-102945-20121121162326.patch text/plain 4001 tomhudson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNTM5MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTIxICBUb20gSHVk c29uICA8dG9taHVkc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBBdm9pZCBjcmVhdGluZyBk ZWdlbmVyYXRlIGN1YmljcyBhdCBjb3JuZXJzIG9mIHJvdW5kZWQgcmVjdHMuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI5NDUKKworICAgICAgICBS ZXZpZXdlZCBieSBTdGVwaGVuIFdoaXRlLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3Rpbmcg bGF5b3V0IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvUGF0aC5jcHA6Cisg ICAgICAgIChQYXRoOjphZGRCZXppZXJzRm9yUm91bmRlZFJlY3QpOgorCiAyMDEyLTExLTIxICBG bG9yaW4gTWFsaXRhICA8Zm1hbGl0YUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVt XSBVbnJldmlld2VkIE1hYyBidWlsZCBmaXggYWZ0ZXIgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9j aGFuZ2VzZXQvMTM1MzkwLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv UGF0aC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv UGF0aC5jcHAJKHJldmlzaW9uIDEzNTM5MykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL1BhdGguY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjUsMjEgKzE2NSwyNSBAQCB2b2lk IFBhdGg6OmFkZEJlemllcnNGb3JSb3VuZGVkUmVjdChjb25zCiAgICAgbW92ZVRvKEZsb2F0UG9p bnQocmVjdC54KCkgKyB0b3BMZWZ0UmFkaXVzLndpZHRoKCksIHJlY3QueSgpKSk7CiAKICAgICBh ZGRMaW5lVG8oRmxvYXRQb2ludChyZWN0Lm1heFgoKSAtIHRvcFJpZ2h0UmFkaXVzLndpZHRoKCks IHJlY3QueSgpKSk7Ci0gICAgYWRkQmV6aWVyQ3VydmVUbyhGbG9hdFBvaW50KHJlY3QubWF4WCgp IC0gdG9wUmlnaHRSYWRpdXMud2lkdGgoKSAqIGdDaXJjbGVDb250cm9sUG9pbnQsIHJlY3QueSgp KSwKLSAgICAgICAgICAgICAgICAgICAgIEZsb2F0UG9pbnQocmVjdC5tYXhYKCksIHJlY3QueSgp ICsgdG9wUmlnaHRSYWRpdXMuaGVpZ2h0KCkgKiBnQ2lyY2xlQ29udHJvbFBvaW50KSwKLSAgICAg ICAgICAgICAgICAgICAgIEZsb2F0UG9pbnQocmVjdC5tYXhYKCksIHJlY3QueSgpICsgdG9wUmln aHRSYWRpdXMuaGVpZ2h0KCkpKTsKKyAgICBpZiAodG9wUmlnaHRSYWRpdXMud2lkdGgoKSA+IDAg fHwgdG9wUmlnaHRSYWRpdXMuaGVpZ2h0KCkgPiAwKQorICAgICAgICBhZGRCZXppZXJDdXJ2ZVRv KEZsb2F0UG9pbnQocmVjdC5tYXhYKCkgLSB0b3BSaWdodFJhZGl1cy53aWR0aCgpICogZ0NpcmNs ZUNvbnRyb2xQb2ludCwgcmVjdC55KCkpLAorICAgICAgICAgICAgRmxvYXRQb2ludChyZWN0Lm1h eFgoKSwgcmVjdC55KCkgKyB0b3BSaWdodFJhZGl1cy5oZWlnaHQoKSAqIGdDaXJjbGVDb250cm9s UG9pbnQpLAorICAgICAgICAgICAgRmxvYXRQb2ludChyZWN0Lm1heFgoKSwgcmVjdC55KCkgKyB0 b3BSaWdodFJhZGl1cy5oZWlnaHQoKSkpOwogICAgIGFkZExpbmVUbyhGbG9hdFBvaW50KHJlY3Qu bWF4WCgpLCByZWN0Lm1heFkoKSAtIGJvdHRvbVJpZ2h0UmFkaXVzLmhlaWdodCgpKSk7Ci0gICAg YWRkQmV6aWVyQ3VydmVUbyhGbG9hdFBvaW50KHJlY3QubWF4WCgpLCByZWN0Lm1heFkoKSAtIGJv dHRvbVJpZ2h0UmFkaXVzLmhlaWdodCgpICogZ0NpcmNsZUNvbnRyb2xQb2ludCksCi0gICAgICAg ICAgICAgICAgICAgICBGbG9hdFBvaW50KHJlY3QubWF4WCgpIC0gYm90dG9tUmlnaHRSYWRpdXMu d2lkdGgoKSAqIGdDaXJjbGVDb250cm9sUG9pbnQsIHJlY3QubWF4WSgpKSwKLSAgICAgICAgICAg ICAgICAgICAgIEZsb2F0UG9pbnQocmVjdC5tYXhYKCkgLSBib3R0b21SaWdodFJhZGl1cy53aWR0 aCgpLCByZWN0Lm1heFkoKSkpOworICAgIGlmIChib3R0b21SaWdodFJhZGl1cy53aWR0aCgpID4g MCB8fCBib3R0b21SaWdodFJhZGl1cy5oZWlnaHQoKSA+IDApCisgICAgICAgIGFkZEJlemllckN1 cnZlVG8oRmxvYXRQb2ludChyZWN0Lm1heFgoKSwgcmVjdC5tYXhZKCkgLSBib3R0b21SaWdodFJh ZGl1cy5oZWlnaHQoKSAqIGdDaXJjbGVDb250cm9sUG9pbnQpLAorICAgICAgICAgICAgRmxvYXRQ b2ludChyZWN0Lm1heFgoKSAtIGJvdHRvbVJpZ2h0UmFkaXVzLndpZHRoKCkgKiBnQ2lyY2xlQ29u dHJvbFBvaW50LCByZWN0Lm1heFkoKSksCisgICAgICAgICAgICBGbG9hdFBvaW50KHJlY3QubWF4 WCgpIC0gYm90dG9tUmlnaHRSYWRpdXMud2lkdGgoKSwgcmVjdC5tYXhZKCkpKTsKICAgICBhZGRM aW5lVG8oRmxvYXRQb2ludChyZWN0LngoKSArIGJvdHRvbUxlZnRSYWRpdXMud2lkdGgoKSwgcmVj dC5tYXhZKCkpKTsKLSAgICBhZGRCZXppZXJDdXJ2ZVRvKEZsb2F0UG9pbnQocmVjdC54KCkgKyBi b3R0b21MZWZ0UmFkaXVzLndpZHRoKCkgKiBnQ2lyY2xlQ29udHJvbFBvaW50LCByZWN0Lm1heFko KSksCi0gICAgICAgICAgICAgICAgICAgICBGbG9hdFBvaW50KHJlY3QueCgpLCByZWN0Lm1heFko KSAtIGJvdHRvbUxlZnRSYWRpdXMuaGVpZ2h0KCkgKiBnQ2lyY2xlQ29udHJvbFBvaW50KSwKLSAg ICAgICAgICAgICAgICAgICAgIEZsb2F0UG9pbnQocmVjdC54KCksIHJlY3QubWF4WSgpIC0gYm90 dG9tTGVmdFJhZGl1cy5oZWlnaHQoKSkpOworICAgIGlmIChib3R0b21MZWZ0UmFkaXVzLndpZHRo KCkgPiAwIHx8IGJvdHRvbUxlZnRSYWRpdXMuaGVpZ2h0KCkgPiAwKQorICAgICAgICBhZGRCZXpp ZXJDdXJ2ZVRvKEZsb2F0UG9pbnQocmVjdC54KCkgKyBib3R0b21MZWZ0UmFkaXVzLndpZHRoKCkg KiBnQ2lyY2xlQ29udHJvbFBvaW50LCByZWN0Lm1heFkoKSksCisgICAgICAgICAgICBGbG9hdFBv aW50KHJlY3QueCgpLCByZWN0Lm1heFkoKSAtIGJvdHRvbUxlZnRSYWRpdXMuaGVpZ2h0KCkgKiBn Q2lyY2xlQ29udHJvbFBvaW50KSwKKyAgICAgICAgICAgIEZsb2F0UG9pbnQocmVjdC54KCksIHJl Y3QubWF4WSgpIC0gYm90dG9tTGVmdFJhZGl1cy5oZWlnaHQoKSkpOwogICAgIGFkZExpbmVUbyhG bG9hdFBvaW50KHJlY3QueCgpLCByZWN0LnkoKSArIHRvcExlZnRSYWRpdXMuaGVpZ2h0KCkpKTsK LSAgICBhZGRCZXppZXJDdXJ2ZVRvKEZsb2F0UG9pbnQocmVjdC54KCksIHJlY3QueSgpICsgdG9w TGVmdFJhZGl1cy5oZWlnaHQoKSAqIGdDaXJjbGVDb250cm9sUG9pbnQpLAotICAgICAgICAgICAg ICAgICAgICAgRmxvYXRQb2ludChyZWN0LngoKSArIHRvcExlZnRSYWRpdXMud2lkdGgoKSAqIGdD aXJjbGVDb250cm9sUG9pbnQsIHJlY3QueSgpKSwKLSAgICAgICAgICAgICAgICAgICAgIEZsb2F0 UG9pbnQocmVjdC54KCkgKyB0b3BMZWZ0UmFkaXVzLndpZHRoKCksIHJlY3QueSgpKSk7CisgICAg aWYgKHRvcExlZnRSYWRpdXMud2lkdGgoKSA+IDAgfHwgdG9wTGVmdFJhZGl1cy5oZWlnaHQoKSA+ IDApCisgICAgICAgIGFkZEJlemllckN1cnZlVG8oRmxvYXRQb2ludChyZWN0LngoKSwgcmVjdC55 KCkgKyB0b3BMZWZ0UmFkaXVzLmhlaWdodCgpICogZ0NpcmNsZUNvbnRyb2xQb2ludCksCisgICAg ICAgICAgICBGbG9hdFBvaW50KHJlY3QueCgpICsgdG9wTGVmdFJhZGl1cy53aWR0aCgpICogZ0Np cmNsZUNvbnRyb2xQb2ludCwgcmVjdC55KCkpLAorICAgICAgICAgICAgRmxvYXRQb2ludChyZWN0 LngoKSArIHRvcExlZnRSYWRpdXMud2lkdGgoKSwgcmVjdC55KCkpKTsKIAogICAgIGNsb3NlU3Vi cGF0aCgpOwogfQo=