102942 2012-11-21 07:34:14 -0800 [Qt] Compiling against QtWebkit API requires QT_DLL to be defined 2022-02-28 04:05:43 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76773 1 hausmann hausmann abecsi jturcotte vestbo webkit.review.bot oldest_to_newest 772957 0 hausmann 2012-11-21 07:34:14 -0800 The fact that QT_DLL is required for the correct import/export macros breaks the build of applications against QtWebKit when using cmake. See also https://bugreports.qt-project.org/browse/QTBUG-28043 772964 1 175445 hausmann 2012-11-21 07:44:28 -0800 Created attachment 175445 Patch 772993 2 175445 vestbo 2012-11-21 08:17:31 -0800 Comment on attachment 175445 Patch lgtm 774374 3 hausmann 2012-11-23 03:30:35 -0800 Committed r135585: <http://trac.webkit.org/changeset/135585> 175445 2012-11-21 07:44:28 -0800 2022-02-28 04:05:43 -0800 Patch bug-102942-20121121164318.patch text/plain 4573 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NDA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDE3MDY1NzM0ZjRk ZWIwZWJmNzgxYjY0MjhhZWExMTdjOTE2NzE4MDUuLjYxNDlmMTU1YWRlODA4YjY3NDU2YWUzMmI2 YTk4OTFhMGVlMzI0OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMTEt MjEgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5AZGlnaWEuY29tPgorCisgICAgICAg IFtRdF0gQ29tcGlsaW5nIGFnYWluc3QgUXRXZWJraXQgQVBJIHJlcXVpcmVzIFFUX0RMTCB0byBi ZSBkZWZpbmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDI5NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZW1vdmUgdGhlIHJlcXVpcmVtZW50IG9mIGhhdmluZyBRVF9ETEwgZGVmaW5lZCBpbiBvcmRl ciBmb3IgdGhlIFFXRUJLSVRfRVhQT1JUCisgICAgICAgIG1hY3JvIHRvIGJlIGRlZmluZWQgYXMg UV9ERUNMX0lNUE9SVC4gSW5zdGVhZCB1bmlmeSB0aGUgZXhwb3J0IG1hY3JvIGRlZmluaXRpb24K KyAgICAgICAgdG8gZm9sbG93IHRoZSBzYW1lIHJ1bGVzIGFzIG90aGVyIFF0IDUgbW9kdWxlcywg d2l0aCB0aGUgZXhjZXB0aW9uIHRoYXQgaW5zdGVhZCBvZgorICAgICAgICBRVF9CVUlMRF9XRUJL SVRfTElCIHdlIGNvbnRpbnVlIHRvIHVzZSBCVUlMRElOR19XRUJLSVQsIGJlY2F1c2UgdGhhdCdz IHVzZWQgYWxzbworICAgICAgICBpbiBvdGhlciBjcm9zcy1wbGF0Zm9ybSBoZWFkZXIgZmlsZXMg dG8gZGV0ZXJtaW5lIHRoZSBjb3JyZWN0IG1lYW5pbmcgb2YgZXhwb3J0CisgICAgICAgIG1hY3Jv cy4KKworICAgICAgICAqIEFwaS9xd2Via2l0Z2xvYmFsLmg6CisKIDIwMTItMTEtMjAgIFNoZXJp ZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHIxMzUyOTUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L0Fw aS9xd2Via2l0Z2xvYmFsLmggYi9Tb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2Via2l0Z2xvYmFsLmgK aW5kZXggN2VlNTZkZTg2YzIxOThjNzM5OTMwMTZmMmVlODY3NmQ4NmM0NDUzNi4uOTQ3YmEwNjU0 M2RmNzkzZDhlNTk1MGZkNzA1ODAzYjY1MmNmYzU4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9xdC9BcGkvcXdlYmtpdGdsb2JhbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJr aXRnbG9iYWwuaApAQCAtMjgsMjIgKzI4LDE0IEBACiAvLyBVc2U6ICNpZiAoUVRXRUJLSVRfVkVS U0lPTiA+PSBRVFdFQktJVF9WRVJTSU9OX0NIRUNLKDIsIDAsIDApKS4gU2ltaWxhciB0byBRdC4K ICNkZWZpbmUgUVRXRUJLSVRfVkVSU0lPTl9DSEVDSyhtYWpvciwgbWlub3IsIHBhdGNoKSAoKG1h am9yPDwxNil8KG1pbm9yPDw4KXwocGF0Y2gpKQogCi0jaWYgZGVmaW5lZChRVF9NQUtFRExMKSAg ICAgICAgLyogY3JlYXRlIGEgUXQgRExMIGxpYnJhcnkgKi8KKyNpZm5kZWYgUVRfU1RBVElDCiAj ICBpZiBkZWZpbmVkKEJVSUxESU5HX1dFQktJVCkKICMgICAgICBkZWZpbmUgUVdFQktJVF9FWFBP UlQgUV9ERUNMX0VYUE9SVAogIyAgZWxzZQogIyAgICAgIGRlZmluZSBRV0VCS0lUX0VYUE9SVCBR X0RFQ0xfSU1QT1JUCiAjICBlbmRpZgotI2VsaWYgZGVmaW5lZChRVF9ETEwpIC8qIHVzZSBhIFF0 IERMTCBsaWJyYXJ5ICovCi0jICBkZWZpbmUgUVdFQktJVF9FWFBPUlQgUV9ERUNMX0lNUE9SVAot I2VuZGlmCi0KLSNpZiAhZGVmaW5lZChRV0VCS0lUX0VYUE9SVCkKLSMgIGlmIGRlZmluZWQoUVRf U0hBUkVEKQotIyAgICBkZWZpbmUgUVdFQktJVF9FWFBPUlQgUV9ERUNMX0VYUE9SVAotIyAgZWxz ZQotIyAgICBkZWZpbmUgUVdFQktJVF9FWFBPUlQKLSMgIGVuZGlmCisjZWxzZQorIyAgZGVmaW5l IFFXRUJLSVRfRVhQT1JUCiAjZW5kaWYKIAogI2VuZGlmIC8vIFFXRUJLSVRHTE9CQUxfSApkaWZm IC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGMzMTQ0NWE4 MTFiM2UzMmY3M2EyNTJiY2FmNjM1YWRlZjZhMTYzZGQuLmU0ZTA0NDdlZDI5MDBiMDc0M2VmZmMw ZGYzZGIxMjQzMzc2MDQ0ODkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29s cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0xMS0yMSAgU2ltb24gSGF1c21hbm4g IDxzaW1vbi5oYXVzbWFubkBkaWdpYS5jb20+CisKKyAgICAgICAgW1F0XSBDb21waWxpbmcgYWdh aW5zdCBRdFdlYmtpdCBBUEkgcmVxdWlyZXMgUVRfRExMIHRvIGJlIGRlZmluZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjk0MgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB0aGUgcmVxdWly ZW1lbnQgb2YgaGF2aW5nIFFUX0RMTCBkZWZpbmVkIGluIG9yZGVyIGZvciB0aGUgUVdFQktJVF9F WFBPUlQKKyAgICAgICAgbWFjcm8gdG8gYmUgZGVmaW5lZCBhcyBRX0RFQ0xfSU1QT1JULiBJbnN0 ZWFkIHVuaWZ5IHRoZSBleHBvcnQgbWFjcm8gZGVmaW5pdGlvbgorICAgICAgICB0byBmb2xsb3cg dGhlIHNhbWUgcnVsZXMgYXMgb3RoZXIgUXQgNSBtb2R1bGVzLCB3aXRoIHRoZSBleGNlcHRpb24g dGhhdCBpbnN0ZWFkIG9mCisgICAgICAgIFFUX0JVSUxEX1dFQktJVF9MSUIgd2UgY29udGludWUg dG8gdXNlIEJVSUxESU5HX1dFQktJVCwgYmVjYXVzZSB0aGF0J3MgdXNlZCBhbHNvCisgICAgICAg IGluIG90aGVyIGNyb3NzLXBsYXRmb3JtIGhlYWRlciBmaWxlcyB0byBkZXRlcm1pbmUgdGhlIGNv cnJlY3QgbWVhbmluZyBvZiBleHBvcnQKKyAgICAgICAgbWFjcm9zLgorCisgICAgICAgICogcW1h a2UvbWtzcGVjcy9mZWF0dXJlcy9kZWZhdWx0X3Bvc3QucHJmOgorICAgICAgICAqIHFtYWtlL21r c3BlY3MvZmVhdHVyZXMvd2luMzIvZGVmYXVsdF9wb3N0LnByZjoKKwogMjAxMi0xMS0yMSAgVGhp YWdvIE1hcmNvcyBQLiBTYW50b3MgIDx0aGlhZ28uc2FudG9zQGludGVsLmNvbT4KIAogICAgICAg ICBbRUZMXSBLVVJMIHVuaXQgdGVzdCBjcmFzaGluZyB3aGVuIHRpbGVkIGJhY2tpbmcgc3RvcmUg aXMgZW5hYmxlZCBvbiBSZWxlYXNlIEJvdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL3FtYWtlL21rc3Bl Y3MvZmVhdHVyZXMvZGVmYXVsdF9wb3N0LnByZiBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVy ZXMvZGVmYXVsdF9wb3N0LnByZgppbmRleCA0Nzc2ZDFkOTIwOWQyNWZiZGFmOWE5NGFhMGFjY2Mz NTViMmVmZmZmLi5mMjk4MzhmYmYzZGFhN2QyNGY5N2YxZmQzNGRlYjU0NGY3NDJhMTlkIDEwMDY0 NAotLS0gYS9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2RlZmF1bHRfcG9zdC5wcmYKKysr IGIvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9kZWZhdWx0X3Bvc3QucHJmCkBAIC0xNTYs NyArMTU2LDcgQEAgY29udGFpbnMoVEVNUExBVEUsIGxpYikgewogICAgIERFRklORVMgKz0gQlVJ TERJTkdfJCR7VEFSR0VUfQogCiAgICAgIyBUcmlnZ2VycyB0aGUgcmlnaHQgZXhwb3J0IG1hY3Jv IGZvciB0aGUgUXRXZWJLaXQgQVBJIChzZWUgcXdlYmtpdGdsb2JhbC5oKQotICAgIERFRklORVMg Kz0gQlVJTERJTkdfV0VCS0lUCisgICAgIWNvbnRhaW5zKFFULCB3ZWJraXR3aWRnZXRzKTogREVG SU5FUyArPSBCVUlMRElOR19XRUJLSVQKIAogICAgICMgUHJldmVudCBuYW1lIGNsYXNoZXMgd2hl biBidWlsZGluZyBib3RoIGRlYnVnIGFuZCByZWxlYXNlLiBRdDUncyBtb2R1bGUKICAgICAjIHN5 c3RlbSBhbHJlYWR5IHRha2VzIGNhcmUgb2YgdGhpcyBmb3IgdGhlIHRvcCBsZXZlbCBRdFdlYktp dCBsaWJyYXJ5LgpkaWZmIC0tZ2l0IGEvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy93aW4z Mi9kZWZhdWx0X3Bvc3QucHJmIGIvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy93aW4zMi9k ZWZhdWx0X3Bvc3QucHJmCmluZGV4IDkzODYxZWYwYTMxNDEyOTA4ZTU5ZTZkYmYzYjI1OTAzMmM1 ZTQyZTkuLmFjZjJlODYxYmQ1Y2Q5NzU0YzBiOTYxNjI3MzZhYWQ5MDA3ZDFiYzYgMTAwNjQ0Ci0t LSBhL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvd2luMzIvZGVmYXVsdF9wb3N0LnByZgor KysgYi9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL3dpbjMyL2RlZmF1bHRfcG9zdC5wcmYK QEAgLTM5LDUgKzM5LDMgQEAgc2hhcmVkOmNvbnRhaW5zKFRFTVBMQVRFLCBsaWIpIHsKICAgICBH RU5FUkFURURfU09VUkNFUyArPSAkJGZvcndhcmRlZF9leHBvcnRzLnRhcmdldAogfQogCi0jIFRv IGVuc3VyZSB0aGUgUXQgZXhwb3J0IG1hY3JvcyBhcmUgc2V0IHRvIGRsbGV4cG9ydAotY29udGFp bnMoVEVNUExBVEUsIGxpYik6IWNvbnRhaW5zKFFULCB3ZWJraXR3aWRnZXRzKTogREVGSU5FUyAr PSBRVF9NQUtFRExMCg==