102938 2012-11-21 06:50:07 -0800 BrowserMarshal.h build fail 2013-09-17 04:57:03 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 shenyute berto berto cgarcia commit-queue gustavo mrobinson zan oldest_to_newest 772913 0 175433 shenyute 2012-11-21 06:50:07 -0800 Created attachment 175433 patch to fix the build error Encounter build error in Webkit gtk as the following: CXXLD Programs/ImageDiff CC Tools/MiniBrowser/gtk/Programs_MiniBrowser-BrowserCellRendererVariant.o ../../Tools/MiniBrowser/gtk/BrowserCellRendererVariant.c:27:28: fatal error: BrowserMarshal.h: No such file or directory compilation terminated. make[1]: *** [Tools/MiniBrowser/gtk/Programs_MiniBrowser-BrowserCellRendererVariant.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory `/home/ytshen/thirdparty/WebKit/WebKitBuild/Debug' make: *** [all] Error 2 Failed to build WebKit using 'make'! 928733 1 211526 berto 2013-09-13 02:56:15 -0700 Created attachment 211526 Simplify the makefile Thanks for spotting the typo in the makefile, although I don't quite see how that fixes the whole thing. The stamp-mini-browser-marshal files seem unnecessary to me, it should be enough to just list the dependencies directly needed to build BrowserMarshal.h and BrowserMarshal.c without creating the intermediate files. 929671 2 211526 gustavo 2013-09-16 06:30:22 -0700 Comment on attachment 211526 Simplify the makefile Might wanna take a peek at the commit that added this indirection just to be sure it was not working around some other crazy behaviour, but it looks unnecessary indeed. 929762 3 berto 2013-09-16 09:34:28 -0700 (In reply to comment #2) > Might wanna take a peek at the commit that added this indirection > just to be sure it was not working around some other crazy > behaviour, but it looks unnecessary indeed. Yeah, Carlos was mentioning this comment: https://git.gnome.org/browse/gtk+/tree/gtk/Makefile.am#n1148 I took a quick look but I didn't quite get why it is necessary. I'll double check before committing this patch. 929795 4 cgarcia 2013-09-16 10:25:16 -0700 (In reply to comment #3) > (In reply to comment #2) > > Might wanna take a peek at the commit that added this indirection > > just to be sure it was not working around some other crazy > > behaviour, but it looks unnecessary indeed. > > Yeah, Carlos was mentioning this comment: > > https://git.gnome.org/browse/gtk+/tree/gtk/Makefile.am#n1148 > > I took a quick look but I didn't quite get why it is necessary. I'll > double check before committing this patch. Yes, please, I think it would be enough to make sure make distcheck passes. 930068 5 berto 2013-09-16 23:04:56 -0700 Looks like distcheck is failing for me even without the patch: In file included from ../../Source/WebCore/platform/graphics/Font.h:28:0, from ../../Source/WebCore/platform/graphics/GraphicsContext.h:33, from ../../Source/WebCore/platform/graphics/ImageBuffer.h:34, from ../../Source/WebCore/platform/graphics/GeneratorGeneratedImage.h:32, from ../../Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp:27: ../../Source/WebCore/platform/graphics/FontDescription.h:36:35: fatal error: WebKitFontFamilyNames.h: No such file or directory compilation terminated. either I'm doing something wrong or this is bug 76388 again ? 930076 6 cgarcia 2013-09-16 23:42:18 -0700 (In reply to comment #5) > Looks like distcheck is failing for me even without the patch: > > In file included from ../../Source/WebCore/platform/graphics/Font.h:28:0, > from ../../Source/WebCore/platform/graphics/GraphicsContext.h:33, > from ../../Source/WebCore/platform/graphics/ImageBuffer.h:34, > from ../../Source/WebCore/platform/graphics/GeneratorGeneratedImage.h:32, > from ../../Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp:27: > ../../Source/WebCore/platform/graphics/FontDescription.h:36:35: fatal error: WebKitFontFamilyNames.h: No such file or directory > compilation terminated. > > either I'm doing something wrong or this is bug 76388 again ? Nah, distcheck is almost always broken, I'll try to find some time to fix it. 930106 7 berto 2013-09-17 02:14:20 -0700 (In reply to comment #6) > Nah, distcheck is almost always broken, I'll try to find some time to fix it. Ah, that's because I tried to do distcheck from a clean build. (which I guess it should anyway work? but that's a different issue) 930136 8 211882 berto 2013-09-17 03:56:03 -0700 Created attachment 211882 Patch I see that we're using the stamp method in other places so I think we should just fix the variable name now. If the stamp thing is worth changing I would leave that for a separate bug. 930152 9 berto 2013-09-17 04:57:03 -0700 Committed r155945: <http://trac.webkit.org/changeset/155945> 175433 2012-11-21 06:50:07 -0800 2013-09-13 02:56:15 -0700 patch to fix the build error patch text/plain 756 shenyute ZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9HTlVtYWtlZmlsZS5hbSBiL1Rvb2xz L01pbmlCcm93c2VyL2d0ay9HTlVtYWtlZmlsZS5hbQppbmRleCA1MDk3NGFlLi5mMDY1MjUwIDEw MDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvR05VbWFrZWZpbGUuYW0KKysrIGIvVG9v bHMvTWluaUJyb3dzZXIvZ3RrL0dOVW1ha2VmaWxlLmFtCkBAIC02MCw3ICs2MCw3IEBAIHN0YW1w LW1pbmktYnJvd3Nlci1tYXJzaGFsLmM6ICQobWluaWJyb3dzZXJfbWFyc2hhbF9saXN0KQogICAg ICAgICQoQU1fVl9HRU4pJChHTElCX0dFTk1BUlNIQUwpIC0tcHJlZml4PWJyb3dzZXJfbWFyc2hh bCAkKG1pbmlicm93c2VyX21hcnNoYWxfbGlzdCkgLS1ib2R5ID4gJChHRU5TT1VSQ0VTX1dFQktJ VDIpL0Jyb3dzZXJNYXJzaGFsLmMgJiYgXAogICAgICAgIGVjaG8gdGltZXN0YW1wID4gJChARikK IAotc3RhbXAtbWluaS1icm93c2VyLW1hcnNoYWwuaDogJChNaW5pQnJvd3Nlcl9tYXJzaGFsX2xp c3QpCitzdGFtcC1taW5pLWJyb3dzZXItbWFyc2hhbC5oOiAkKG1pbmlicm93c2VyX21hcnNoYWxf bGlzdCkKICAgICAgICAkKEFNX1ZfR0VOKSQoR0xJQl9HRU5NQVJTSEFMKSAtLXByZWZpeD1icm93 c2VyX21hcnNoYWwgJChtaW5pYnJvd3Nlcl9tYXJzaGFsX2xpc3QpIC0taGVhZGVyID4gJChHRU5T T1VSQ0VTX1dFQktJVDIpL0Jyb3dzZXJNYXJzaGFsLmggJiYgXAogICAgICAgIGVjaG8gdGltZXN0 YW1wID4gJChARikKIAoK 211526 2013-09-13 02:56:15 -0700 2013-09-17 03:56:03 -0700 Simplify the makefile 102938.diff text/plain 2343 berto ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5Nzcx M2E4Li43MmJkNDVhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDktMTMgIEFsYmVydG8gR2FyY2lhICA8YmVy dG9AaWdhbGlhLmNvbT4KKworICAgICAgICBCcm93c2VyTWFyc2hhbC5oIGJ1aWxkIGZhaWwKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjkzOAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCB0eXBvIGlu IHRoZSBwcmVyZXF1aXNpdGVzIG9mIEJyb3dzZXJNYXJzaGFsLmggYW5kIHNpbXBsaWZ5IHRoZQor ICAgICAgICBtYWtlZmlsZS4gVGhlIHN0YW1wIGZpbGVzIGFyZSBub3QgcmVhbGx5IG5lY2Vzc2Fy eSB0byBnZW5lcmF0ZQorICAgICAgICBCcm93c2VyTWFyc2hhbC4qCisKKyAgICAgICAgKiBNaW5p QnJvd3Nlci9ndGsvR05VbWFrZWZpbGUuYW06CisKIDIwMTMtMDktMTMgIERhcmluIEFkbGVyICA8 ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIEdpdmUgYWN0aW9ucyBpbiBSYW5nZSBjbGFzcyBO T05fU0hPVVRJTkdfTkFNRVMKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9HTlVt YWtlZmlsZS5hbSBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9HTlVtYWtlZmlsZS5hbQppbmRleCBl MzVjYWI4Li40MjRhMjVmIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvR05VbWFr ZWZpbGUuYW0KKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0dOVW1ha2VmaWxlLmFtCkBAIC00 OSwyNiArNDksMTcgQEAgUHJvZ3JhbXNfTWluaUJyb3dzZXJfTERGTEFHUyA9IFwKIAogQ0xFQU5G SUxFUyArPSBcCiAJJCh0b3BfYnVpbGRkaXIpL1Byb2dyYW1zL01pbmlCcm93c2VyIFwKLQkkKG1p bmlicm93c2VyX2J1aWx0X3NvdXJjZXMpIFwKLQkkKHRvcF9idWlsZGRpcikvc3RhbXAtbWluaS1i cm93c2VyLW1hcnNoYWwuaCBcCi0JJCh0b3BfYnVpbGRkaXIpL3N0YW1wLW1pbmktYnJvd3Nlci1t YXJzaGFsLmMKKwkkKG1pbmlicm93c2VyX2J1aWx0X3NvdXJjZXMpCiAKIEJVSUxUX1NPVVJDRVMg Kz0gJChtaW5pYnJvd3Nlcl9idWlsdF9zb3VyY2VzKQogCiBtaW5pYnJvd3Nlcl9tYXJzaGFsX2xp c3QgPSAkKHNyY2RpcikvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL2Jyb3dzZXItbWFyc2hhbC5saXN0 CiAKLSQoR0VOU09VUkNFU19XRUJLSVQyKS9Ccm93c2VyTWFyc2hhbC5oOiBzdGFtcC1taW5pLWJy b3dzZXItbWFyc2hhbC5oCi0JQHRydWUKLSQoR0VOU09VUkNFU19XRUJLSVQyKS9Ccm93c2VyTWFy c2hhbC5jOiBzdGFtcC1taW5pLWJyb3dzZXItbWFyc2hhbC5jCi0JQHRydWUKLQotc3RhbXAtbWlu aS1icm93c2VyLW1hcnNoYWwuYzogJChtaW5pYnJvd3Nlcl9tYXJzaGFsX2xpc3QpCi0JJChBTV9W X0dFTikkKEdMSUJfR0VOTUFSU0hBTCkgLS1wcmVmaXg9YnJvd3Nlcl9tYXJzaGFsICQobWluaWJy b3dzZXJfbWFyc2hhbF9saXN0KSAtLWJvZHkgPiAkKEdFTlNPVVJDRVNfV0VCS0lUMikvQnJvd3Nl ck1hcnNoYWwuYyAmJiBcCi0JZWNobyB0aW1lc3RhbXAgPiAkKEBGKQorJChHRU5TT1VSQ0VTX1dF QktJVDIpL0Jyb3dzZXJNYXJzaGFsLmg6ICQobWluaWJyb3dzZXJfbWFyc2hhbF9saXN0KQorCSQo QU1fVl9HRU4pJChHTElCX0dFTk1BUlNIQUwpIC0tcHJlZml4PWJyb3dzZXJfbWFyc2hhbCAkKG1p bmlicm93c2VyX21hcnNoYWxfbGlzdCkgLS1oZWFkZXIgPiAkKEdFTlNPVVJDRVNfV0VCS0lUMikv QnJvd3Nlck1hcnNoYWwuaAogCi1zdGFtcC1taW5pLWJyb3dzZXItbWFyc2hhbC5oOiAkKE1pbmlC cm93c2VyX21hcnNoYWxfbGlzdCkKLQkkKEFNX1ZfR0VOKSQoR0xJQl9HRU5NQVJTSEFMKSAtLXBy ZWZpeD1icm93c2VyX21hcnNoYWwgJChtaW5pYnJvd3Nlcl9tYXJzaGFsX2xpc3QpIC0taGVhZGVy ID4gJChHRU5TT1VSQ0VTX1dFQktJVDIpL0Jyb3dzZXJNYXJzaGFsLmggJiYgXAotCWVjaG8gdGlt ZXN0YW1wID4gJChARikKKyQoR0VOU09VUkNFU19XRUJLSVQyKS9Ccm93c2VyTWFyc2hhbC5jOiAk KG1pbmlicm93c2VyX21hcnNoYWxfbGlzdCkKKwkkKEFNX1ZfR0VOKSQoR0xJQl9HRU5NQVJTSEFM KSAtLXByZWZpeD1icm93c2VyX21hcnNoYWwgJChtaW5pYnJvd3Nlcl9tYXJzaGFsX2xpc3QpIC0t Ym9keSA+ICQoR0VOU09VUkNFU19XRUJLSVQyKS9Ccm93c2VyTWFyc2hhbC5jCiAKIEVYVFJBX0RJ U1QgKz0gXAogCSQoc3JjZGlyKS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvYnJvd3Nlci1tYXJzaGFs Lmxpc3QK 211882 2013-09-17 03:56:03 -0700 2013-09-17 04:55:28 -0700 Patch 102938.diff text/plain 1243 berto ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlNjdl NTQxLi5jN2NmNDE1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDktMTcgIFl1VGVoIFNoZW4gIDxzaGVueXV0 ZUBob3RtYWlsLmNvbT4KKworICAgICAgICBCcm93c2VyTWFyc2hhbC5oIGJ1aWxkIGZhaWwKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjkzOAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCB2YXJpYWJs ZSBuYW1lLgorCisgICAgICAgICogTWluaUJyb3dzZXIvZ3RrL0dOVW1ha2VmaWxlLmFtOgorCiAy MDEzLTA5LTE2ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAg IFtXaW5kb3dzXSBDbGVhbiB1cCBXaW5MYXVuY2hlciBieSB1c2luZyBzbWFydCBwb2ludGVycwpk aWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0dOVW1ha2VmaWxlLmFtIGIvVG9vbHMv TWluaUJyb3dzZXIvZ3RrL0dOVW1ha2VmaWxlLmFtCmluZGV4IGIxYjk5NWEuLmQ0ZTEzMDUgMTAw NjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9HTlVtYWtlZmlsZS5hbQorKysgYi9Ub29s cy9NaW5pQnJvd3Nlci9ndGsvR05VbWFrZWZpbGUuYW0KQEAgLTY1LDcgKzY1LDcgQEAgc3RhbXAt bWluaS1icm93c2VyLW1hcnNoYWwuYzogJChtaW5pYnJvd3Nlcl9tYXJzaGFsX2xpc3QpCiAJJChB TV9WX0dFTikkKEdMSUJfR0VOTUFSU0hBTCkgLS1wcmVmaXg9YnJvd3Nlcl9tYXJzaGFsICQobWlu aWJyb3dzZXJfbWFyc2hhbF9saXN0KSAtLWJvZHkgPiAkKEdFTlNPVVJDRVNfV0VCS0lUMikvQnJv d3Nlck1hcnNoYWwuYyAmJiBcCiAJZWNobyB0aW1lc3RhbXAgPiAkKEBGKQogCi1zdGFtcC1taW5p LWJyb3dzZXItbWFyc2hhbC5oOiAkKE1pbmlCcm93c2VyX21hcnNoYWxfbGlzdCkKK3N0YW1wLW1p bmktYnJvd3Nlci1tYXJzaGFsLmg6ICQobWluaWJyb3dzZXJfbWFyc2hhbF9saXN0KQogCSQoQU1f Vl9HRU4pJChHTElCX0dFTk1BUlNIQUwpIC0tcHJlZml4PWJyb3dzZXJfbWFyc2hhbCAkKG1pbmli cm93c2VyX21hcnNoYWxfbGlzdCkgLS1oZWFkZXIgPiAkKEdFTlNPVVJDRVNfV0VCS0lUMikvQnJv d3Nlck1hcnNoYWwuaCAmJiBcCiAJZWNobyB0aW1lc3RhbXAgPiAkKEBGKQogCg==