102910 2012-11-21 02:46:00 -0800 [EFL] Fail to compile CSSComputedStyleDeclaration.cpp on trunk@135354 2012-11-21 04:45:14 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Critical --- 0 halton.huo webkit-unassigned oldest_to_newest 772707 0 halton.huo 2012-11-21 02:46:00 -0800 As http://queues.webkit.org/results/14894924 shows, the EFL port fail to compile CSSComputedStyleDeclaration.cpp /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:323:5: error: ‘CSSPropertyWebkitShapeInside’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:324:5: error: ‘CSSPropertyWebkitShapeOutside’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:351:5: error: ‘CSSPropertyWebkitFlowInto’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:352:5: error: ‘CSSPropertyWebkitFlowFrom’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:353:5: error: ‘CSSPropertyWebkitRegionOverflow’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:354:5: error: ‘CSSPropertyWebkitRegionBreakAfter’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:355:5: error: ‘CSSPropertyWebkitRegionBreakBefore’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:356:5: error: ‘CSSPropertyWebkitRegionBreakInside’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:362:5: error: ‘CSSPropertyWebkitWrapFlow’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:363:5: error: ‘CSSPropertyWebkitShapeMargin’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:364:5: error: ‘CSSPropertyWebkitShapePadding’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:365:5: error: ‘CSSPropertyWebkitWrapThrough’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp: In member function ‘WTF::PassRefPtr<WebCore::CSSValue> WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue(WebCore::CSSPropertyID, WebCore::EUpdateLayout) const’: /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1734:14: error: ‘CSSPropertyWebkitRegionBreakAfter’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1736:14: error: ‘CSSPropertyWebkitRegionBreakBefore’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1738:14: error: ‘CSSPropertyWebkitRegionBreakInside’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2490:14: error: ‘CSSPropertyWebkitFlowInto’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2494:14: error: ‘CSSPropertyWebkitFlowFrom’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2498:14: error: ‘CSSPropertyWebkitRegionOverflow’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2502:14: error: ‘CSSPropertyWebkitWrapFlow’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2504:14: error: ‘CSSPropertyWebkitShapeMargin’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2506:14: error: ‘CSSPropertyWebkitShapePadding’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2508:14: error: ‘CSSPropertyWebkitShapeInside’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2515:14: error: ‘CSSPropertyWebkitShapeOutside’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2520:14: error: ‘CSSPropertyWebkitWrapThrough’ was not declared in this scope /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2658:14: error: ‘CSSPropertyWebkitWrap’ was not declared in this scope [ 29%] Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/css/CSSImportRule.cpp.o /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp: In member function ‘virtual WTF::PassRefPtr<WebCore::StylePropertySet> WebCore::CSSComputedStyleDeclaration::copy() const’: /home/halton/work/projects/webkit/WebKit/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2769:1: error: control reaches end of non-void function [-Werror=return-type] cc1plus: all warnings being treated as errors make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/css/CSSComputedStyleDeclaration.cpp.o] Error 1 772760 1 halton.huo 2012-11-21 03:30:37 -0800 Turn out, the generated DerivedSources/WebCore/CSSPropertyNames.gperf and CSSPropertyNames.h missing lots of props, such as 576 -webkit-animation, CSSPropertyWebkitAnimation 577 -webkit-animation-delay, CSSPropertyWebkitAnimationDelay 578 -webkit-animation-direction, CSSPropertyWebkitAnimationDirection 579 -webkit-animation-duration, CSSPropertyWebkitAnimationDuration 580 -webkit-animation-fill-mode, CSSPropertyWebkitAnimationFillMode 581 -webkit-animation-iteration-count, CSSPropertyWebkitAnimationIterationCount 582 -webkit-animation-name, CSSPropertyWebkitAnimationName 583 -webkit-animation-play-state, CSSPropertyWebkitAnimationPlayState 584 -webkit-animation-timing-function, CSSPropertyWebkitAnimationTimingFunction 585 -webkit-appearance, CSSPropertyWebkitAppearance 586 -webkit-aspect-ratio, CSSPropertyWebkitAspectRatio 587 -webkit-backface-visibility, CSSPropertyWebkitBackfaceVisibility While gtk build at same revision does generate them, I'm afraid it is a bug for makeprop.pl. I'm looking at it. 772804 2 halton.huo 2012-11-21 04:45:14 -0800 It is true that my fix for bug 102903 cause this failure, I'll close this bug as invalid and fix my patch.