102909 2012-11-21 02:29:26 -0800 Position in QWebHitTestResult does not match documentation 2012-11-21 16:03:57 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98139 1 allan.jensen allan.jensen webkit.review.bot oldest_to_newest 772687 0 allan.jensen 2012-11-21 02:29:26 -0800 The position in QWebHitTestResult is documented as 'the position where the hit-test occured', but the point from HitTestResult that we use to initialize this value with is the point in inner most hit frame, and not the original hit-test point. 772713 1 175396 allan.jensen 2012-11-21 02:50:03 -0800 Created attachment 175396 Patch 772999 2 175396 jturcotte 2012-11-21 08:35:07 -0800 Comment on attachment 175396 Patch How does this work, if I do a QWebFrame::hitTestContent on a sub-frame, what position will QWebHitTestResult::pos return me? 773001 3 allan.jensen 2012-11-21 08:45:14 -0800 (In reply to comment #2) > (From update of attachment 175396 [details]) > How does this work, if I do a QWebFrame::hitTestContent on a sub-frame, what position will QWebHitTestResult::pos return me? Hit-testing a sub-frame will automatically be escalated to hit test in the main-frame. So essentially you can't. 773008 4 175456 allan.jensen 2012-11-21 09:08:08 -0800 Created attachment 175456 Patch Do not change behaviour, change documentation 773379 5 175456 webkit.review.bot 2012-11-21 16:03:53 -0800 Comment on attachment 175456 Patch Clearing flags on attachment: 175456 Committed r135449: <http://trac.webkit.org/changeset/135449> 773380 6 webkit.review.bot 2012-11-21 16:03:57 -0800 All reviewed patches have been landed. Closing bug. 175396 2012-11-21 02:50:03 -0800 2012-11-21 09:08:04 -0800 Patch bug-102909-20121121114724.patch text/plain 1632 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MzU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IGYzMGJjNzE3NTcz NzFmYmZiZTU4NDJkYWJkM2ZkYTMxYzkxYTFmZTUuLjk5ZjFiOWMwZTk3M2NkYTg0ZjgzN2QyZDBk N2YzMTc0MTBjZmM1MmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTEt MjEgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CisKKyAg ICAgICAgUG9zaXRpb24gaW4gUVdlYkhpdFRlc3RSZXN1bHQgZG9lcyBub3QgbWF0Y2ggZG9jdW1l bnRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAyOTA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VG8gbWF0Y2ggb3VyIGRvY3VtZW50YXRpb24gd2Ugc2hvdWxkIHJldHVybiB0aGUgaGl0LXRlc3Qg cG9pbnQgaW4gdGhlIG1haW4gZnJhbWUuCisgICAgICAgIFRoaXMgb25seSBtYWtlcyBhIGRpZmZl cmVuY2Ugd2hlbiBoaXR0aW5nIGxvY2F0aW9ucyBpbiBzdWItZnJhbWVzLgorCisgICAgICAgICog QXBpL3F3ZWJmcmFtZS5jcHA6CisgICAgICAgIChRV2ViSGl0VGVzdFJlc3VsdFByaXZhdGU6OlFX ZWJIaXRUZXN0UmVzdWx0UHJpdmF0ZSk6CisKIDIwMTItMTEtMTIgIEFsbGFuIFNhbmRmZWxkIEpl bnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CiAKICAgICAgICAgRGlzYW1iaWd1YXRlIGlu bmVyTm9kZUZyYW1lUG9pbnQgYW5kIG1haW5GcmFtZVBvaW50CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwIGIvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYmZy YW1lLmNwcAppbmRleCBiNzczYjk2MzE0YzhlNmJkODAzN2YxMmQ2NGE0YjdkYzg3NzJlNDZiLi5m MTVhYWYzMzhhZTNkZDg4NWNhOGFkYTJlZjNhY2U3ZTRlZmJlMDEyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvQXBp L3F3ZWJmcmFtZS5jcHAKQEAgLTE1OTgsOCArMTU5OCw3IEBAIFFXZWJIaXRUZXN0UmVzdWx0UHJp dmF0ZTo6UVdlYkhpdFRlc3RSZXN1bHRQcml2YXRlKGNvbnN0IFdlYkNvcmU6OkhpdFRlc3RSZXN1 bHQKIHsKICAgICBpZiAoIWhpdFRlc3QuaW5uZXJOb2RlKCkpCiAgICAgICAgIHJldHVybjsKLSAg ICAvLyBGSVhNRTogVGhpcyBzaG91bGQgcHJvYmFibHkgdXNlIHJvdW5kZWRQb2ludEluTWFpbkZy YW1lIGlmIGl0IGlzIHRvIG1hdGNoIHRoZSBkb2N1bWVudGF0aW9uIG9mIFFXZWJIaXRUZXN0UmVz dWx0LgotICAgIHBvcyA9IGhpdFRlc3Qucm91bmRlZFBvaW50SW5Jbm5lck5vZGVGcmFtZSgpOwor ICAgIHBvcyA9IGhpdFRlc3Qucm91bmRlZFBvaW50SW5NYWluRnJhbWUoKTsKICAgICBXZWJDb3Jl OjpUZXh0RGlyZWN0aW9uIGRpcjsKICAgICB0aXRsZSA9IGhpdFRlc3QudGl0bGUoZGlyKTsKICAg ICBsaW5rVGV4dCA9IGhpdFRlc3QudGV4dENvbnRlbnQoKTsK 175456 2012-11-21 09:08:08 -0800 2012-11-21 16:03:53 -0800 Patch bug-102909-20121121180529.patch text/plain 2658 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDAwYjk1ZTE0MjMw OWM2NzA4ZGFmOTI5ZWRmYTI5Njc5Nzk3NjE3MjcuLmFjMjk3YzBlMjc4N2U0OGQxOWM0YzAwMGEy NDM4ZTBkYWM5N2UwZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTItMTEt MjEgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CiAKKyAg ICAgICAgUG9zaXRpb24gaW4gUVdlYkhpdFRlc3RSZXN1bHQgZG9lcyBub3QgbWF0Y2ggZG9jdW1l bnRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAyOTA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q29ycmVjdCBkb2N1bWVudGF0aW9uIGFuZCBzaW1wbGlmeSB1c2luZyB0aGUgbmV3IGlubmVyTm9k ZUZyYW1lIG1ldGhvZC4KKworICAgICAgICAqIEFwaS9xd2ViZnJhbWUuY3BwOgorICAgICAgICAo UVdlYkhpdFRlc3RSZXN1bHRQcml2YXRlOjpRV2ViSGl0VGVzdFJlc3VsdFByaXZhdGUpOgorCisy MDEyLTExLTIxICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29t PgorCiAgICAgICAgIERpc2FtYmlndWF0ZSBpbm5lck5vZGVGcmFtZVBvaW50IGFuZCBtYWluRnJh bWVQb2ludAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTgxMzkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcCBi L1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAKaW5kZXggYjc3M2I5NjMxNGM4ZTZi ZDgwMzdmMTJkNjRhNGI3ZGM4NzcyZTQ2Yi4uMTMxMDM0OGVkODk3OTQ5MGFhMmJjMGIyMmZkYzJk YzE2ZDUxYjY1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwCkBAIC0xNTk4LDcgKzE1 OTgsNiBAQCBRV2ViSGl0VGVzdFJlc3VsdFByaXZhdGU6OlFXZWJIaXRUZXN0UmVzdWx0UHJpdmF0 ZShjb25zdCBXZWJDb3JlOjpIaXRUZXN0UmVzdWx0CiB7CiAgICAgaWYgKCFoaXRUZXN0LmlubmVy Tm9kZSgpKQogICAgICAgICByZXR1cm47Ci0gICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIHByb2Jh Ymx5IHVzZSByb3VuZGVkUG9pbnRJbk1haW5GcmFtZSBpZiBpdCBpcyB0byBtYXRjaCB0aGUgZG9j dW1lbnRhdGlvbiBvZiBRV2ViSGl0VGVzdFJlc3VsdC4KICAgICBwb3MgPSBoaXRUZXN0LnJvdW5k ZWRQb2ludEluSW5uZXJOb2RlRnJhbWUoKTsKICAgICBXZWJDb3JlOjpUZXh0RGlyZWN0aW9uIGRp cjsKICAgICB0aXRsZSA9IGhpdFRlc3QudGl0bGUoZGlyKTsKQEAgLTE2MjUsOSArMTYyNCw5IEBA IFFXZWJIaXRUZXN0UmVzdWx0UHJpdmF0ZTo6UVdlYkhpdFRlc3RSZXN1bHRQcml2YXRlKGNvbnN0 IFdlYkNvcmU6OkhpdFRlc3RSZXN1bHQKICAgICBpc0NvbnRlbnRTZWxlY3RlZCA9IGhpdFRlc3Qu aXNTZWxlY3RlZCgpOwogICAgIGlzU2Nyb2xsQmFyID0gaGl0VGVzdC5zY3JvbGxiYXIoKTsKIAot ICAgIGlmIChpbm5lck5vblNoYXJlZE5vZGUgJiYgaW5uZXJOb25TaGFyZWROb2RlLT5kb2N1bWVu dCgpCi0gICAgICAgICYmIGlubmVyTm9uU2hhcmVkTm9kZS0+ZG9jdW1lbnQoKS0+ZnJhbWUoKSkK LSAgICAgICAgZnJhbWUgPSBRV2ViRnJhbWVQcml2YXRlOjpraXQoaW5uZXJOb25TaGFyZWROb2Rl LT5kb2N1bWVudCgpLT5mcmFtZSgpKTsKKyAgICBXZWJDb3JlOjpGcmFtZSAqaW5uZXJOb2RlRnJh bWUgPSBoaXRUZXN0LmlubmVyTm9kZUZyYW1lKCk7CisgICAgaWYgKGlubmVyTm9kZUZyYW1lKQor ICAgICAgICBmcmFtZSA9IFFXZWJGcmFtZVByaXZhdGU6OmtpdChpbm5lck5vZGVGcmFtZSk7CiAK ICAgICBlbmNsb3NpbmdCbG9jayA9IFFXZWJFbGVtZW50KFdlYkNvcmU6OmVuY2xvc2luZ0Jsb2Nr KGlubmVyTm9kZS5nZXQoKSkpOwogfQpAQCAtMTY4NSw3ICsxNjg0LDkgQEAgYm9vbCBRV2ViSGl0 VGVzdFJlc3VsdDo6aXNOdWxsKCkgY29uc3QKIH0KIAogLyohCi0gICAgUmV0dXJucyB0aGUgcG9z aXRpb24gd2hlcmUgdGhlIGhpdCB0ZXN0IG9jY3VyZWQuCisgICAgUmV0dXJucyB0aGUgcG9zaXRp b24gd2hlcmUgdGhlIGhpdCB0ZXN0IG9jY3VyZWQgaW4gdGhlIGNvb3JkaW5hdGVzIG9mIGZyYW1l IGNvbnRhaW5pbmcgdGhlIGVsZW1lbnQgaGl0LgorCisgICAgXHNhIGZyYW1lKCkKICovCiBRUG9p bnQgUVdlYkhpdFRlc3RSZXN1bHQ6OnBvcygpIGNvbnN0CiB7CkBAIC0xODQ5LDcgKzE4NTAsNyBA QCBRV2ViRWxlbWVudCBRV2ViSGl0VGVzdFJlc3VsdDo6ZWxlbWVudCgpIGNvbnN0CiB9CiAKIC8q IQotICAgIFJldHVybnMgdGhlIGZyYW1lIHRoZSBoaXQgdGVzdCB3YXMgZXhlY3V0ZWQgaW4uCisg ICAgUmV0dXJucyB0aGUgZnJhbWUgb2YgdGhlIGVsZW1lbnQgaGl0LgogKi8KIFFXZWJGcmFtZSAq UVdlYkhpdFRlc3RSZXN1bHQ6OmZyYW1lKCkgY29uc3QKIHsK