102907 2012-11-21 02:26:35 -0800 [GTK] TargetFrame and innerNodeFrame confused 2013-05-16 08:18:38 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98139 1 allan.jensen allan.jensen darin oldest_to_newest 772684 0 allan.jensen 2012-11-21 02:26:35 -0800 While trying to clarify the point returned by HitTestResult, I have gone through all the call-sites using the point, and have noticed what I can only assume are errors in webkithittestresult.cpp. First of all you use targetFrame instead of the frame of the innernode to translate to window coordinates. This is likely wrong since targetframe is the frame the link your are hovering will be opened in (open link in different frame/open link in new window feature). Secondly your fall-back logic while probably not necessary uses the point in innerNodeFrame, it should probably instead use the point in mainFrame instead and translate from the mainframe. Alternatively you can always translate from the main-frame coordinates once the patch for bug #98139 lands. 772717 1 175397 allan.jensen 2012-11-21 02:54:39 -0800 Created attachment 175397 Patch 889826 2 175397 mrobinson 2013-05-16 07:58:09 -0700 Comment on attachment 175397 Patch Thanks! 889835 3 175397 allan.jensen 2013-05-16 08:18:33 -0700 Comment on attachment 175397 Patch Clearing flags on attachment: 175397 Committed r150182: <http://trac.webkit.org/changeset/150182> 889836 4 allan.jensen 2013-05-16 08:18:38 -0700 All reviewed patches have been landed. Closing bug. 175397 2012-11-21 02:54:39 -0800 2013-05-16 08:18:33 -0700 Patch bug-102907-20121121115200.patch text/plain 2514 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MzU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggNDdmYmZhYjNl YzA2MWYyZWE2ZjlhZTM4ZjdkNWJmZDgyY2Y1NzAzMy4uNDFlMWUyOTdhN2M0MzlhYjk4Y2ZjOTEx ODA5NjY2OWQ0OTcxZjQ1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEy LTExLTIxICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgor CisgICAgICAgIFtHVEtdIFRhcmdldEZyYW1lIGFuZCBpbm5lck5vZGVGcmFtZSBjb25mdXNlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyOTA3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3ZWJraXQv d2Via2l0aGl0dGVzdHJlc3VsdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OmtpdCk6CisKIDIwMTIt MTEtMTIgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CiAK ICAgICAgICAgRGlzYW1iaWd1YXRlIGlubmVyTm9kZUZyYW1lUG9pbnQgYW5kIG1haW5GcmFtZVBv aW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0aGl0dGVzdHJl c3VsdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0aGl0dGVzdHJlc3VsdC5j cHAKaW5kZXggYzQwODFhNzY0NWIxYjUzODRlOGRiNDBmNmJmZjg4NjdhMDI2ZTM4NS4uY2IxYzkw OTYyYTZlNzc5MGFjZmNjYmJjMDY1NmVmNTFhZDAyNmNlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdGhpdHRlc3RyZXN1bHQuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvZ3RrL3dlYmtpdC93ZWJraXRoaXR0ZXN0cmVzdWx0LmNwcApAQCAtMjg4LDcgKzI4OCw3IEBA IFdlYktpdEhpdFRlc3RSZXN1bHQqIGtpdChjb25zdCBXZWJDb3JlOjpIaXRUZXN0UmVzdWx0JiBy ZXN1bHQpCiAgICAgR093blB0cjxjaGFyPiBpbWFnZVVSSSgwKTsKICAgICBHT3duUHRyPGNoYXI+ IG1lZGlhVVJJKDApOwogICAgIFdlYktpdERPTU5vZGUqIG5vZGUgPSAwOwotICAgIFdlYkNvcmU6 OkZyYW1lKiB0YXJnZXRGcmFtZTsKKyAgICBXZWJDb3JlOjpGcmFtZSogaW5uZXJOb2RlRnJhbWU7 CiAgICAgV2ViQ29yZTo6SW50UG9pbnQgcG9pbnQ7CiAKICAgICBpZiAoIXJlc3VsdC5hYnNvbHV0 ZUxpbmtVUkwoKS5pc0VtcHR5KCkpIHsKQEAgLTMxNSwxNCArMzE1LDE0IEBAIFdlYktpdEhpdFRl c3RSZXN1bHQqIGtpdChjb25zdCBXZWJDb3JlOjpIaXRUZXN0UmVzdWx0JiByZXN1bHQpCiAgICAg aWYgKHJlc3VsdC5pbm5lck5vblNoYXJlZE5vZGUoKSkKICAgICAgICAgbm9kZSA9IGtpdChyZXN1 bHQuaW5uZXJOb25TaGFyZWROb2RlKCkpOwogCi0gICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIHBy b2JhYmx5IHVzZSBpbm5lck5vZGVGcmFtZSwgYXMgdGFyZ2V0RnJhbWUgaXMgdGhlIHBvdGVudGlh bGx5IGRpZmZlcmVudCBmcmFtZSB0aGUgbGluayBvcGVucyBpbi4KLSAgICB0YXJnZXRGcmFtZSA9 IHJlc3VsdC50YXJnZXRGcmFtZSgpOwotICAgIGlmICh0YXJnZXRGcmFtZSAmJiB0YXJnZXRGcmFt ZS0+dmlldygpKSB7CisgICAgaW5uZXJOb2RlRnJhbWUgPSByZXN1bHQuaW5uZXJOb2RlRnJhbWUo KTsKKyAgICBpZiAoaW5uZXJOb2RlRnJhbWUgJiYgaW5uZXJOb2RlRnJhbWUtPnZpZXcoKSkgewog ICAgICAgICAvLyBDb252ZXJ0IGRvY3VtZW50IGNvb3JkcyB0byB3aWRnZXQgY29vcmRzLgotICAg ICAgICBwb2ludCA9IHRhcmdldEZyYW1lLT52aWV3KCktPmNvbnRlbnRzVG9XaW5kb3cocmVzdWx0 LnJvdW5kZWRQb2ludEluSW5uZXJOb2RlRnJhbWUoKSk7CisgICAgICAgIHBvaW50ID0gaW5uZXJO b2RlRnJhbWUtPnZpZXcoKS0+Y29udGVudHNUb1dpbmRvdyhyZXN1bHQucm91bmRlZFBvaW50SW5J bm5lck5vZGVGcmFtZSgpKTsKICAgICB9IGVsc2UgewotICAgICAgICAvLyBGSVhNRTogVGhpcyBz aG91bGQgcHJvYmFibHkgdXNlIHJvdW5kZWRQb2ludEluTWFpbkZyYW1lIGFuZCB0cmFuc2xhdGUg ZnJvbSB0aGUgbWFpbmZyYW1lLgotICAgICAgICBwb2ludCA9IHJlc3VsdC5yb3VuZGVkUG9pbnRJ bklubmVyTm9kZUZyYW1lKCk7CisgICAgICAgIC8vIEZJWE1FOiBNYWluIGZyYW1lIGNvb3JkcyBp cyBub3QgdGhlIHNhbWUgYXMgd2luZG93IGNvb3JkcywKKyAgICAgICAgLy8gYnV0IHdlIGRvIG5v dCBoYXZlIHBvaW50ZXIgdG8gIG1haW5mcmFtZSB2aWV3IGhlcmUuCisgICAgICAgIHBvaW50ID0g cmVzdWx0LnJvdW5kZWRQb2ludEluTWFpbkZyYW1lKCk7CiAgICAgfQogCiAgICAgcmV0dXJuIFdF QktJVF9ISVRfVEVTVF9SRVNVTFQoZ19vYmplY3RfbmV3KFdFQktJVF9UWVBFX0hJVF9URVNUX1JF U1VMVCwK