102906 2012-11-21 01:58:03 -0800 Web Inspector: Ctrl+A closes breakpoint condition editor 2012-11-21 09:35:06 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 lushnikov lushnikov apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 772655 0 lushnikov 2012-11-21 01:58:03 -0800 Steps to reproduce: 1. Open dev-tools 2. Go to Sources 3. Open any js file 4. right click on a line-number -> add conditional breakpoint 5. Click Ctrl+A What happens: Conditional breakpoint editing window gets hidden; source code gets selected What should happen: Text inside conditional breakpoint editor should get selected 772666 1 175384 lushnikov 2012-11-21 02:14:46 -0800 Created attachment 175384 Patch 772702 2 175390 lushnikov 2012-11-21 02:43:37 -0800 Created attachment 175390 Patch 772786 3 175390 aandrey 2012-11-21 04:16:53 -0800 Comment on attachment 175390 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175390&action=review > Source/WebCore/inspector/front-end/DefaultTextEditor.js:421 > + if (WebInspector.currentFocusElement().nodeName === "INPUT") call WebInspector.isBeingEdited(e.target) maybe? 772793 4 175390 pfeldman 2012-11-21 04:28:14 -0800 Comment on attachment 175390 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175390&action=review >> Source/WebCore/inspector/front-end/DefaultTextEditor.js:421 >> + if (WebInspector.currentFocusElement().nodeName === "INPUT") > > call WebInspector.isBeingEdited(e.target) maybe? You can edit text in non-INPUT fields as well. Imagine if we switch conditional breakpoints to the text area... You should check that e.target has no ancestors with className "webkit-line-decorations" instead. 773000 5 175454 lushnikov 2012-11-21 08:39:56 -0800 Created attachment 175454 Patch 773035 6 175454 webkit.review.bot 2012-11-21 09:35:02 -0800 Comment on attachment 175454 Patch Clearing flags on attachment: 175454 Committed r135412: <http://trac.webkit.org/changeset/135412> 773036 7 webkit.review.bot 2012-11-21 09:35:06 -0800 All reviewed patches have been landed. Closing bug. 175384 2012-11-21 02:14:46 -0800 2012-11-21 02:43:33 -0800 Patch bug-102906-20121121141233.patch text/plain 3690 lushnikov U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MzU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTBkMjdkNWU3N2M1OTQ3 Y2UxMmVmMjViMjI0ZWM2ZjI4OWVkNzJjYy4uODQ5YTJjZTY3NWY5YWIwYWVmZjc5YTBmOWFmNDQ1 MGM2ZTNiZWZlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTExLTIxICBBbmRy ZXkgTHVzaG5pa292ICA8bHVzaG5pa292QGNocm9taXVtLmNvbT4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBDdHJsK0EgY2xvc2VzIGJyZWFrcG9pbnQgY29uZGl0aW9uIGVkaXRvcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyOTA2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yd2FyZCBldmVyeSBz aG9ydGN1dCBpbiBEZWZhdWx0VGV4dEVkaXRvciB0bworICAgICAgICBKYXZhc2NyaXB0U291cmNl RnJhbWUgKHRocm91Z2ggVGV4dEVkaXRvckRlbGVnYXRlKSB3aGljaCBjYW4KKyAgICAgICAgaGFu ZGxlIGl0IGFuZCByZWplY3QgZGVmYXVsdCBlZGl0b3IgYWN0aW9uCisKKyAgICAgICAgKiBpbnNw ZWN0b3IvZnJvbnQtZW5kL0RlZmF1bHRUZXh0RWRpdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkRlZmF1bHRUZXh0RWRpdG9yLnByb3RvdHlwZS5faGFuZGxlS2V5RG93bik6IGNhbGwKKyAg ICAgICAgZGVsZWdhdGUgbWV0aG9kIGJlZm9yZSBwcm9jZXNzaW5nIHNob3J0Y3V0CisgICAgICAg ICogaW5zcGVjdG9yL2Zyb250LWVuZC9KYXZhU2NyaXB0U291cmNlRnJhbWUuanM6CisgICAgICAg IChXZWJJbnNwZWN0b3IuSmF2YVNjcmlwdFNvdXJjZUZyYW1lLnByb3RvdHlwZS5vbktleWJvYXJk U2hvcnRjdXRDbGlja2VkKToKKyAgICAgICAgaGFuZGxlIHNob3J0Y3V0IGlmZiB3ZSBhcmUgbm90 IGVkaXRpbmcgYnJlYWtwb2ludCBjb25kaXRpb24KKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQt ZW5kL1NvdXJjZUZyYW1lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JEZWxl Z2F0ZUZvclNvdXJjZUZyYW1lLnByb3RvdHlwZS5vbktleWJvYXJkU2hvcnRjdXRDbGlja2VkKToK KyAgICAgICAgYWRkIG9uS2V5Ym9hcmRTaG9ydGN1dENsaWNrZWQgbWV0aG9kIGluIFRleHRFZGl0 b3JEZWxlZ2F0ZQorCiAyMDEyLTExLTIxICBLdW5paGlrbyBTYWthbW90byAgPGtzYWthbW90b0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgRW5hYmxlIGRhdGFsaXN0IFVJIGZvciBpbnB1dCB0eXBl cyBkYXRldGltZSBhbmQgZGF0ZXRpbWUtbG9jYWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvRGVmYXVsdFRleHRFZGl0b3IuanMgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RlZmF1bHRUZXh0RWRpdG9yLmpzCmluZGV4IDU2N2E5NmI2 NjY5OTZmM2FjODk2ZmU4MjhiY2FhNzM3MjdlYmZjNjUuLmI0YTA2ZjUzMGYyZDM3ZTJhNGIxYjdh ZGMzMmQ5ZTBlYzg2YjlhZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvRGVmYXVsdFRleHRFZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9EZWZhdWx0VGV4dEVkaXRvci5qcwpAQCAtNDIwLDcgKzQyMCw3IEBAIFdl Ykluc3BlY3Rvci5EZWZhdWx0VGV4dEVkaXRvci5wcm90b3R5cGUgPSB7CiAgICAgICAgIHZhciBz aG9ydGN1dEtleSA9IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lm1ha2VLZXlGcm9tRXZl bnQoZSk7CiAKICAgICAgICAgdmFyIGhhbmRsZXIgPSB0aGlzLl9zaG9ydGN1dHNbc2hvcnRjdXRL ZXldOwotICAgICAgICBpZiAoaGFuZGxlciAmJiBoYW5kbGVyKCkpIHsKKyAgICAgICAgaWYgKHRo aXMuX2RlbGVnYXRlLm9uS2V5Ym9hcmRTaG9ydGN1dENsaWNrZWQoc2hvcnRjdXRLZXkpICYmIGhh bmRsZXIgJiYgaGFuZGxlcigpKSB7CiAgICAgICAgICAgICBlLmNvbnN1bWUodHJ1ZSk7CiAgICAg ICAgICAgICByZXR1cm47CiAgICAgICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvSmF2YVNjcmlwdFNvdXJjZUZyYW1lLmpzIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9KYXZhU2NyaXB0U291cmNlRnJhbWUuanMKaW5kZXggMzIx MGMzYThmNTFhYzRiMDQ3MGMwNWFiMDhkYjA1MDI0NmVlNDllYi4uMjc4MDc0NWQ3NTFiM2Y4ZTVj NTk2NTViNTlmYWEyYzdjNTE4MjUzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9KYXZhU2NyaXB0U291cmNlRnJhbWUuanMKKysrIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9KYXZhU2NyaXB0U291cmNlRnJhbWUuanMKQEAgLTE3OSw2 ICsxNzksMTEgQEAgV2ViSW5zcGVjdG9yLkphdmFTY3JpcHRTb3VyY2VGcmFtZS5wcm90b3R5cGUg PSB7CiAgICAgICAgIGRlbGV0ZSB0aGlzLl9pc1NldHRpbmdXb3JraW5nQ29weTsKICAgICB9LAog CisgICAgb25LZXlib2FyZFNob3J0Y3V0Q2xpY2tlZDogZnVuY3Rpb24oc2hvcnRjdXQpCisgICAg eworICAgICAgICByZXR1cm4gIXRoaXMuX2NvbmRpdGlvbkVkaXRvckVsZW1lbnQ7CisgICAgfSwK KwogICAgIF93aWxsTWVyZ2VUb1ZNOiBmdW5jdGlvbigpCiAgICAgewogICAgICAgICBpZiAodGhp cy5fc3VwcG9ydHNFbmFibGVkQnJlYWtwb2ludHNXaGlsZUVkaXRpbmcoKSkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU291cmNlRnJhbWUuanMgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZyYW1lLmpzCmluZGV4IDc2OWZj MTZlMzY2NGI0YjBjM2RjZjljMDdhMDVhYjdlNjk4MGJlZGUuLmExZjcxZWIwZTAxMTMzOTlhN2I2 YWE3MDljZjlmYzBmYTE2N2E0M2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvU291cmNlRnJhbWUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcwpAQCAtNjY0LDYgKzY2NCwxNiBAQCBXZWJJbnNwZWN0 b3IuVGV4dEVkaXRvckRlbGVnYXRlRm9yU291cmNlRnJhbWUgPSBmdW5jdGlvbihzb3VyY2VGcmFt ZSkKIH0KIAogV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JEZWxlZ2F0ZUZvclNvdXJjZUZyYW1lLnBy b3RvdHlwZSA9IHsKKworICAgIG9uS2V5Ym9hcmRTaG9ydGN1dENsaWNrZWQ6IGZ1bmN0aW9uKHNo b3J0Y3V0KQorICAgIHsKKyAgICAgICAgdmFyIG5leHQgPSB0aGlzLl9zb3VyY2VGcmFtZS5vbktl eWJvYXJkU2hvcnRjdXRDbGlja2VkOworICAgICAgICBpZiAobmV4dCkKKyAgICAgICAgICAgIHJl dHVybiBuZXh0LmNhbGwodGhpcy5fc291cmNlRnJhbWUsIHNob3J0Y3V0KTsKKyAgICAgICAgZWxz ZQorICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfSwKKwogICAgIG9uVGV4dENoYW5nZWQ6 IGZ1bmN0aW9uKG9sZFJhbmdlLCBuZXdSYW5nZSkKICAgICB7CiAgICAgICAgIHRoaXMuX3NvdXJj ZUZyYW1lLm9uVGV4dENoYW5nZWQob2xkUmFuZ2UsIG5ld1JhbmdlKTsK 175390 2012-11-21 02:43:37 -0800 2012-11-21 08:39:53 -0800 Patch bug-102906-20121121144124.patch text/plain 1678 lushnikov U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzNkZTkwOWU5MmRmMDY3 OWRlZjdjMDQ3Y2I1NzAyNzBmM2I3ZjZiZi4uYWVkNzI5M2NiMDQ0ODk1OTg0ZWQ0YTI4ZWZiZTRj MGZiYjkwMmRlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTIxICBBbmRy ZXkgTHVzaG5pa292ICA8bHVzaG5pa292QGNocm9taXVtLmNvbT4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBDdHJsK0EgY2xvc2VzIGJyZWFrcG9pbnQgY29uZGl0aW9uIGVkaXRvcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyOTA2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGlzYWJsZSBzaG9ydGN1 dCBoYW5kbGluZyBmb3IgRGVmYXVsdFRleHRFZGl0b3IgaWYgc2hvcnRjdXQgd2FzCisgICAgICAg IHRyaWdnZXJlZCBpbiBpbnB1dCBlbGVtZW50CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQt ZW5kL0RlZmF1bHRUZXh0RWRpdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRlZmF1bHRU ZXh0RWRpdG9yLnByb3RvdHlwZS5faGFuZGxlS2V5RG93bik6IEFkZCBjaGVjayBmb3IKKyAgICAg ICAgZXZlbnQgdGFyZ2V0IGVsZW1lbnQKKwogMjAxMi0xMS0yMSAgVnNldm9sb2QgVmxhc292ICA8 dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZXF1ZXN0IHBy ZXZpZXcgdHVuaW5nOiBlbmFibGUganNvbiBwcmV2aWV3IGZvciB0ZXh0L2h0bWwgWEhScwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZWZhdWx0VGV4dEVk aXRvci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGVmYXVsdFRleHRF ZGl0b3IuanMKaW5kZXggNTY3YTk2YjY2Njk5NmYzYWM4OTZmZTgyOGJjYWE3MzcyN2ViZmM2NS4u MTUxYWMzZGNlY2E0ODBjZmQyMjhmYTFhMjFhNzg0ZWJiMzYzNzA3OCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZWZhdWx0VGV4dEVkaXRvci5qcworKysg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RlZmF1bHRUZXh0RWRpdG9yLmpz CkBAIC00MTcsNiArNDE3LDEwIEBAIFdlYkluc3BlY3Rvci5EZWZhdWx0VGV4dEVkaXRvci5wcm90 b3R5cGUgPSB7CiAKICAgICBfaGFuZGxlS2V5RG93bjogZnVuY3Rpb24oZSkKICAgICB7CisgICAg ICAgIC8vIElucHV0IGVsZW1lbnQgY2FuIGhhbmRsZSBzaG9ydGN1dHMgYnkgaXRzZWxmIC0gbm8g bmVlZCBmb3IgdXMgdG8gZG8gYW55dGhpbmcKKyAgICAgICAgaWYgKFdlYkluc3BlY3Rvci5jdXJy ZW50Rm9jdXNFbGVtZW50KCkubm9kZU5hbWUgPT09ICJJTlBVVCIpCisgICAgICAgICAgICByZXR1 cm47CisKICAgICAgICAgdmFyIHNob3J0Y3V0S2V5ID0gV2ViSW5zcGVjdG9yLktleWJvYXJkU2hv cnRjdXQubWFrZUtleUZyb21FdmVudChlKTsKIAogICAgICAgICB2YXIgaGFuZGxlciA9IHRoaXMu X3Nob3J0Y3V0c1tzaG9ydGN1dEtleV07Cg== 175454 2012-11-21 08:39:56 -0800 2012-11-21 09:35:02 -0800 Patch bug-102906-20121121203743.patch text/plain 1699 lushnikov U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1Mzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjk5ZmQzZGMxZTQ5N2Fl MDBkODlkZTA3NTUxNTkxYmE3YmNkMTVmZS4uNWU0YzM4ODc1ZjA4ZDZiMmExODYwM2UxMDlkMGE4 MzYxMDdmZGQyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTIxICBBbmRy ZXkgTHVzaG5pa292ICA8bHVzaG5pa292QGNocm9taXVtLmNvbT4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBDdHJsK0EgY2xvc2VzIGJyZWFrcG9pbnQgY29uZGl0aW9uIGVkaXRvcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyOTA2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hlY2sgaWYgZS50YXJn ZXQgaGFzIG5vIGFuY2VzdG9ycyB3aXRoIGNsYXNzTmFtZQorICAgICAgICAid2Via2l0LWxpbmUt ZGVjb3JhdGlvbnMiIGluIERlZmF1bHRUZXh0RWRpdG9yLl9oYW5kbGVLZXlEb3duCisKKyAgICAg ICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0RlZmF1bHRUZXh0RWRpdG9yLmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLkRlZmF1bHRUZXh0RWRpdG9yLnByb3RvdHlwZS5faGFuZGxlS2V5RG93bik6 IEFkZCBjaGVjaworCiAyMDEyLTExLTIxICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBbVjhdIFJlbW92ZSBTVFJJTkdfVE9fVjhQQVJBTUVURVJfRVhDRVBU SU9OX0JMT0NLKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvRGVmYXVsdFRleHRFZGl0b3IuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL0RlZmF1bHRUZXh0RWRpdG9yLmpzCmluZGV4IDU2N2E5NmI2NjY5OTZmM2FjODk2ZmU4Mjhi Y2FhNzM3MjdlYmZjNjUuLmFjMDIxMjlhMDkxY2FlYjkwMjU3YjFkOTM3MGE3YmNlYzVjY2NhZWMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGVmYXVsdFRl eHRFZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZWZh dWx0VGV4dEVkaXRvci5qcwpAQCAtNDE3LDYgKzQxNywxMSBAQCBXZWJJbnNwZWN0b3IuRGVmYXVs dFRleHRFZGl0b3IucHJvdG90eXBlID0gewogCiAgICAgX2hhbmRsZUtleURvd246IGZ1bmN0aW9u KGUpCiAgICAgeworICAgICAgICAvLyBJZiB0aGUgZXZlbnQgd2FzIG5vdCB0cmlnZ2VyZWQgZnJv bSB0aGUgZW50aXJlIGVkaXRvciwgdGhlbgorICAgICAgICAvLyBpZ25vcmUgaXQuIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI5MDYKKyAgICAgICAgaWYgKGUudGFy Z2V0LmVuY2xvc2luZ05vZGVPclNlbGZXaXRoQ2xhc3MoIndlYmtpdC1saW5lLWRlY29yYXRpb25z IikpCisgICAgICAgICAgICByZXR1cm47CisKICAgICAgICAgdmFyIHNob3J0Y3V0S2V5ID0gV2Vi SW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQubWFrZUtleUZyb21FdmVudChlKTsKIAogICAgICAg ICB2YXIgaGFuZGxlciA9IHRoaXMuX3Nob3J0Y3V0c1tzaG9ydGN1dEtleV07Cg==