102902 2012-11-21 01:42:37 -0800 Web Inspector: reparenting view does not detach from the previous parent. 2012-11-21 04:37:48 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 772632 0 pfeldman 2012-11-21 01:42:37 -0800 Patch to follow. 772649 1 175381 pfeldman 2012-11-21 01:55:46 -0800 Created attachment 175381 Patch 772696 2 175381 vsevik 2012-11-21 02:37:32 -0800 Comment on attachment 175381 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175381&action=review > Source/WebCore/inspector/front-end/View.js:169 > + if (this.element.parentElement) This check is already present in detach 772798 3 175381 webkit.review.bot 2012-11-21 04:37:45 -0800 Comment on attachment 175381 Patch Clearing flags on attachment: 175381 Committed r135386: <http://trac.webkit.org/changeset/135386> 772799 4 webkit.review.bot 2012-11-21 04:37:48 -0800 All reviewed patches have been landed. Closing bug. 175381 2012-11-21 01:55:46 -0800 2012-11-21 04:37:45 -0800 Patch bug-102902-20121121135333.patch text/plain 3649 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzEyNjY3M2ExNzAzOGRk NzI2YTllYWViOTQ3NjhiNzcwZThmYzFjNi4uOTkxM2VkMTcwZGZiMGJlMDdhNWExMDFlZjEzZTk5 MTljYTg3ZWEyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTExLTIxICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHJlcGFyZW50aW5nIHZpZXcgZG9lcyBub3QgZGV0YWNoIGZyb20gdGhlIHByZXZpb3VzIHBh cmVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MjkwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog aW5zcGVjdG9yL2Zyb250LWVuZC9WaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlZpZXcu cHJvdG90eXBlLnNob3cpOgorCiAyMDEyLTExLTIxICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTM1MzU4Lgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9WaWV3LmpzIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9WaWV3LmpzCmluZGV4IDkzNDBkNDg4 ZmI5OTExMzk1Nzc4YTljMDY5NGJjZjE2ODE3ZjE2OWIuLjczOGJlZDQ0ZjJiM2YzZTA5MGUwZDE5 MTQzNTdmMjMyMjRlZTNiNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvVmlldy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1ZpZXcuanMKQEAgLTE2Niw2ICsxNjYsOSBAQCBXZWJJbnNwZWN0b3IuVmlldy5wcm90b3R5cGUg PSB7CiAKICAgICAgICAgLy8gVXBkYXRlIHZpZXcgaGllcmFyY2h5CiAgICAgICAgIGlmICh0aGlz LmVsZW1lbnQucGFyZW50RWxlbWVudCAhPT0gcGFyZW50RWxlbWVudCkgeworICAgICAgICAgICAg aWYgKHRoaXMuZWxlbWVudC5wYXJlbnRFbGVtZW50KQorICAgICAgICAgICAgICAgIHRoaXMuZGV0 YWNoKCk7CisKICAgICAgICAgICAgIHZhciBjdXJyZW50UGFyZW50ID0gcGFyZW50RWxlbWVudDsK ICAgICAgICAgICAgIHdoaWxlIChjdXJyZW50UGFyZW50ICYmICFjdXJyZW50UGFyZW50Ll9fdmll dykKICAgICAgICAgICAgICAgICBjdXJyZW50UGFyZW50ID0gY3VycmVudFBhcmVudC5wYXJlbnRF bGVtZW50OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCmluZGV4IDk5Y2RmNmE4N2Q4ODExZTZkZGE4NDM3OTVmMTAyOWIyNTRlODA4MGEu LmEzZGE2NWExNDJiZWY1MTA5NmYyNDZmMmMyYzcwMzE2MGUyYTEyY2YgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMiBAQAorMjAxMi0xMS0yMSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9y Zz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiByZXBhcmVudGluZyB2aWV3IGRvZXMgbm90IGRl dGFjaCBmcm9tIHRoZSBwcmV2aW91cyBwYXJlbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI5MDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci92aWV3LWV2ZW50cy5odG1sOgorCiAy MDEyLTExLTIxICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFVucmV2aWV3ZWQuIFVwZGF0ZWQgdGVzdCBleHBlY3RhdGlvbnMuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9pbnNwZWN0b3Ivdmlldy1ldmVudHMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvaW5zcGVjdG9yL3ZpZXctZXZlbnRzLWV4cGVjdGVkLnR4dAppbmRleCA5MmUwZWVhMTNjMmQ1 ZTZlY2U3ZTI3Njg5ODI1ZDM1YWFlMGRjNjk0Li4wMTcyMzAyNWY4ZDBhZWFlYTM5YWNkNzA5M2My YTE2OTk5OGVkMTNmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3Ivdmlldy1ldmVu dHMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci92aWV3LWV2ZW50cy1l eHBlY3RlZC50eHQKQEAgLTE5MSwzICsxOTEsMjIgQEAgUGFyZW50LmRldGFjaCgpCiAgIFBhcmVu dC53aWxsSGlkZSgpCiBDaGlsZC5kZXRhY2goKQogCitSdW5uaW5nOiB0ZXN0U2hvd0RldGFjaGVz RnJvbVByZXZpb3VzCitQYXJlbnQxKCkKK1BhcmVudDIoKQorQ2hpbGQoKQorUGFyZW50MS5zaG93 KCkKKyAgUGFyZW50MS53YXNTaG93bigpCisgIFBhcmVudDEub25SZXNpemUoKQorUGFyZW50Mi5z aG93KCkKKyAgUGFyZW50Mi53YXNTaG93bigpCisgIFBhcmVudDIub25SZXNpemUoKQorQ2hpbGQu c2hvdygpCisgIENoaWxkLndhc1Nob3duKCkKKyAgQ2hpbGQub25SZXNpemUoKQorQ2hpbGQuc2hv dygpCitDaGlsZC5kZXRhY2goKQorICBDaGlsZC53aWxsSGlkZSgpCisgIENoaWxkLndhc1Nob3du KCkKKyAgQ2hpbGQub25SZXNpemUoKQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0 b3Ivdmlldy1ldmVudHMuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci92aWV3LWV2ZW50cy5o dG1sCmluZGV4IDE2MTVjMTE5ZDk2MGU5MzQzMzExZThmODdkOGUyOTY3MGJjYjc4MmIuLjAwZDZm NjkzN2NjOTA3YWVlNGMxYmJiMWI5MmM5ZDlkZmJlNzkyMDMgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2luc3BlY3Rvci92aWV3LWV2ZW50cy5odG1sCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rv ci92aWV3LWV2ZW50cy5odG1sCkBAIC0yODcsNiArMjg3LDE4IEBAIGZ1bmN0aW9uIHRlc3QoKQog ICAgICAgICAgICAgcGFyZW50Vmlldy5kZXRhY2hPbldpbGxIaWRlID0gY2hpbGRWaWV3OwogICAg ICAgICAgICAgcGFyZW50Vmlldy5kZXRhY2goKTsKICAgICAgICAgICAgIG5leHQoKTsKKyAgICAg ICAgfSwKKworICAgICAgICBmdW5jdGlvbiB0ZXN0U2hvd0RldGFjaGVzRnJvbVByZXZpb3VzKG5l eHQpCisgICAgICAgIHsKKyAgICAgICAgICAgIHZhciBwYXJlbnRWaWV3MSA9IG5ldyBUZXN0Vmll dygiUGFyZW50MSIpOworICAgICAgICAgICAgdmFyIHBhcmVudFZpZXcyID0gbmV3IFRlc3RWaWV3 KCJQYXJlbnQyIik7CisgICAgICAgICAgICB2YXIgY2hpbGRWaWV3ID0gbmV3IFRlc3RWaWV3KCJD aGlsZCIpOworICAgICAgICAgICAgcGFyZW50VmlldzEuc2hvdyhXZWJJbnNwZWN0b3IuaW5zcGVj dG9yVmlldy5lbGVtZW50KTsKKyAgICAgICAgICAgIHBhcmVudFZpZXcyLnNob3coV2ViSW5zcGVj dG9yLmluc3BlY3RvclZpZXcuZWxlbWVudCk7CisgICAgICAgICAgICBjaGlsZFZpZXcuc2hvdyhw YXJlbnRWaWV3MS5lbGVtZW50KTsKKyAgICAgICAgICAgIGNoaWxkVmlldy5zaG93KHBhcmVudFZp ZXcyLmVsZW1lbnQpOworICAgICAgICAgICAgbmV4dCgpOwogICAgICAgICB9CiAgICAgXSk7CiB9 Cg==