102884 2012-11-20 23:18:12 -0800 Unused parameters on ScrollingCoordinator.cpp 2012-11-21 01:10:27 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ktf.kim ktf.kim andersca haraken jamesr tonikitoo webkit.review.bot oldest_to_newest 772501 0 ktf.kim 2012-11-20 23:18:12 -0800 Because the 'platformLayer' parameter is not used when !USE(ACCELERATED_COMPOSITING), use UNUSED_PARAM macro to fix build warning -Wunused-parameter Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:283:6: warning: unused parameter ‘scrollingLayerPositionAction’ [-Wunused-parameter] 772504 1 175346 ktf.kim 2012-11-20 23:20:38 -0800 Created attachment 175346 Patch 772506 2 175346 ktf.kim 2012-11-20 23:22:19 -0800 Comment on attachment 175346 Patch Because the 'scrollingLayerPositionAction' parameter is not used when !USE(ACCELERATED_COMPOSITING), use UNUSED_PARAM macro to fix build warning -Wunused-parameter 772532 3 175346 haraken 2012-11-21 00:09:11 -0800 Comment on attachment 175346 Patch ok 772591 4 175346 webkit.review.bot 2012-11-21 01:10:23 -0800 Comment on attachment 175346 Patch Clearing flags on attachment: 175346 Committed r135360: <http://trac.webkit.org/changeset/135360> 772593 5 webkit.review.bot 2012-11-21 01:10:27 -0800 All reviewed patches have been landed. Closing bug. 175346 2012-11-20 23:20:38 -0800 2012-11-21 01:10:23 -0800 Patch bug-102884-20121121161825.patch text/plain 1475 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzA2NThmZDE3MWU1Yzk5 MjZmODYwYTczZDRkMWJmZDAyMTkzZjdjZC4uMDU3NTUxNTFlYjY4NjE5MzBkNjhmZDU5MTYzNzRi Mzk5NGNmOTUwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTIwICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFVudXNlZCBwYXJhbWV0 ZXJzIG9uIFNjcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyODg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQmVjYXVzZSB0aGUgJ3Njcm9sbGluZ0xheWVyUG9zaXRp b25BY3Rpb24nIHBhcmFtZXRlciBpcyBub3QgdXNlZCB3aGVuICFVU0UoQUNDRUxFUkFURURfQ09N UE9TSVRJTkcpLAorICAgICAgICB1c2UgVU5VU0VEX1BBUkFNIG1hY3JvIHRvIGZpeCBidWlsZCB3 YXJuaW5nIC1XdW51c2VkLXBhcmFtZXRlcgorCisgICAgICAgICogcGFnZS9zY3JvbGxpbmcvU2Ny b2xsaW5nQ29vcmRpbmF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nQ29vcmRp bmF0b3I6OnVwZGF0ZU1haW5GcmFtZVNjcm9sbFBvc2l0aW9uKToKKwogMjAxMi0xMS0yMCAgS2Vu dGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1Y4XSBSZW1vdmUg djgvY3VzdG9tL1Y4WE1MSHR0cFJlcXVlc3RDb25zdHJ1Y3Rvci5jcHAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcAppbmRl eCBkMjFiMGU5OTI3ZDQ5MzFhZWVlN2M1ZWE2MWY1NjU5OWY2OGY2YjczLi5jZDk0MzJjMmE4MmQ4 ZTAxODAwNzQ3YzRiMmZkMDg3NGUwOWViMjYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCkBAIC0zMTEsNiArMzEx LDggQEAgdm9pZCBTY3JvbGxpbmdDb29yZGluYXRvcjo6dXBkYXRlTWFpbkZyYW1lU2Nyb2xsUG9z aXRpb24oY29uc3QgSW50UG9pbnQmIHNjcm9sbFAKICAgICAgICAgICAgIHN5bmNDaGlsZFBvc2l0 aW9ucyh2aWV3cG9ydFJlY3QpOwogICAgICAgICB9CiAgICAgfQorI2Vsc2UKKyAgICBVTlVTRURf UEFSQU0oc2Nyb2xsaW5nTGF5ZXJQb3NpdGlvbkFjdGlvbik7CiAjZW5kaWYKIH0KIAo=