102876 2012-11-20 22:03:19 -0800 [V8] Remove v8/custom/V8XMLHttpRequestConstructor.cpp 2012-11-20 22:51:04 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth gyuyoung.kim japhet rakuco webkit.review.bot oldest_to_newest 772463 0 haraken 2012-11-20 22:03:19 -0800 It doesn't make sense to have one custom cpp file for XXX::constructorCallback() only. We can move XXX::constructorCallback() in v8/custom/V8XXXConstructor.cpp to v8/custom/V8XXXCustom.cpp and thus remove v8/custom/V8XXXConstructor.cpp. Note: Some XXX::constructorCallback()s are already written in v8/custom/V8XXXCustom.cpp. JSC already has almost all XXX::constructorCallback()s in js/JSXXXCustom.cpp. 772466 1 175338 haraken 2012-11-20 22:06:02 -0800 Created attachment 175338 Patch 772480 2 175338 haraken 2012-11-20 22:17:11 -0800 Comment on attachment 175338 Patch Thanks! 772493 3 175338 webkit.review.bot 2012-11-20 22:50:59 -0800 Comment on attachment 175338 Patch Clearing flags on attachment: 175338 Committed r135354: <http://trac.webkit.org/changeset/135354> 772494 4 webkit.review.bot 2012-11-20 22:51:04 -0800 All reviewed patches have been landed. Closing bug. 175338 2012-11-20 22:06:02 -0800 2012-11-20 22:50:59 -0800 Patch bug-102876-20121121150349.patch text/plain 6871 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MzQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDY0ODcwNmFiMzJkMmM1 MmJhOTFkNjYzM2I4ZDU5YTRhMmNhNDc4Ny4uNjNiYzM1YmU4YzI3YjYzYzVjOGFjODNlM2ZkZjQy ZjBiMGE3MTc4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDEyLTExLTIwICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIFJlbW92ZSB2 OC9jdXN0b20vVjhYTUxIdHRwUmVxdWVzdENvbnN0cnVjdG9yLmNwcAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyODc2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgZG9lc24ndCBtYWtlIHNlbnNlIHRv IGhhdmUgb25lIGN1c3RvbSBjcHAgZmlsZSBmb3IKKyAgICAgICAgWFhYOjpjb25zdHJ1Y3RvckNh bGxiYWNrKCkgb25seS4gV2UgY2FuIG1vdmUgWFhYOjpjb25zdHJ1Y3RvckNhbGxiYWNrKCkKKyAg ICAgICAgaW4gdjgvY3VzdG9tL1Y4WFhYQ29uc3RydWN0b3IuY3BwIHRvIHY4L2N1c3RvbS9WOFhY WEN1c3RvbS5jcHAKKyAgICAgICAgYW5kIHRodXMgcmVtb3ZlIHY4L2N1c3RvbS9WOFhYWENvbnN0 cnVjdG9yLmNwcC4KKworICAgICAgICBOb3RlOiBTb21lIFhYWDo6Y29uc3RydWN0b3JDYWxsYmFj aygpcyBhcmUgYWxyZWFkeSB3cml0dGVuIGluCisgICAgICAgIHY4L2N1c3RvbS9WOFhYWEN1c3Rv bS5jcHAuIEpTQyBhbHJlYWR5IGhhcyBhbG1vc3QgYWxsCisgICAgICAgIFhYWDo6Y29uc3RydWN0 b3JDYWxsYmFjaygpcyBpbiBqcy9KU1hYWEN1c3RvbS5jcHAuCisKKyAgICAgICAgTm8gdGVzdHMu IE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIFVzZVY4LmNtYWtlOgorICAgICAg ICAqIFdlYkNvcmUuZ3lwaToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhYTUxIdHRw UmVxdWVzdENvbnN0cnVjdG9yLmNwcDogUmVtb3ZlZC4KKyAgICAgICAgKiBiaW5kaW5ncy92OC9j dXN0b20vVjhYTUxIdHRwUmVxdWVzdEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOFhN TEh0dHBSZXF1ZXN0Ojpjb25zdHJ1Y3RvckNhbGxiYWNrQ3VzdG9tKToKKyAgICAgICAgKFdlYkNv cmUpOgorCisyMDEyLTExLTIwICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4K KwogICAgICAgICBbVjhdIEludHJvZHVjZSBjb25zdHJ1Y3RvckNhbGxiYWNrQ3VzdG9tKCkKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjc2MwogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Vc2VWOC5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL1Vz ZVY4LmNtYWtlCmluZGV4IDczMjk5NDI2MjQ1YTQ1NzE1MWY1NTI1MzE3MTE0NmMyMGZkNGY4ZDQu LmQyYTVmN2Q0OTc5YjRkZDM2ODllMDY1OTY4NWNhNWQyOWE0OWY4MDEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL1VzZVY4LmNtYWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL1VzZVY4LmNtYWtl CkBAIC0xNTIsNyArMTUyLDYgQEAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCiAgICAgYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4V2ViS2l0UG9pbnRDb25zdHJ1Y3Rvci5jcHAKICAgICBiaW5kaW5n cy92OC9jdXN0b20vVjhXb3JrZXJDb250ZXh0Q3VzdG9tLmNwcAogICAgIGJpbmRpbmdzL3Y4L2N1 c3RvbS9WOFdvcmtlckN1c3RvbS5jcHAKLSAgICBiaW5kaW5ncy92OC9jdXN0b20vVjhYTUxIdHRw UmVxdWVzdENvbnN0cnVjdG9yLmNwcAogICAgIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOFhNTEh0dHBS ZXF1ZXN0Q3VzdG9tLmNwcAogICAgIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOFhTTFRQcm9jZXNzb3JD dXN0b20uY3BwCiApCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cGkgYi9T b3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cGkKaW5kZXggYThiM2ZlZGI2NDIyNWVmYTQ0OWE4YTIw NzgxZjQ4Mzg5NzZiNDViOC4uYTI3N2IxNzU3NWE5NDM5ZGE2NzJhYjc2YTZlNThlMDczOWExNTcy NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXBpCisrKyBiL1NvdXJjZS9X ZWJDb3JlL1dlYkNvcmUuZ3lwaQpAQCAtMjQzNyw3ICsyNDM3LDYgQEAKICAgICAgICAgICAgICdi aW5kaW5ncy92OC9jdXN0b20vVjhXZWJLaXRQb2ludENvbnN0cnVjdG9yLmNwcCcsCiAgICAgICAg ICAgICAnYmluZGluZ3MvdjgvY3VzdG9tL1Y4V29ya2VyQ29udGV4dEN1c3RvbS5jcHAnLAogICAg ICAgICAgICAgJ2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFdvcmtlckN1c3RvbS5jcHAnLAotICAgICAg ICAgICAgJ2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFhNTEh0dHBSZXF1ZXN0Q29uc3RydWN0b3IuY3Bw JywKICAgICAgICAgICAgICdiaW5kaW5ncy92OC9jdXN0b20vVjhYTUxIdHRwUmVxdWVzdEN1c3Rv bS5jcHAnLAogICAgICAgICAgICAgJ2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFhTTFRQcm9jZXNzb3JD dXN0b20uY3BwJywKICAgICAgICAgICAgICdiaW5kaW5ncy92OC9ucHJ1bnRpbWUuY3BwJywKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFhNTEh0dHBSZXF1 ZXN0Q29uc3RydWN0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4 WE1MSHR0cFJlcXVlc3RDb25zdHJ1Y3Rvci5jcHAKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDZiNTUxNzZjZmNmMjk0YzFiZTZkMDk4ZjU1YTdlYzkxMmNiMTYzY2EuLjAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvY3VzdG9tL1Y4WE1MSHR0cFJlcXVlc3RDb25zdHJ1Y3Rvci5jcHAKKysrIC9kZXYvbnVs bApAQCAtMSw2MiArMCwwIEBACi0vKgotICogQ29weXJpZ2h0IChDKSAyMDA4LCAyMDA5IEdvb2ds ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCi0gKgotICogUmVkaXN0cmlidXRpb24gYW5kIHVz ZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0Ci0gKiBtb2RpZmlj YXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlv bnMgYXJlCi0gKiBtZXQ6Ci0gKgotICogICAgICogUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBj b2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKLSAqIG5vdGljZSwgdGhpcyBsaXN0 IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KLSAqICAgICAqIFJl ZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUKLSAq IGNvcHlyaWdodCBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93 aW5nIGRpc2NsYWltZXIKLSAqIGluIHRoZSBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRl cmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUKLSAqIGRpc3RyaWJ1dGlvbi4KLSAqICAgICAqIE5laXRo ZXIgdGhlIG5hbWUgb2YgR29vZ2xlIEluYy4gbm9yIHRoZSBuYW1lcyBvZiBpdHMKLSAqIGNvbnRy aWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBlbmRvcnNlIG9yIHByb21vdGUgcHJvZHVjdHMgZGVyaXZl ZCBmcm9tCi0gKiB0aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBw ZXJtaXNzaW9uLgotICoKLSAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlS SUdIVCBIT0xERVJTIEFORCBDT05UUklCVVRPUlMKLSAqICJBUyBJUyIgQU5EIEFOWSBFWFBSRVNT IE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UCi0gKiBMSU1JVEVEIFRP LCBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBG T1IKLSAqIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBT SEFMTCBUSEUgQ09QWVJJR0hUCi0gKiBPV05FUiBPUiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZP UiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwKLSAqIFNQRUNJQUwsIEVYRU1QTEFS WSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QKLSAqIExJTUlU RUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1Mg T0YgVVNFLAotICogREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBI T1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZCi0gKiBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVS IElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCi0gKiAoSU5DTFVESU5HIE5F R0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UK LSAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkg T0YgU1VDSCBEQU1BR0UuCi0gKi8KLQotI2luY2x1ZGUgImNvbmZpZy5oIgotI2luY2x1ZGUgIlY4 WE1MSHR0cFJlcXVlc3QuaCIKLQotI2luY2x1ZGUgIkZyYW1lLmgiCi0jaW5jbHVkZSAiT3JpZ2lu QWNjZXNzRW50cnkuaCIKLSNpbmNsdWRlICJTZWN1cml0eU9yaWdpbi5oIgotI2luY2x1ZGUgIlY4 QmluZGluZy5oIgotI2luY2x1ZGUgIlY4RE9NV2luZG93U2hlbGwuaCIKLSNpbmNsdWRlICJWOFV0 aWxpdGllcy5oIgotI2luY2x1ZGUgIldvcmtlckNvbnRleHQuaCIKLSNpbmNsdWRlICJXb3JrZXJD b250ZXh0RXhlY3V0aW9uUHJveHkuaCIKLQotbmFtZXNwYWNlIFdlYkNvcmUgewotCi12ODo6SGFu ZGxlPHY4OjpWYWx1ZT4gVjhYTUxIdHRwUmVxdWVzdDo6Y29uc3RydWN0b3JDYWxsYmFja0N1c3Rv bShjb25zdCB2ODo6QXJndW1lbnRzJiBhcmdzKQotewotICAgIFNjcmlwdEV4ZWN1dGlvbkNvbnRl eHQqIGNvbnRleHQgPSBnZXRTY3JpcHRFeGVjdXRpb25Db250ZXh0KCk7Ci0KLSAgICBSZWZQdHI8 U2VjdXJpdHlPcmlnaW4+IHNlY3VyaXR5T3JpZ2luOwotICAgIGlmIChjb250ZXh0LT5pc0RvY3Vt ZW50KCkpIHsKLSAgICAgICAgaWYgKERPTVdyYXBwZXJXb3JsZCogd29ybGQgPSB3b3JsZEZvckVu dGVyZWRDb250ZXh0SWZJc29sYXRlZCgpKQotICAgICAgICAgICAgc2VjdXJpdHlPcmlnaW4gPSB3 b3JsZC0+aXNvbGF0ZWRXb3JsZFNlY3VyaXR5T3JpZ2luKCk7Ci0gICAgfQotCi0gICAgUmVmUHRy PFhNTEh0dHBSZXF1ZXN0PiB4bWxIdHRwUmVxdWVzdCA9IFhNTEh0dHBSZXF1ZXN0OjpjcmVhdGUo Y29udGV4dCwgc2VjdXJpdHlPcmlnaW4pOwotCi0gICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiB3 cmFwcGVyID0gYXJncy5Ib2xkZXIoKTsKLSAgICBWOERPTVdyYXBwZXI6OmNyZWF0ZURPTVdyYXBw ZXIoeG1sSHR0cFJlcXVlc3QucmVsZWFzZSgpLCAmaW5mbywgd3JhcHBlcik7Ci0gICAgcmV0dXJu IHdyYXBwZXI7Ci19Ci0KLX0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFhNTEh0dHBSZXF1ZXN0Q3VzdG9tLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFhNTEh0dHBSZXF1ZXN0Q3VzdG9t LmNwcAppbmRleCA4NTg0NTYwYjRiYThmODkwNzhlN2Q0YTFmYjZhY2EyN2Q3ZTRiNzEzLi45MjE4 ZjZhOWUxNmI4NzAxN2NjZmY0ZWJiODk1OGE1N2M0NTZjZTlmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhYTUxIdHRwUmVxdWVzdEN1c3RvbS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4WE1MSHR0cFJlcXVlc3RDdXN0 b20uY3BwCkBAIC00OSw2ICs0OSwyMyBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK3Y4OjpI YW5kbGU8djg6OlZhbHVlPiBWOFhNTEh0dHBSZXF1ZXN0Ojpjb25zdHJ1Y3RvckNhbGxiYWNrQ3Vz dG9tKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MpCit7CisgICAgU2NyaXB0RXhlY3V0aW9uQ29u dGV4dCogY29udGV4dCA9IGdldFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKTsKKworICAgIFJlZlB0 cjxTZWN1cml0eU9yaWdpbj4gc2VjdXJpdHlPcmlnaW47CisgICAgaWYgKGNvbnRleHQtPmlzRG9j dW1lbnQoKSkgeworICAgICAgICBpZiAoRE9NV3JhcHBlcldvcmxkKiB3b3JsZCA9IHdvcmxkRm9y RW50ZXJlZENvbnRleHRJZklzb2xhdGVkKCkpCisgICAgICAgICAgICBzZWN1cml0eU9yaWdpbiA9 IHdvcmxkLT5pc29sYXRlZFdvcmxkU2VjdXJpdHlPcmlnaW4oKTsKKyAgICB9CisKKyAgICBSZWZQ dHI8WE1MSHR0cFJlcXVlc3Q+IHhtbEh0dHBSZXF1ZXN0ID0gWE1MSHR0cFJlcXVlc3Q6OmNyZWF0 ZShjb250ZXh0LCBzZWN1cml0eU9yaWdpbik7CisKKyAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+ IHdyYXBwZXIgPSBhcmdzLkhvbGRlcigpOworICAgIFY4RE9NV3JhcHBlcjo6Y3JlYXRlRE9NV3Jh cHBlcih4bWxIdHRwUmVxdWVzdC5yZWxlYXNlKCksICZpbmZvLCB3cmFwcGVyKTsKKyAgICByZXR1 cm4gd3JhcHBlcjsKK30KKwogdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4WE1MSHR0cFJlcXVlc3Q6 OnJlc3BvbnNlVGV4dEFjY2Vzc29yR2V0dGVyKHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBuYW1lLCBj b25zdCB2ODo6QWNjZXNzb3JJbmZvJiBpbmZvKQogewogICAgIElOQ19TVEFUUygiRE9NLlhNTEh0 dHBSZXF1ZXN0LnJlc3BvbnNldGV4dC5fZ2V0Iik7Cg==