102867 2012-11-20 20:38:00 -0800 [EFL][WK2] Remove setting word from ewk_view_setting_encoding_custom_XXX APIs 2012-11-21 02:56:26 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 js45.yang webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 772426 0 js45.yang 2012-11-20 20:38:00 -0800 ewk_view_setting_encoding_custom_XXX APIs might be misunderstanded as the "setting" word because ewk_view_setting_encoding_custom_set triggers the "reload" operation. And ewk_view_setting_XXX is not correct because there is ewk_settings object for settings. The setting word from ewk_view_setting_encoding_custom_XXX APIs should be removed. 772429 1 175332 js45.yang 2012-11-20 20:40:52 -0800 Created attachment 175332 Patch 772616 2 175332 rakuco 2012-11-21 01:34:43 -0800 Comment on attachment 175332 Patch This looks like a nice improvement; I suggest a few additional ones: o Please mention in the _set() documentation that the page is going to be reloaded. o "encoding_custom" still sounds a bit weird. How about "ewk_view_custom_encoding_{get,set}" or "ewk_view_custom_text_encoding_{get,set}"? 772638 3 js45.yang 2012-11-21 01:48:43 -0800 (In reply to comment #2) > (From update of attachment 175332 [details]) > This looks like a nice improvement; I suggest a few additional ones: > o Please mention in the _set() documentation that the page is going to be reloaded. > o "encoding_custom" still sounds a bit weird. How about "ewk_view_custom_encoding_{get,set}" or "ewk_view_custom_text_encoding_{get,set}"? Thanks for your review. I'll upload new patch. 772657 4 js45.yang 2012-11-21 01:58:16 -0800 (In reply to comment #2) > (From update of attachment 175332 [details]) > This looks like a nice improvement; I suggest a few additional ones: > o Please mention in the _set() documentation that the page is going to be reloaded. I checked that it was already mentioned like the below. * Sets the custom character encoding and reloads the page. > o "encoding_custom" still sounds a bit weird. How about "ewk_view_custom_encoding_{get,set}" or "ewk_view_custom_text_encoding_{get,set}"? I'll change that. 772672 5 175386 js45.yang 2012-11-21 02:18:38 -0800 Created attachment 175386 Patch 772689 6 175386 rakuco 2012-11-21 02:31:34 -0800 Comment on attachment 175386 Patch LGTM. 772718 7 175386 webkit.review.bot 2012-11-21 02:56:21 -0800 Comment on attachment 175386 Patch Clearing flags on attachment: 175386 Committed r135372: <http://trac.webkit.org/changeset/135372> 772719 8 webkit.review.bot 2012-11-21 02:56:26 -0800 All reviewed patches have been landed. Closing bug. 175332 2012-11-20 20:40:52 -0800 2012-11-21 02:18:33 -0800 Patch bug-102867-20121121133839.patch text/plain 6464 js45.yang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNmQ1NTkyYmZkOTFlMWJm YjQ1MDU3OTU4MTRkYmZmMmJjYWJhMDc5Mi4uZjY3ODI1YWNjY2U3N2RkYTE4YmVhMDU4MmNhNjJl MGY1MTQ0M2MzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTExLTIwICBKb25n c2VvayBZYW5nICA8anM0NS55YW5nQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl0g UmVtb3ZlICJzZXR0aW5nIiB3b3JkIGZyb20gZXdrX3ZpZXdfc2V0dGluZ19lbmNvZGluZ19jdXN0 b21fWFhYIEFQSXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMjg2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlbmFtZSBld2tfdmlld19zZXR0aW5nX2VuY29kaW5nX2N1c3RvbV9YWFggQVBJcyB0byBl d2tfdmlld19lbmNvZGluZ19jdXN0b21fWFhYIEFQSXMuCisKKyAgICAgICAgZXdrX3ZpZXdfc2V0 dGluZ19lbmNvZGluZ19jdXN0b21fWFhYIEFQSXMgbWlnaHQgYmUgbWlzdW5kZXJzdGFuZGVkIGFz IHRoZSAic2V0dGluZyIgd29yZAorICAgICAgICBiZWNhdXNlIGV3a192aWV3X3NldHRpbmdfZW5j b2RpbmdfY3VzdG9tX3NldCB0cmlnZ2VycyB0aGUgInJlbG9hZCIgb3BlcmF0aW9uLgorICAgICAg ICBBbmQgZXdrX3ZpZXdfc2V0dGluZ19YWFggaXMgbm90IGNvcnJlY3QgYmVjYXVzZSB0aGVyZSBp cyBld2tfc2V0dGluZ3Mgb2JqZWN0IGZvciBzZXR0aW5ncy4KKworICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvZWZsL2V3a192aWV3LmNwcDoKKyAgICAgICAgKGV3a192aWV3X2VuY29kaW5nX2N1c3Rv bV9nZXQpOgorICAgICAgICAoZXdrX3ZpZXdfZW5jb2RpbmdfY3VzdG9tX3NldCk6CisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHA6CisgICAgICAgIChURVNUX0YpOgorCiAyMDEy LTExLTE5ICBLeXVuZ1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtX SzJdIFVudXNlZCBwYXJhbWV0ZXJzIG9uIENvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5jcHAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAppbmRleCBmN2Vm NGY4MzVmYmZhMzdmYjdlNDkzMWRlZWYzZjI5MTI5OWJkOWZkLi4yZGE3MjNmYjc3ZDNkYmVkZTU1 ZGY3NmVkYzMzNTlhNzE0YzRhNzc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvZXdrX3ZpZXcuY3BwCkBAIC03NDYsMTQgKzc0NiwxNCBAQCBFaW5hX0Jvb2wgZXdrX3Zp ZXdfaHRtbF9zdHJpbmdfbG9hZChFdmFzX09iamVjdCogZXdrVmlldywgY29uc3QgY2hhciogaHRt bCwgY29ucwogICAgIHJldHVybiB0cnVlOwogfQogCi1jb25zdCBjaGFyKiBld2tfdmlld19zZXR0 aW5nX2VuY29kaW5nX2N1c3RvbV9nZXQoY29uc3QgRXZhc19PYmplY3QqIGV3a1ZpZXcpCitjb25z dCBjaGFyKiBld2tfdmlld19lbmNvZGluZ19jdXN0b21fZ2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBl d2tWaWV3KQogewogICAgIEVXS19WSUVXX0lNUExfR0VUX09SX1JFVFVSTihld2tWaWV3LCBpbXBs LCAwKTsKIAogICAgIHJldHVybiBpbXBsLT5jdXN0b21UZXh0RW5jb2RpbmdOYW1lKCk7CiB9CiAK LUVpbmFfQm9vbCBld2tfdmlld19zZXR0aW5nX2VuY29kaW5nX2N1c3RvbV9zZXQoRXZhc19PYmpl Y3QqIGV3a1ZpZXcsIGNvbnN0IGNoYXIqIGVuY29kaW5nKQorRWluYV9Cb29sIGV3a192aWV3X2Vu Y29kaW5nX2N1c3RvbV9zZXQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIGNvbnN0IGNoYXIqIGVuY29k aW5nKQogewogICAgIEVXS19WSUVXX0lNUExfR0VUX09SX1JFVFVSTihld2tWaWV3LCBpbXBsLCBm YWxzZSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3 a192aWV3LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5oCmlu ZGV4IDc1MDE2MTE3NGI5YTQ1N2ZmMmVkZTk4ODUxOGIwYjM0Njc3MmI1N2YuLmI0NWNjNzQ1ZTMx NzJiNzI1NjEzZmM4OGI1M2UxMzc2Mjc5MWI1ZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaApAQCAtNjQ4LDcgKzY0OCw3IEBAIEVBUEkgY29uc3QgY2hh ciAqZXdrX3ZpZXdfdGhlbWVfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0ICpvKTsKICAqIEByZXR1cm4g QGMgZWluYV9zdHJpbnNoYXJlIGNvbnRhaW5pbmcgdGhlIGN1cnJlbnQgZW5jb2RpbmcsIG9yCiAg KiAgICAgICAgIEBjIE5VTEwgaWYgaXQncyBub3Qgc2V0CiAgKi8KLUVBUEkgY29uc3QgY2hhciAg KmV3a192aWV3X3NldHRpbmdfZW5jb2RpbmdfY3VzdG9tX2dldChjb25zdCBFdmFzX09iamVjdCAq byk7CitFQVBJIGNvbnN0IGNoYXIgICpld2tfdmlld19lbmNvZGluZ19jdXN0b21fZ2V0KGNvbnN0 IEV2YXNfT2JqZWN0ICpvKTsKIAogLyoqCiAgKiBTZXRzIHRoZSBjdXN0b20gY2hhcmFjdGVyIGVu Y29kaW5nIGFuZCByZWxvYWRzIHRoZSBwYWdlLgpAQCAtNjU4LDcgKzY1OCw3IEBAIEVBUEkgY29u c3QgY2hhciAgKmV3a192aWV3X3NldHRpbmdfZW5jb2RpbmdfY3VzdG9tX2dldChjb25zdCBFdmFz X09iamVjdCAqbyk7CiAgKgogICogQHJldHVybiBAYyBFSU5BX1RSVUUgb24gc3VjY2VzcyBAYyBF SU5BX0ZBTFNFIG90aGVyd2lzZQogICovCi1FQVBJIEVpbmFfQm9vbCAgICBld2tfdmlld19zZXR0 aW5nX2VuY29kaW5nX2N1c3RvbV9zZXQoRXZhc19PYmplY3QgKm8sIGNvbnN0IGNoYXIgKmVuY29k aW5nKTsKK0VBUEkgRWluYV9Cb29sICAgIGV3a192aWV3X2VuY29kaW5nX2N1c3RvbV9zZXQoRXZh c19PYmplY3QgKm8sIGNvbnN0IGNoYXIgKmVuY29kaW5nKTsKIAogLyoqCiAgKiBTZWFyY2hlcyBh bmQgaGlnaHRsaWdodHMgdGhlIGdpdmVuIHN0cmluZyBpbiB0aGUgZG9jdW1lbnQuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmll dy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJf dmlldy5jcHAKaW5kZXggZWQ1YmJiMWJiMWEwN2NiNTU2ZjVjZDIwZjZlZThiYTIxN2YwODQ0ZS4u OWZlM2E0YzUyZWFkNzFkYTNlOTVjZWM5NmQ5YTZmZWExNzc5YWVkMCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl92aWV3 LmNwcApAQCAtMTQyLDEyICsxNDIsMTIgQEAgVEVTVF9GKEVXSzJVbml0VGVzdEJhc2UsIGV3a192 aWV3X25hdmlnYXRpb24pCiAKIFRFU1RfRihFV0syVW5pdFRlc3RCYXNlLCBld2tfdmlld19zZXR0 aW5nX2VuY29kaW5nX2N1c3RvbSkKIHsKLSAgICBBU1NFUlRfRkFMU0UoZXdrX3ZpZXdfc2V0dGlu Z19lbmNvZGluZ19jdXN0b21fZ2V0KHdlYlZpZXcoKSkpOwotICAgIEFTU0VSVF9UUlVFKGV3a192 aWV3X3NldHRpbmdfZW5jb2RpbmdfY3VzdG9tX3NldCh3ZWJWaWV3KCksICJVVEYtOCIpKTsKLSAg ICBBU1NFUlRfU1RSRVEoIlVURi04IiwgZXdrX3ZpZXdfc2V0dGluZ19lbmNvZGluZ19jdXN0b21f Z2V0KHdlYlZpZXcoKSkpOworICAgIEFTU0VSVF9GQUxTRShld2tfdmlld19lbmNvZGluZ19jdXN0 b21fZ2V0KHdlYlZpZXcoKSkpOworICAgIEFTU0VSVF9UUlVFKGV3a192aWV3X2VuY29kaW5nX2N1 c3RvbV9zZXQod2ViVmlldygpLCAiVVRGLTgiKSk7CisgICAgQVNTRVJUX1NUUkVRKCJVVEYtOCIs IGV3a192aWV3X2VuY29kaW5nX2N1c3RvbV9nZXQod2ViVmlldygpKSk7CiAgICAgLy8gU2V0IHRo ZSBkZWZhdWx0IGNoYXJzZXQuCi0gICAgQVNTRVJUX1RSVUUoZXdrX3ZpZXdfc2V0dGluZ19lbmNv ZGluZ19jdXN0b21fc2V0KHdlYlZpZXcoKSwgMCkpOwotICAgIEFTU0VSVF9GQUxTRShld2tfdmll d19zZXR0aW5nX2VuY29kaW5nX2N1c3RvbV9nZXQod2ViVmlldygpKSk7CisgICAgQVNTRVJUX1RS VUUoZXdrX3ZpZXdfZW5jb2RpbmdfY3VzdG9tX3NldCh3ZWJWaWV3KCksIDApKTsKKyAgICBBU1NF UlRfRkFMU0UoZXdrX3ZpZXdfZW5jb2RpbmdfY3VzdG9tX2dldCh3ZWJWaWV3KCkpKTsKIH0KIAog c3RhdGljIHZvaWQgb25Gb3JtQWJvdXRUb0JlU3VibWl0dGVkKHZvaWQqIHVzZXJEYXRhLCBFdmFz X09iamVjdCosIHZvaWQqIGV2ZW50SW5mbykKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3ZDQ1YzhjYTlhYjNlNTUwM2VlNmNhNDBkMmQyMGViNDYy N2M2OTQ5Li5hYjExNjgzMDg2Yjk1N2ZhY2MxZDEzNWI2ZTFjZTEwMDQwMWYwMzk1IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMTEtMjAgIEpvbmdzZW9rIFlhbmcgIDxqczQ1LnlhbmdAc2Ftc3VuZy5jb20+CisK KyAgICAgICAgW0VGTF1bV0syXSBSZW1vdmUgInNldHRpbmciIHdvcmQgZnJvbSBld2tfdmlld19z ZXR0aW5nX2VuY29kaW5nX2N1c3RvbV9YWFggQVBJcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyODY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmVuYW1lIGV3a192aWV3X3NldHRpbmdfZW5jb2Rpbmdf Y3VzdG9tX1hYWCBBUElzIHRvIGV3a192aWV3X2VuY29kaW5nX2N1c3RvbV9YWFggQVBJcy4KKwor ICAgICAgICBld2tfdmlld19zZXR0aW5nX2VuY29kaW5nX2N1c3RvbV9YWFggQVBJcyBtaWdodCBi ZSBtaXN1bmRlcnN0YW5kZWQgYXMgdGhlICJzZXR0aW5nIiB3b3JkCisgICAgICAgIGJlY2F1c2Ug ZXdrX3ZpZXdfc2V0dGluZ19lbmNvZGluZ19jdXN0b21fc2V0IHRyaWdnZXJzIHRoZSAicmVsb2Fk IiBvcGVyYXRpb24uCisgICAgICAgIEFuZCBld2tfdmlld19zZXR0aW5nX1hYWCBpcyBub3QgY29y cmVjdCBiZWNhdXNlIHRoZXJlIGlzIGV3a19zZXR0aW5ncyBvYmplY3QgZm9yIHNldHRpbmdzLgor CisgICAgICAgICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAgICAgKG9uX2tleV9kb3du KToKKwogMjAxMi0xMS0yMCAgTWF0ZXVzeiBMZXN6a28gIDxtLmxlc3prb0BzYW1zdW5nLmNvbT4K IAogICAgICAgICBbRUZMXVtHVEtdU2hhcmluZyBhY2Nlc3NpYmlsaXR5IHN1cHBvcnQgaW4gV2Vi S2l0VGVzdFJ1bm5lci4KZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMg Yi9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCmluZGV4IDkyZDNmMmZmOWYzZTQyNmNhNWE4 OTcxMzEwYTM4NDU2NmEwNGM4N2QuLjQ3NWZkMTVmZWEzOGI5MmQ3MjIyNWFiZTI2MGE3YmY0MDY1 MGE5MGEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKKysrIGIvVG9v bHMvTWluaUJyb3dzZXIvZWZsL21haW4uYwpAQCAtMTgxLDcgKzE4MSw3IEBAIG9uX2tleV9kb3du KHZvaWQgKnVzZXJfZGF0YSwgRXZhcyAqZSwgRXZhc19PYmplY3QgKmV3a192aWV3LCB2b2lkICpl dmVudF9pbmZvKQogICAgIH0gZWxzZSBpZiAoIXN0cmNtcChldi0+a2V5LCAiRjMiKSkgewogICAg ICAgICBjdXJyZW50RW5jb2RpbmcgPSAoY3VycmVudEVuY29kaW5nICsgMSkgJSAoc2l6ZW9mKGVu Y29kaW5ncykgLyBzaXplb2YoZW5jb2RpbmdzWzBdKSk7CiAgICAgICAgIGluZm8oIlNldCBlbmNv ZGluZyAoRjMpIHByZXNzZWQuIE5ldyBlbmNvZGluZyB0byAlcyIsIGVuY29kaW5nc1tjdXJyZW50 RW5jb2RpbmddKTsKLSAgICAgICAgZXdrX3ZpZXdfc2V0dGluZ19lbmNvZGluZ19jdXN0b21fc2V0 KGV3a192aWV3LCBlbmNvZGluZ3NbY3VycmVudEVuY29kaW5nXSk7CisgICAgICAgIGV3a192aWV3 X2VuY29kaW5nX2N1c3RvbV9zZXQoZXdrX3ZpZXcsIGVuY29kaW5nc1tjdXJyZW50RW5jb2Rpbmdd KTsKICAgICB9IGVsc2UgaWYgKCFzdHJjbXAoZXYtPmtleSwgIkY1IikpIHsKICAgICAgICAgaW5m bygiUmVsb2FkIChGNSkgd2FzIHByZXNzZWQsIHJlbG9hZGluZy5cbiIpOwogICAgICAgICBld2tf dmlld19yZWxvYWQoZXdrX3ZpZXcpOwo= 175386 2012-11-21 02:18:38 -0800 2012-11-21 02:56:21 -0800 Patch bug-102867-20121121191625.patch text/plain 6458 js45.yang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNmQ1NTkyYmZkOTFlMWJm YjQ1MDU3OTU4MTRkYmZmMmJjYWJhMDc5Mi4uMDg5MDNjNmI3NzljNTgwZjBkMDIxOWY4NTU3MmE2 NmU3ODc5OTVjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTExLTIwICBKb25n c2VvayBZYW5nICA8anM0NS55YW5nQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl0g UmVuYW1lIGV3a192aWV3X3NldHRpbmdfZW5jb2RpbmdfY3VzdG9tX1hYWCB0byBld2tfdmlld19j dXN0b21fZW5jb2RpbmdfWFhYCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMDI4NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSZW5hbWUgZXdrX3ZpZXdfc2V0dGluZ19lbmNvZGluZ19jdXN0b21fWFhYIHRv IGV3a192aWV3X2N1c3RvbV9lbmNvZGluZ19YWFguCisKKyAgICAgICAgZXdrX3ZpZXdfc2V0dGlu Z19lbmNvZGluZ19jdXN0b21fWFhYIEFQSXMgbWlnaHQgYmUgbWlzdW5kZXJzdGFuZGVkIGFzIHRo ZSAic2V0dGluZyIgd29yZAorICAgICAgICBiZWNhdXNlIGV3a192aWV3X3NldHRpbmdfZW5jb2Rp bmdfY3VzdG9tX3NldCB0cmlnZ2VycyB0aGUgInJlbG9hZCIgb3BlcmF0aW9uLgorICAgICAgICBB bmQgZXdrX3ZpZXdfc2V0dGluZ19YWFggaXMgbm90IGNvcnJlY3QgYmVjYXVzZSB0aGVyZSBpcyBl d2tfc2V0dGluZ3Mgb2JqZWN0IGZvciBzZXR0aW5ncy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvZWZsL2V3a192aWV3LmNwcDoKKyAgICAgICAgKGV3a192aWV3X2VuY29kaW5nX2N1c3RvbV9n ZXQpOgorICAgICAgICAoZXdrX3ZpZXdfZW5jb2RpbmdfY3VzdG9tX3NldCk6CisgICAgICAgICog VUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2Vm bC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHA6CisgICAgICAgIChURVNUX0YpOgorCiAyMDEyLTEx LTE5ICBLeXVuZ1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtXSzJd IFVudXNlZCBwYXJhbWV0ZXJzIG9uIENvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5jcHAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAppbmRleCBmN2VmNGY4 MzVmYmZhMzdmYjdlNDkzMWRlZWYzZjI5MTI5OWJkOWZkLi40MTRlYWJlZWNmYjIwZjlhZjE3MzYz ZGQ0ODMyZjg0ODEwYjFmZWJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2VmbC9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l ZmwvZXdrX3ZpZXcuY3BwCkBAIC03NDYsMTQgKzc0NiwxNCBAQCBFaW5hX0Jvb2wgZXdrX3ZpZXdf aHRtbF9zdHJpbmdfbG9hZChFdmFzX09iamVjdCogZXdrVmlldywgY29uc3QgY2hhciogaHRtbCwg Y29ucwogICAgIHJldHVybiB0cnVlOwogfQogCi1jb25zdCBjaGFyKiBld2tfdmlld19zZXR0aW5n X2VuY29kaW5nX2N1c3RvbV9nZXQoY29uc3QgRXZhc19PYmplY3QqIGV3a1ZpZXcpCitjb25zdCBj aGFyKiBld2tfdmlld19jdXN0b21fZW5jb2RpbmdfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBld2tW aWV3KQogewogICAgIEVXS19WSUVXX0lNUExfR0VUX09SX1JFVFVSTihld2tWaWV3LCBpbXBsLCAw KTsKIAogICAgIHJldHVybiBpbXBsLT5jdXN0b21UZXh0RW5jb2RpbmdOYW1lKCk7CiB9CiAKLUVp bmFfQm9vbCBld2tfdmlld19zZXR0aW5nX2VuY29kaW5nX2N1c3RvbV9zZXQoRXZhc19PYmplY3Qq IGV3a1ZpZXcsIGNvbnN0IGNoYXIqIGVuY29kaW5nKQorRWluYV9Cb29sIGV3a192aWV3X2N1c3Rv bV9lbmNvZGluZ19zZXQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIGNvbnN0IGNoYXIqIGVuY29kaW5n KQogewogICAgIEVXS19WSUVXX0lNUExfR0VUX09SX1JFVFVSTihld2tWaWV3LCBpbXBsLCBmYWxz ZSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192 aWV3LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5oCmluZGV4 IDc1MDE2MTE3NGI5YTQ1N2ZmMmVkZTk4ODUxOGIwYjM0Njc3MmI1N2YuLjRiMGI4MzgzOGUyMWQy MTk0OTJmMmJiZjZiYzBjMzdiMDY0NzM4NDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvZXdrX3ZpZXcuaApAQCAtNjQ4LDcgKzY0OCw3IEBAIEVBUEkgY29uc3QgY2hhciAq ZXdrX3ZpZXdfdGhlbWVfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0ICpvKTsKICAqIEByZXR1cm4gQGMg ZWluYV9zdHJpbnNoYXJlIGNvbnRhaW5pbmcgdGhlIGN1cnJlbnQgZW5jb2RpbmcsIG9yCiAgKiAg ICAgICAgIEBjIE5VTEwgaWYgaXQncyBub3Qgc2V0CiAgKi8KLUVBUEkgY29uc3QgY2hhciAgKmV3 a192aWV3X3NldHRpbmdfZW5jb2RpbmdfY3VzdG9tX2dldChjb25zdCBFdmFzX09iamVjdCAqbyk7 CitFQVBJIGNvbnN0IGNoYXIgICpld2tfdmlld19jdXN0b21fZW5jb2RpbmdfZ2V0KGNvbnN0IEV2 YXNfT2JqZWN0ICpvKTsKIAogLyoqCiAgKiBTZXRzIHRoZSBjdXN0b20gY2hhcmFjdGVyIGVuY29k aW5nIGFuZCByZWxvYWRzIHRoZSBwYWdlLgpAQCAtNjU4LDcgKzY1OCw3IEBAIEVBUEkgY29uc3Qg Y2hhciAgKmV3a192aWV3X3NldHRpbmdfZW5jb2RpbmdfY3VzdG9tX2dldChjb25zdCBFdmFzX09i amVjdCAqbyk7CiAgKgogICogQHJldHVybiBAYyBFSU5BX1RSVUUgb24gc3VjY2VzcyBAYyBFSU5B X0ZBTFNFIG90aGVyd2lzZQogICovCi1FQVBJIEVpbmFfQm9vbCAgICBld2tfdmlld19zZXR0aW5n X2VuY29kaW5nX2N1c3RvbV9zZXQoRXZhc19PYmplY3QgKm8sIGNvbnN0IGNoYXIgKmVuY29kaW5n KTsKK0VBUEkgRWluYV9Cb29sICAgIGV3a192aWV3X2N1c3RvbV9lbmNvZGluZ19zZXQoRXZhc19P YmplY3QgKm8sIGNvbnN0IGNoYXIgKmVuY29kaW5nKTsKIAogLyoqCiAgKiBTZWFyY2hlcyBhbmQg aGlnaHRsaWdodHMgdGhlIGdpdmVuIHN0cmluZyBpbiB0aGUgZG9jdW1lbnQuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmll dy5jcHAKaW5kZXggZWQ1YmJiMWJiMWEwN2NiNTU2ZjVjZDIwZjZlZThiYTIxN2YwODQ0ZS4uM2E2 YzZiYWJlNTM3ZjE0MTZjMzI3MDdlNTE2NmIyMzc0NTQyMmU2ZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl92aWV3LmNw cApAQCAtMTQyLDEyICsxNDIsMTIgQEAgVEVTVF9GKEVXSzJVbml0VGVzdEJhc2UsIGV3a192aWV3 X25hdmlnYXRpb24pCiAKIFRFU1RfRihFV0syVW5pdFRlc3RCYXNlLCBld2tfdmlld19zZXR0aW5n X2VuY29kaW5nX2N1c3RvbSkKIHsKLSAgICBBU1NFUlRfRkFMU0UoZXdrX3ZpZXdfc2V0dGluZ19l bmNvZGluZ19jdXN0b21fZ2V0KHdlYlZpZXcoKSkpOwotICAgIEFTU0VSVF9UUlVFKGV3a192aWV3 X3NldHRpbmdfZW5jb2RpbmdfY3VzdG9tX3NldCh3ZWJWaWV3KCksICJVVEYtOCIpKTsKLSAgICBB U1NFUlRfU1RSRVEoIlVURi04IiwgZXdrX3ZpZXdfc2V0dGluZ19lbmNvZGluZ19jdXN0b21fZ2V0 KHdlYlZpZXcoKSkpOworICAgIEFTU0VSVF9GQUxTRShld2tfdmlld19jdXN0b21fZW5jb2Rpbmdf Z2V0KHdlYlZpZXcoKSkpOworICAgIEFTU0VSVF9UUlVFKGV3a192aWV3X2N1c3RvbV9lbmNvZGlu Z19zZXQod2ViVmlldygpLCAiVVRGLTgiKSk7CisgICAgQVNTRVJUX1NUUkVRKCJVVEYtOCIsIGV3 a192aWV3X2N1c3RvbV9lbmNvZGluZ19nZXQod2ViVmlldygpKSk7CiAgICAgLy8gU2V0IHRoZSBk ZWZhdWx0IGNoYXJzZXQuCi0gICAgQVNTRVJUX1RSVUUoZXdrX3ZpZXdfc2V0dGluZ19lbmNvZGlu Z19jdXN0b21fc2V0KHdlYlZpZXcoKSwgMCkpOwotICAgIEFTU0VSVF9GQUxTRShld2tfdmlld19z ZXR0aW5nX2VuY29kaW5nX2N1c3RvbV9nZXQod2ViVmlldygpKSk7CisgICAgQVNTRVJUX1RSVUUo ZXdrX3ZpZXdfY3VzdG9tX2VuY29kaW5nX3NldCh3ZWJWaWV3KCksIDApKTsKKyAgICBBU1NFUlRf RkFMU0UoZXdrX3ZpZXdfY3VzdG9tX2VuY29kaW5nX2dldCh3ZWJWaWV3KCkpKTsKIH0KIAogc3Rh dGljIHZvaWQgb25Gb3JtQWJvdXRUb0JlU3VibWl0dGVkKHZvaWQqIHVzZXJEYXRhLCBFdmFzX09i amVjdCosIHZvaWQqIGV2ZW50SW5mbykKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rv b2xzL0NoYW5nZUxvZwppbmRleCA3ZDQ1YzhjYTlhYjNlNTUwM2VlNmNhNDBkMmQyMGViNDYyN2M2 OTQ5Li5kNzBiMDk2NjdmYWFlOGE4YWMwOGU1OGE0NGExZmFhNGZmODhlY2YzIDEwMDY0NAotLS0g YS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTItMTEtMjAgIEpvbmdzZW9rIFlhbmcgIDxqczQ1LnlhbmdAc2Ftc3VuZy5jb20+CisKKyAg ICAgICAgW0VGTF1bV0syXSBSZW5hbWUgZXdrX3ZpZXdfc2V0dGluZ19lbmNvZGluZ19jdXN0b21f WFhYIHRvIGV3a192aWV3X2N1c3RvbV9lbmNvZGluZ19YWFgKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjg2NworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbmFtZSBld2tfdmlld19zZXR0aW5nX2VuY29k aW5nX2N1c3RvbV9YWFggdG8gZXdrX3ZpZXdfY3VzdG9tX2VuY29kaW5nX1hYWC4KKworICAgICAg ICBld2tfdmlld19zZXR0aW5nX2VuY29kaW5nX2N1c3RvbV9YWFggQVBJcyBtaWdodCBiZSBtaXN1 bmRlcnN0YW5kZWQgYXMgdGhlICJzZXR0aW5nIiB3b3JkCisgICAgICAgIGJlY2F1c2UgZXdrX3Zp ZXdfc2V0dGluZ19lbmNvZGluZ19jdXN0b21fc2V0IHRyaWdnZXJzIHRoZSAicmVsb2FkIiBvcGVy YXRpb24uCisgICAgICAgIEFuZCBld2tfdmlld19zZXR0aW5nX1hYWCBpcyBub3QgY29ycmVjdCBi ZWNhdXNlIHRoZXJlIGlzIGV3a19zZXR0aW5ncyBvYmplY3QgZm9yIHNldHRpbmdzLgorCisgICAg ICAgICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAgICAgKG9uX2tleV9kb3duKToKKwog MjAxMi0xMS0yMCAgTWF0ZXVzeiBMZXN6a28gIDxtLmxlc3prb0BzYW1zdW5nLmNvbT4KIAogICAg ICAgICBbRUZMXVtHVEtdU2hhcmluZyBhY2Nlc3NpYmlsaXR5IHN1cHBvcnQgaW4gV2ViS2l0VGVz dFJ1bm5lci4KZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMgYi9Ub29s cy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCmluZGV4IDkyZDNmMmZmOWYzZTQyNmNhNWE4OTcxMzEw YTM4NDU2NmEwNGM4N2QuLjI2MTg4MmZmOWQ5ODc5OGRiN2Q1Y2FkMTU0M2YyZDI4NjJmNTdlYjEg MTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKKysrIGIvVG9vbHMvTWlu aUJyb3dzZXIvZWZsL21haW4uYwpAQCAtMTgxLDcgKzE4MSw3IEBAIG9uX2tleV9kb3duKHZvaWQg KnVzZXJfZGF0YSwgRXZhcyAqZSwgRXZhc19PYmplY3QgKmV3a192aWV3LCB2b2lkICpldmVudF9p bmZvKQogICAgIH0gZWxzZSBpZiAoIXN0cmNtcChldi0+a2V5LCAiRjMiKSkgewogICAgICAgICBj dXJyZW50RW5jb2RpbmcgPSAoY3VycmVudEVuY29kaW5nICsgMSkgJSAoc2l6ZW9mKGVuY29kaW5n cykgLyBzaXplb2YoZW5jb2RpbmdzWzBdKSk7CiAgICAgICAgIGluZm8oIlNldCBlbmNvZGluZyAo RjMpIHByZXNzZWQuIE5ldyBlbmNvZGluZyB0byAlcyIsIGVuY29kaW5nc1tjdXJyZW50RW5jb2Rp bmddKTsKLSAgICAgICAgZXdrX3ZpZXdfc2V0dGluZ19lbmNvZGluZ19jdXN0b21fc2V0KGV3a192 aWV3LCBlbmNvZGluZ3NbY3VycmVudEVuY29kaW5nXSk7CisgICAgICAgIGV3a192aWV3X2N1c3Rv bV9lbmNvZGluZ19zZXQoZXdrX3ZpZXcsIGVuY29kaW5nc1tjdXJyZW50RW5jb2RpbmddKTsKICAg ICB9IGVsc2UgaWYgKCFzdHJjbXAoZXYtPmtleSwgIkY1IikpIHsKICAgICAgICAgaW5mbygiUmVs b2FkIChGNSkgd2FzIHByZXNzZWQsIHJlbG9hZGluZy5cbiIpOwogICAgICAgICBld2tfdmlld19y ZWxvYWQoZXdrX3ZpZXcpOwo=