102865 2012-11-20 20:35:20 -0800 [EFL][WK2] Correct the parameters of WebPlatformTouchPoint. 2012-11-22 00:44:41 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enmi.lee enmi.lee gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 772421 0 enmi.lee 2012-11-20 20:35:20 -0800 WebPlatformTouchPoint() gets the screen position as a 3rd parameter and contents position as a fourth parameter, But we are passing the contents position as a 3rd parameter and screen position as a fourth parameter. So, I want to correct that. 772428 1 175331 enmi.lee 2012-11-20 20:39:32 -0800 Created attachment 175331 Patch 773496 2 laszlo.gombos 2012-11-21 19:16:40 -0800 This looks good to me. I think it would also help if we could consistently order the arguments everywhere so that screen/device position comes first and content position follows (e.g. in WebEventFactory::createWebTouchEvent(), NativeWebTouchEvent::NativeWebTouchEvent()). Kenneth, what do you think ? 773672 3 175331 kenneth 2012-11-22 00:17:59 -0800 Comment on attachment 175331 Patch Could this be tested somehow? At least the content position part should be testable 773692 4 175331 webkit.review.bot 2012-11-22 00:41:08 -0800 Comment on attachment 175331 Patch Clearing flags on attachment: 175331 Committed r135491: <http://trac.webkit.org/changeset/135491> 773693 5 webkit.review.bot 2012-11-22 00:41:13 -0800 All reviewed patches have been landed. Closing bug. 773694 6 enmi.lee 2012-11-22 00:44:41 -0800 (In reply to comment #3) > (From update of attachment 175331 [details]) > Could this be tested somehow? At least the content position part should be testable Actually, I found and tested this problem on Tizen. I agree with you and we need test cases to test positions. 175331 2012-11-20 20:39:32 -0800 2012-11-22 00:41:08 -0800 Patch bug-102865-20121121133719.patch text/plain 1660 enmi.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjBhYTAxMjcyYWY3YWI1 YWJmMTVmMjU0ZDJlZGRjMzFhY2U5NzQ0Ny4uYjZiNDdlMDUxODc4MjhjNGMyZDY2MjYyMWM1OWI3 Y2NlYjcyNmNiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTIwICBFdW5t aSBMZWUgIDxldW5taTE1LmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIENv cnJlY3QgdGhlIHBhcmFtZXRlcnMgb2YgV2ViUGxhdGZvcm1Ub3VjaFBvaW50LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyODY1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2V0IHRoZSBzY3JlZW4gcG9z aXRpb24gYXMgYSB0aGlyZCBwYXJhbWV0ZXIgYW5kIGNvbnRlbnRzIHBvc2l0aW9uIGFzCisgICAg ICAgIGEgZm91cnRoIHBhcmFtZXRlciBvZiBXZWJQbGF0Zm9ybVRvdWNoUG9pbnQoKS4KKworICAg ICAgICAqIFNoYXJlZC9lZmwvV2ViRXZlbnRGYWN0b3J5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6 V2ViRXZlbnRGYWN0b3J5OjpjcmVhdGVXZWJUb3VjaEV2ZW50KToKKwogMjAxMi0xMS0yMCAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjEzNTI5NS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1No YXJlZC9lZmwvV2ViRXZlbnRGYWN0b3J5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9lZmwv V2ViRXZlbnRGYWN0b3J5LmNwcAppbmRleCAwNDI5NTg3MTRmY2Q2Y2NhOTgyZjE0ZmYzMzU0OGEy OGQ4NGM4ZWM3Li5iOTk5MjUwODQzOGQ3MGYxNGYxMTM5YTk0MTM0NDAwMGFiOThjY2U0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvZWZsL1dlYkV2ZW50RmFjdG9yeS5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvU2hhcmVkL2VmbC9XZWJFdmVudEZhY3RvcnkuY3BwCkBAIC0yNTAs NyArMjUwLDcgQEAgV2ViVG91Y2hFdmVudCBXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYlRvdWNo RXZlbnQoRXdrX1RvdWNoX0V2ZW50X1R5cGUgdHlwZSwgY28KICAgICAgICAgfQogCiAgICAgICAg IEludFBvaW50IHBvcyhwb2ludC0+eCwgcG9pbnQtPnkpOwotICAgICAgICB0b3VjaFBvaW50cy5h cHBlbmQoV2ViUGxhdGZvcm1Ub3VjaFBvaW50KHBvaW50LT5pZCwgc3RhdGUsIHRvV2ViQ29udGVu dC5tYXBQb2ludChwb3MpLCB0b0RldmljZVNjcmVlbi5tYXBQb2ludChwb3MpKSk7CisgICAgICAg IHRvdWNoUG9pbnRzLmFwcGVuZChXZWJQbGF0Zm9ybVRvdWNoUG9pbnQocG9pbnQtPmlkLCBzdGF0 ZSwgdG9EZXZpY2VTY3JlZW4ubWFwUG9pbnQocG9zKSwgdG9XZWJDb250ZW50Lm1hcFBvaW50KHBv cykpKTsKICAgICB9CiAKICAgICByZXR1cm4gV2ViVG91Y2hFdmVudCh0eXBlRm9yVG91Y2hFdmVu dCh0eXBlKSwgdG91Y2hQb2ludHMsIG1vZGlmaWVyc0ZvckV2ZW50KG1vZGlmaWVycyksIHRpbWVz dGFtcCk7Cg==