102858 2012-11-20 19:08:45 -0800 [v8] 4% regression in dom_traverse tests 2013-09-01 10:34:38 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 103821 1 ojan abarth abarth andersca cdumez haraken oldest_to_newest 772378 0 ojan 2012-11-20 19:08:45 -0800 haraken, abarth, looks to be one of your patches. http://build.chromium.org/f/chromium/perf/chromium-rel-win7-webkit/dromaeo_domcoretraverse/report.html?rev=168181&graph=dom_traverse_previousSibling&trace=score&history=150 http://build.chromium.org/f/chromium/perf/chromium-rel-win7-webkit/dromaeo_domcoretraverse/report.html?rev=168181&graph=dom_traverse_nextSibling&trace=score&history=150 http://build.chromium.org/f/chromium/perf/chromium-rel-win7-webkit/dromaeo_domcoretraverse/report.html?rev=168181&graph=dom_traverse_previousSibling&history=150 http://build.chromium.org/f/chromium/perf/chromium-rel-win7-webkit/dromaeo_domcoretraverse/report.html?rev=168181&graph=dom_traverse_nextSibling&history=150 Regression range seems to be http://trac.webkit.org/log/?verbose=on&rev=134736&stop_rev=134728. 776996 1 ojan 2012-11-27 11:12:06 -0800 ping 777342 2 haraken 2012-11-27 16:24:01 -0800 (In reply to comment #0) > Regression range seems to be http://trac.webkit.org/log/?verbose=on&rev=134736&stop_rev=134728. abarth: Maybe the culprit is r134729 ? Other changes in the range don't change generated code at all. 777345 3 abarth 2012-11-27 16:25:27 -0800 Sure. We can revert that patch to see. We'll need to do the revert manually though. 777944 4 176492 abarth 2012-11-28 08:47:48 -0800 Created attachment 176492 Patch 777948 5 176492 abarth 2012-11-28 08:50:59 -0800 Comment on attachment 176492 Patch Clearing flags on attachment: 176492 Committed r136015: <http://trac.webkit.org/changeset/136015> 777950 6 abarth 2012-11-28 08:51:43 -0800 I'm leaving this bug open to remind us to check where the bot is actually healed. 778381 7 abarth 2012-11-28 14:52:38 -0800 No luck. 778705 8 cdumez 2012-11-28 22:42:18 -0800 After the roll out, the following bindings generation test is failing: FAIL: (V8) V8TestNode.h --- WebCore/bindings/scripts/test/V8/V8TestNode.h 2012-11-19 18:49:35.208640094 -0800 +++ /tmp/tmpIYlIMK/V8TestNode.h 2012-11-28 09:23:10.983184745 -0800 @@ -88,10 +88,11 @@ // in an isolated world. The fastest way we know how to do that is to check // whether the holder's inline wrapper is the same wrapper we see in the // v8::AccessorInfo. - v8::Handle<v8::Object> wrapper = (holder->wrapper() == info.Holder()) ? impl->wrapper() : DOMDataStore::getNode(impl, info.GetIsolate()); + v8::Handle<v8::Object> holderWrapper = info.Holder(); + v8::Handle<v8::Object> wrapper = (holder->wrapper() == holderWrapper) ? impl->wrapper() : DOMDataStore::getNode(impl, info.GetIsolate()); if (!wrapper.IsEmpty()) return wrapper; - return wrap(impl, info.Holder(), info.GetIsolate()); + return wrap(impl, holderWrapper, info.GetIsolate()); } inline v8::Handle<v8::Value> toV8(PassRefPtr< TestNode > impl, v8::Handle<v8::Object> creationContext = v8::Handle<v8::Object>(), v8::Isolate* isolate = 0) 778706 9 haraken 2012-11-28 22:45:31 -0800 (In reply to comment #8) > After the roll out, the following bindings generation test is failing: Sorry, fixed in r136100. 780558 10 ojan 2012-11-30 17:02:37 -0800 (In reply to comment #7) > No luck. Not only that, it may have caused https://bugs.webkit.org/show_bug.cgi?id=103791. 923513 11 andersca 2013-09-01 10:34:38 -0700 V8 is gone. 176492 2012-11-28 08:47:48 -0800 2012-11-28 08:50:59 -0800 Patch bug-102858-20121128084523.patch text/plain 1987 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2QxZjc2MGFhMDI4ZGI4 ZDg2ZTZmMjk0NTk4Y2ZlNmIzMTFkNGNmNS4uMjZkNzM4ZTRiNjZiN2ZjYWEyMTM4NDVmOWJjNzI3 MTc1OGI2ZDhkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTI4ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW3Y4XSA0JSByZWdyZXNzaW9u IGluIGRvbV90cmF2ZXJzZSB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTAyODU4CisKKyAgICAgICAgVW5yZXZpZXdlZC4KKworICAgICAgICBU aGlzIHBhdGNoIGlzIGEgbWFudWFsIHJvbGxvdXQgb2YKKyAgICAgICAgaHR0cDovL3RyYWMud2Vi a2l0Lm9yZy9jaGFuZ2VzZXQvMTM0NzI5LiBXZSBjYW4ndCBkbyBhIG1lY2hhbmljYWwKKyAgICAg ICAgcm9sbG91dCBiZWNhdXNlIFY4RE9NV3JhcHBlcjo6Z2V0Q2FjaGVkV3JhcHBlciBubyBsb25n ZXIgZXhpc3RzLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgu cG06CisgICAgICAgIChHZW5lcmF0ZUhlYWRlcik6CisKIDIwMTItMTEtMjggIEJ5dW5nd29vIExl ZSAgPGJ3ODAubGVlQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIFVzZSBtdXRleCBsb2Nr ZXIgaW4gd2FrZVVwKCkgdG8gZW5zdXJlIHRocmVhZC1zYWZldHkuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbSBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCmluZGV4IDAwZWM4ZmY2 YTliZDk5YWYxOTZjMDJjODIxYjBkZjY0MTU2N2Y3YjkuLjhhZGIwY2VmZjEzNWJkMzRmYmE0MTc1 NTNmMzRhOGZlNDEyNGI4MzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Nj cmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Nj cmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC01OTMsMTAgKzU5MywxMSBAQCBpbmxpbmUgdjg6 OkhhbmRsZTx2ODo6VmFsdWU+IHRvVjhGYXN0KCR7bmF0aXZlVHlwZX0qIGltcGwsIGNvbnN0IHY4 OjpBY2Nlc3NvckluZgogICAgIC8vIGluIGFuIGlzb2xhdGVkIHdvcmxkLiBUaGUgZmFzdGVzdCB3 YXkgd2Uga25vdyBob3cgdG8gZG8gdGhhdCBpcyB0byBjaGVjawogICAgIC8vIHdoZXRoZXIgdGhl IGhvbGRlcidzIGlubGluZSB3cmFwcGVyIGlzIHRoZSBzYW1lIHdyYXBwZXIgd2Ugc2VlIGluIHRo ZQogICAgIC8vIHY4OjpBY2Nlc3NvckluZm8uCi0gICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiB3 cmFwcGVyID0gKGhvbGRlci0+d3JhcHBlcigpID09IGluZm8uSG9sZGVyKCkpID8gaW1wbC0+d3Jh cHBlcigpIDogRE9NRGF0YVN0b3JlOjpnZXROb2RlKGltcGwsIGluZm8uR2V0SXNvbGF0ZSgpKTsK KyAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGhvbGRlcldyYXBwZXIgPSBpbmZvLkhvbGRlcigp OworICAgIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gd3JhcHBlciA9IChob2xkZXItPndyYXBwZXIo KSA9PSBob2xkZXJXcmFwcGVyKSA/IGltcGwtPndyYXBwZXIoKSA6IERPTURhdGFTdG9yZTo6Z2V0 Tm9kZShpbXBsLCBpbmZvLkdldElzb2xhdGUoKSk7CiAgICAgaWYgKCF3cmFwcGVyLklzRW1wdHko KSkKICAgICAgICAgcmV0dXJuIHdyYXBwZXI7Ci0gICAgcmV0dXJuIHdyYXAoaW1wbCwgaW5mby5I b2xkZXIoKSwgaW5mby5HZXRJc29sYXRlKCkpOworICAgIHJldHVybiB3cmFwKGltcGwsIGhvbGRl cldyYXBwZXIsIGluZm8uR2V0SXNvbGF0ZSgpKTsKIH0KIEVORAogICAgICAgICB9Cg==