102810 2012-11-20 06:41:21 -0800 [Qt] No test of double-click to zoom out 2012-11-20 08:11:11 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen abecsi cmarcelo kenneth menard webkit.review.bot oldest_to_newest 771812 0 allan.jensen 2012-11-20 06:41:21 -0800 We have a basic test of double-click to zoom, but it doesn't test any of the finer behavior of double click to zoom out. Since this behaviour is more complicated, it is probably more likely to be broken by accidently and should therefore have be tested. 771817 1 175203 allan.jensen 2012-11-20 06:45:31 -0800 Created attachment 175203 Patch 771872 2 175203 kenneth 2012-11-20 07:57:18 -0800 Comment on attachment 175203 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175203&action=review > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml:101 > + } > + function test_double_zoomInAndBack() { newline? 771880 3 allan.jensen 2012-11-20 08:11:11 -0800 Committed r135282: <http://trac.webkit.org/changeset/135282> 175203 2012-11-20 06:45:31 -0800 2012-11-20 07:57:18 -0800 Patch bug-102810-20121120154253.patch text/plain 7046 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MjcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDRkMjM0MGQ3MWM4MWYw MWFjYThiMWE4MWI2NTE4ZjM5YWE5ODQ1OS4uMjEwZTdmNWQzMWFhZDA0YjU2OTE2MDVlYTk4MzQ3 ZWFhYzc5YmZlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEyLTExLTIwICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCisgICAgICAgIFtR dF0gTm8gdGVzdCBvZiBkb3VibGUtY2xpY2sgdG8gem9vbSBvdXQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjgxMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZHMgdGVzdHMgb2Ygem9vbS1zdGFjayBi ZWhhdmlvdXIsIHRoZSBhYmlsaXR5IHRvIHJlc3RvcmUgcHJldmlvdXMgem9vbSBsZXZlbHMuIEl0 IHRlc3RzCisgICAgICAgIHRoYXQgem9vbSBvdXQgYWx3YXlzIGdvZXMgdG8gbG93ZXIgem9vbSBs ZXZlbHMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZp ZXcvdHN0X2RvdWJsZVRhcFRvWm9vbS5xbWw6CisKKzIwMTItMTEtMjAgIEFsbGFuIFNhbmRmZWxk IEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CisKICAgICAgICAgW1F0XSBab29tIGxv Z2ljIGNvbmZ1c2VkIGJ5IHBhZ2UgYW5kIHBpbmNoIHJlc2l6ZQogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyODAzCiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvV2ViVmlldy90c3RfZG91 YmxlVGFwVG9ab29tLnFtbCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMv cW1sdGVzdHMvV2ViVmlldy90c3RfZG91YmxlVGFwVG9ab29tLnFtbAppbmRleCBkMjFlZjIxMWEx ZjY0ZWI4YjE4ZTY5ZWFhNDlkMDdiZmMwZmI5YjQxLi5kZWZkODQ5YzM2OGFiMjE4NmQxZTZiYjRj NGVkYjA3N2UwM2EwMDNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X2RvdWJsZVRhcFRvWm9vbS5xbWwKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3Rz dF9kb3VibGVUYXBUb1pvb20ucW1sCkBAIC04LDggKzgsOCBAQCBpbXBvcnQgIi4uL2NvbW1vbiIK IEl0ZW0gewogICAgIFRlc3RXZWJWaWV3IHsKICAgICAgICAgaWQ6IHdlYlZpZXcKLSAgICAgICAg d2lkdGg6IDQ4MAotICAgICAgICBoZWlnaHQ6IDcyMAorICAgICAgICB3aWR0aDogMzIwCisgICAg ICAgIGhlaWdodDogMjQwCiAKICAgICAgICAgcHJvcGVydHkgdmFyaWFudCByZXN1bHQKIApAQCAt MTksNyArMTksMTAgQEAgSXRlbSB7CiAgICAgICAgICAgICAiPC9oZWFkPiIgKwogICAgICAgICAg ICAgIjxib2R5PiIgKwogICAgICAgICAgICAgIiAgICA8ZGl2IGlkPSd0YXJnZXQnICIgKwotICAg ICAgICAgICAgIiAgICAgICAgIHN0eWxlPSdwb3NpdGlvbjphYnNvbHV0ZTsgbGVmdDoyMDsgdG9w OjIwOyB3aWR0aDoyMDA7IGhlaWdodDoyMDA7Jz4iICsKKyAgICAgICAgICAgICIgICAgICAgICBz dHlsZT0ncG9zaXRpb246YWJzb2x1dGU7IGxlZnQ6MjA7IHRvcDoyMDsgd2lkdGg6MjIwOyBoZWln aHQ6ODA7Jz4iICsKKyAgICAgICAgICAgICIgICAgPC9kaXY+IiArCisgICAgICAgICAgICAiICAg IDxkaXYgaWQ9J3NtYWxsdGFyZ2V0JyAiICsKKyAgICAgICAgICAgICIgICAgICAgICBzdHlsZT0n cG9zaXRpb246YWJzb2x1dGU7IGxlZnQ6MjA7IHRvcDoxMjA7IHdpZHRoOjE0MDsgaGVpZ2h0Ojgw Oyc+IiArCiAgICAgICAgICAgICAiICAgIDwvZGl2PiIgKwogICAgICAgICAgICAgIjwvYm9keT4i CiAKQEAgLTQ5LDcgKzUyLDcgQEAgSXRlbSB7CiAgICAgICAgICAgICBzY2FsZVNweS5jbGVhcigp CiAgICAgICAgIH0KIAotICAgICAgICBmdW5jdGlvbiBkb2N1bWVudFNpemUoKSB7CisgICAgICAg IGZ1bmN0aW9uIHdpbmRvd1NpemUoKSB7CiAgICAgICAgICAgICByZXN1bHRTcHkuY2xlYXIoKTsK ICAgICAgICAgICAgIHZhciByZXN1bHQ7CiAKQEAgLTc3LDE5ICs4MCwxMzggQEAgSXRlbSB7CiAg ICAgICAgICAgICBzY2FsZVNweS53YWl0KCkKICAgICAgICAgfQogCi0gICAgICAgIGZ1bmN0aW9u IHRlc3RfYmFzaWMoKSB7CisgICAgICAgIGZ1bmN0aW9uIHRlc3RfYmFzaWNfem9vbUluQW5kQmFj aygpIHsKICAgICAgICAgICAgIHdlYlZpZXcudXJsID0gd2ViVmlldy5jb250ZW50CiAgICAgICAg ICAgICB2ZXJpZnkod2ViVmlldy53YWl0Rm9yVmlld3BvcnRSZWFkeSgpKQogCi0gICAgICAgICAg ICBjb21wYXJlKGRvY3VtZW50U2l6ZSgpLCAiNDgweDcyMCIpCisgICAgICAgICAgICBjb21wYXJl KHdpbmRvd1NpemUoKSwgIjMyMHgyNDAiKQogCiAgICAgICAgICAgICBjb21wYXJlKHRlc3QuY29u dGVudHNTY2FsZSwgMS4wKQogCiAgICAgICAgICAgICB2YXIgcmVjdCA9IGVsZW1lbnRSZWN0KCJ0 YXJnZXQiKTsKICAgICAgICAgICAgIHZhciBuZXdTY2FsZSA9IHdlYlZpZXcud2lkdGggLyAocmVj dC53aWR0aCArIDIgKiAxMCkgLy8gaW5mbGF0ZWQgYnkgMTBweAotICAgICAgICAgICAgZG91Ymxl VGFwQXRQb2ludChyZWN0LmxlZnQgKyByZWN0LmhlaWdodCAvIDIsIHJlY3QudG9wICsgcmVjdC53 aWR0aCAvIDIpCisgICAgICAgICAgICBkb3VibGVUYXBBdFBvaW50KDEwMCwgNTApCiAKICAgICAg ICAgICAgIGNvbXBhcmUodGVzdC5jb250ZW50c1NjYWxlLCBuZXdTY2FsZSkKKworICAgICAgICAg ICAgZG91YmxlVGFwQXRQb2ludCgxMDAsIDUwKQorCisgICAgICAgICAgICBjb21wYXJlKHRlc3Qu Y29udGVudHNTY2FsZSwgMS4wKQorICAgICAgICB9CisgICAgICAgIGZ1bmN0aW9uIHRlc3RfZG91 YmxlX3pvb21JbkFuZEJhY2soKSB7CisgICAgICAgICAgICB3ZWJWaWV3LnVybCA9IHdlYlZpZXcu Y29udGVudAorICAgICAgICAgICAgdmVyaWZ5KHdlYlZpZXcud2FpdEZvclZpZXdwb3J0UmVhZHko KSkKKworICAgICAgICAgICAgY29tcGFyZSh3aW5kb3dTaXplKCksICIzMjB4MjQwIikKKyAgICAg ICAgICAgIGNvbXBhcmUodGVzdC5jb250ZW50c1NjYWxlLCAxLjApCisKKyAgICAgICAgICAgIHZh ciB0YXJnZXQgPSBlbGVtZW50UmVjdCgidGFyZ2V0Iik7CisgICAgICAgICAgICB2YXIgc21hbGx0 YXJnZXQgPSBlbGVtZW50UmVjdCgic21hbGx0YXJnZXQiKTsKKyAgICAgICAgICAgIHZhciB0YXJn ZXRTY2FsZSA9IHdlYlZpZXcud2lkdGggLyAodGFyZ2V0LndpZHRoICsgMiAqIDEwKSAvLyBpbmZs YXRlZCBieSAxMHB4CisgICAgICAgICAgICB2YXIgc21hbGxUYXJnZXRTY2FsZSA9IHdlYlZpZXcu d2lkdGggLyAoc21hbGx0YXJnZXQud2lkdGggKyAyICogMTApIC8vIGluZmxhdGVkIGJ5IDEwcHgK KworICAgICAgICAgICAgZG91YmxlVGFwQXRQb2ludCgxMDAsIDUwKQorCisgICAgICAgICAgICBj b21wYXJlKHRlc3QuY29udGVudHNTY2FsZSwgdGFyZ2V0U2NhbGUpCisKKyAgICAgICAgICAgIGRv dWJsZVRhcEF0UG9pbnQoMTAwLCAxNjApCisKKyAgICAgICAgICAgIGNvbXBhcmUodGVzdC5jb250 ZW50c1NjYWxlLCBzbWFsbFRhcmdldFNjYWxlKQorCisgICAgICAgICAgICAvLyBab29tIG91dCBi eSBkb3VibGUgY2xpY2tpbmcgZmlyc3QgdGhlIHNtYWxsIHRhcmdldCBhbmQgdGhlbiB0aGUgbGFy Z2UgdGFyZ2V0LgorICAgICAgICAgICAgZG91YmxlVGFwQXRQb2ludCgxMDAsIDEyMCkKKworICAg ICAgICAgICAgY29tcGFyZSh0ZXN0LmNvbnRlbnRzU2NhbGUsIHRhcmdldFNjYWxlKQorCisgICAg ICAgICAgICBkb3VibGVUYXBBdFBvaW50KDEwMCwgNTApCisKKyAgICAgICAgICAgIGNvbXBhcmUo dGVzdC5jb250ZW50c1NjYWxlLCAxLjApCisgICAgICAgIH0KKworICAgICAgICBmdW5jdGlvbiB0 ZXN0X2RvdWJsZV96b29tSW5BbmRCYWNrMigpIHsKKyAgICAgICAgICAgIHdlYlZpZXcudXJsID0g d2ViVmlldy5jb250ZW50CisgICAgICAgICAgICB2ZXJpZnkod2ViVmlldy53YWl0Rm9yVmlld3Bv cnRSZWFkeSgpKQorCisgICAgICAgICAgICBjb21wYXJlKHdpbmRvd1NpemUoKSwgIjMyMHgyNDAi KQorICAgICAgICAgICAgY29tcGFyZSh0ZXN0LmNvbnRlbnRzU2NhbGUsIDEuMCkKKworICAgICAg ICAgICAgdmFyIHRhcmdldCA9IGVsZW1lbnRSZWN0KCJ0YXJnZXQiKTsKKyAgICAgICAgICAgIHZh ciBzbWFsbHRhcmdldCA9IGVsZW1lbnRSZWN0KCJzbWFsbHRhcmdldCIpOworICAgICAgICAgICAg dmFyIHRhcmdldFNjYWxlID0gd2ViVmlldy53aWR0aCAvICh0YXJnZXQud2lkdGggKyAyICogMTAp IC8vIGluZmxhdGVkIGJ5IDEwcHgKKyAgICAgICAgICAgIHZhciBzbWFsbFRhcmdldFNjYWxlID0g d2ViVmlldy53aWR0aCAvIChzbWFsbHRhcmdldC53aWR0aCArIDIgKiAxMCkgLy8gaW5mbGF0ZWQg YnkgMTBweAorCisgICAgICAgICAgICBkb3VibGVUYXBBdFBvaW50KDEwMCwgNTApCisKKyAgICAg ICAgICAgIGNvbXBhcmUodGVzdC5jb250ZW50c1NjYWxlLCB0YXJnZXRTY2FsZSkKKworICAgICAg ICAgICAgZG91YmxlVGFwQXRQb2ludCgxMDAsIDE2MCkKKworICAgICAgICAgICAgY29tcGFyZSh0 ZXN0LmNvbnRlbnRzU2NhbGUsIHNtYWxsVGFyZ2V0U2NhbGUpCisKKyAgICAgICAgICAgIC8vIFpv b20gb3V0IGJ5IGRvdWJsZSBjbGlja2luZyB0aGUgc21hbGwgdGFyZ2V0IHR3aWNlLgorICAgICAg ICAgICAgZG91YmxlVGFwQXRQb2ludCgxMDAsIDEyMCkKKworICAgICAgICAgICAgY29tcGFyZSh0 ZXN0LmNvbnRlbnRzU2NhbGUsIHRhcmdldFNjYWxlKQorCisgICAgICAgICAgICBkb3VibGVUYXBB dFBvaW50KDEwMCwgMTYwKQorCisgICAgICAgICAgICBjb21wYXJlKHRlc3QuY29udGVudHNTY2Fs ZSwgMS4wKQorICAgICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24gdGVzdF9kb3VibGVfem9vbUlu T3V0QW5kQmFjaygpIHsKKyAgICAgICAgICAgIHdlYlZpZXcudXJsID0gd2ViVmlldy5jb250ZW50 CisgICAgICAgICAgICB2ZXJpZnkod2ViVmlldy53YWl0Rm9yVmlld3BvcnRSZWFkeSgpKQorCisg ICAgICAgICAgICBjb21wYXJlKHdpbmRvd1NpemUoKSwgIjMyMHgyNDAiKQorICAgICAgICAgICAg Y29tcGFyZSh0ZXN0LmNvbnRlbnRzU2NhbGUsIDEuMCkKKworICAgICAgICAgICAgdmFyIHRhcmdl dCA9IGVsZW1lbnRSZWN0KCJ0YXJnZXQiKTsKKyAgICAgICAgICAgIHZhciBzbWFsbHRhcmdldCA9 IGVsZW1lbnRSZWN0KCJzbWFsbHRhcmdldCIpOworICAgICAgICAgICAgdmFyIHRhcmdldFNjYWxl ID0gd2ViVmlldy53aWR0aCAvICh0YXJnZXQud2lkdGggKyAyICogMTApIC8vIGluZmxhdGVkIGJ5 IDEwcHgKKyAgICAgICAgICAgIHZhciBzbWFsbFRhcmdldFNjYWxlID0gd2ViVmlldy53aWR0aCAv IChzbWFsbHRhcmdldC53aWR0aCArIDIgKiAxMCkgLy8gaW5mbGF0ZWQgYnkgMTBweAorCisgICAg ICAgICAgICBkb3VibGVUYXBBdFBvaW50KDEwMCwgNTApCisKKyAgICAgICAgICAgIGNvbXBhcmUo dGVzdC5jb250ZW50c1NjYWxlLCB0YXJnZXRTY2FsZSkKKworICAgICAgICAgICAgZG91YmxlVGFw QXRQb2ludCgxMDAsIDE2MCkKKworICAgICAgICAgICAgY29tcGFyZSh0ZXN0LmNvbnRlbnRzU2Nh bGUsIHNtYWxsVGFyZ2V0U2NhbGUpCisKKyAgICAgICAgICAgIC8vIFpvb20gb3V0IGJ5IGRvdWJs ZSBjbGlja2luZyB0aGUgbGFyZ2UgdGFyZ2V0IHR3aWNlLgorICAgICAgICAgICAgZG91YmxlVGFw QXRQb2ludCgxMDAsIDQwKQorCisgICAgICAgICAgICBjb21wYXJlKHRlc3QuY29udGVudHNTY2Fs ZSwgdGFyZ2V0U2NhbGUpCisKKyAgICAgICAgICAgIGRvdWJsZVRhcEF0UG9pbnQoMTAwLCA1MCkK KworICAgICAgICAgICAgY29tcGFyZSh0ZXN0LmNvbnRlbnRzU2NhbGUsIDEuMCkKKyAgICAgICAg fQorCisgICAgICAgIGZ1bmN0aW9uIHRlc3RfZG91YmxlX3pvb21Jbk91dEFuZEJhY2syKCkgewor ICAgICAgICAgICAgd2ViVmlldy51cmwgPSB3ZWJWaWV3LmNvbnRlbnQKKyAgICAgICAgICAgIHZl cmlmeSh3ZWJWaWV3LndhaXRGb3JWaWV3cG9ydFJlYWR5KCkpCisKKyAgICAgICAgICAgIGNvbXBh cmUod2luZG93U2l6ZSgpLCAiMzIweDI0MCIpCisgICAgICAgICAgICBjb21wYXJlKHRlc3QuY29u dGVudHNTY2FsZSwgMS4wKQorCisgICAgICAgICAgICB2YXIgdGFyZ2V0ID0gZWxlbWVudFJlY3Qo InRhcmdldCIpOworICAgICAgICAgICAgdmFyIHNtYWxsdGFyZ2V0ID0gZWxlbWVudFJlY3QoInNt YWxsdGFyZ2V0Iik7CisgICAgICAgICAgICB2YXIgdGFyZ2V0U2NhbGUgPSB3ZWJWaWV3LndpZHRo IC8gKHRhcmdldC53aWR0aCArIDIgKiAxMCkgLy8gaW5mbGF0ZWQgYnkgMTBweAorICAgICAgICAg ICAgdmFyIHNtYWxsVGFyZ2V0U2NhbGUgPSB3ZWJWaWV3LndpZHRoIC8gKHNtYWxsdGFyZ2V0Lndp ZHRoICsgMiAqIDEwKSAvLyBpbmZsYXRlZCBieSAxMHB4CisKKyAgICAgICAgICAgIC8vIFpvb20g aW4gZGlyZWN0bHkgdG8gdGhlIHNtYWxsIHRhcmdldCwgYW5kIHRoZW4gb3V0IG92ZXIgdGhlIGxh cmdlIHRhcmdldC4KKyAgICAgICAgICAgIGRvdWJsZVRhcEF0UG9pbnQoMTAwLCAxNDApCisKKyAg ICAgICAgICAgIGNvbXBhcmUodGVzdC5jb250ZW50c1NjYWxlLCBzbWFsbFRhcmdldFNjYWxlKQor CisgICAgICAgICAgICBkb3VibGVUYXBBdFBvaW50KDEwMCwgMjApCisKKyAgICAgICAgICAgIGNv bXBhcmUodGVzdC5jb250ZW50c1NjYWxlLCB0YXJnZXRTY2FsZSkKKworICAgICAgICAgICAgZG91 YmxlVGFwQXRQb2ludCgxMDAsIDUwKQorCisgICAgICAgICAgICBjb21wYXJlKHRlc3QuY29udGVu dHNTY2FsZSwgMS4wKQogICAgICAgICB9CiAgICAgfQogfQo=