102806 2012-11-20 05:47:19 -0800 [V8] Introduce GenerateConstructorHeader() to CodeGeneratorV8.pm 2012-11-20 22:08:10 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 102763 1 haraken haraken abarth japhet ossy webkit.review.bot oldest_to_newest 771780 0 haraken 2012-11-20 05:47:19 -0800 This is an incremental step for introducing constructorCallbackCustom(). See bug 102763. 771783 1 175197 haraken 2012-11-20 05:49:10 -0800 Created attachment 175197 Patch 772015 2 175197 abarth 2012-11-20 10:53:26 -0800 Comment on attachment 175197 Patch ok 772231 3 175197 webkit.review.bot 2012-11-20 15:42:57 -0800 Comment on attachment 175197 Patch Clearing flags on attachment: 175197 Committed r135322: <http://trac.webkit.org/changeset/135322> 772232 4 webkit.review.bot 2012-11-20 15:43:00 -0800 All reviewed patches have been landed. Closing bug. 772462 5 ossy 2012-11-20 22:02:56 -0800 (In reply to comment #3) > (From update of attachment 175197 [details]) > Clearing flags on attachment: 175197 > > Committed r135322: <http://trac.webkit.org/changeset/135322> It broke the bindings tests on the bots. Could you fix it? 772464 6 haraken 2012-11-20 22:04:35 -0800 (In reply to comment #5) > (In reply to comment #3) > > (From update of attachment 175197 [details] [details]) > > Clearing flags on attachment: 175197 > > > > Committed r135322: <http://trac.webkit.org/changeset/135322> > > It broke the bindings tests on the bots. Could you fix it? I think it I already fixed it. But it looks like another patch broke the test again. I'll fix it in mins. 772472 7 haraken 2012-11-20 22:08:10 -0800 (In reply to comment #6) > > It broke the bindings tests on the bots. Could you fix it? > > I think it I already fixed it. But it looks like another patch broke the test again. I'll fix it in mins. Fixed in r135351. 175197 2012-11-20 05:49:10 -0800 2012-11-20 15:42:57 -0800 Patch bug-102806-20121120224659.patch text/plain 4467 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTkzZjBmNDYwNzVmYjll ODhhZDMyZDVkMmMxOTM4ZDRjYjlmNmZkNC4uZTg2YzhiYTdlMjJlOTMxODViZjE2NjJiMmQ5ZmUy OWRiNzg2N2I1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTExLTIwICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIEludHJvZHVj ZSBHZW5lcmF0ZUNvbnN0cnVjdG9ySGVhZGVyKCkgdG8gQ29kZUdlbmVyYXRvclY4LnBtCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI4MDYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGFuIGlu Y3JlbWVudGFsIHN0ZXAgZm9yIGludHJvZHVjaW5nIGNvbnN0cnVjdG9yQ2FsbGJhY2tDdXN0b20o KS4KKyAgICAgICAgKFNlZSBidWcgMTAyNzYzLikgVGhpcyBwYXRjaCBhZGRzIEdlbmVyYXRlQ29u c3RydWN0b3JIZWFkZXIoKQorICAgICAgICB0aGF0IGdlbmVyYXRlcyBhIGNvbW1vbiBjb2RlIGZv ciBjb25zdHJ1Y3RvcnMuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlv ci4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtOgorICAg ICAgICAoR2VuZXJhdGVPdmVybG9hZGVkQ29uc3RydWN0b3JDYWxsYmFjayk6CisgICAgICAgIChH ZW5lcmF0ZVNpbmdsZUNvbnN0cnVjdG9yQ2FsbGJhY2spOgorICAgICAgICAoR2VuZXJhdGVFdmVu dENvbnN0cnVjdG9yQ2FsbGJhY2spOgorICAgICAgICAoR2VuZXJhdGVOYW1lZENvbnN0cnVjdG9y Q2FsbGJhY2spOgorICAgICAgICAoR2VuZXJhdGVDb25zdHJ1Y3RvckhlYWRlcik6CisKIDIwMTIt MTEtMTkgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIENvbGxl Y3QgdXNlciBzdHlsZSBzaGVldHMgaW4gRG9jdW1lbnRTdHlsZVNoZWV0Q29sbGVjdGlvbgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgu cG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpp bmRleCA3ZTQ1M2JlYWIxZDhhMWI1MTFmMDA0NzE1YTMwYTcyNmUyNzcyYTg3Li5kZWE5ZmRiYTNk M2NkYmU3MzkxYWFiZDU1MDJiMWM1NTI4YmFlNTU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpAQCAtMTg1NSwxMyArMTg1NSw4 IEBAIHN1YiBHZW5lcmF0ZU92ZXJsb2FkZWRDb25zdHJ1Y3RvckNhbGxiYWNrCiB2ODo6SGFuZGxl PHY4OjpWYWx1ZT4gVjgke2ludGVyZmFjZU5hbWV9Ojpjb25zdHJ1Y3RvckNhbGxiYWNrKGNvbnN0 IHY4OjpBcmd1bWVudHMmIGFyZ3MpCiB7CiAgICAgSU5DX1NUQVRTKCJET00uJHtpbnRlcmZhY2VO YW1lfS5Db25zdHJ1Y3RvciIpOwotICAgIGlmICghYXJncy5Jc0NvbnN0cnVjdENhbGwoKSkKLSAg ICAgICAgcmV0dXJuIHRocm93VHlwZUVycm9yKCJET00gb2JqZWN0IGNvbnN0cnVjdG9yIGNhbm5v dCBiZSBjYWxsZWQgYXMgYSBmdW5jdGlvbi4iKTsKLQotICAgIGlmIChDb25zdHJ1Y3Rvck1vZGU6 OmN1cnJlbnQoKSA9PSBDb25zdHJ1Y3Rvck1vZGU6OldyYXBFeGlzdGluZ09iamVjdCkKLSAgICAg ICAgcmV0dXJuIGFyZ3MuSG9sZGVyKCk7Ci0KIEVORAorICAgIHB1c2goQGltcGxDb250ZW50LCBH ZW5lcmF0ZUNvbnN0cnVjdG9ySGVhZGVyKCkpOwogCiAgICAgbXkgJGxlYXN0TnVtTWFuZGF0b3J5 UGFyYW1zID0gMjU1OwogICAgIGZvcmVhY2ggbXkgJGNvbnN0cnVjdG9yIChAeyRpbnRlcmZhY2Ut PmNvbnN0cnVjdG9yc30pIHsKQEAgLTE5MTYsMTMgKzE5MTEsNyBAQCB2ODo6SGFuZGxlPHY4OjpW YWx1ZT4gVjgke2ludGVyZmFjZU5hbWV9Ojpjb25zdHJ1Y3RvciR7b3ZlcmxvYWRlZEluZGV4U3Ry aW5nfUNhbAogRU5ECiAKICAgICBpZiAoJGZ1bmN0aW9uLT57b3ZlcmxvYWRlZEluZGV4fSA9PSAw KSB7Ci0gICAgICAgcHVzaChAaW1wbENvbnRlbnQsIDw8RU5EKTsKLSAgICBpZiAoIWFyZ3MuSXND b25zdHJ1Y3RDYWxsKCkpCi0gICAgICAgIHJldHVybiB0aHJvd1R5cGVFcnJvcigiRE9NIG9iamVj dCBjb25zdHJ1Y3RvciBjYW5ub3QgYmUgY2FsbGVkIGFzIGEgZnVuY3Rpb24uIik7Ci0KLSAgICBp ZiAoQ29uc3RydWN0b3JNb2RlOjpjdXJyZW50KCkgPT0gQ29uc3RydWN0b3JNb2RlOjpXcmFwRXhp c3RpbmdPYmplY3QpCi0gICAgICAgIHJldHVybiBhcmdzLkhvbGRlcigpOwotRU5ECisgICAgICAg IHB1c2goQGltcGxDb250ZW50LCBHZW5lcmF0ZUNvbnN0cnVjdG9ySGVhZGVyKCkpOwogICAgICAg ICBwdXNoKEBpbXBsQ29udGVudCwgR2VuZXJhdGVBcmd1bWVudHNDb3VudENoZWNrKCRmdW5jdGlv biwgJGludGVyZmFjZSkpOwogICAgIH0KIApAQCAtMjAxMSwxMyArMjAwMCwxMCBAQCBzdWIgR2Vu ZXJhdGVFdmVudENvbnN0cnVjdG9yQ2FsbGJhY2sKIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOCR7 aW50ZXJmYWNlTmFtZX06OmNvbnN0cnVjdG9yQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYg YXJncykKIHsKICAgICBJTkNfU1RBVFMoIkRPTS4ke2ludGVyZmFjZU5hbWV9LkNvbnN0cnVjdG9y Iik7CitFTkQKKyAgICBwdXNoKEBpbXBsQ29udGVudCwgR2VuZXJhdGVDb25zdHJ1Y3RvckhlYWRl cigpKTsKIAotICAgIGlmICghYXJncy5Jc0NvbnN0cnVjdENhbGwoKSkKLSAgICAgICAgcmV0dXJu IHRocm93VHlwZUVycm9yKCJET00gb2JqZWN0IGNvbnN0cnVjdG9yIGNhbm5vdCBiZSBjYWxsZWQg YXMgYSBmdW5jdGlvbi4iKTsKLQotICAgIGlmIChDb25zdHJ1Y3Rvck1vZGU6OmN1cnJlbnQoKSA9 PSBDb25zdHJ1Y3Rvck1vZGU6OldyYXBFeGlzdGluZ09iamVjdCkKLSAgICAgICAgcmV0dXJuIGFy Z3MuSG9sZGVyKCk7Ci0KKyAgICBwdXNoKEBpbXBsQ29udGVudCwgPDxFTkQpOwogICAgIGlmIChh cmdzLkxlbmd0aCgpIDwgMSkKICAgICAgICAgcmV0dXJuIHRocm93Tm90RW5vdWdoQXJndW1lbnRz RXJyb3IoYXJncy5HZXRJc29sYXRlKCkpOwogCkBAIC0yMTE4LDEyICsyMTA0LDkgQEAgc3RhdGlj IHY4OjpIYW5kbGU8djg6OlZhbHVlPiAke3Y4SW50ZXJmYWNlTmFtZX1Db25zdHJ1Y3RvckNhbGxi YWNrKGNvbnN0IHY4OjpBcmcKIHsKICAgICBJTkNfU1RBVFMoIkRPTS4ke2ludGVyZmFjZU5hbWV9 LkNvbnN0cnVjdG9yIik7CiAgICAgJHttYXliZU9ic2VydmVGZWF0dXJlfQotICAgIGlmICghYXJn cy5Jc0NvbnN0cnVjdENhbGwoKSkKLSAgICAgICAgcmV0dXJuIHRocm93VHlwZUVycm9yKCJET00g b2JqZWN0IGNvbnN0cnVjdG9yIGNhbm5vdCBiZSBjYWxsZWQgYXMgYSBmdW5jdGlvbi4iKTsKLQot ICAgIGlmIChDb25zdHJ1Y3Rvck1vZGU6OmN1cnJlbnQoKSA9PSBDb25zdHJ1Y3Rvck1vZGU6Oldy YXBFeGlzdGluZ09iamVjdCkKLSAgICAgICAgcmV0dXJuIGFyZ3MuSG9sZGVyKCk7Ci0KK0VORAor ICAgIHB1c2goQGltcGxDb250ZW50LCBHZW5lcmF0ZUNvbnN0cnVjdG9ySGVhZGVyKCkpOworICAg IHB1c2goQGltcGxDb250ZW50LCA8PEVORCk7CiAgICAgRG9jdW1lbnQqIGRvY3VtZW50ID0gY3Vy cmVudERvY3VtZW50KEJpbmRpbmdTdGF0ZTo6aW5zdGFuY2UoKSk7CiAKICAgICAvLyBNYWtlIHN1 cmUgdGhlIGRvY3VtZW50IGlzIGFkZGVkIHRvIHRoZSBET00gTm9kZSBtYXAuIE90aGVyd2lzZSwg dGhlICR7aW50ZXJmYWNlTmFtZX0gaW5zdGFuY2UKQEAgLTIyMDcsNiArMjE5MCwxOCBAQCB2ODo6 UGVyc2lzdGVudDx2ODo6RnVuY3Rpb25UZW1wbGF0ZT4gJHt2OEludGVyZmFjZU5hbWV9Q29uc3Ry dWN0b3I6OkdldFRlbXBsYXRlKAogRU5ECiB9CiAKK3N1YiBHZW5lcmF0ZUNvbnN0cnVjdG9ySGVh ZGVyCit7CisgICAgbXkgJGNvbnRlbnQgPSA8PEVORDsKKyAgICBpZiAoIWFyZ3MuSXNDb25zdHJ1 Y3RDYWxsKCkpCisgICAgICAgIHJldHVybiB0aHJvd1R5cGVFcnJvcigiRE9NIG9iamVjdCBjb25z dHJ1Y3RvciBjYW5ub3QgYmUgY2FsbGVkIGFzIGEgZnVuY3Rpb24uIik7CisKKyAgICBpZiAoQ29u c3RydWN0b3JNb2RlOjpjdXJyZW50KCkgPT0gQ29uc3RydWN0b3JNb2RlOjpXcmFwRXhpc3RpbmdP YmplY3QpCisgICAgICAgIHJldHVybiBhcmdzLkhvbGRlcigpOworRU5ECisgICAgcmV0dXJuICRj b250ZW50OworfQorCiBzdWIgR2VuZXJhdGVCYXRjaGVkQXR0cmlidXRlRGF0YQogewogICAgIG15 ICRpbnRlcmZhY2UgPSBzaGlmdDsK