102794 2012-11-20 04:12:36 -0800 Fix QNX Qt build by enabling JIT. 2012-12-12 03:40:15 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 74040 0 sergio.martins webkit-unassigned benjamin hausmann milian.wolff ojan philn webkit.review.bot xan.lopez oldest_to_newest 771737 0 sergio.martins 2012-11-20 04:12:36 -0800 Fix QNX Qt build by enabling JIT. 771739 1 175187 sergio.martins 2012-11-20 04:17:51 -0800 Created attachment 175187 Patch 771741 2 175188 sergio.martins 2012-11-20 04:21:45 -0800 Created attachment 175188 Patch 771742 3 sergio.martins 2012-11-20 04:23:30 -0800 This is related to https://bugs.webkit.org/show_bug.cgi?id=98031 ( LLint failure ) 772784 4 175188 hausmann 2012-11-21 04:10:14 -0800 Comment on attachment 175188 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175188&action=review > Source/WTF/wtf/Platform.h:1008 > +#if !defined(ENABLE_YARR_JIT) && (ENABLE(JIT) || ENABLE(LLINT_C_LOOP)) && !PLATFORM(CHROMIUM) && !(OS(QNX) && PLATFORM(QT)) This change is missing a ChangeLog and I don't understand why this part is necessary (no changelog ;) If you enable the JIT, why not also enable YARR_JIT? 772785 5 sergio.martins 2012-11-21 04:13:34 -0800 Seems like the Changelog changes weren't uploaded 781874 6 177325 sergio.martins 2012-12-03 14:17:10 -0800 Created attachment 177325 Patch 787081 7 177325 hausmann 2012-12-10 01:35:21 -0800 Comment on attachment 177325 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177325&action=review > Source/WTF/wtf/Platform.h:900 > + && !(OS(QNX) && !PLATFORM(QT)) // We use jit in qnx qt jit -> JIT. qnx -> QNX. qt -> Qt And the use of C++ comments in this header file breaks the build of any C files, as the Gtk EWS indicated. 789392 8 179011 sergio.martins 2012-12-12 02:44:08 -0800 Created attachment 179011 Patch 789427 9 179011 webkit.review.bot 2012-12-12 03:40:11 -0800 Comment on attachment 179011 Patch Clearing flags on attachment: 179011 Committed r137449: <http://trac.webkit.org/changeset/137449> 789428 10 webkit.review.bot 2012-12-12 03:40:15 -0800 All reviewed patches have been landed. Closing bug. 175187 2012-11-20 04:17:51 -0800 2012-11-20 04:21:41 -0800 Patch bug-102794-20121120121349.patch text/plain 997 sergio.martins U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9Q bGF0Zm9ybS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRleCAwYWI4MDg2Y2MwZjI0 NmRiNTA1NDI5ZDZhNDg4NTc4MmNiYWMxN2RiLi45M2U3M2FjMTlmZTIxYWE2ODE3NDM3MjZkNjIw OTQ2MjFhZTBiYWVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisrKyBi L1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTg5NSw3ICs4OTUsNyBAQAogICAgICYmIChD UFUoWDg2KSB8fCBDUFUoWDg2XzY0KSB8fCBDUFUoQVJNKSB8fCBDUFUoTUlQUykpIFwKICAgICAm JiAoT1MoREFSV0lOKSB8fCAhQ09NUElMRVIoR0NDKSB8fCBHQ0NfVkVSU0lPTl9BVF9MRUFTVCg0 LCAxLCAwKSkgXAogICAgICYmICFPUyhXSU5DRSkgXAotICAgICYmICFPUyhRTlgpCisgICAgJiYg IShPUyhRTlgpICYmICFQTEFURk9STShRVCkpIC8vIFdlIHVzZSBqaXQgaW4gcW54IHF0CiAjZGVm aW5lIEVOQUJMRV9KSVQgMQogI2VuZGlmCiAKQEAgLTEwMDUsNyArMTAwNSw3IEBACiAjZGVmaW5l IEVOQUJMRV9SRUdFWFBfVFJBQ0lORyAwCiAKIC8qIFlldCBBbm90aGVyIFJlZ2V4IFJ1bnRpbWUg LSB0dXJuZWQgb24gYnkgZGVmYXVsdCBmb3IgSklUIGVuYWJsZWQgcG9ydHMuICovCi0jaWYgIWRl ZmluZWQoRU5BQkxFX1lBUlJfSklUKSAmJiAoRU5BQkxFKEpJVCkgfHwgRU5BQkxFKExMSU5UX0Nf TE9PUCkpICYmICFQTEFURk9STShDSFJPTUlVTSkKKyNpZiAhZGVmaW5lZChFTkFCTEVfWUFSUl9K SVQpICYmIChFTkFCTEUoSklUKSB8fCBFTkFCTEUoTExJTlRfQ19MT09QKSkgJiYgIVBMQVRGT1JN KENIUk9NSVVNKSAmJiAhKE9TKFFOWCkgJiYgUExBVEZPUk0oUVQpKQogI2RlZmluZSBFTkFCTEVf WUFSUl9KSVQgMQogCiAvKiBTZXR0aW5nIHRoaXMgZmxhZyBjb21wYXJlcyBKSVQgcmVzdWx0cyB3 aXRoIGludGVycHJldGVyIHJlc3VsdHMuICovCg== 175188 2012-11-20 04:21:45 -0800 2012-12-03 14:17:05 -0800 Patch bug-102794-20121120121743.patch text/plain 997 sergio.martins U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9Q bGF0Zm9ybS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRleCAwYWI4MDg2Y2MwZjI0 NmRiNTA1NDI5ZDZhNDg4NTc4MmNiYWMxN2RiLi45M2U3M2FjMTlmZTIxYWE2ODE3NDM3MjZkNjIw OTQ2MjFhZTBiYWVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisrKyBi L1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTg5NSw3ICs4OTUsNyBAQAogICAgICYmIChD UFUoWDg2KSB8fCBDUFUoWDg2XzY0KSB8fCBDUFUoQVJNKSB8fCBDUFUoTUlQUykpIFwKICAgICAm JiAoT1MoREFSV0lOKSB8fCAhQ09NUElMRVIoR0NDKSB8fCBHQ0NfVkVSU0lPTl9BVF9MRUFTVCg0 LCAxLCAwKSkgXAogICAgICYmICFPUyhXSU5DRSkgXAotICAgICYmICFPUyhRTlgpCisgICAgJiYg IShPUyhRTlgpICYmICFQTEFURk9STShRVCkpIC8vIFdlIHVzZSBqaXQgaW4gcW54IHF0CiAjZGVm aW5lIEVOQUJMRV9KSVQgMQogI2VuZGlmCiAKQEAgLTEwMDUsNyArMTAwNSw3IEBACiAjZGVmaW5l IEVOQUJMRV9SRUdFWFBfVFJBQ0lORyAwCiAKIC8qIFlldCBBbm90aGVyIFJlZ2V4IFJ1bnRpbWUg LSB0dXJuZWQgb24gYnkgZGVmYXVsdCBmb3IgSklUIGVuYWJsZWQgcG9ydHMuICovCi0jaWYgIWRl ZmluZWQoRU5BQkxFX1lBUlJfSklUKSAmJiAoRU5BQkxFKEpJVCkgfHwgRU5BQkxFKExMSU5UX0Nf TE9PUCkpICYmICFQTEFURk9STShDSFJPTUlVTSkKKyNpZiAhZGVmaW5lZChFTkFCTEVfWUFSUl9K SVQpICYmIChFTkFCTEUoSklUKSB8fCBFTkFCTEUoTExJTlRfQ19MT09QKSkgJiYgIVBMQVRGT1JN KENIUk9NSVVNKSAmJiAhKE9TKFFOWCkgJiYgUExBVEZPUk0oUVQpKQogI2RlZmluZSBFTkFCTEVf WUFSUl9KSVQgMQogCiAvKiBTZXR0aW5nIHRoaXMgZmxhZyBjb21wYXJlcyBKSVQgcmVzdWx0cyB3 aXRoIGludGVycHJldGVyIHJlc3VsdHMuICovCg== 177325 2012-12-03 14:17:10 -0800 2012-12-12 02:44:03 -0800 Patch bug-102794-20121203221250.patch text/plain 1753 sergio.martins U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2Mzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDBlNTNhMjgyY2M4MDllMzNhZDNjZjRk NjE1YzM4ZWZhNjMzMDg2YWEuLmQwNjhlZDAyYjliMDBhOGZjY2E0ZjMzYWZmYzBjZGY1ZmU1NTE3 N2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMTItMDMgIFNlcmdpbyBNYXJ0aW5zICA8c2Vy Z2lvLm1hcnRpbnNAa2RhYi5jb20+CisKKyAgICAgICAgRml4IFFOWCBRdCBidWlsZCBieSBlbmFi bGluZyBKSVQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDI3OTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBKSVQgaXMgd29ya2luZywgc28gZW5hYmxlIGl0LiBPdGhlcndpc2UgTExJTlQgZ2V0cyBlbmFi bGVkLCBhbmQKKyAgICAgICAgdGhhdCBkb2Vzbid0IGNvbXBpbGUuCisKKyAgICAgICAgWUFSUl9K SVQgaXMgY3Jhc2hpbmcgYXQgdGhpcyB0aW1lIHRob3VnaCwgc28gZGlzYWJsZSBpdC4KKworICAg ICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDEyLTEyLTAyICBGaWxpcCBQaXpsbyAgPGZwaXps b0BhcHBsZS5jb20+CiAKICAgICAgICAgSXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIGJ1aWxkIGFu ZCBydW4gd2l0aCBERkdfRU5BQkxFKFBST1BBR0FUSU9OX1ZFUkJPU0UpCmRpZmYgLS1naXQgYS9T b3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRl eCAxNjAzMDE5OWEzYWRlZjBlMDdkMmNmYTY5MjNlNWY2NzE4MjA4MGQ3Li45YTc5YTc1YzZiZGMy MTQ0N2ZmZmRhYzhiOTJiOTJhZmVkYWMwN2ZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Q bGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTg5Nyw3ICs4OTcs NyBAQAogICAgICYmIChDUFUoWDg2KSB8fCBDUFUoWDg2XzY0KSB8fCBDUFUoQVJNKSB8fCBDUFUo TUlQUykpIFwKICAgICAmJiAoT1MoREFSV0lOKSB8fCAhQ09NUElMRVIoR0NDKSB8fCBHQ0NfVkVS U0lPTl9BVF9MRUFTVCg0LCAxLCAwKSkgXAogICAgICYmICFPUyhXSU5DRSkgXAotICAgICYmICFP UyhRTlgpCisgICAgJiYgIShPUyhRTlgpICYmICFQTEFURk9STShRVCkpIC8vIFdlIHVzZSBqaXQg aW4gcW54IHF0CiAjZGVmaW5lIEVOQUJMRV9KSVQgMQogI2VuZGlmCiAKQEAgLTEwMDcsNyArMTAw Nyw3IEBACiAjZGVmaW5lIEVOQUJMRV9SRUdFWFBfVFJBQ0lORyAwCiAKIC8qIFlldCBBbm90aGVy IFJlZ2V4IFJ1bnRpbWUgLSB0dXJuZWQgb24gYnkgZGVmYXVsdCBmb3IgSklUIGVuYWJsZWQgcG9y dHMuICovCi0jaWYgIWRlZmluZWQoRU5BQkxFX1lBUlJfSklUKSAmJiAoRU5BQkxFKEpJVCkgfHwg RU5BQkxFKExMSU5UX0NfTE9PUCkpICYmICFQTEFURk9STShDSFJPTUlVTSkKKyNpZiAhZGVmaW5l ZChFTkFCTEVfWUFSUl9KSVQpICYmIChFTkFCTEUoSklUKSB8fCBFTkFCTEUoTExJTlRfQ19MT09Q KSkgJiYgIVBMQVRGT1JNKENIUk9NSVVNKSAmJiAhKE9TKFFOWCkgJiYgUExBVEZPUk0oUVQpKQog I2RlZmluZSBFTkFCTEVfWUFSUl9KSVQgMQogCiAvKiBTZXR0aW5nIHRoaXMgZmxhZyBjb21wYXJl cyBKSVQgcmVzdWx0cyB3aXRoIGludGVycHJldGVyIHJlc3VsdHMuICovCg== 179011 2012-12-12 02:44:08 -0800 2012-12-12 03:40:11 -0800 Patch bug-102794-20121212103947.patch text/plain 1737 sergio.martins U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDE1MGY0NTQ2OWNkNmM2YzBkNDRkMjUx YjdhNzNlZTUyNjg0MzQyYmQuLjc5ZGQyOGY3YzRmMmVmYTQ2YzVjMmRmMzA5MGViNWU0NWY4ZTc2 YTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMTItMTIgIFNlcmdpbyBNYXJ0aW5zICA8c2Vy Z2lvLm1hcnRpbnNAa2RhYi5jb20+CisKKyAgICAgICAgRml4IFFOWCBRdCBidWlsZCBieSBlbmFi bGluZyBKSVQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDI3OTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBKSVQgaXMgd29ya2luZywgc28gZW5hYmxlIGl0LiBPdGhlcndpc2UgTExJTlQgZ2V0cyBlbmFi bGVkLCBhbmQKKyAgICAgICAgdGhhdCBkb2Vzbid0IGNvbXBpbGUuCisKKyAgICAgICAgWUFSUl9K SVQgaXMgY3Jhc2hpbmcgYXQgdGhpcyB0aW1lIHRob3VnaCwgc28gZGlzYWJsZSBpdC4KKworICAg ICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDEyLTEyLTA4ICBQYXRyaWNrIEdhbnN0ZXJlciAg PHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIENvbXBpbGluZyBXVEYgb3V0c2lkZSBvZiBX ZWJLaXQgZmFpbGVkIG9uIFdpbmRvd3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRm b3JtLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IDE2MDMwMTk5YTNhZGVmMGUw N2QyY2ZhNjkyM2U1ZjY3MTgyMDgwZDcuLmRhZjMyMmVkYmI0NDcwMTcyYTdkZTA2NGM4Zjk5ZTVm YTM2Mzk2MjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKKysrIGIvU291 cmNlL1dURi93dGYvUGxhdGZvcm0uaApAQCAtODk3LDcgKzg5Nyw3IEBACiAgICAgJiYgKENQVShY ODYpIHx8IENQVShYODZfNjQpIHx8IENQVShBUk0pIHx8IENQVShNSVBTKSkgXAogICAgICYmIChP UyhEQVJXSU4pIHx8ICFDT01QSUxFUihHQ0MpIHx8IEdDQ19WRVJTSU9OX0FUX0xFQVNUKDQsIDEs IDApKSBcCiAgICAgJiYgIU9TKFdJTkNFKSBcCi0gICAgJiYgIU9TKFFOWCkKKyAgICAmJiAhKE9T KFFOWCkgJiYgIVBMQVRGT1JNKFFUKSkgLyogV2UgdXNlIEpJVCBpbiBRTlggUXQgKi8KICNkZWZp bmUgRU5BQkxFX0pJVCAxCiAjZW5kaWYKIApAQCAtMTAwNyw3ICsxMDA3LDcgQEAKICNkZWZpbmUg RU5BQkxFX1JFR0VYUF9UUkFDSU5HIDAKIAogLyogWWV0IEFub3RoZXIgUmVnZXggUnVudGltZSAt IHR1cm5lZCBvbiBieSBkZWZhdWx0IGZvciBKSVQgZW5hYmxlZCBwb3J0cy4gKi8KLSNpZiAhZGVm aW5lZChFTkFCTEVfWUFSUl9KSVQpICYmIChFTkFCTEUoSklUKSB8fCBFTkFCTEUoTExJTlRfQ19M T09QKSkgJiYgIVBMQVRGT1JNKENIUk9NSVVNKQorI2lmICFkZWZpbmVkKEVOQUJMRV9ZQVJSX0pJ VCkgJiYgKEVOQUJMRShKSVQpIHx8IEVOQUJMRShMTElOVF9DX0xPT1ApKSAmJiAhUExBVEZPUk0o Q0hST01JVU0pICYmICEoT1MoUU5YKSAmJiBQTEFURk9STShRVCkpCiAjZGVmaW5lIEVOQUJMRV9Z QVJSX0pJVCAxCiAKIC8qIFNldHRpbmcgdGhpcyBmbGFnIGNvbXBhcmVzIEpJVCByZXN1bHRzIHdp dGggaW50ZXJwcmV0ZXIgcmVzdWx0cy4gKi8K