102774 2012-11-19 23:52:04 -0800 [V8] Remove V8ParameterBase 2012-11-20 01:56:47 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 771606 0 haraken 2012-11-19 23:52:04 -0800 V8ParameterBase is redundant. 771607 1 175159 haraken 2012-11-19 23:54:02 -0800 Created attachment 175159 Patch 771609 2 haraken 2012-11-19 23:55:45 -0800 After landing this patch, I'll merge prepare() with V8Parameter's constructor (prepare() is always called just after constructing V8Parameter). I'll also rename V8Parameter to a better name (V8Parameter is just a "super" class for String and AtomicString). 771657 3 175159 abarth 2012-11-20 01:24:21 -0800 Comment on attachment 175159 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175159&action=review > Source/WebCore/bindings/v8/V8StringResource.h:52 > +template <V8ParameterMode MODE = DefaultMode> MODE -> Mode > Source/WebCore/bindings/v8/V8StringResource.h:55 > + V8Parameter(v8::Local<v8::Value> object) : m_v8Object(object), m_mode(Externalize), m_string() { } Please split this up into multiple lines. 771666 4 175172 haraken 2012-11-20 01:34:13 -0800 Created attachment 175172 patch for landing 771672 5 175172 webkit.review.bot 2012-11-20 01:56:43 -0800 Comment on attachment 175172 patch for landing Clearing flags on attachment: 175172 Committed r135266: <http://trac.webkit.org/changeset/135266> 771673 6 webkit.review.bot 2012-11-20 01:56:47 -0800 All reviewed patches have been landed. Closing bug. 175159 2012-11-19 23:54:02 -0800 2012-11-20 01:34:10 -0800 Patch bug-102774-20121120165151.patch text/plain 3984 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MjQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWJmNjA3YjIxZjMwYWM0 NjIwZTBmZDE3MTE5ZjEzOGEyMDU4MDgwMi4uM2JjZGEwZmIwZDZkNDJlOGUwY2FkMTAxMmQyODAw NTE0ZDQ0M2E2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEyLTExLTE5ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIFJlbW92ZSBW OFBhcmFtZXRlckJhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwMjc3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFY4UGFyYW1ldGVyQmFzZSBpcyBhIHJlZHVuZGFudCBpbmRpcmVjdGlvbi4KKyAgICAg ICAgV2UgY2FuIGZsYXR0ZW4gbWV0aG9kcyBvZiBWOFBhcmFtZXRlckJhc2UgdG8gVjhQYXJhbWV0 ZXIuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAg ICAqIGJpbmRpbmdzL3Y4L1Y4U3RyaW5nUmVzb3VyY2UuaDoKKyAgICAgICAgKFdlYkNvcmU6OlY4 UGFyYW1ldGVyOjpWOFBhcmFtZXRlcik6CisgICAgICAgIChWOFBhcmFtZXRlcik6CisgICAgICAg IChXZWJDb3JlOjpWOFBhcmFtZXRlcjo6dG9TdHJpbmcpOgorICAgICAgICAoV2ViQ29yZTo6Ojpw cmVwYXJlKToKKworMjAxMi0xMS0xOSAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5v cmc+CisKICAgICAgICAgSW4gQ29kZUdlbmVyYXRvck9iai5wbSB3ZSBzaG91bGQgcmVuYW1lICRk YXRhTm9kZSB0byAkaW50ZXJmYWNlLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTAyNzQ5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L1Y4U3RyaW5nUmVzb3VyY2UuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 U3RyaW5nUmVzb3VyY2UuaAppbmRleCA1NWNkYmE2ZTJjMDAxMWZlMDUwYTlhYzBlYzIyMGNlY2Y3 ZGUxMjk0Li41Y2QzNTczMjlkNzU1M2M1OTQzZTQzZTQ1OTRhZWY3MjdiNTExNWU1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFN0cmluZ1Jlc291cmNlLmgKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhTdHJpbmdSZXNvdXJjZS5oCkBAIC00MSwxNCAr NDEsMjQgQEAgdGVtcGxhdGUgPHR5cGVuYW1lIFN0cmluZ1R5cGU+CiBTdHJpbmdUeXBlIHY4U3Ry aW5nVG9XZWJDb3JlU3RyaW5nKHY4OjpIYW5kbGU8djg6OlN0cmluZz4sIEV4dGVybmFsTW9kZSk7 CiBTdHJpbmcgaW50MzJUb1dlYkNvcmVTdHJpbmcoaW50IHZhbHVlKTsKIAotY2xhc3MgVjhQYXJh bWV0ZXJCYXNlIHsKKy8vIFY4UGFyYW1ldGVyIGlzIGFuIGFkYXB0ZXIgY2xhc3MgdGhhdCBjb252 ZXJ0cyBWOCB2YWx1ZXMgdG8gU3RyaW5ncworLy8gb3IgQXRvbWljU3RyaW5ncyBhcyBhcHByb3By aWF0ZSwgdXNpbmcgbXVsdGlwbGUgdHlwZWNhc3Qgb3BlcmF0b3JzLgorZW51bSBWOFBhcmFtZXRl ck1vZGUgeworICAgIERlZmF1bHRNb2RlLAorICAgIFdpdGhOdWxsQ2hlY2ssCisgICAgV2l0aFVu ZGVmaW5lZE9yTnVsbENoZWNrCit9OworCit0ZW1wbGF0ZSA8VjhQYXJhbWV0ZXJNb2RlIE1PREUg PSBEZWZhdWx0TW9kZT4KK2NsYXNzIFY4UGFyYW1ldGVyIHsKIHB1YmxpYzoKKyAgICBWOFBhcmFt ZXRlcih2ODo6TG9jYWw8djg6OlZhbHVlPiBvYmplY3QpIDogbV92OE9iamVjdChvYmplY3QpLCBt X21vZGUoRXh0ZXJuYWxpemUpLCBtX3N0cmluZygpIHsgfQorCisgICAgYm9vbCBwcmVwYXJlKCk7 CiAgICAgb3BlcmF0b3IgU3RyaW5nKCkgeyByZXR1cm4gdG9TdHJpbmc8U3RyaW5nPigpOyB9CiAg ICAgb3BlcmF0b3IgQXRvbWljU3RyaW5nKCkgeyByZXR1cm4gdG9TdHJpbmc8QXRvbWljU3RyaW5n PigpOyB9CiAKLXByb3RlY3RlZDoKLSAgICBWOFBhcmFtZXRlckJhc2Uodjg6OkxvY2FsPHY4OjpW YWx1ZT4gb2JqZWN0KSA6IG1fdjhPYmplY3Qob2JqZWN0KSwgbV9tb2RlKEV4dGVybmFsaXplKSwg bV9zdHJpbmcoKSB7IH0KLQorcHJpdmF0ZToKICAgICBib29sIHByZXBhcmVCYXNlKCkKICAgICB7 CiAgICAgICAgIGlmIChtX3Y4T2JqZWN0LklzRW1wdHkoKSkKQEAgLTgxLDExICs5MSw2IEBAIHBy b3RlY3RlZDoKICAgICAgICAgbV92OE9iamVjdC5DbGVhcigpOyAvLyBUbyBzaWduYWwgdGhhdCBT dHJpbmcgaXMgcmVhZHkuCiAgICAgfQogCi1wcml2YXRlOgotICAgIHY4OjpMb2NhbDx2ODo6VmFs dWU+IG1fdjhPYmplY3Q7Ci0gICAgRXh0ZXJuYWxNb2RlIG1fbW9kZTsKLSAgICBTdHJpbmcgbV9z dHJpbmc7Ci0KICAgICB0ZW1wbGF0ZSA8Y2xhc3MgU3RyaW5nVHlwZT4KICAgICBTdHJpbmdUeXBl IHRvU3RyaW5nKCkKICAgICB7CkBAIC05NCwyOCArOTksMTUgQEAgcHJpdmF0ZToKIAogICAgICAg ICByZXR1cm4gU3RyaW5nVHlwZShtX3N0cmluZyk7CiAgICAgfQotfTsKLQotLy8gVjhQYXJhbWV0 ZXIgaXMgYW4gYWRhcHRlciBjbGFzcyB0aGF0IGNvbnZlcnRzIFY4IHZhbHVlcyB0byBTdHJpbmdz Ci0vLyBvciBBdG9taWNTdHJpbmdzIGFzIGFwcHJvcHJpYXRlLCB1c2luZyBtdWx0aXBsZSB0eXBl Y2FzdCBvcGVyYXRvcnMuCi1lbnVtIFY4UGFyYW1ldGVyTW9kZSB7Ci0gICAgRGVmYXVsdE1vZGUs Ci0gICAgV2l0aE51bGxDaGVjaywKLSAgICBXaXRoVW5kZWZpbmVkT3JOdWxsQ2hlY2sKLX07CiAK LXRlbXBsYXRlIDxWOFBhcmFtZXRlck1vZGUgTU9ERSA9IERlZmF1bHRNb2RlPgotY2xhc3MgVjhQ YXJhbWV0ZXI6IHB1YmxpYyBWOFBhcmFtZXRlckJhc2UgewotcHVibGljOgotICAgIFY4UGFyYW1l dGVyKHY4OjpMb2NhbDx2ODo6VmFsdWU+IG9iamVjdCkgOiBWOFBhcmFtZXRlckJhc2Uob2JqZWN0 KSB7IH0KLSAgICBWOFBhcmFtZXRlcih2ODo6TG9jYWw8djg6OlZhbHVlPiBvYmplY3QsIGJvb2wp IDogVjhQYXJhbWV0ZXJCYXNlKG9iamVjdCkgeyBwcmVwYXJlKCk7IH0KLQotICAgIGJvb2wgcHJl cGFyZSgpOworICAgIHY4OjpMb2NhbDx2ODo6VmFsdWU+IG1fdjhPYmplY3Q7CisgICAgRXh0ZXJu YWxNb2RlIG1fbW9kZTsKKyAgICBTdHJpbmcgbV9zdHJpbmc7CiB9OwogCiB0ZW1wbGF0ZTw+IGlu bGluZSBib29sIFY4UGFyYW1ldGVyPERlZmF1bHRNb2RlPjo6cHJlcGFyZSgpCiB7Ci0gICAgcmV0 dXJuIFY4UGFyYW1ldGVyQmFzZTo6cHJlcGFyZUJhc2UoKTsKKyAgICByZXR1cm4gcHJlcGFyZUJh c2UoKTsKIH0KIAogdGVtcGxhdGU8PiBpbmxpbmUgYm9vbCBWOFBhcmFtZXRlcjxXaXRoTnVsbENo ZWNrPjo6cHJlcGFyZSgpCkBAIC0xMjQsOCArMTE2LDcgQEAgdGVtcGxhdGU8PiBpbmxpbmUgYm9v bCBWOFBhcmFtZXRlcjxXaXRoTnVsbENoZWNrPjo6cHJlcGFyZSgpCiAgICAgICAgIHNldFN0cmlu ZyhTdHJpbmcoKSk7CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KLQotICAgIHJldHVybiBW OFBhcmFtZXRlckJhc2U6OnByZXBhcmVCYXNlKCk7CisgICAgcmV0dXJuIHByZXBhcmVCYXNlKCk7 CiB9CiAKIHRlbXBsYXRlPD4gaW5saW5lIGJvb2wgVjhQYXJhbWV0ZXI8V2l0aFVuZGVmaW5lZE9y TnVsbENoZWNrPjo6cHJlcGFyZSgpCkBAIC0xMzQsOCArMTI1LDcgQEAgdGVtcGxhdGU8PiBpbmxp bmUgYm9vbCBWOFBhcmFtZXRlcjxXaXRoVW5kZWZpbmVkT3JOdWxsQ2hlY2s+OjpwcmVwYXJlKCkK ICAgICAgICAgc2V0U3RyaW5nKFN0cmluZygpKTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAg fQotCi0gICAgcmV0dXJuIFY4UGFyYW1ldGVyQmFzZTo6cHJlcGFyZUJhc2UoKTsKKyAgICByZXR1 cm4gcHJlcGFyZUJhc2UoKTsKIH0KICAgICAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK 175172 2012-11-20 01:34:13 -0800 2012-11-20 01:56:43 -0800 patch for landing bug-102774-20121120183202.patch text/plain 4020 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MjQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWJmNjA3YjIxZjMwYWM0 NjIwZTBmZDE3MTE5ZjEzOGEyMDU4MDgwMi4uN2FhMjhlOWU3OTg3NjIxZmE5YTZjODZjYmZhYjRh MjRmYzJlZmJjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEyLTExLTE5ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIFJlbW92ZSBW OFBhcmFtZXRlckJhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwMjc3NAorCisgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCisKKyAgICAg ICAgVjhQYXJhbWV0ZXJCYXNlIGlzIGEgcmVkdW5kYW50IGluZGlyZWN0aW9uLgorICAgICAgICBX ZSBjYW4gZmxhdHRlbiBtZXRob2RzIG9mIFY4UGFyYW1ldGVyQmFzZSB0byBWOFBhcmFtZXRlci4K KworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICog YmluZGluZ3MvdjgvVjhTdHJpbmdSZXNvdXJjZS5oOgorICAgICAgICAoV2ViQ29yZTo6VjhQYXJh bWV0ZXI6OlY4UGFyYW1ldGVyKToKKyAgICAgICAgKFY4UGFyYW1ldGVyKToKKyAgICAgICAgKFdl YkNvcmU6OlY4UGFyYW1ldGVyOjp0b1N0cmluZyk6CisgICAgICAgIChXZWJDb3JlOjo6OnByZXBh cmUpOgorCisyMDEyLTExLTE5ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4K KwogICAgICAgICBJbiBDb2RlR2VuZXJhdG9yT2JqLnBtIHdlIHNob3VsZCByZW5hbWUgJGRhdGFO b2RlIHRvICRpbnRlcmZhY2UuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMDI3NDkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhTdHJpbmdSZXNvdXJjZS5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhTdHJp bmdSZXNvdXJjZS5oCmluZGV4IDU1Y2RiYTZlMmMwMDExZmUwNTBhOWFjMGVjMjIwY2VjZjdkZTEy OTQuLjFhNzA3ZGI2Mjg3ODhkMjNlYzliZjJjNTUzNTYzNTU4MmQ4NDFjZDYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4U3RyaW5nUmVzb3VyY2UuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFN0cmluZ1Jlc291cmNlLmgKQEAgLTQxLDE0ICs0MSwy OSBAQCB0ZW1wbGF0ZSA8dHlwZW5hbWUgU3RyaW5nVHlwZT4KIFN0cmluZ1R5cGUgdjhTdHJpbmdU b1dlYkNvcmVTdHJpbmcodjg6OkhhbmRsZTx2ODo6U3RyaW5nPiwgRXh0ZXJuYWxNb2RlKTsKIFN0 cmluZyBpbnQzMlRvV2ViQ29yZVN0cmluZyhpbnQgdmFsdWUpOwogCi1jbGFzcyBWOFBhcmFtZXRl ckJhc2UgeworLy8gVjhQYXJhbWV0ZXIgaXMgYW4gYWRhcHRlciBjbGFzcyB0aGF0IGNvbnZlcnRz IFY4IHZhbHVlcyB0byBTdHJpbmdzCisvLyBvciBBdG9taWNTdHJpbmdzIGFzIGFwcHJvcHJpYXRl LCB1c2luZyBtdWx0aXBsZSB0eXBlY2FzdCBvcGVyYXRvcnMuCitlbnVtIFY4UGFyYW1ldGVyTW9k ZSB7CisgICAgRGVmYXVsdE1vZGUsCisgICAgV2l0aE51bGxDaGVjaywKKyAgICBXaXRoVW5kZWZp bmVkT3JOdWxsQ2hlY2sKK307CisKK3RlbXBsYXRlIDxWOFBhcmFtZXRlck1vZGUgTW9kZSA9IERl ZmF1bHRNb2RlPgorY2xhc3MgVjhQYXJhbWV0ZXIgewogcHVibGljOgorICAgIFY4UGFyYW1ldGVy KHY4OjpMb2NhbDx2ODo6VmFsdWU+IG9iamVjdCkKKyAgICAgICAgOiBtX3Y4T2JqZWN0KG9iamVj dCkKKyAgICAgICAgLCBtX21vZGUoRXh0ZXJuYWxpemUpCisgICAgICAgICwgbV9zdHJpbmcoKQor ICAgIHsKKyAgICB9CisKKyAgICBib29sIHByZXBhcmUoKTsKICAgICBvcGVyYXRvciBTdHJpbmco KSB7IHJldHVybiB0b1N0cmluZzxTdHJpbmc+KCk7IH0KICAgICBvcGVyYXRvciBBdG9taWNTdHJp bmcoKSB7IHJldHVybiB0b1N0cmluZzxBdG9taWNTdHJpbmc+KCk7IH0KIAotcHJvdGVjdGVkOgot ICAgIFY4UGFyYW1ldGVyQmFzZSh2ODo6TG9jYWw8djg6OlZhbHVlPiBvYmplY3QpIDogbV92OE9i amVjdChvYmplY3QpLCBtX21vZGUoRXh0ZXJuYWxpemUpLCBtX3N0cmluZygpIHsgfQotCitwcml2 YXRlOgogICAgIGJvb2wgcHJlcGFyZUJhc2UoKQogICAgIHsKICAgICAgICAgaWYgKG1fdjhPYmpl Y3QuSXNFbXB0eSgpKQpAQCAtODEsMTEgKzk2LDYgQEAgcHJvdGVjdGVkOgogICAgICAgICBtX3Y4 T2JqZWN0LkNsZWFyKCk7IC8vIFRvIHNpZ25hbCB0aGF0IFN0cmluZyBpcyByZWFkeS4KICAgICB9 CiAKLXByaXZhdGU6Ci0gICAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gbV92OE9iamVjdDsKLSAgICBF eHRlcm5hbE1vZGUgbV9tb2RlOwotICAgIFN0cmluZyBtX3N0cmluZzsKLQogICAgIHRlbXBsYXRl IDxjbGFzcyBTdHJpbmdUeXBlPgogICAgIFN0cmluZ1R5cGUgdG9TdHJpbmcoKQogICAgIHsKQEAg LTk0LDI4ICsxMDQsMTUgQEAgcHJpdmF0ZToKIAogICAgICAgICByZXR1cm4gU3RyaW5nVHlwZSht X3N0cmluZyk7CiAgICAgfQotfTsKLQotLy8gVjhQYXJhbWV0ZXIgaXMgYW4gYWRhcHRlciBjbGFz cyB0aGF0IGNvbnZlcnRzIFY4IHZhbHVlcyB0byBTdHJpbmdzCi0vLyBvciBBdG9taWNTdHJpbmdz IGFzIGFwcHJvcHJpYXRlLCB1c2luZyBtdWx0aXBsZSB0eXBlY2FzdCBvcGVyYXRvcnMuCi1lbnVt IFY4UGFyYW1ldGVyTW9kZSB7Ci0gICAgRGVmYXVsdE1vZGUsCi0gICAgV2l0aE51bGxDaGVjaywK LSAgICBXaXRoVW5kZWZpbmVkT3JOdWxsQ2hlY2sKLX07Ci0KLXRlbXBsYXRlIDxWOFBhcmFtZXRl ck1vZGUgTU9ERSA9IERlZmF1bHRNb2RlPgotY2xhc3MgVjhQYXJhbWV0ZXI6IHB1YmxpYyBWOFBh cmFtZXRlckJhc2UgewotcHVibGljOgotICAgIFY4UGFyYW1ldGVyKHY4OjpMb2NhbDx2ODo6VmFs dWU+IG9iamVjdCkgOiBWOFBhcmFtZXRlckJhc2Uob2JqZWN0KSB7IH0KLSAgICBWOFBhcmFtZXRl cih2ODo6TG9jYWw8djg6OlZhbHVlPiBvYmplY3QsIGJvb2wpIDogVjhQYXJhbWV0ZXJCYXNlKG9i amVjdCkgeyBwcmVwYXJlKCk7IH0KIAotICAgIGJvb2wgcHJlcGFyZSgpOworICAgIHY4OjpMb2Nh bDx2ODo6VmFsdWU+IG1fdjhPYmplY3Q7CisgICAgRXh0ZXJuYWxNb2RlIG1fbW9kZTsKKyAgICBT dHJpbmcgbV9zdHJpbmc7CiB9OwogCiB0ZW1wbGF0ZTw+IGlubGluZSBib29sIFY4UGFyYW1ldGVy PERlZmF1bHRNb2RlPjo6cHJlcGFyZSgpCiB7Ci0gICAgcmV0dXJuIFY4UGFyYW1ldGVyQmFzZTo6 cHJlcGFyZUJhc2UoKTsKKyAgICByZXR1cm4gcHJlcGFyZUJhc2UoKTsKIH0KIAogdGVtcGxhdGU8 PiBpbmxpbmUgYm9vbCBWOFBhcmFtZXRlcjxXaXRoTnVsbENoZWNrPjo6cHJlcGFyZSgpCkBAIC0x MjQsOCArMTIxLDcgQEAgdGVtcGxhdGU8PiBpbmxpbmUgYm9vbCBWOFBhcmFtZXRlcjxXaXRoTnVs bENoZWNrPjo6cHJlcGFyZSgpCiAgICAgICAgIHNldFN0cmluZyhTdHJpbmcoKSk7CiAgICAgICAg IHJldHVybiB0cnVlOwogICAgIH0KLQotICAgIHJldHVybiBWOFBhcmFtZXRlckJhc2U6OnByZXBh cmVCYXNlKCk7CisgICAgcmV0dXJuIHByZXBhcmVCYXNlKCk7CiB9CiAKIHRlbXBsYXRlPD4gaW5s aW5lIGJvb2wgVjhQYXJhbWV0ZXI8V2l0aFVuZGVmaW5lZE9yTnVsbENoZWNrPjo6cHJlcGFyZSgp CkBAIC0xMzQsOCArMTMwLDcgQEAgdGVtcGxhdGU8PiBpbmxpbmUgYm9vbCBWOFBhcmFtZXRlcjxX aXRoVW5kZWZpbmVkT3JOdWxsQ2hlY2s+OjpwcmVwYXJlKCkKICAgICAgICAgc2V0U3RyaW5nKFN0 cmluZygpKTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQotCi0gICAgcmV0dXJuIFY4UGFy YW1ldGVyQmFzZTo6cHJlcGFyZUJhc2UoKTsKKyAgICByZXR1cm4gcHJlcGFyZUJhc2UoKTsKIH0K ICAgICAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK