102773 2012-11-19 23:29:23 -0800 [EFL][WK2] Remove #include "ewk_view_private.h" in PageViewportControllerClientEfl.cpp 2012-11-21 16:21:27 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 ljaehun.lim webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 771570 0 ljaehun.lim 2012-11-19 23:29:23 -0800 PageViewportControllerClientEfl.cpp doesn't need to include ewk_view_private.h. 771572 1 175154 ljaehun.lim 2012-11-19 23:31:35 -0800 Created attachment 175154 Patch 771675 2 175154 rakuco 2012-11-20 02:01:00 -0800 Comment on attachment 175154 Patch Looks OK. 773243 3 175154 laszlo.gombos 2012-11-21 13:50:09 -0800 Comment on attachment 175154 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175154&action=review Overall looks good. > Source/WebKit2/ChangeLog:3 > + [EFL][WK2] Remove #include #include "ewk_view_private.h" in PageViewportControllerClientEfl.cpp Please remove the double #include. 773311 4 175525 ljaehun.lim 2012-11-21 14:45:39 -0800 Created attachment 175525 Patch 773395 5 175525 webkit.review.bot 2012-11-21 16:21:23 -0800 Comment on attachment 175525 Patch Clearing flags on attachment: 175525 Committed r135453: <http://trac.webkit.org/changeset/135453> 773396 6 webkit.review.bot 2012-11-21 16:21:27 -0800 All reviewed patches have been landed. Closing bug. 175154 2012-11-19 23:31:35 -0800 2012-11-21 14:45:31 -0800 Patch bug-102773-20121120162923.patch text/plain 1360 ljaehun.lim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MjUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNmQ1NTkyYmZkOTFlMWJm YjQ1MDU3OTU4MTRkYmZmMmJjYWJhMDc5Mi4uOGY3NDQ4ZTE2ZDA4YjAxY2EwNzAxM2M4OThlNTc5 NWIwZWIzZjVjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTExLTE5ICBKYWVo dW4gTGltICA8bGphZWh1bi5saW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBS ZW1vdmUgI2luY2x1ZGUgI2luY2x1ZGUgImV3a192aWV3X3ByaXZhdGUuaCIgaW4gUGFnZVZpZXdw b3J0Q29udHJvbGxlckNsaWVudEVmbC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwMjc3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFBhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRFZmwuY3BwIGRv ZXNuJ3QgbmVlZCB0byBpbmNsdWRlIGV3a192aWV3X3ByaXZhdGUuaC4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9lZmwvUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudEVmbC5jcHA6CisKIDIwMTIt MTEtMTkgIEt5dW5nVGFlIEtpbSAgPGt0Zi5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgW1dL Ml0gVW51c2VkIHBhcmFtZXRlcnMgb24gQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmNwcApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9QYWdlVmlld3BvcnRDb250cm9s bGVyQ2xpZW50RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvUGFnZVZpZXdw b3J0Q29udHJvbGxlckNsaWVudEVmbC5jcHAKaW5kZXggYmE4OWUzY2RkN2E0NTExNmYyMTdkY2Vh NzZhZTBhNGVmMTIxOGMwMS4uY2RkNTY1MDA4NWY5MjgxOTg5MjBhOThjYzZjMzM1ZWY5MjIwYjFj MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9QYWdlVmlld3BvcnRD b250cm9sbGVyQ2xpZW50RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZs L1BhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRFZmwuY3BwCkBAIC0zMyw3ICszMyw2IEBACiAj aW5jbHVkZSAiTGF5ZXJUcmVlUmVuZGVyZXIuaCIKICNpbmNsdWRlICJQYWdlVmlld3BvcnRDb250 cm9sbGVyLmgiCiAjaW5jbHVkZSAiVHJhbnNmb3JtYXRpb25NYXRyaXguaCIKLSNpbmNsdWRlICJl d2tfdmlld19wcml2YXRlLmgiCiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCg== 175525 2012-11-21 14:45:39 -0800 2012-11-21 16:21:23 -0800 Patch bug-102773-20121122074325.patch text/plain 1357 ljaehun.lim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NDM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDVkY2MzMzcxN2M4Njhm YmUzNzFmODU3ZTMxOTg5MmJmNjFhNTE0OC4uYjhmYTYwNmQ5N2JjYWE2ZDIzNzEyYjdhYjExZTRk OTEzYjJmZjE5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTExLTIxICBKYWVo dW4gTGltICA8bGphZWh1bi5saW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBS ZW1vdmUgI2luY2x1ZGUgImV3a192aWV3X3ByaXZhdGUuaCIgaW4gUGFnZVZpZXdwb3J0Q29udHJv bGxlckNsaWVudEVmbC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwMjc3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFBhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRFZmwuY3BwIGRvZXNuJ3QgbmVl ZCB0byBpbmNsdWRlIGV3a192aWV3X3ByaXZhdGUuaC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9l ZmwvUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudEVmbC5jcHA6CisKIDIwMTItMTEtMjEgIEh1 YW5nIERvbmdzdW5nICA8bHV4dGVsbGFAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgUkVHUkVT U0lPTihyMTM1MjEyKTogRml4IGNyYXNoIGR1ZSB0byBhbiBpbmZpbml0ZSByZWN0LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9QYWdlVmlld3BvcnRDb250cm9sbGVy Q2xpZW50RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvUGFnZVZpZXdwb3J0 Q29udHJvbGxlckNsaWVudEVmbC5jcHAKaW5kZXggYmE4OWUzY2RkN2E0NTExNmYyMTdkY2VhNzZh ZTBhNGVmMTIxOGMwMS4uY2RkNTY1MDA4NWY5MjgxOTg5MjBhOThjYzZjMzM1ZWY5MjIwYjFjMCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9QYWdlVmlld3BvcnRDb250 cm9sbGVyQ2xpZW50RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1Bh Z2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRFZmwuY3BwCkBAIC0zMyw3ICszMyw2IEBACiAjaW5j bHVkZSAiTGF5ZXJUcmVlUmVuZGVyZXIuaCIKICNpbmNsdWRlICJQYWdlVmlld3BvcnRDb250cm9s bGVyLmgiCiAjaW5jbHVkZSAiVHJhbnNmb3JtYXRpb25NYXRyaXguaCIKLSNpbmNsdWRlICJld2tf dmlld19wcml2YXRlLmgiCiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCg==