102768 2012-11-19 22:13:33 -0800 Merge checks for creating renderers into shouldCreateRenderer 2012-11-20 09:45:14 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 esprehn esprehn dglazkov morrita ojan tasak webkit.review.bot oldest_to_newest 771514 0 esprehn 2012-11-19 22:13:33 -0800 Merge checks for creating renderers into shouldCreateRenderer 771521 1 175141 esprehn 2012-11-19 22:21:57 -0800 Created attachment 175141 Patch 771523 2 esprehn 2012-11-19 22:28:23 -0800 I can't find anyone who ever actually sets the document level shouldCreateRenderers to false, so this would seem to be dead code, though it is exposed for the mac port in the WebFramePrivate.h header so maybe Safari uses it internally? I suppose the feature is theoretically useful for future ports/features too... 771941 3 175141 webkit.review.bot 2012-11-20 09:45:11 -0800 Comment on attachment 175141 Patch Clearing flags on attachment: 175141 Committed r135290: <http://trac.webkit.org/changeset/135290> 771942 4 webkit.review.bot 2012-11-20 09:45:14 -0800 All reviewed patches have been landed. Closing bug. 175141 2012-11-19 22:21:57 -0800 2012-11-20 09:45:11 -0800 Patch bug-102768-20121120011947.patch text/plain 2535 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MjQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTgxODkzN2NhOGIwZmRi ZDA5MDIyMWJhNTNmYWRlODE0YmIzYTA3Yi4uODBlZWM4YmViNzgxMGNmMDYxMGE1NDM4YjcwNTM3 OTA4Y2RhOWMyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTExLTE5ICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIE1lcmdlIGNoZWNr cyBmb3IgY3JlYXRpbmcgcmVuZGVyZXJzIGludG8gc2hvdWxkQ3JlYXRlUmVuZGVyZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjc2OAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1lcmdlIHRoZSBjaGVj a3MgZm9yIGlmIHJlbmRlcmVycyBzaG91bGQgYmUgY3JlYXRlZCBpbnRvIHNob3VsZENyZWF0ZVJl bmRlcmVyCisgICAgICAgIHNvIHNpbXBsaWZ5IHRoZSBjb2RlIGFuZCBlbnN1cmUgY29ycmVjdG5l c3MgaWYgZG9pbmcKKyAgICAgICAgTm9kZVJlbmRlcmluZ0NvbnRleHQobm9kZSkuc2hvdWxkQ3Jl YXRlUmVuZGVyZXIoKSBpbiBvdGhlciBwbGFjZXMgaW4gd2Via2l0LgorCisgICAgICAgIE5vIG5l dyB0ZXN0cywganVzdCByZWZhY3RvcmluZy4KKworICAgICAgICAqIGRvbS9Ob2RlUmVuZGVyaW5n Q29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOb2RlUmVuZGVyaW5nQ29udGV4dDo6c2hv dWxkQ3JlYXRlUmVuZGVyZXIpOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZVJlbmRlcmVyRmFjdG9y eTo6Y3JlYXRlUmVuZGVyZXJJZk5lZWRlZCk6CisKIDIwMTItMTEtMTkgIFl1cnkgU2VtaWtoYXRz a3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gRml4IENocm9t aXVtIERlYnVnIGNvbXBpbGF0aW9uIGFmdGVyIHIxMzUyMzAuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9kb20vTm9kZVJlbmRlcmluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9t L05vZGVSZW5kZXJpbmdDb250ZXh0LmNwcAppbmRleCBkNzJhMjY1M2NjZWJiM2E0M2YwODRiNGMz NmNiZjdkZDMzYmEyMWIzLi42MDk5MjJjODEzMTc5MjdiOTk5YzcyYzJhMWVkOTBlMjRkMzViY2Zi IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZVJlbmRlcmluZ0NvbnRleHQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlUmVuZGVyaW5nQ29udGV4dC5jcHAKQEAgLTE0 Miw2ICsxNDIsOCBAQCBSZW5kZXJPYmplY3QqIE5vZGVSZW5kZXJpbmdDb250ZXh0OjpwYXJlbnRS ZW5kZXJlcigpIGNvbnN0CiAKIGJvb2wgTm9kZVJlbmRlcmluZ0NvbnRleHQ6OnNob3VsZENyZWF0 ZVJlbmRlcmVyKCkgY29uc3QKIHsKKyAgICBpZiAoIW1fbm9kZS0+ZG9jdW1lbnQoKS0+c2hvdWxk Q3JlYXRlUmVuZGVyZXJzKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAoIW1fcGFy ZW50RGV0YWlscy5ub2RlKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBSZW5kZXJPYmpl Y3QqIHBhcmVudFJlbmRlcmVyID0gdGhpcy0+cGFyZW50UmVuZGVyZXIoKTsKQEAgLTIzNSwxMiAr MjM3LDcgQEAgc3RhdGljIHZvaWQgYWRqdXN0SW5zZXJ0aW9uUG9pbnRGb3JUb3BMYXllckVsZW1l bnQoRWxlbWVudCogZWxlbWVudCwgUmVuZGVyT2JqZWMKIHZvaWQgTm9kZVJlbmRlcmVyRmFjdG9y eTo6Y3JlYXRlUmVuZGVyZXJJZk5lZWRlZCgpCiB7CiAgICAgTm9kZSogbm9kZSA9IG1fY29udGV4 dC5ub2RlKCk7Ci0gICAgRG9jdW1lbnQqIGRvY3VtZW50ID0gbm9kZS0+ZG9jdW1lbnQoKTsKLSAg ICBpZiAoIWRvY3VtZW50LT5zaG91bGRDcmVhdGVSZW5kZXJlcnMoKSkKLSAgICAgICAgcmV0dXJu OwotCiAgICAgQVNTRVJUKCFub2RlLT5yZW5kZXJlcigpKTsKLSAgICBBU1NFUlQoZG9jdW1lbnQt PnNob3VsZENyZWF0ZVJlbmRlcmVycygpKTsKIAogICAgIGlmICghbV9jb250ZXh0LnNob3VsZENy ZWF0ZVJlbmRlcmVyKCkpCiAgICAgICAgIHJldHVybjsKQEAgLTI3MCw2ICsyNjcsNyBAQCB2b2lk IE5vZGVSZW5kZXJlckZhY3Rvcnk6OmNyZWF0ZVJlbmRlcmVySWZOZWVkZWQoKQogICAgIFJlbmRl ck9iamVjdCogbmV3UmVuZGVyZXIgPSBjcmVhdGVSZW5kZXJlcigpOwogCiAjaWYgRU5BQkxFKEZV TExTQ1JFRU5fQVBJKQorICAgIERvY3VtZW50KiBkb2N1bWVudCA9IG5vZGUtPmRvY3VtZW50KCk7 CiAgICAgaWYgKGRvY3VtZW50LT53ZWJraXRJc0Z1bGxTY3JlZW4oKSAmJiBkb2N1bWVudC0+d2Vi a2l0Q3VycmVudEZ1bGxTY3JlZW5FbGVtZW50KCkgPT0gbm9kZSkKICAgICAgICAgbmV3UmVuZGVy ZXIgPSBSZW5kZXJGdWxsU2NyZWVuOjp3cmFwUmVuZGVyZXIobmV3UmVuZGVyZXIsIHBhcmVudFJl bmRlcmVyLCBkb2N1bWVudCk7CiAjZW5kaWYK