102743 2012-11-19 16:51:13 -0800 Clean up loop in NodeRenderingContext::nextRenderer and previousRenderer 2012-11-19 20:19:32 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 esprehn esprehn dglazkov morrita ojan webkit.review.bot oldest_to_newest 771211 0 esprehn 2012-11-19 16:51:13 -0800 Clean up loop in NodeRenderingContext::nextRenderer 771220 1 175082 esprehn 2012-11-19 16:55:51 -0800 Created attachment 175082 Patch 771429 2 175082 morrita 2012-11-19 20:11:04 -0800 Comment on attachment 175082 Patch Thanks for the cleanup! 771433 3 175082 webkit.review.bot 2012-11-19 20:19:28 -0800 Comment on attachment 175082 Patch Clearing flags on attachment: 175082 Committed r135237: <http://trac.webkit.org/changeset/135237> 771434 4 webkit.review.bot 2012-11-19 20:19:32 -0800 All reviewed patches have been landed. Closing bug. 175082 2012-11-19 16:55:51 -0800 2012-11-19 20:19:28 -0800 Patch bug-102743-20121119195341.patch text/plain 2665 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MjA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWY1NjgwMDcyZjhhZTE4 NjYwZWJkMTlhNjg1OTlkNjNjMzNlM2M2Zi4uNDU3YWEyMGFiOGU5ZTk4NWEwOWJmNzdlYzQ1MmI5 Y2JhMGRlNjQ0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTExLTE5ICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIENsZWFuIHVwIGxv b3AgaW4gTm9kZVJlbmRlcmluZ0NvbnRleHQ6Om5leHRSZW5kZXJlciBhbmQgcHJldmlvdXNSZW5k ZXJlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAy NzQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2xl YW4gdXAgd2hpbGUgKHRydWUpIGxvb3BzIGluIE5vZGVSZW5kZXJpbmdDb250ZXh0IHJlZHVjaW5n IHRoZQorICAgICAgICBhbW91bnQgb2YgY29kZSBhbmQgdGhlIG5lZWQgZm9yIEFTU0VSVF9OT1Rf UkVBQ0hFRC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGp1c3Qgc2ltcGxpZmNhdGlvbi4KKwor ICAgICAgICAqIGRvbS9Ob2RlUmVuZGVyaW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpOb2RlUmVuZGVyaW5nQ29udGV4dDo6bmV4dFJlbmRlcmVyKToKKyAgICAgICAgKFdlYkNvcmU6 Ok5vZGVSZW5kZXJpbmdDb250ZXh0OjpwcmV2aW91c1JlbmRlcmVyKToKKwogMjAxMi0xMS0xOSAg QWxwaGEgTGFtICA8aGNsYW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE5vdCByZXZpZXdlZC4g QnVpbGQgZml4IGZvciBDaHJvbWl1bS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9O b2RlUmVuZGVyaW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZVJlbmRlcmlu Z0NvbnRleHQuY3BwCmluZGV4IDIxZjFjM2Y4OTlmYjA5M2ZiZmZiODI0NjFhYzFlMGM1YjUzYTgx OWQuLjRiYjdhZmQzMzgwMTA4NGJkNjQ4MDIwM2FiMTRlYjhkNDE2MWVlODAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlUmVuZGVyaW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL05vZGVSZW5kZXJpbmdDb250ZXh0LmNwcApAQCAtOTQsMTkgKzk0LDE1IEBA IFJlbmRlck9iamVjdCogTm9kZVJlbmRlcmluZ0NvbnRleHQ6Om5leHRSZW5kZXJlcigpIGNvbnN0 CiAgICAgICAgIHJldHVybiAwOwogCiAgICAgQ29tcG9zZWRTaGFkb3dUcmVlV2Fsa2VyIHdhbGtl cihtX25vZGUpOwotICAgIGRvIHsKLSAgICAgICAgd2Fsa2VyLm5leHRTaWJsaW5nKCk7Ci0gICAg ICAgIGlmICghd2Fsa2VyLmdldCgpKQotICAgICAgICAgICAgcmV0dXJuIDA7CisgICAgZm9yICh3 YWxrZXIubmV4dFNpYmxpbmcoKTsgd2Fsa2VyLmdldCgpOyB3YWxrZXIubmV4dFNpYmxpbmcoKSkg ewogICAgICAgICBpZiAoUmVuZGVyT2JqZWN0KiByZW5kZXJlciA9IHdhbGtlci5nZXQoKS0+cmVu ZGVyZXIoKSkgewogICAgICAgICAgICAgLy8gRG8gbm90IHJldHVybiBlbGVtZW50cyB0aGF0IGFy ZSBhdHRhY2hlZCB0byBhIGRpZmZlcmVudCBmbG93LXRocmVhZC4KICAgICAgICAgICAgIGlmIChy ZW5kZXJlci0+c3R5bGUoKSAmJiAhcmVuZGVyZXItPnN0eWxlKCktPmZsb3dUaHJlYWQoKS5pc0Vt cHR5KCkpCiAgICAgICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgICByZXR1cm4gcmVu ZGVyZXI7CiAgICAgICAgIH0KLSAgICB9IHdoaWxlICh0cnVlKTsKKyAgICB9CiAKLSAgICBBU1NF UlRfTk9UX1JFQUNIRUQoKTsKICAgICByZXR1cm4gMDsKIH0KIApAQCAtMTIyLDE5ICsxMTgsMTUg QEAgUmVuZGVyT2JqZWN0KiBOb2RlUmVuZGVyaW5nQ29udGV4dDo6cHJldmlvdXNSZW5kZXJlcigp IGNvbnN0CiAgICAgLy8gaG93ZXZlciwgd2hlbiBJIHRyaWVkIGFkZGluZyBpdCwgc2V2ZXJhbCB0 ZXN0cyBmYWlsZWQuCiAKICAgICBDb21wb3NlZFNoYWRvd1RyZWVXYWxrZXIgd2Fsa2VyKG1fbm9k ZSk7Ci0gICAgZG8gewotICAgICAgICB3YWxrZXIucHJldmlvdXNTaWJsaW5nKCk7Ci0gICAgICAg IGlmICghd2Fsa2VyLmdldCgpKQotICAgICAgICAgICAgcmV0dXJuIDA7CisgICAgZm9yICh3YWxr ZXIucHJldmlvdXNTaWJsaW5nKCk7IHdhbGtlci5nZXQoKTsgd2Fsa2VyLnByZXZpb3VzU2libGlu ZygpKSB7CiAgICAgICAgIGlmIChSZW5kZXJPYmplY3QqIHJlbmRlcmVyID0gd2Fsa2VyLmdldCgp LT5yZW5kZXJlcigpKSB7CiAgICAgICAgICAgICAvLyBEbyBub3QgcmV0dXJuIGVsZW1lbnRzIHRo YXQgYXJlIGF0dGFjaGVkIHRvIGEgZGlmZmVyZW50IGZsb3ctdGhyZWFkLgogICAgICAgICAgICAg aWYgKHJlbmRlcmVyLT5zdHlsZSgpICYmICFyZW5kZXJlci0+c3R5bGUoKS0+Zmxvd1RocmVhZCgp LmlzRW1wdHkoKSkKICAgICAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgICAgIHJldHVy biByZW5kZXJlcjsKICAgICAgICAgfQotICAgIH0gd2hpbGUgKHRydWUpOworICAgIH0KIAotICAg IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIHJldHVybiAwOwogfQogCg==