102706 2012-11-19 12:23:57 -0800 Add ResourceBuffer::append(CFDataRef) to get code to compile with USE(NETWORK_CFDATA_ARRAY_CALLBACK) 2012-11-26 12:49:57 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psolanki psolanki ap beidson japhet joepeck psolanki webkit.review.bot oldest_to_newest 770934 0 psolanki 2012-11-19 12:23:57 -0800 With USE(NETWORK_CFDATA_ARRAY_CALLBACK), the code doesn't compile. We need ResourceBuffer::append(CFDataRef) and a few minor changes. 770953 1 175027 psolanki 2012-11-19 12:42:40 -0800 Created attachment 175027 Patch 771122 2 ap 2012-11-19 15:49:34 -0800 Looks good to me. Brady should take a look, since he's been actively working in this area of code recently. 771268 3 175027 bfulgham 2012-11-19 17:32:15 -0800 Comment on attachment 175027 Patch Looks good to me. R=me. 771308 4 beidson 2012-11-19 17:49:22 -0800 Nothing wrong with this patch as a build fix. But fair warning - CFDATA_ARRAY_CALLBACK is somewhat incompatible with the IPC architecture of NetworkProcess mode, so we might have to revisit this type of thing in the future. 775789 5 psolanki 2012-11-26 12:49:57 -0800 Committed r135755: <http://trac.webkit.org/changeset/135755> 175027 2012-11-19 12:42:40 -0800 2012-11-19 17:32:36 -0800 Patch bug-102706-20121119124032.patch text/plain 2638 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MDM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWE3ZTQ1YmRmZTM5MTgx OWNlZGMyYThjYTcxOTEzYzFiNTJmMmNkZC4uMmMxZDgxMjViOGM5NGUyNDMxY2MzMjJmMjFiNzlj YWMzYzBkYTUzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTExLTE5ICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgUmVzb3VyY2VC dWZmZXI6OmFwcGVuZChDRkRhdGFSZWYpIHRvIGdldCBjb2RlIHRvIGNvbXBpbGUgd2l0aCBVU0Uo TkVUV09SS19DRkRBVEFfQVJSQVlfQ0FMTEJBQ0spCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI3MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSB0aGUgZmxhZyBpc24n dCBlbmFibGVkLiBBbHNvIHRoZSBmdW5jdGlvbmFsaXR5IHNob3VsZCBiZSBjb3ZlcmVkIGJ5Cisg ICAgICAgIGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogbG9hZGVyL1Jlc291cmNlQnVmZmVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VCdWZm ZXI6OmFwcGVuZCk6CisgICAgICAgICogbG9hZGVyL1Jlc291cmNlQnVmZmVyLmg6CisgICAgICAg IChSZXNvdXJjZUJ1ZmZlcik6CisgICAgICAgICogbG9hZGVyL21hYy9SZXNvdXJjZUxvYWRlck1h Yy5tbToKKwogMjAxMi0xMS0xNiAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNv bT4KIAogICAgICAgICBJbXByb3ZlIHRoZSBwZXJmb3JtYW5jZSBvZiByZWN0IHRyYW5zZm9ybQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlQnVmZmVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUJ1ZmZlci5jcHAKaW5kZXggMGUzMGVjMzIzNWMz NDllMGFmNzM3NDM5YWVkYmE5MTViMDIwMmUxOS4uNTdhZTlhYzViYWZhZmY3Yjc2NWEzNjE1MDcx MjU4YjQyNTg2Y2ZkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNl QnVmZmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VCdWZmZXIuY3Bw CkBAIC03MSw2ICs3MSwxNCBAQCB2b2lkIFJlc291cmNlQnVmZmVyOjphcHBlbmQoY29uc3QgY2hh ciogZGF0YSwgdW5zaWduZWQgc2l6ZSkKICAgICBtX3NoYXJlZEJ1ZmZlci0+YXBwZW5kKGRhdGEs IHNpemUpOwogfQogCisjaWYgVVNFKE5FVFdPUktfQ0ZEQVRBX0FSUkFZX0NBTExCQUNLKQordm9p ZCBSZXNvdXJjZUJ1ZmZlcjo6YXBwZW5kKENGRGF0YVJlZiBkYXRhKQoreworICAgIEFTU0VSVCht X3NoYXJlZEJ1ZmZlcik7CisgICAgbV9zaGFyZWRCdWZmZXItPmFwcGVuZChkYXRhKTsKK30KKyNl bmRpZgorCiB2b2lkIFJlc291cmNlQnVmZmVyOjpjbGVhcigpCiB7CiAgICAgbV9zaGFyZWRCdWZm ZXItPmNsZWFyKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VC dWZmZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUJ1ZmZlci5oCmluZGV4IDgz NjQyZmZkMzk5MTFiMmU2MDdlYjVjODZiOWEzNGQ2ZDc1YjEyMzkuLjJmZGQ4ZjM2N2JlMTVlMWVh NjYzNTU0NjM3N2Y3ZTFmMjg4YzhmYzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9SZXNvdXJjZUJ1ZmZlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUJ1 ZmZlci5oCkBAIC01NSw2ICs1NSw5IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgaXNFbXB0 eSgpIGNvbnN0OwogCiAgICAgdm9pZCBhcHBlbmQoY29uc3QgY2hhciosIHVuc2lnbmVkKTsKKyNp ZiBVU0UoTkVUV09SS19DRkRBVEFfQVJSQVlfQ0FMTEJBQ0spCisgICAgdm9pZCBhcHBlbmQoQ0ZE YXRhUmVmKTsKKyNlbmRpZgogICAgIHZvaWQgY2xlYXIoKTsKICAgICAKICAgICB1bnNpZ25lZCBn ZXRTb21lRGF0YShjb25zdCBjaGFyKiYgZGF0YSwgdW5zaWduZWQgcG9zaXRpb24gPSAwKSBjb25z dDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9tYWMvUmVzb3VyY2VMb2FkZXJN YWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvbWFjL1Jlc291cmNlTG9hZGVyTWFjLm1tCmlu ZGV4IGFkNGQ2MGExNjA4NTM1NmIzM2RkYmUxZmFjNGYxODcxZjYwZTcwNGQuLjhlN2NlOWZlNWZm OWRjYTVmMTc2YWMzMjMyNTFjNTljMDg4MWU2MWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2xvYWRlci9tYWMvUmVzb3VyY2VMb2FkZXJNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvbG9h ZGVyL21hYy9SZXNvdXJjZUxvYWRlck1hYy5tbQpAQCAtMzUsNiArMzUsNyBAQAogCiAjaWYgVVNF KE5FVFdPUktfQ0ZEQVRBX0FSUkFZX0NBTExCQUNLKQogI2luY2x1ZGUgIkluc3BlY3Rvckluc3Ry dW1lbnRhdGlvbi5oIgorI2luY2x1ZGUgIlJlc291cmNlQnVmZmVyLmgiCiAjZW5kaWYKIAogI2lm IFVTRShDRk5FVFdPUkspCg==