102704 2012-11-19 12:18:14 -0800 [EFL] Add fallback for WebkitTestRunner if opengl is not available. 2012-11-19 21:35:28 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ostap73 ostap73 laszlo.gombos lucas.de.marchi webkit.review.bot yael oldest_to_newest 770930 0 ostap73 2012-11-19 12:18:14 -0800 Crash: ASSERTION FAILED: m_ptr /home/sl/work/webkit/Source/WTF/wtf/OwnPtr.h(72) : WTF::OwnPtr<T>::ValueType* WTF::OwnPtr<T>::operator->() const [with T = WTR::TestInvocation; WTF::OwnPtr<T>::PtrType = WTR::TestInvocation*; WTF::OwnPtr<T>::ValueType = WTR::TestInvocation] 1 0x80666be WTF::OwnPtr<WTR::TestInvocation>::operator->() const 2 0x8062c14 WTR::TestController::run() 3 0x8060a0d WTR::TestController::TestController(int, char const**) 4 0x8075b77 main 5 0xb05304d3 __libc_start_main 6 0x805f611 770942 1 175024 ostap73 2012-11-19 12:32:01 -0800 Created attachment 175024 Patch 771046 2 yael 2012-11-19 14:45:53 -0800 LGTM 771228 3 175024 laszlo.gombos 2012-11-19 17:01:08 -0800 Comment on attachment 175024 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175024&action=review > Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:36 > + ecoreEvas = ecore_evas_new(engine, 0, 0, 800, 600, 0); I would add a comment here // Graceful fallback to software rendering if evas_gl engine is not available. 771453 4 175129 ostap73 2012-11-19 21:07:48 -0800 Created attachment 175129 Patch for landing 771477 5 175129 webkit.review.bot 2012-11-19 21:35:24 -0800 Comment on attachment 175129 Patch for landing Clearing flags on attachment: 175129 Committed r135246: <http://trac.webkit.org/changeset/135246> 771478 6 webkit.review.bot 2012-11-19 21:35:28 -0800 All reviewed patches have been landed. Closing bug. 175024 2012-11-19 12:32:01 -0800 2012-11-19 21:07:43 -0800 Patch bug-102704-20121119123937.patch text/plain 1643 ostap73 U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MTc1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWI2M2YyZGVlYmY1MDEyMWU0NWZhNWM5ZWVmOTEwZTQ4 Y2MyYjVhOS4uM2I4MzFjMDZiYzZlOTZiMWYxYzQ4Y2MwNmRjZmJjNGQ3NGQ3YTA3ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTExLTE5ICBWaWF0Y2hlc2xhdiBPc3RhcGVua28gIDx2Lm9zdGFwZW5rb0BzYW1z dW5nLmNvbT4KKworICAgICAgICBbRUZMXSBBZGQgZmFsbGJhY2sgZm9yIFdlYmtpdFRlc3RSdW5u ZXIgaWYgb3BlbmdsIGlzIG5vdCBhdmFpbGFibGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI3MDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgZmFsbGJhY2sgdG8gbm9uLW9wZW5nbCBldmFzIGVu Z2luZSBpbiBXZWJraXRUZXN0UnVubmVyIGlmIG9wZW5nbCBpcyBub3QgYXZhaWxhYmxlLgorCisg ICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9lZmwvUGxhdGZvcm1XZWJWaWV3RWZsLmNwcDoKKyAg ICAgICAgKFdUUjo6aW5pdEVjb3JlRXZhcyk6CisKIDIwMTItMTEtMTkgIE5hdGUgQ2hhcGluICA8 amFwaGV0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBNb3ZlIGVtcHR5IGxvYWRpbmcgdG8gRG9j dW1lbnRMb2FkZXIsIHNpbXBsaWZ5IEZyYW1lTG9hZGVyOjppbml0KCkKZGlmZiAtLWdpdCBhL1Rv b2xzL1dlYktpdFRlc3RSdW5uZXIvZWZsL1BsYXRmb3JtV2ViVmlld0VmbC5jcHAgYi9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL2VmbC9QbGF0Zm9ybVdlYlZpZXdFZmwuY3BwCmluZGV4IGNiOTU3ZDVk OTJmNjZhMTAwYTEzZDcxODUyZTdiNzJjYzBlNWRmYTYuLmRhOTdjM2RjNGRkMTFhYWU3MmFjOTY2 ODY0MDlhZGUzYTAyNmQzMWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZWZs L1BsYXRmb3JtV2ViVmlld0VmbC5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9lZmwv UGxhdGZvcm1XZWJWaWV3RWZsLmNwcApAQCAtMzAsMTEgKzMwLDE0IEBAIG5hbWVzcGFjZSBXVFIg ewogCiBzdGF0aWMgRWNvcmVfRXZhcyogaW5pdEVjb3JlRXZhcygpCiB7Ci0gICAgY29uc3QgY2hh ciogZW5naW5lID0gMDsKKyAgICBFY29yZV9FdmFzKiBlY29yZUV2YXMgPSAwOwogI2lmIGRlZmlu ZWQoV1RGX1VTRV9BQ0NFTEVSQVRFRF9DT01QT1NJVElORykgJiYgZGVmaW5lZChIQVZFX0VDT1JF X1gpCi0gICAgZW5naW5lID0gIm9wZW5nbF94MTEiOworICAgIGNvbnN0IGNoYXIqIGVuZ2luZSA9 ICJvcGVuZ2xfeDExIjsKKyAgICBlY29yZUV2YXMgPSBlY29yZV9ldmFzX25ldyhlbmdpbmUsIDAs IDAsIDgwMCwgNjAwLCAwKTsKKyAgICBpZiAoIWVjb3JlRXZhcykKICNlbmRpZgotICAgIEVjb3Jl X0V2YXMqIGVjb3JlRXZhcyA9IGVjb3JlX2V2YXNfbmV3KGVuZ2luZSwgMCwgMCwgODAwLCA2MDAs IDApOworICAgIGVjb3JlRXZhcyA9IGVjb3JlX2V2YXNfbmV3KDAsIDAsIDAsIDgwMCwgNjAwLCAw KTsKKwogICAgIGlmICghZWNvcmVFdmFzKQogICAgICAgICByZXR1cm4gMDsKIAo= 175129 2012-11-19 21:07:48 -0800 2012-11-19 21:35:24 -0800 Patch for landing bug-102704-20121119211612.patch text/plain 1726 ostap73 U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MTc1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWI2M2YyZGVlYmY1MDEyMWU0NWZhNWM5ZWVmOTEwZTQ4 Y2MyYjVhOS4uYzhmNDNhYzkwMDBkMzcwMzdhOGY3NjVjZDQ1NTk0ZmI2OGNlYzFmNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTExLTE5ICBWaWF0Y2hlc2xhdiBPc3RhcGVua28gIDx2Lm9zdGFwZW5rb0BzYW1z dW5nLmNvbT4KKworICAgICAgICBbRUZMXSBBZGQgZmFsbGJhY2sgZm9yIFdlYmtpdFRlc3RSdW5u ZXIgaWYgb3BlbmdsIGlzIG5vdCBhdmFpbGFibGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI3MDQKKworICAgICAgICBSZXZpZXdlZCBieSBMYXN6 bG8gR29tYm9zLgorCisgICAgICAgIEFkZCBmYWxsYmFjayB0byBub24tb3BlbmdsIGV2YXMgZW5n aW5lIGluIFdlYmtpdFRlc3RSdW5uZXIgaWYgb3BlbmdsIGlzIG5vdCBhdmFpbGFibGUuCisKKyAg ICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2VmbC9QbGF0Zm9ybVdlYlZpZXdFZmwuY3BwOgorICAg ICAgICAoV1RSOjppbml0RWNvcmVFdmFzKToKKwogMjAxMi0xMS0xOSAgTmF0ZSBDaGFwaW4gIDxq YXBoZXRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE1vdmUgZW1wdHkgbG9hZGluZyB0byBEb2N1 bWVudExvYWRlciwgc2ltcGxpZnkgRnJhbWVMb2FkZXI6OmluaXQoKQpkaWZmIC0tZ2l0IGEvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9lZmwvUGxhdGZvcm1XZWJWaWV3RWZsLmNwcCBiL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvZWZsL1BsYXRmb3JtV2ViVmlld0VmbC5jcHAKaW5kZXggY2I5NTdkNWQ5 MmY2NmExMDBhMTNkNzE4NTJlN2I3MmNjMGU1ZGZhNi4uMzY0ZmJmYTA1YjEzZjAwYTEyMmJjYWQ4 MGY3OGQyMTE0ZGRhNjBhYyAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9lZmwv UGxhdGZvcm1XZWJWaWV3RWZsLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2VmbC9Q bGF0Zm9ybVdlYlZpZXdFZmwuY3BwCkBAIC0zMCwxMSArMzAsMTUgQEAgbmFtZXNwYWNlIFdUUiB7 CiAKIHN0YXRpYyBFY29yZV9FdmFzKiBpbml0RWNvcmVFdmFzKCkKIHsKLSAgICBjb25zdCBjaGFy KiBlbmdpbmUgPSAwOworICAgIEVjb3JlX0V2YXMqIGVjb3JlRXZhcyA9IDA7CiAjaWYgZGVmaW5l ZChXVEZfVVNFX0FDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKSAmJiBkZWZpbmVkKEhBVkVfRUNPUkVf WCkKLSAgICBlbmdpbmUgPSAib3BlbmdsX3gxMSI7CisgICAgY29uc3QgY2hhciogZW5naW5lID0g Im9wZW5nbF94MTEiOworICAgIGVjb3JlRXZhcyA9IGVjb3JlX2V2YXNfbmV3KGVuZ2luZSwgMCwg MCwgODAwLCA2MDAsIDApOworICAgIC8vIEdyYWNlZnVsIGZhbGxiYWNrIHRvIHNvZnR3YXJlIHJl bmRlcmluZyBpZiBldmFzX2dsIGVuZ2luZSBpcyBub3QgYXZhaWxhYmxlLgorICAgIGlmICghZWNv cmVFdmFzKQogI2VuZGlmCi0gICAgRWNvcmVfRXZhcyogZWNvcmVFdmFzID0gZWNvcmVfZXZhc19u ZXcoZW5naW5lLCAwLCAwLCA4MDAsIDYwMCwgMCk7CisgICAgZWNvcmVFdmFzID0gZWNvcmVfZXZh c19uZXcoMCwgMCwgMCwgODAwLCA2MDAsIDApOworCiAgICAgaWYgKCFlY29yZUV2YXMpCiAgICAg ICAgIHJldHVybiAwOwogCg==